Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On Fri, Jul 20, 2018 at 4:01 PM, Ruediger Pluem wrote: > > You describe the inconsistency in case c->data_in_input_filters is 1, > I did for the case that c->data_in_input_filters is 0, but yes we could have > inconsistencies in both cases > and the question is if they are always fine. So far it

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On 07/20/2018 03:49 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: >> >> On 07/20/2018 02:38 PM, Yann Ylavic wrote: >>> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: On 07/19/2018 12:36 AM, yla...@apache.org wrote: > > -if

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: > > On 07/20/2018 02:38 PM, Yann Ylavic wrote: >> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >>> >>> On 07/19/2018 12:36 AM, yla...@apache.org wrote: -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK)

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On 07/20/2018 02:38 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >> >> On 07/19/2018 12:36 AM, yla...@apache.org wrote: >>> >>> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >>> +if (ap_run_input_pending(c) != OK) { >> >> We have

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: > > On 07/19/2018 12:36 AM, yla...@apache.org wrote: >> >> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >> +if (ap_run_input_pending(c) != OK) { > > We have a different code flow here now. If

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

sh from mpm_event. > > Modified: > httpd/httpd/trunk/include/httpd.h > httpd/httpd/trunk/modules/http/http_request.c > httpd/httpd/trunk/server/mpm/event/event.c > httpd/httpd/trunk/server/mpm/motorz/motorz.c > httpd/httpd/trunk/server/mpm/simple/simple_io.c

Re: svn commit: r1820098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mpm_common.xml include/ap_listen.h os/unix/unixd.c server/listen.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/

> Shouldn't we check that this is used GLOBAL_ONLY? > > ap_check_cmd_context(cmd, GLOBAL_ONLY); > >> Modified: httpd/httpd/trunk/server/mpm/prefork/prefork.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/prefork/prefork.c?rev=1820098=1820097=1820098=diff >>

Re: svn commit: r1820098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mpm_common.xml include/ap_listen.h os/unix/unixd.c server/listen.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/

ttpd/httpd/trunk/CHANGES > httpd/httpd/trunk/docs/manual/mod/mpm_common.xml > httpd/httpd/trunk/include/ap_listen.h > httpd/httpd/trunk/os/unix/unixd.c > httpd/httpd/trunk/server/listen.c > httpd/httpd/trunk/server/mpm/event/event.c > httpd/httpd/tru

MPM motorz

During testing the 2.5.0 alpha candidate I observed various problems with the motorz MPM: looping on CPU, segmentation faults and quite some test errors I do not get for the event MPM. Do others see such issues as well? Regards, Rainer

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On 05/03/2016 05:51 PM, William A Rowe Jr wrote: > On Mon, May 2, 2016 at 3:09 AM, Ruediger Pluem > wrote: > > > On 04/28/2016 10:19 AM, Ruediger Pluem wrote: > > > > On 04/27/2016 08:41 PM, wr...@apache.org

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Tue, May 3, 2016 at 10:51 AM, William A Rowe Jr wrote: > > If we want to be more robust, have a look at the current 2.4.x > implementation of ap_get_useragent_host() in core.c... > > if (r->useragent_addr == conn->client_addr) { > return

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Mon, May 2, 2016 at 3:09 AM, Ruediger Pluem wrote: > > On 04/28/2016 10:19 AM, Ruediger Pluem wrote: > > > > On 04/27/2016 08:41 PM, wr...@apache.org wrote: > >> Author: wrowe > >> Date: Wed Apr 27 18:41:49 2016 > >> New Revision: 1741310 > >> > >> URL:

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

s/http2/h2_conn_io.c >> httpd/httpd/trunk/modules/http2/h2_task.c >> httpd/httpd/trunk/server/core.c >> httpd/httpd/trunk/server/mpm/event/event.c >> httpd/httpd/trunk/server/mpm/motorz/motorz.c >> httpd/httpd/trunk/server/mpm/simple/simple_io.c &g

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Thu, Apr 28, 2016 at 5:22 PM, William A Rowe Jr wrote: > > What I meant is that the request line *MUST* be touched - wiped > clean - for any status_from_conn(c) request. > > When we say we preserve the most recent state of the worker in > the scoreboard, that old request

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Thu, Apr 28, 2016 at 4:37 AM, Yann Ylavic wrote: > On Thu, Apr 28, 2016 at 4:30 AM, William A Rowe Jr > wrote: > > On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic > wrote: > >> > >> On Wed, Apr 27, 2016 at 8:41 PM,

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Thu, Apr 28, 2016 at 11:37 AM, Yann Ylavic wrote: > > OK, so the worker scoreboard entry is up to date with the latest > connection/request handled. > Now let's consider the case in KEEAPALIVE state where a new request > arrives (possibly on another connection for

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Thu, Apr 28, 2016 at 4:30 AM, William A Rowe Jr wrote: > On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic wrote: >> >> On Wed, Apr 27, 2016 at 8:41 PM, wrote: >> > Ensure http2 follows http in the meaning of >> > status WRITE

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

> Am 28.04.2016 um 10:08 schrieb Rainer Jung : > > Am 28.04.2016 um 04:30 schrieb William A Rowe Jr: >> On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic > > wrote: >> >>I was offline today so couldn't comment on the

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

e_ip if the status is accidently > updated from an uninitialized request_rec. > > > Modified: > httpd/httpd/trunk/modules/http2/h2_conn_io.c > httpd/httpd/trunk/modules/http2/h2_task.c > httpd/httpd/trunk/server/core.c > httpd/httpd/trunk/server/mpm/event/event.c &g

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

Am 28.04.2016 um 04:30 schrieb William A Rowe Jr: On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic > wrote: I was offline today so couldn't comment on the different messages on the subject, so I'll try to summarize (here) my understanding,

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Wed, Apr 27, 2016 at 9:30 PM, William A Rowe Jr wrote: > On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic wrote: > >> >> So now, either we choose to not report workers' activity in between >> requests (there are just multi-purpose

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

On Wed, Apr 27, 2016 at 6:16 PM, Yann Ylavic wrote: > I was offline today so couldn't comment on the different messages on > the subject, so I'll try to summarize (here) my understanding, so > far... > > On Wed, Apr 27, 2016 at 8:41 PM, wrote: > >

Re: svn commit: r1741310 - in /httpd/httpd/trunk: modules/http2/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/ server/mpm/winnt/ server/mpm/worker/

I was offline today so couldn't comment on the different messages on the subject, so I'll try to summarize (here) my understanding, so far... On Wed, Apr 27, 2016 at 8:41 PM, wrote: > Author: wrowe > Date: Wed Apr 27 18:41:49 2016 > New Revision: 1741310 > > URL:

Re: svn commit: r1736216 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

> On Mar 22, 2016, at 9:11 PM, Graham Leggett wrote: > > On 22 Mar 2016, at 7:08 PM, yla...@apache.org wrote: > >> URL: http://svn.apache.org/viewvc?rev=1736216=rev >> Log: >> Follow up to r1734656: restore c->data_in_input_filters usage to >> see if it helps unblocking test

Re: svn commit: r1736216 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On Wed, Mar 23, 2016 at 2:11 AM, Graham Leggett wrote: > On 22 Mar 2016, at 7:08 PM, yla...@apache.org wrote: > >> URL: http://svn.apache.org/viewvc?rev=1736216=rev >> Log: >> Follow up to r1734656: restore c->data_in_input_filters usage to >> see if it helps unblocking test

Re: svn commit: r1736216 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On 22 Mar 2016, at 7:08 PM, yla...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1736216=rev > Log: > Follow up to r1734656: restore c->data_in_input_filters usage to > see if it helps unblocking test framework. I created an almost identical patch before doing an update, the only

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 22 Mar 2016, at 7:11 PM, Yann Ylavic wrote: > In r1736216, I tried to restore c->data_in_input_filters usage as > prior to r1734656. > Does it help (or I'll revert)? Got caught up in other stuff before I could get to the bottom of this :( It looks like we need to

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

In r1736216, I tried to restore c->data_in_input_filters usage as prior to r1734656. Does it help (or I'll revert)? On Tue, Mar 22, 2016 at 1:02 PM, Jim Jagielski wrote: > Well, we gotta do something. This is a significant breakage. > >> On Mar 15, 2016, at 4:29 AM, Yann

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

Well, we gotta do something. This is a significant breakage. > On Mar 15, 2016, at 4:29 AM, Yann Ylavic wrote: > > On Tue, Mar 15, 2016 at 12:42 AM, Graham Leggett wrote: >> On 14 Mar 2016, at 10:48 AM, Ruediger Pluem wrote: >> >>>

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

/http_core.c httpd/httpd/trunk/modules/http/http_request.c httpd/httpd/trunk/server/core.c httpd/httpd/trunk/server/core_filters.c httpd/httpd/trunk/server/mpm/event/event.c httpd/httpd/trunk/server/mpm/motorz/motorz.c httpd/httpd/trunk/server/mpm/simple/simple_io.c httpd

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Mar 15, 2016 at 12:42 AM, Graham Leggett wrote: > On 14 Mar 2016, at 10:48 AM, Ruediger Pluem wrote: > >> This seems to cause frequent (no always) failures with test 8 of >> t/ssl/proxy.t. >> The request times out with a 504 status. So it looks like

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 14 Mar 2016, at 10:48 AM, Ruediger Pluem wrote: > This seems to cause frequent (no always) failures with test 8 of > t/ssl/proxy.t. > The request times out with a 504 status. So it looks like the "backend" in > this request does not respond. > Used MPM is Event, OS CentOS

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

They are also proxy-timeout related it seems: # testing : QUERY_STRING passed OK # expected: qr/QUERY_STRING = horse=trigger\n/s # received: ' # # 504 Proxy Error # # Proxy Error # The gateway did not receive a timely response # from the upstream server or application. # ' not ok 27 # Failed

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 03/14/2016 02:55 PM, Jim Jagielski wrote: > >> On Mar 14, 2016, at 4:48 AM, Ruediger Pluem wrote: >> >> >> This seems to cause frequent (no always) failures with test 8 of >> t/ssl/proxy.t. >> The request times out with a 504 status. So it looks like the "backend" in >>

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

> On Mar 14, 2016, at 4:48 AM, Ruediger Pluem wrote: > > > This seems to cause frequent (no always) failures with test 8 of > t/ssl/proxy.t. > The request times out with a 504 status. So it looks like the "backend" in > this request does not respond. > Used MPM is Event,

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

trunk/modules/http/http_core.c > httpd/httpd/trunk/modules/http/http_request.c > httpd/httpd/trunk/server/core.c > httpd/httpd/trunk/server/core_filters.c > httpd/httpd/trunk/server/mpm/event/event.c > httpd/httpd/trunk/server/mpm/motorz/motorz.c > httpd/httpd/

Re: motorz

> On Feb 16, 2016, at 4:08 AM, Plüm, Rüdiger, Vodafone Group > <ruediger.pl...@vodafone.com> wrote: > > > >> -Ursprüngliche Nachricht- >> Von: Jim Jagielski [mailto:j...@jagunet.com] >> Gesendet: Montag, 15. Februar 2016 23:51 >> An

AW: motorz

> -Ursprüngliche Nachricht- > Von: Jim Jagielski [mailto:j...@jagunet.com] > Gesendet: Montag, 15. Februar 2016 23:51 > An: dev@httpd.apache.org > Betreff: Re: motorz > > The more I think of it, the more I think we should just > remove motorz and simple from trun

Re: motorz

On Mon, Feb 15, 2016 at 5:51 PM, Jim Jagielski <j...@jagunet.com> wrote: > The more I think of it, the more I think we should just > remove motorz and simple from trunk... Or keep them around > but not really worry about them. I didn't want to be a buzzkill, but +1.

Re: motorz

The more I think of it, the more I think we should just remove motorz and simple from trunk... Or keep them around but not really worry about them. The fun and interesting stuff is already in event, and although it might be nice to, for example, move the worker_pool stuff to a simply

motorz

Anyone had a chance yet to play around and/or hack on the motorz mpm yet... I plan on jumping back in on it and was curious if people had fixes, etc that they were working on.

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

Le 04/10/2015 12:10, minf...@apache.org a écrit : Author: minfrin Date: Sun Oct 4 10:10:51 2015 New Revision: 1706669 URL: http://svn.apache.org/viewvc?rev=1706669=rev Log: core: Extend support for asynchronous write completion from the network filter to any connection or request filter.

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 5:34 PM, Graham Leggett wrote: > > apr_bucket_simple_copy() looks wrong - in theory we should have a proper copy > function that does the right thing with the second copy, for example by not > copying the pool. If we blindly copy the pool (or the request

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 3:51 PM, Yann Ylavic wrote: > On Tue, Oct 6, 2015 at 3:41 PM, Graham Leggett wrote: >> On 6 Oct 2015, at 14:32, Yann Ylavic wrote: >> >>> So it seems to relate to the EOR bucket, first not being passed >>>

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 3:36 PM, Stefan Eissing wrote: > FYI: /trunk no longer works with mod_http2. 2.4.x does. I see missing > response data, it seems, so the most likely cause are the changes in filter > handling. Did not find the time to investigate further. > >

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 5:22 PM, Yann Ylavic wrote: >> Just did that, same thing. >> I was using mpm_worker, but now tried mpm_event with same segfaults. > > Looks like mod_bucketeer is the culprit. > It fails to remove itself from the filter stack on EOS, and hence > makes a

AW: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

/event/ server/mpm/motorz/ > server/mpm/simple/ > > On Tue, Oct 6, 2015 at 5:34 PM, Graham Leggett <minf...@sharp.fm> wrote: > > > > apr_bucket_simple_copy() looks wrong - in theory we should have a > proper copy function that does the right thing with the second co

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

> On Oct 6, 2015, at 1:29 PM, Graham Leggett wrote: > > On 06 Oct 2015, at 7:00 PM, Yann Ylavic wrote: > >> Yet another filter which does not remove itself after the EOS, and >> destroys the EOR bucket while still using *r after. > > I am wondering if

RE: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

> -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Dienstag, 6. Oktober 2015 01:40 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ > modules/http/ modules/ssl/ server/ server/mpm/event/

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 7:29 PM, Graham Leggett wrote: > I am wondering if the EOR bucket is a suboptimal way to clean up after > ourselves. > > The MPM itself is in a position to know when the filter buffers are all empty > and it is safe to delete a request pool. I am imagining

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 9:37 AM, Plüm, Rüdiger, Vodafone Group wrote: > >> From: Yann Ylavic [mailto:ylavic@gmail.com] >> >> Also it seems that we leak the hash iterator here (on c->pool). > > Why do we leak here? apr_hash_first(NULL, is used. So no new iterator is

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 9:37 AM, Plüm, Rüdiger, Vodafone Group wrote: > >> -Original Message- >> From: Yann Ylavic [mailto:ylavic@gmail.com] >> >> > Modified: httpd/httpd/trunk/server/mpm/event/event.c >> > URL: >>

RE: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

> -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Dienstag, 6. Oktober 2015 11:13 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ > modules/http/ modules/ssl/ server/ server/mpm/event/

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 1:39 AM, Yann Ylavic wrote: >> + >> +/** Buffered data associated with the current filter. */ >> +apr_bucket_brigade *bb; >> + >> +/** Dedicated pool to use for deferred writes. */ >> +apr_pool_t *deferred_pool; > > Could we make these

RE: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

> -Original Message- > From: Graham Leggett [mailto:minf...@sharp.fm] > Sent: Dienstag, 6. Oktober 2015 12:16 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ > modules/http/ modules/ssl/ server/ server/mpm/event/

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

>> Subject: Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ >> modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ >> server/mpm/simple/ >> >> On Tue, Oct 6, 2015 at 9:37 AM, Plüm, Rüdiger, Vodafone Group >> <ruediger.pl...@vodafon

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 12:26 PM, Plüm, Rüdiger, Vodafone Group wrote: > How can you be sure that you don't have transient buckets in the brigade that > point to memory that changed or is invalid, once you reinstate the brigade? Because it’s a request filter, not a

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 12:36 PM, Yann Ylavic wrote: >> Although the brigade is empty, don't we need to prevent the brigade being >> used by multiple threads in parallel? >> Using one per connection prevents this. > > Hmm, the filters are also allocated per connection/request

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 12:15 PM, Graham Leggett wrote: > On 06 Oct 2015, at 1:39 AM, Yann Ylavic wrote: > >>> + >>> +/** Buffered data associated with the current filter. */ >>> +apr_bucket_brigade *bb; >>> + >>> +/** Dedicated pool to use for

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 12:57 PM, Graham Leggett wrote: > > On 06 Oct 2015, at 12:36 PM, Yann Ylavic wrote: >> BTW, I wonder if we can "reinstate" the filters in arbitrary order >> like in the above loop (the order seems to depend on the calls to >>

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 3:51 PM, Yann Ylavic wrote: > > Just did that, same thing. > I was using mpm_worker, but now tried mpm_event with same segfaults. FWIW, I'm running an (old) Debian 6.0.10 (squeeze, 64bit).

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 1:07 PM, Yann Ylavic wrote: > What I meant is that passing an empty brigade to a reinstate-able > filter may make it pass its data to the next filter, so we may want to > do this only on the first reinstate-able filter starting from > r->output_filters.

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 12:36 PM, Graham Leggett wrote: >> How can you be sure that you don't have transient buckets in the brigade >> that point to memory that changed or is invalid, once you reinstate the >> brigade? > > Because it’s a request filter, not a connection filter.

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 3:41 PM, Graham Leggett wrote: > On 6 Oct 2015, at 14:32, Yann Ylavic wrote: > >> So it seems to relate to the EOR bucket, first not being passed >> through, and second leading to a double-free or alike. >> >> Did not investigate

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Sun, Oct 4, 2015 at 12:10 PM, wrote: > Author: minfrin > Date: Sun Oct 4 10:10:51 2015 > New Revision: 1706669 > > URL: http://svn.apache.org/viewvc?rev=1706669=rev > Log: > core: Extend support for asynchronous write completion from the > network filter to any connection

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 3:32 PM, Yann Ylavic wrote: > > Just wanted to run the tests framework on trunk for a local change but > it seems that this commit (bisected to) makes many tests to segfault. Forgot to mention, same thing with follow up r1706670 applied.

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

FYI: /trunk no longer works with mod_http2. 2.4.x does. I see missing response data, it seems, so the most likely cause are the changes in filter handling. Did not find the time to investigate further. Please be aware the mod_h2 uses pool/brigade hierarchies in new and unexpected ways. The

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 6 Oct 2015, at 14:32, Yann Ylavic wrote: > So it seems to relate to the EOR bucket, first not being passed > through, and second leading to a double-free or alike. > > Did not investigate further... Did you rebuild you tree completely clean before trying it out?

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

+1 (concept) > On Oct 6, 2015, at 11:53 AM, Yann Ylavic wrote: > > On Tue, Oct 6, 2015 at 5:34 PM, Graham Leggett wrote: >> >> apr_bucket_simple_copy() looks wrong - in theory we should have a proper >> copy function that does the right thing with the

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 06 Oct 2015, at 7:00 PM, Yann Ylavic wrote: > Yet another filter which does not remove itself after the EOS, and > destroys the EOR bucket while still using *r after. I am wondering if the EOR bucket is a suboptimal way to clean up after ourselves. The MPM itself is

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 5:53 PM, Yann Ylavic wrote: > On Tue, Oct 6, 2015 at 5:34 PM, Graham Leggett wrote: >> >> apr_bucket_simple_copy() looks wrong - in theory we should have a proper >> copy function that does the right thing with the second copy, for

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 6:29 PM, Yann Ylavic wrote: > > all tests pass now. I spoke too soon... New segfault is in mod_substitute: Program terminated with signal 11, Segmentation fault. (gdb) bt #0 0x7fa02fbaec2b in allocator_free (allocator=0x1cedcb0, node=0x0) at

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 7:00 PM, Yann Ylavic wrote: > On Tue, Oct 6, 2015 at 6:29 PM, Yann Ylavic wrote: >> >> all tests pass now. > > I spoke too soon... > > New segfault is in mod_substitute: Fixed in r1707091. Now all tests really pass :p I wonder

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On Tue, Oct 6, 2015 at 5:22 PM, Yann Ylavic wrote: > still the new filter should probably work > with the existing... s/new filter/new filter stack mechanism/

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

me); > +break; > +} > + > +if (ap_filter_should_yield(f)) { > +data_in_output_filters = 1; > +} > +} > + > +rindex = apr_hash_next(rindex); > } This

Re: svn commit: r1666619 - /httpd/httpd/trunk/server/mpm/motorz/motorz.c

to tell how to order elements, what is a duplicate, and eventually what is an exact element one is looking for (and motorz needs this, unlike event), I guess we have to hack all that there... On Fri, Apr 10, 2015 at 3:26 PM, Jim Jagielski j...@jagunet.com wrote: Isn't the whole idea of skiplists

Re: svn commit: r1666619 - /httpd/httpd/trunk/server/mpm/motorz/motorz.c

only need one compare function for add semantic with apr_skiplist_insert() and unique timers (pointers). It also works with apr_skiplist_remove() and apr_skiplist_find(). Modified: httpd/httpd/trunk/server/mpm/motorz/motorz.c Modified: httpd/httpd/trunk/server/mpm/motorz/motorz.c URL

Re: motorz and 2.4.13

On Tue, 31 Mar 2015 10:49:47 -0400 Jim Jagielski j...@jagunet.com wrote: Apologies for not hacking on motorz lately... will ramp up :) BTW: Would it make sense to consider a release of 2.4.13 in April to coincide w/ ApacheCon? We've historically produced a release at the beginning

motorz and 2.4.13

Apologies for not hacking on motorz lately... will ramp up :) BTW: Would it make sense to consider a release of 2.4.13 in April to coincide w/ ApacheCon?

Re: svn commit: r1666619 - /httpd/httpd/trunk/server/mpm/motorz/motorz.c

() and unique timers (pointers). It also works with apr_skiplist_remove() and apr_skiplist_find(). Modified: httpd/httpd/trunk/server/mpm/motorz/motorz.c Modified: httpd/httpd/trunk/server/mpm/motorz/motorz.c URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/motorz/motorz.c?rev

Re: svn commit: r1665385 - in /httpd/httpd/trunk/server/mpm/motorz: motorz.c motorz.h

://svn.apache.org/r1665385 Log: motorz: revert bogus r1665381. How about using a timer per connection, eg : This also avoids allocating the timers on scon-pool and saves the pool_cleanup_register()/kill() whenever a timer is registered/killed (motorz_conn_pool_cleanup() is now registered once at creation

Re: svn commit: r1665385 - in /httpd/httpd/trunk/server/mpm/motorz: motorz.c motorz.h

On Mar 10, 2015, at 5:08 AM, Yann Ylavic yla...@apache.org wrote: On Tue, Mar 10, 2015 at 12:39 AM, yla...@apache.org wrote: Author: ylavic Date: Mon Mar 9 23:39:05 2015 New Revision: 1665385 URL: http://svn.apache.org/r1665385 Log: motorz: revert bogus r1665381. How about using

Re: svn commit: r1665385 - in /httpd/httpd/trunk/server/mpm/motorz: motorz.c motorz.h

On Tue, Mar 10, 2015 at 12:39 AM, yla...@apache.org wrote: Author: ylavic Date: Mon Mar 9 23:39:05 2015 New Revision: 1665385 URL: http://svn.apache.org/r1665385 Log: motorz: revert bogus r1665381. How about using a timer per connection, eg : Index: server/mpm/motorz/motorz.c

EventOpt and MotorZ

In r1664077 I made 2 changes to trunk. First of all, since all the coolness of EventOpt has been pulled into Event, there's no need to keep EventOpt around, so it's been trashed. Also... I went ahead and added MotorZ which is a mashup of Prefork and Simple, in hopes that more eyes will allow