[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code b

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4174 To unsubscr

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4182/1/be/src/exec/row-batch-list-test.cc

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. IMPALA-4049: fix empty batch handling NLJ build side Memory from the build side of a nested loop join is re

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 9: (13 comments) http://gerrit.cloudera.org:8080/#/c/4066/9/be/src/runtime/c

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4182/1/be/src/exec/row-batch-list-test.cc File

[Impala-ASF-CR] DRAFT PREVIEW: Prereqs for load test system testing

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: DRAFT PREVIEW: Prereqs for load test system testing .. Patch Set 1: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-v

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4162/5/fe/src/main/

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4162 to look at the new patch set (#5). Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ...

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4162/4/fe/src/main

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4162/4/fe/s

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4182 Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. IMPALA-4049: fix empty batch handling NLJ build side Memory from

[Impala-ASF-CR] Avoid unnecessary copy of RowDescriptor into RowBatch

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4181 Change subject: Avoid unnecessary copy of RowDescriptor into RowBatch .. Avoid unnecessary copy of RowDescriptor into RowBatch This comm

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/4066/7/be/src/runtime/coord

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#9). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch, Impala

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#8). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch, Impala

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test join queries.py.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_join_queries.py. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4169 To unsub

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test join queries.py.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3491: Use unique database fixture in test_join_queries.py. .. IMPALA-3491: Use unique database fixture in test_join_queries.py. Testing: Ran

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/4/be/src/exec/hdfs-scan-node.h

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 5: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4174 to look at the new patch set (#5). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. ..

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 15: This two patch 1. add authz test and conjunct test. 2. make the scan range

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

2016-08-30 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3942/1/fe/src/main/java/com/cloudera/impala/analysis

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/4/be/src/exec/hdf

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a scan

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-08-30 Thread Kathy Sun (Code Review)
Kathy Sun has uploaded a new patch set (#15). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-08-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 11: > From the discussion today: > > Points agreed on: > - Collapse Executors and states,

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Revert "Use impala-python when building shell tarball" .. Revert "Use impala-python when building shell tarball" This reverts commit 34bc6a72dbbb4fd0093

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Revert "Use impala-python when building shell tarball" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4176 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4066/7/be/src/runtime/coordinat

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/4066/5/be/src/runtime/coor

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#7). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch, Impala

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. IMPALA-4019: initialize member variables in HdfsTableSink This fixes a bug that could po

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4171 To unsubscribe, v

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 3: (1 comment) Thanks for the fast turnaround, Michael! http://gerrit.cloudera.org:8080/#/c/4

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. .. IMPALA-1657: Rework detection and reporting of corrupt table stats. 1. Minor

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4166 To uns

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Revert "Use impala-python when building shell tarball" .. Patch Set 1: Code-Review+2 Yikes... Another example of us getting burned by having 2 pythons. -- To

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Revert "Use impala-python when building shell tarball" .. Patch Set 1: Code-Review+2 Nice catch -- To view, visit http://gerrit.cloudera.org:8080/4176 To unsubscri

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Revert "Use impala-python when building shell tarball" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4176 To unsubscribe, visi

[Impala-ASF-CR] Revert "Use impala-python when building shell tarball"

2016-08-30 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has uploaded a new change for review. http://gerrit.cloudera.org:8080/4176 Change subject: Revert "Use impala-python when building shell tarball" .. Revert "Use impala-python when building shell tarball" T

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. IMPALA-4037,IMPALA-4038: fix locking during query cancellation * Refactor the child query handlin

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a scan

[Impala-ASF-CR] IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs.

2016-08-30 Thread Alex Behm (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4162 to look at the new patch set (#4). Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ...

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/2/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4175 Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. IMPALA-3718: Support subset of functional-query for Kudu Ad

[Impala-ASF-CR] IMPALA-3481: Use Kudu ScanToken API for scan ranges

2016-08-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3481: Use Kudu ScanToken API for scan ranges .. IMPALA-3481: Use Kudu ScanToken API for scan ranges Switches the planner and KuduScanNode to use Kudu's new

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a scan

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4174/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.

Re: [DISCUSS] Branching for a release soon?

2016-08-30 Thread Jim Apple
Testing is passing. I am waiting on the following commits to land in master, though, before I cherry-pick them to branch-2.7.0: https://gerrit.cloudera.org/#/c/3995/ https://gerrit.cloudera.org/#/c/3937/ https://gerrit.cloudera.org/#/c/3936/ https://gerrit.cloudera.org/#/c/4160/ These are all int

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-nod

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. .. Patch Set 1: (4 comments) Doing another pass over the code now. There are still two open questions: - use batch A

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-no

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4174 Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/4171 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test join queries.py.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_join_queries.py. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4169 To unsubscri

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-avro-scanner.cc File be/src/exe

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-3905: Add single-threaded scan node. .. IMPALA-3905: Add single-threaded scan node. Adds a new single-threaded scan node HdfsScanNodeMt that materializes tuples

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu table

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/4047/1//COMMIT_MSG Commit Message: PS1, Lin

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4171 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 6: (4 comments) Don't mean to distract, but have some suggestions for making a bit

[Impala-ASF-CR] Bump Impala version to 2.8

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Impala version to 2.8 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4170 To unsubscribe, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-08-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 11: >From the discussion today: Points agreed on: - Collapse Executors and states, i.e. collaps

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: Code-Review-2 I started a GVO. Marking -2 so it won't accidentally get merged. -- To

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. .. Patch Set 3: Code-Review+2 Carry Marcel's +2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4166 to look at the new patch set (#2). Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats.

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4166/1/fe/src/main/java/com/cl

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/3/tests/conftest.py

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test join queries.py.

2016-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_join_queries.py. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4169 To unsub

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4171 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. IMPALA-3491: Use unique database fixture in test_ddl.py. Allows parametrizing the unique database fixture w

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/2/tests/metadata/test_hms_integration.

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4171 Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. IMPALA-4019: initialize member variables in HdfsTableSink T

[Impala-ASF-CR] IMPALA-1657: Rework detection and reporting of corrupt table stats.

2016-08-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. .. Patch Set 1: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/4166/1/fe

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-08-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-avro-scanner.cc File be/sr

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Abandoned decided against this change -- To view, visit http://gerrit.cloudera.org:8080/3862 To unsubscribe, vi

[Impala-CR](cdh5-trunk) Bump Impala version to 2.8.0

2016-08-30 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: Bump Impala version to 2.8.0 .. Abandoned Wrong project -- To view, visit http://gerrit.cloudera.org:8080/4072 To unsubscribe, visit http://gerrit.cloudera.org:8080/setti

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/2/tests/metadata/test_hms_integrat

[Impala-ASF-CR] Bump Impala version to 2.8

2016-08-30 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has posted comments on this change. Change subject: Bump Impala version to 2.8 .. Patch Set 1: (1 comment) Responded http://gerrit.cloudera.org:8080/#/c/4170/1/bin/save-version.sh File bin/save-version.sh:

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

2016-08-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4155/1/testdata/workloads/functional-q

[Impala-ASF-CR] Bump Impala version to 2.8

2016-08-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Bump Impala version to 2.8 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4170/1/bin/save-version.sh File bin/save-version.sh: PS1, Line 24: cdh5

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: I just rebased both patches, and the new version also passes a private jenkins r

[Impala-ASF-CR] Bump Impala version to 2.8

2016-08-30 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has uploaded a new change for review. http://gerrit.cloudera.org:8080/4170 Change subject: Bump Impala version to 2.8 .. Bump Impala version to 2.8 Change-Id: I5b147dee9bb7fcb159e98a008c01659a4cb7473b ---

[Impala-CR](cdh5-trunk) Bump Impala version to 2.8.0

2016-08-30 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has posted comments on this change. Change subject: Bump Impala version to 2.8.0 .. Patch Set 1: Code-Review-1 This is for the old project, should be for Impala-ASF -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#4). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-37

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-30 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3936 to look at the new patch set (#3). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. IMPALA-37

[Impala-ASF-CR] IMPALA-4020: Catalog update can fail due to database creation/deletion in hive

2016-08-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Catalog update can fail due to database creation/deletion in hive .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4161/2/

[Impala-ASF-CR] IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide

2016-08-30 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3808: Add incubating DISCLAIMER from the Incubator Branding Guide .. Patch Set 1: I have branched for 2.7.0 and I anticipate cherry-picking this from master

CLAs not required for non-committers

2016-08-30 Thread Jim Apple
I have changed our "How to contribute" page to note that CLAs are not required, a piece of information I learned from Todd, one of our mentors. https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=65147115&selectedPageVersions=12&selectedPageVersions=11 Note that CLAs are re

Re: release testing - error that I don't see in the bug tracker

2016-08-30 Thread Jim Apple
Ran it again and it passed. I'll file a bug but not hold up the 2.7.0 release cycle for this. On Mon, Aug 29, 2016 at 6:51 PM, Jim Apple wrote: > I am seeing an error like the one below with my 2.7.0 release testing. > I looked in the issue tracker to see if I could find a fix I could > cherry pi

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test join queries.py.

2016-08-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4169 Change subject: IMPALA-3491: Use unique database fixture in test_join_queries.py. .. IMPALA-3491: Use unique database fixture in test_join_q

  1   2   >