[Toolchain-CR] IMPALA-4477: Bump Kudu to latest commit on master (60aa54e)

2016-12-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu to latest commit on master (60aa54e) .. Patch Set 1: Code-Review+1 Would be good for Tim to take a look. -- To view, visit http://gerrit.clo

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW IMPALA-4223: Fix buffer handling in ScannerContext

2016-10-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: PREVIEW IMPALA-4223: Fix buffer handling in ScannerContext .. Patch Set 1: Can't make changes to 2.6 - that release has shipped. What branch did you intend? -- T

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache .. Patch Set 1: Same -- To view, visit http://gerrit.cloudera.org:8080/4645 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has abandoned this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Abandoned Continued: https://gerrit.cloudera.org/#/c/4371/ -- To view, visit http://gerrit.cloudera.org:8080/3576

[Impala-CR](cdh5-trunk) IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 5: Looks like you continued this over here to switch projects: https://gerrit.cloudera.org/#/c/4

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/4094/13/be/src/exprs/expr-test.cc File be/src/

[Impala-ASF-CR] IMPALA-4097: Crash in kudu-scan-node-test

2016-09-09 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4097: Crash in kudu-scan-node-test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4337 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-09-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 13: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3993/13/be/src/bufferpool

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

2016-09-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/405

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

2016-09-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-09-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool/reservation-

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-09-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 10: (12 comments) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool/reservation

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

2016-09-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 4: Code-Review+2 (5 comments) I still think it'd be clearer to clean up how codegen repo

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

2016-09-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4188/3/be/src/util/runtime-profile.c

[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall

2016-09-06 Thread Dan Hecht (Code Review)
Dan Hecht has abandoned this change. Change subject: IMPALA-3382: Long warnings cause impala-shell to stall .. Abandoned IMPALA-3859 made this unneeded. -- To view, visit http://gerrit.cloudera.org:8080/2821 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4205 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: How about adding an end-to-end case in expr.test (or somewhere) especially since this b

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 5: Clearly we were missing some basic test coverage. Do we have any other test gaps around

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (16 comments) Only partially made it through the rest of the change, still going. But w

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/util/bit-util.cc File be/

[Impala-ASF-CR] IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned.

2016-09-01 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4058: ByteSwap256 assumed memory was 16-byte aligned. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4205/3/be/src/util/bit-util.cc File be/

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-08-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3993/8/be/src/bufferpool/reservation-tra

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: (1 comment) > This is a bug, but not worth holding up the build for. This is an

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: > (12 comments) > > Mostly style comments, but one question about disabling b

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

2016-08-31 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/4/be/src/exec/hdf

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4066/7/be/src/runtime/coordinat

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/2/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4174/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4019: initialize member variables in HdfsTableSink

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4019: initialize member variables in HdfsTableSink .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4171 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 6: (4 comments) Don't mean to distract, but have some suggestions for making a bit

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-08-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (26 comments) Focused on the public interface. http://gerrit.cloudera.org:8080/#/c/3993

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 9: What's the next step here? -- To view, visit http://gerrit.cloudera.or

[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times

2016-08-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times .. Patch Set 1: Anuj, did you run those tests? What was the outcome? -- To view, visit http

[Impala-CR](cdh5-trunk) IMPALA-3382: Long warnings cause impala-shell to stall

2016-08-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3382: Long warnings cause impala-shell to stall .. Patch Set 1: Marcell, is this something you will move forward or should it be abandoned? -- To view, visi

[Impala-ASF-CR] IMPALA-4027:Memory leak with ExprCtxs not free

2016-08-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4027:Memory leak with ExprCtxs not free .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4132 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 2: > > It passed the packaging build: > > http://golden.jenkins.cloudera.com/job/CDH5-Packaging-

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 5: > Exhaustive tests failed because the offsets for the GZIP version of > alltypeserrorornulls

[Impala-ASF-CR] IMPALA-2550 Introduce query-wide execution context.

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3817/7/be/src/service/query-exec-mgr.cc File be/

[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3832: test invalid data handling in lzo text scanner .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4096/3/tests/query_test/te

[Impala-ASF-CR] IMPALA-3832: test invalid data handling in lzo text scanner

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3832: test invalid data handling in lzo text scanner .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4096/2/tests/query_test/test_scanners_f

[Impala-ASF-CR] IMPALA-2550 Introduce query-wide execution context.

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 8: (3 comments) Just to summarize some key points from the discussion today so we don't forget: -

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-23 Thread Dan Hecht (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4020 to look at the new patch set (#5). Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. IMPA

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4020 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 4: > This passes a core test run. Running exhaustive, and local (to test > FS changes) now. Di

[Impala-ASF-CR] IMPALA-2550 Introduce query-wide execution context.

2016-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3817/7/be/src/service/query-exec-mgr.cc File be

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsub

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-avro

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/3774/10/be/src/exec/hdfs-avr

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/3938/4/be/src/runtime/buffered-block-mg

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3774/9/be/src/exec/hdfs-parque

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/3774/9/be/src/exec/hdfs-parqu

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/40

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4020/3/tests/common/test_result_verifier.py

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3791 To unsubscribe,

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4018 To unsubsc

[Impala-ASF-CR] IMPALA-3996: Migrate to updated Kudu insert string API

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3996: Migrate to updated Kudu insert string API .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4055 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4018/4/be/src/exec/hdfs-table-s

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4064 To unsubsc

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: Code-Review+2 (1 comment) Oops, sorry missed your comment. http://gerrit.cloud

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 4: Does this pass the tests? -- To view, visit http://gerrit.cloudera.org:8080/40

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/exec-no

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/exec-node.cc File be/s

[Impala-ASF-CR] IMPALA-3090: always log memory limit errors

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3090: always log memory limit errors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4049 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/hdfs-parquet-scanner.

[Impala-ASF-CR] Fix stress test runner bug introduced by IMPALA-3969

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Fix stress test runner bug introduced by IMPALA-3969 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4019 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4020/2/testdata/workloads/functional-query/q

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4018/2/be/src/exec/hdfs-table-s

[Impala-ASF-CR] PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3817/5/be/src/runtime/fragment-exec-sta

[Impala-ASF-CR] IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2988: Refactor HdfsTableSink::Close() so that it cannot fail .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4018/1/be/src/exec/hdfs-table-

[Impala-ASF-CR] IMPALA-(3895,3859): Don't log file data on parse errors

2016-08-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors .. Patch Set 1: (3 comments) Does hdfs-rcfile-scan-node-errors.test need updates as well? http://gerrit.clo

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

2016-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

2016-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

2016-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Patch Set 5: Please see my comment on the JIRA. Looking at the old code, I don't see how this could be

[Impala-ASF-CR] IMPALA-3943: Adhere to abort on error in ProcessFooter().

2016-08-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3943: Adhere to abort_on_error in ProcessFooter(). .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3862/5/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-3918: remove Cloudera copyright from the shell welcome message

2016-08-16 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/4005 Change subject: IMPALA-3918: remove Cloudera copyright from the shell welcome message .. IMPALA-3918: remove Cloudera copyright from the she

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: (1 comment) Debug action (possibly need an extension) sounds good to me as well. We coul

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 3: (7 comments) Some initial comments. I think if you clean up some of the terminology it w

[Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3940 To

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet-scanner.

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: > We probably need to create a malformed table with bad data in some > columns. Is there

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/2569/23/be/src/bufferpool/buffer-poo

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 1: Just so we have the trail: https://gerrit.cloudera.org/#/c/3688/ -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: is there a better / more direct way to test this rather than relying on the stress test?

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 2: > I ran private Jenkins jobs, which passed, so our builds should be > fine. I don't really kn

[Impala-CR](cdh5-trunk) IMPALA-3823: Add timer to measure Parquet footer reads

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3576/5/be/src/exec/hdfs-parquet-scanner.cc Fi

[Impala-ASF-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3807

[Impala-ASF-CR] IMPALA-3470: DecompressorTest is flaky.

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3470: DecompressorTest is flaky. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3954 To unsubscribe, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 2: Is there anything that needs to be updated on the packaging side of things? i.e. will a night

[Impala-ASF-CR] IMPALA-3952: Clear scratch batch mem pool if Open() failed.

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3952: Clear scratch batch mem pool if Open() failed. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3953 To unsubscribe, vis

[Impala-CR](cdh5-trunk) IMPALA-3201: buffer pool header only

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 7: Code-Review+2 (2 comments) Please also let Marcel finish his review. http://gerrit.cloudera.org:8080/#/c/3688/

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3832 To unsubs

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3832/2//COMMIT_MSG Commit Mess

[Impala-ASF-CR] Remove dead and untested code

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove dead and untested code .. Patch Set 1: Code-Review+2 Nice! -- To view, visit http://gerrit.cloudera.org:8080/3989 To unsubscribe, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3953: Fixes for KuduScanNode BE test failure

2016-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3953: Fixes for KuduScanNode BE test failure .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 7: I was just giving an example of where we could lose coverage, but didn't

[Impala-ASF-CR] IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight.

2016-08-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/3832/2//COMMIT_MSG Commit Mes

[Impala-ASF-CR] IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO.

2016-08-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. .. Patch Set 7: > By default, pytest captures test output, and as far as I can see, > i

  1   2   3   4   5   6   7   8   9   >