Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
nfsantos commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503753351 ## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java: ## @@ -436,4 +437,12 @@ public static IndexingMode from(

Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
steffenvan commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503743424 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -52,8 +53,12 @@ class ElasticIndexHel

[PR] Old revisions cleanup (rebased) [jackrabbit-oak]

2024-02-26 Thread via GitHub
Joscorbe opened a new pull request, #1328: URL: https://github.com/apache/jackrabbit-oak/pull/1328 Introduce a way to safely detect and delete old revisions in a document. This could be useful to cleanup documents that sometimes grows above the supported size in MongoDB (16MB). This

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on code in PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503044724 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1255,28 +1305,40 @@ public void removeGar

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on code in PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503043793 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1255,28 +1305,40 @@ public void removeGar

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on code in PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503042672 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -942,21 +949,63 @@ public void collectGarb

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-26 Thread via GitHub
rishabhdaim commented on code in PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1502951816 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -942,21 +949,63 @@ public void collectGarb

[PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
fabriziofortino opened a new pull request, #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327 Some indexes, like elasticsearch have a concept of an internal version (or mapping version) to handle breaking changes. This information is sometimes needed from external tools that do

Re: [PR] OAK-10660 : childOrder overwrite-cleanup variant based on getBranch, … [jackrabbit-oak]

2024-02-26 Thread via GitHub
mbaedke commented on PR #1326: URL: https://github.com/apache/jackrabbit-oak/pull/1326#issuecomment-1964345672 I removed Julian's initial changes. Tests behave as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] OAK-10660: DocumentNodeStore: avoid repeated commits of :childOrder in branch commits [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on PR #1317: URL: https://github.com/apache/jackrabbit-oak/pull/1317#issuecomment-1964277787 @reschke , @mbaedke , did a draft of an alternative that doesnt need the new wiring : check https://github.com/apache/jackrabbit-oak/pull/1326 -- This is an automated message

[PR] OAK-10660 : childOrder overwrite-cleanup variant based on getBranch, … [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli opened a new pull request, #1326: URL: https://github.com/apache/jackrabbit-oak/pull/1326 …without additional wiring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1964120375 PS: now the flaky test succeeded but the build failed with the known ``` The plugin [java] does not support Java 11.0.22 ``` I'd suggest to ignore this failure fo

Re: [PR] OAK-10660: DocumentNodeStore: avoid repeated commits of :childOrder in branch commits [jackrabbit-oak]

2024-02-26 Thread via GitHub
stefan-egli commented on PR #1317: URL: https://github.com/apache/jackrabbit-oak/pull/1317#issuecomment-1963832706 Also [commented](https://issues.apache.org/jira/browse/OAK-10660?focusedCommentId=17820636&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17820636

Re: [PR] OAK-10660: DocumentNodeStore: avoid repeated commits of :childOrder in branch commits [jackrabbit-oak]

2024-02-26 Thread via GitHub
rishabhdaim commented on code in PR #1317: URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1502313352 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ## @@ -354,7 +360,27 @@ private void applyToDocumentStore(Revisio

Re: [PR] OAK-10661: oak-search-elastic: remove workaround for elasticsearch-java#404 [jackrabbit-oak]

2024-02-26 Thread via GitHub
fabriziofortino merged PR #1316: URL: https://github.com/apache/jackrabbit-oak/pull/1316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [PR] OAK-10669: Upgrade maven-versions-plugin to 2.16.2 [jackrabbit-oak]

2024-02-26 Thread via GitHub
reschke merged PR #1325: URL: https://github.com/apache/jackrabbit-oak/pull/1325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10668: examples: update jetty-maven-plugin to 11.0.20 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke opened a new pull request, #1324: URL: https://github.com/apache/jackrabbit-oak/pull/1324 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10668: examples: update jetty-maven-plugin to 11.0.20 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1324: URL: https://github.com/apache/jackrabbit-oak/pull/1324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10667: Update jacoco plugin to 0.8.11 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1323: URL: https://github.com/apache/jackrabbit-oak/pull/1323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10667: Update jacoco plugin to 0.8.11 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke opened a new pull request, #1323: URL: https://github.com/apache/jackrabbit-oak/pull/1323 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10666: oak-store-composite: update maven-depends plugin to 1.5.0 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1322: URL: https://github.com/apache/jackrabbit-oak/pull/1322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10665: Update checkstyle-plugin dependency to version 3.3.1 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1321: URL: https://github.com/apache/jackrabbit-oak/pull/1321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10665: Update checkstyle-plugin dependency to version 3.3.1 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke opened a new pull request, #1321: URL: https://github.com/apache/jackrabbit-oak/pull/1321 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10664: Update spotbugs plugin to 4.8.3.1 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1320: URL: https://github.com/apache/jackrabbit-oak/pull/1320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10664: Update spotbugs plugin to 4.8.3.1 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke opened a new pull request, #1320: URL: https://github.com/apache/jackrabbit-oak/pull/1320 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10663: Upgrade maven-bundle-plugin to 5.1.9 [jackrabbit-oak]

2024-02-25 Thread via GitHub
reschke merged PR #1319: URL: https://github.com/apache/jackrabbit-oak/pull/1319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10660: DocumentNodeStore: avoid repeated commits of :childOrder in branch commits [jackrabbit-oak]

2024-02-23 Thread via GitHub
reschke opened a new pull request, #1317: URL: https://github.com/apache/jackrabbit-oak/pull/1317 This is a proof of concept. It passes the new tests. The idea is to keep track of previous revisions in the branch, and to augment any change to _childOrder with removals of the previous

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-23 Thread via GitHub
smiroslav merged PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackr

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-23 Thread via GitHub
rishabhdaim commented on PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#issuecomment-1960920185 @reschke I am wondering if instead of modifying the existing `DocumentStore` classes we create a new wrapper over the DoocumentStore and perform all the diagnostic stuff there,

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-22 Thread via GitHub
rishabhdaim commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1499524843 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-22 Thread via GitHub
stefan-egli commented on PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1959685635 PS: unmerged branch commit GC might need some rework/review after introduction of orphaned node deletion GC -- This is an automated message from the Apache Git Service. To re

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-22 Thread via GitHub
stefan-egli commented on PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1959683912 fix attempt in https://github.com/apache/jackrabbit-oak/pull/1315/commits/21fc93adcf079ed31e8bae99c0ce4fccd91bb406 -- This is an automated message from the Apache Git Service

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-22 Thread via GitHub
stefan-egli commented on PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1959592672 ``` [INFO] Results: [INFO] Error: Failures: Error:BranchCommitGCTest.unmergedAddAndRemoveChild:372 expected:<0> but was:<1> Error: Errors: Error:B

Re: [PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-22 Thread via GitHub
stefan-egli commented on PR #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1959540796 Note that this PR also contains some new tests that were discovered while testing for orphaned node removal : lateWriteRemoveChildGC_noSweep (part of OAK-10535), lateWriteRemov

[PR] OAK-10659 : remove orphaned nodes/documents [jackrabbit-oak]

2024-02-22 Thread via GitHub
stefan-egli opened a new pull request, #1315: URL: https://github.com/apache/jackrabbit-oak/pull/1315 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-22 Thread via GitHub
mbaedke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1499134958 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-22 Thread via GitHub
reschke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1498889521 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497894711 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497883439 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497874038 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497871150 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497866061 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497853848 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497853848 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497849495 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +277,61 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497847325 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +277,61 @@ private static String diagsForEntry(Map.E

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497844697 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +278,73 @@ private static String diagsForEntry(M

Re: [PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314#discussion_r1497822015 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/util/Utils.java: ## @@ -274,6 +277,61 @@ private static String diagsForEntry(M

[PR] OAK-10657: shrink in-DB documents after updates fail due to 16MB limit [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke opened a new pull request, #1314: URL: https://github.com/apache/jackrabbit-oak/pull/1314 Just a proof-of-concept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke merged PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497414337 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentStoreEx

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497412750 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentStoreEx

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497347097 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentSto

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
reschke commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497317853 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentStoreEx

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497248562 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentSto

Re: [PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-21 Thread via GitHub
stefan-egli commented on code in PR #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313#discussion_r1497248562 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -2317,10 +2320,19 @@ private DocumentSto

[PR] OAK-10656: MongoDocumentStore: keep metrics about document size related exceptions [jackrabbit-oak]

2024-02-20 Thread via GitHub
reschke opened a new pull request, #1313: URL: https://github.com/apache/jackrabbit-oak/pull/1313 ...we can later expand this to cover different exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] OAK-10642: Add tests for operations on very large ordered collections [jackrabbit-oak]

2024-02-20 Thread via GitHub
mbaedke merged PR #1303: URL: https://github.com/apache/jackrabbit-oak/pull/1303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] Merge trunk [jackrabbit-oak]

2024-02-19 Thread via GitHub
mbaedke merged PR #1312: URL: https://github.com/apache/jackrabbit-oak/pull/1312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10642: Add tests for operations on very large ordered collections [jackrabbit-oak]

2024-02-16 Thread via GitHub
mbaedke commented on PR #1303: URL: https://github.com/apache/jackrabbit-oak/pull/1303#issuecomment-1948476731 3 new tests added, 2 of them are expected to fail when run in oak-jcr with ` mvn -DargLine="-Xmx4g" -Dupdate.limit=50 -Dnsfixtures="DOCUMENT_NS" clean install -Dtest=ManyChildre

[PR] OAK-10655 Improve error message in NonDefaultMountWriteReportingObserver [jackrabbit-oak]

2024-02-16 Thread via GitHub
kwin opened a new pull request, #1311: URL: https://github.com/apache/jackrabbit-oak/pull/1311 Do no longer generate an exception just for retrieving the stack trace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Repository writes in SegmentStoreMigrator blocked when migrating to Azure segment store [jackrabbit-oak]

2024-02-16 Thread via GitHub
smiroslav merged PR #1308: URL: https://github.com/apache/jackrabbit-oak/pull/1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackr

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
ahanikel commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946549614 Ah, I see, thanks! LGTM :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
smiroslav commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946415578 > But isn't tarFiles still "null" at that point, causing the NPE? Not after the changes I made in this PR. More specifically, initializing tar readers in the ```init``` met

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
ahanikel commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946399783 But isn't `tarFiles` still "null" at that point, causing the NPE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
smiroslav commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946373795 > But then, that is also true for a separate Map --- wouldn't that Map then grow exceptionally big for large repositories? No, that map contains only segments from the arc

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
ahanikel commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946357721 > Another issue could be if the segment is not in the tar archive that is being recovered. To find the segment in that case, we need TarReader to check other archives since we wil

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
smiroslav commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946314534 > Instead of creating a separate Map, can't we just put the recovered segment in the segment cache, like this? Hi @ahanikel The problem could be if the FileStore is st

Re: [PR] OAK-10649: MemoryDS: add toggle to limit document size [jackrabbit-oak]

2024-02-15 Thread via GitHub
reschke merged PR #1309: URL: https://github.com/apache/jackrabbit-oak/pull/1309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10649: MemoryDS: add toggle to limit document size [jackrabbit-oak]

2024-02-15 Thread via GitHub
reschke commented on code in PR #1309: URL: https://github.com/apache/jackrabbit-oak/pull/1309#discussion_r1491171408 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/memory/MemoryDocumentStore.java: ## @@ -98,6 +99,8 @@ public class MemoryDocumentS

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
smiroslav commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1946263265 @ahanikel, that actually might work as well and requires minimal code change. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] OAK-10649: MemoryDS: add toggle to limit document size [jackrabbit-oak]

2024-02-15 Thread via GitHub
rishabhdaim commented on code in PR #1309: URL: https://github.com/apache/jackrabbit-oak/pull/1309#discussion_r1491127201 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/memory/MemoryDocumentStore.java: ## @@ -16,6 +16,11 @@ */ package org.apach

Re: [PR] OAK-10649: MemoryDS: add toggle to limit document size [jackrabbit-oak]

2024-02-15 Thread via GitHub
rishabhdaim commented on code in PR #1309: URL: https://github.com/apache/jackrabbit-oak/pull/1309#discussion_r1491125739 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/memory/MemoryDocumentStore.java: ## @@ -98,6 +99,8 @@ public class MemoryDocum

Re: [PR] OAK-10653: BasicDocumentStore: handle DocumentStoreException on ds.create [jackrabbit-oak]

2024-02-15 Thread via GitHub
reschke merged PR #1310: URL: https://github.com/apache/jackrabbit-oak/pull/1310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10653: BasicDocumentStore: handle DocumentStoreException on ds.create [jackrabbit-oak]

2024-02-15 Thread via GitHub
reschke opened a new pull request, #1310: URL: https://github.com/apache/jackrabbit-oak/pull/1310 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] OAK-10649: MemoryDS: add toggle to limit document size [jackrabbit-oak]

2024-02-15 Thread via GitHub
reschke opened a new pull request, #1309: URL: https://github.com/apache/jackrabbit-oak/pull/1309 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Issue/oak 10636 [jackrabbit-oak]

2024-02-15 Thread via GitHub
ahanikel commented on PR #1296: URL: https://github.com/apache/jackrabbit-oak/pull/1296#issuecomment-1945802627 @smiroslav If I understand correctly, while the segment containing the blob reference is recovered, the file store tries to load that very segment uncached and fails. Instead of c

[PR] Repository writes in SegmentStoreMigrator blocked when migrating to Azure segment store [jackrabbit-oak]

2024-02-15 Thread via GitHub
smiroslav opened a new pull request, #1308: URL: https://github.com/apache/jackrabbit-oak/pull/1308 https://issues.apache.org/jira/browse/OAK-10652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] OAK-10643: MongoDocumentStore: improve diagnostics for too large docs [jackrabbit-oak]

2024-02-14 Thread via GitHub
reschke merged PR #1306: URL: https://github.com/apache/jackrabbit-oak/pull/1306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10281 : osgi config variant of recovery delay - vs system propert… [jackrabbit-oak]

2024-02-14 Thread via GitHub
stefan-egli merged PR #1288: URL: https://github.com/apache/jackrabbit-oak/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jac

Re: [PR] OAK-10650: MongoDocumentStore.findDocuments can fail with BSON exception [jackrabbit-oak]

2024-02-14 Thread via GitHub
reschke merged PR #1307: URL: https://github.com/apache/jackrabbit-oak/pull/1307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10650: MongoDocumentStore.findDocuments can fail with BSON exception [jackrabbit-oak]

2024-02-14 Thread via GitHub
reschke opened a new pull request, #1307: URL: https://github.com/apache/jackrabbit-oak/pull/1307 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] add missing filterSet to scrFilter [jackrabbit-filevault]

2024-02-14 Thread via GitHub
kwin commented on PR #332: URL: https://github.com/apache/jackrabbit-filevault/pull/332#issuecomment-1943676325 @Walter-Steiner Thanks again, I just merged it. The fix should be part of the next release (not yet scheduled). -- This is an automated message from the Apache Git Service. To

Re: [PR] add missing filterSet to scrFilter [jackrabbit-filevault]

2024-02-14 Thread via GitHub
kwin merged PR #332: URL: https://github.com/apache/jackrabbit-filevault/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

Re: [PR] add missing filterSet to scrFilter [jackrabbit-filevault]

2024-02-14 Thread via GitHub
Walter-Steiner commented on PR #332: URL: https://github.com/apache/jackrabbit-filevault/pull/332#issuecomment-1943384981 Thanks @kwin for looking into this, I created https://issues.apache.org/jira/browse/JCRVLT-746 for it. Now the commit message does not contain this JIRA ID, but I hope

[PR] OAK-10643: MongoDocumentStore: improve diagnostics for too large docs [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke opened a new pull request, #1306: URL: https://github.com/apache/jackrabbit-oak/pull/1306 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] add missing filterSet to scrFilter [jackrabbit-filevault]

2024-02-13 Thread via GitHub
kwin commented on PR #332: URL: https://github.com/apache/jackrabbit-filevault/pull/332#issuecomment-1942131387 Thanks a lot for the PR @Walter-Steiner. Can you open an according issue in https://issues.apache.org/jira/projects/JCRVLT/summary so that we can track that properly? A test woul

Re: [PR] OAK-10645: MongoDS docker container: set default Mongo version to 4.4 [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke merged PR #1305: URL: https://github.com/apache/jackrabbit-oak/pull/1305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10645: MongoDS docker container: set default Mongo version to 4.4 [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke opened a new pull request, #1305: URL: https://github.com/apache/jackrabbit-oak/pull/1305 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10639 : NodeImpl calculate mixinTypes lazy [jackrabbit-oak]

2024-02-13 Thread via GitHub
joerghoh merged PR #1300: URL: https://github.com/apache/jackrabbit-oak/pull/1300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

Re: [PR] OAK-10644: JsopBuilder: remove JDK6ism [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke commented on PR #1304: URL: https://github.com/apache/jackrabbit-oak/pull/1304#issuecomment-1941378248 trunk: [f7b20aa777|https://github.com/apache/jackrabbit-oak/commit/f7b20aa777a4d95a8f8a54ee020b86cd35ee30c1] -- This is an automated message from the Apache Git Service. To respo

Re: [PR] OAK-10644: JsopBuilder: remove JDK6ism [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke merged PR #1304: URL: https://github.com/apache/jackrabbit-oak/pull/1304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[PR] OAK-10644: JsopBuilder: remove JDK6ism [jackrabbit-oak]

2024-02-13 Thread via GitHub
reschke opened a new pull request, #1304: URL: https://github.com/apache/jackrabbit-oak/pull/1304 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] OAK-10281 : osgi config variant of recovery delay - vs system propert… [jackrabbit-oak]

2024-02-12 Thread via GitHub
rishabhdaim commented on PR #1288: URL: https://github.com/apache/jackrabbit-oak/pull/1288#issuecomment-1938234187 My Vote in preferred order : 3 > 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] OAK-10281 : osgi config variant of recovery delay - vs system propert… [jackrabbit-oak]

2024-02-11 Thread via GitHub
mbaedke commented on PR #1288: URL: https://github.com/apache/jackrabbit-oak/pull/1288#issuecomment-1938178323 Maybe I'm just stupid, but I fail to see why the use of a static field is an antipattern in this particular case. -- This is an automated message from the Apache Git Service. To

[PR] add missing filterSet to scrFilter [jackrabbit-filevault]

2024-02-09 Thread via GitHub
Walter-Steiner opened a new pull request, #332: URL: https://github.com/apache/jackrabbit-filevault/pull/332 After a lot of searching I found the following error in the class "org.apache.jackrabbit.vault.rcp.impl.RcpTaskImpl": private static WorkspaceFilter createFilterForExcludes(Lis

[PR] OAK-10642: Add tests for operations on very large ordered collections [jackrabbit-oak]

2024-02-09 Thread via GitHub
mbaedke opened a new pull request, #1303: URL: https://github.com/apache/jackrabbit-oak/pull/1303 Testing repeated reordering in a long running transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Issue/granite 10642 [jackrabbit-oak]

2024-02-09 Thread via GitHub
mbaedke closed pull request #1302: Issue/granite 10642 URL: https://github.com/apache/jackrabbit-oak/pull/1302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Issue/granite 10642 [jackrabbit-oak]

2024-02-09 Thread via GitHub
reschke commented on PR #1302: URL: https://github.com/apache/jackrabbit-oak/pull/1302#issuecomment-1935935014 Rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Issue/granite 10642 [jackrabbit-oak]

2024-02-09 Thread via GitHub
mbaedke opened a new pull request, #1302: URL: https://github.com/apache/jackrabbit-oak/pull/1302 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

<    6   7   8   9   10   11   12   13   14   15   >