Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159014671
Re: `ResultSet`: Yes and, I think you want to avoid using them again even
if they are not complete. As soon as a thread has called `::next` even once,
they are no longer
A while ago, I broached the topic of code standards, and there was a certain
amount of agreement on a few general points, none of which were terribly
controversial.
I want to open a similar topic: code formatting. There are a variety of
different forms of code layout in Jena, which is not
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022611#comment-15022611
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
Rob Vesse created JENA-1075:
---
Summary: NPE in Elephas for Turtle inputs
Key: JENA-1075
URL: https://issues.apache.org/jira/browse/JENA-1075
Project: Apache Jena
Issue Type: Bug
[
https://issues.apache.org/jira/browse/JENA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022026#comment-15022026
]
ASF subversion and git services commented on JENA-1075:
---
Commit
[
https://issues.apache.org/jira/browse/JENA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rob Vesse resolved JENA-1075.
-
Resolution: Fixed
> NPE in Elephas for Turtle inputs
>
>
>
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158934853
I see, thanks for the clarification. But I think my question about what
kind of code we want is still valid - after all, this isn't my project, but
maintained collectively.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158935620
Sure, I was just responding to the question about commits. I agree that
code must be written in a style that supports maintenance over the long term.
I'd make two points
[
https://issues.apache.org/jira/browse/JENA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022115#comment-15022115
]
A. Soroka commented on JENA-1074:
-
Is it absolutely necessary for a `DatasetGraph` to support union graph?
[
https://issues.apache.org/jira/browse/JENA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022115#comment-15022115
]
A. Soroka edited comment on JENA-1074 at 11/23/15 1:53 PM:
---
Is it absolutely
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605114
--- Diff: .travis.yml ---
@@ -0,0 +1,22 @@
+ # Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
I think Travis-CI is
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022119#comment-15022119
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022126#comment-15022126
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158940056
I'm not usually one to complain about this sort of thing, but there is so
much whitespace-change noise in this that it is _really_ hard to figure what
has actually been
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158932591
Thanks @ajs6f - there's quite a lot of fixes in here!
In general, I feel positive about cleanups like this. And it's nice to have
a patch which actually *reduces*
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158933847
Maybe there's confusion about what this PR is for-- I wasn't intending that
it would be merged, but that you would use it as a source of examples, like I
wrote. The
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158938940
Just to be clear, I don't mean to argue that Jena's code is particularly
archaic, just that we should aim for balance between taking advantage of new
capabilities and
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022118#comment-15022118
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605185
--- Diff:
jena-arq/src/main/java/org/apache/jena/atlas/json/io/JSWriter.java ---
@@ -67,7 +67,7 @@ public void startOutput() {}
public static final
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605299
--- Diff:
jena-arq/src/main/java/org/apache/jena/query/ResultSetFormatter.java ---
@@ -48,7 +48,7 @@
public class ResultSetFormatter {
// See also
On 22/11/15 23:16, Gregor Trefs wrote:
Dear Jena Devs,
I am further into my application and think I found a violation of the
Liskov Substitution principle. In short, the principle states that using a
subtype of a type should not alter the meaning of the application. While I
was driving my
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45619712
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseOutputStream.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45619804
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseOutputStream.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620222
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseResultSet.java
---
@@ -309,13 +296,81 @@ private static void
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022340#comment-15022340
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user samaitra commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158972335
@ajs6f I agree. Earlier the PR had changes to jena-base and jena-arq
modules but now I have cleaned up. The files changes required are only in
jena-fuseki2 module.
---
A weightless +1 from me, of course! {grin} I’m excited to see this stuff get in
front of people.
I’m not sure what you mean by “Fuseki integration”, Andy. Do you mean to make
the new dataset impl available as an option in Fuseki (presumably in both the
web admin UI and the CLI for the
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022312#comment-15022312
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158980337
I'm honestly more and more confused about the design here, using
`CacheAction` and `CacheEntry`. It seems that the same work could be
accomplished more clearly either by
Github user rvesse commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158986763
Re: @ajs6f
> All of your commits will get squashed before merge anyway
I don't remember us ever adopting a policy that we squash PRs before
merging them. If
[
https://issues.apache.org/jira/browse/JENA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022279#comment-15022279
]
A. Soroka commented on JENA-1068:
-
Ooh, don't know if it matters, but {{DatasetInMemory}} definitely
Github user samaitra commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45617171
--- Diff: .travis.yml ---
@@ -0,0 +1,22 @@
+ # Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
Sure, will discuss in
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022289#comment-15022289
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022349#comment-15022349
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022365#comment-15022365
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022319#comment-15022319
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620264
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022328#comment-15022328
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022330#comment-15022330
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022362#comment-15022362
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on a diff in the pull request:
Github user samaitra commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45621633
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheEntry.java
---
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022403#comment-15022403
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022376#comment-15022376
]
Andy Seaborne commented on JENA-1068:
-
That's is (and was) OK for {{DatasetImpl}}. The code check
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022419#comment-15022419
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022462#comment-15022462
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158987655
@rvesse Sorry, I didn't phrase that well. I meant that commits _can_ get
squashed, so there's no need to worry about making extra ones.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022433#comment-15022433
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on the pull request:
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158996139
If I understand you correctly, and you are providing `ResultSet` as the
cached value in some cases, are you dealing with threading? That is, are you
ensuring that you don't
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022448#comment-15022448
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-159004022
@osma makes a valid point - Java8 is still quite new and many (most?)
people are not going to see some of the new idioms as natural or easier, and
they can be slower.
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022552#comment-15022552
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on the pull request:
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159007190
Re squashing commits. Apparently, some projects do have such a policy -
sort of moving from the details of initial development outside Apache to
merging. What is very
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022572#comment-15022572
]
ASF GitHub Bot commented on JENA-626:
-
Github user afs commented on the pull request:
Github user samaitra commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159005263
Yes, using `byte[]` to store the result data. I am adding more tests to
validate concurrent operations.I will ensure to return copy of `ResultSet` and
not to write back
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-159008507
Sure, @afs . It might be good to get some of this written down in the docs.
I'll happily close this PR and leave the one directly to @osma's clone in place
for him to do
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159011031
@afs Yes, I work on other projects where that is the case. My feeling is
that (irrespective of policy) it's good form to squash down, not all the way to
one commit, but down
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022591#comment-15022591
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022293#comment-15022293
]
ASF GitHub Bot commented on JENA-626:
-
Github user samaitra commented on the pull request:
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45621175
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java
---
@@ -92,13 +93,15 @@ protected void
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022393#comment-15022393
]
ASF GitHub Bot commented on JENA-626:
-
Github user rvesse commented on the pull request:
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45625411
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022415#comment-15022415
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158994873
I'm not quite clear what you mean by "I faced error as ResultSet is closed,
Query execution error." Do you mean that the `ResultSet` cannot be rewound for
repeated use? And
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022450#comment-15022450
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022307#comment-15022307
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on the pull request:
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022321#comment-15022321
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620403
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/JENA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022344#comment-15022344
]
ASF GitHub Bot commented on JENA-626:
-
Github user ajs6f commented on a diff in the pull request:
Github user samaitra commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45621558
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
69 matches
Mail list logo
