Re: Contribution to Documentation of InfluxDBClient

There is a tiny bit of documentation for the raw one here https://jmeter.apache.org/usermanual/component_reference.html#Backend_Listener But I think updating the real time results page is a great idea. I'm happy to help review any PR you may create. Thanks Graham On Sat, 2 Jan 2021, 17:02 Frank

Re: Setting better defaults for HTTP request

I agree, setting those as defaults is much better than infinite and less concerning than 10s/60s. They probably won't do much to stop people complaining about JMeter hanging on shutdown, was this lack of default timeout the root cause of those complaints or is there something else we can do with t

Re: Setting better defaults for HTTP request

I think it's a good idea, as long as we make it very obvious how to change it in the UI and failure/error message. Would it affect existing scripts? I can imagine some existing (and indeed new) tests might start failing with a 60s read timeout due to some slow calls. Graham On Sat, 19 Dec 2020,

Re: [VOTE] Release JMeter 5.4 RC1

A small thing from me, I noticed that the Raw InfluxDB Backend Listener (https://github.com/apache/jmeter/pull/544) wasn't mentioned in the change log. Could someone add it before the RC2? Thanks! Graham On Wed, 25 Nov 2020 at 17:46, Milamber wrote: > > Hello, > > Please ping me when I can star

Re: Screenshots: documentation, pull requests

Great idea. There is a lot of room for improvement here. Is there somewhere we can host them, like netlify or S3, instead of git? What about the custom highlights around specific parts of the screenshot, is that easy to automate too, but maybe not essential? Graham On Wed, 25 Mar 2020, 21:42 Vl

Send raw results to InfluxDB?

Hi all Is it possible to send raw results to InfluxDB? When I've read the docs and looked at the current BackendListeners it seems we only send summary stats (despite summaryStats=false) I've created a PR which achieves largely what I expected the InfluxDB listner to do https://github.com/apache

Re: JMeter 4.0RC... is still at http://home.apache.org/~milamber/jmeter-...

I think we should, https should improve search rankings. On Wed, 2 Oct 2019 at 19:34, Philippe Mouawad wrote: > > Hello, > Yes we should > > Also I am wondering if we should not ask Infra to redirect http to https > with 301. > > Regards > > On Wed, Oct 2, 2019 at 8:29 PM Vladimir Sitnikov < > si

Re: JUnit5 vs JUnit4

Sounds good to me too, and if any are stubborn, or would look better as Spock tests, perhaps we can re-write them? I can attempt this tonight if no-one else has currently started it? Graham On Wed, 2 Oct 2019 at 17:24, Philippe Mouawad wrote: > > Ok by me > > On Wed, Oct 2, 2019 at 4:12 PM Vlad

Re: Eclipse and hamcrest

If we were looking at replacements I like Google Truth, it's like AssertJ but often with better error messages and with both the code reads more naturally than Hamcrest imo e.g. assertThat(result).isEmpty(); Almost as good as Spock ;) result.isEmpty() On Sat, 28 Sep 2019, 17:30 Felix Schumacher

Re: Replacing nashorn

Option 4, also deprecate and remove support for JS and provide a guide on how to migrate to Groovy? Graham On Wed, 24 Jul 2019, 07:11 Jmeter Tea, wrote: > Hello, > There's GraalVM JavaScript with optional "Nashorn compatibility mode" > > https://github.com/graalvm/graaljs/blob/master/docs/user/

Re: [VOTE] GitHub: disable merge button?

+1 Vladimir, thank you for all your work on migrating to git. I generally prefer "squash and merge". Especially when there is a lot of "noise" in the PR commit history: e.g. "fixed CI", "opps, really fixed CI" etc. Also if the PR is small, a single commit is easier to understand (and even remove

Re: Migrating build system to Gradle

mitted. If that happens, we all save the time in the first place > > Not sure what build script you are referring to. > > > D) Only in case you (or someone else) happen to claim a veto, then we would > > have an interesting conversation. > > > > Of course I would appreciat

Re: Migrating build system to Gradle

Sat, Feb 23, 2019 at 11:49 AM Philippe Mouawad > > wrote: > > > > > > On Sat, Feb 23, 2019 at 5:24 PM Graham Russell wrote: > > > > > > > Sebb: > > > > I will try again on a new VM and write them up, perhaps on Monday. > > > >

Re: Migrating build system to Gradle

feasible as a first step > to delegate dependencies management to Gradle ? > I think it would possibly improve already developer experience. > > Thanks > > > On Sat, Feb 23, 2019 at 11:50 AM Graham Russell wrote: > > > +1 to move to Gradle. > > > > I think

Re: Build failed in Jenkins: JMeter-trunk #7103

Great, thanks. Also, thank you for the rapid PR merge! On Sat, 23 Feb 2019 at 15:32, Philippe Mouawad wrote: > > Yes, I fixed it. > Jenkins should complete successfully now. > > On Sat, Feb 23, 2019 at 4:28 PM Graham Russell wrote: > > > This might be caused by having

Re: Build failed in Jenkins: JMeter-trunk #7103

This might be caused by having both 1.0 and 1.2 in the lib folder, are old jars removed from the Jenkins job? The tests pass on my machine at current trunk. On Sat, 23 Feb 2019 at 15:19, Apache Jenkins Server wrote: > > See > >

Re: Migrating build system to Gradle

+1 to move to Gradle. I think the biggest benefit of moving to Gradle is that it will lead to more contributions. People will no longer have to fight to get the code to import into an IDE (i.e. IntelliJ), compile and successfully run tests. I've just got a new laptop and it took me too long to ge

Re: Migrate SVN -> Git

+1 for moving to git. I think the biggest benefit to move to git is that it will make the merging of all the PRs we get on the github mirror easier ;) Which might then lead to more people more willing to do it and therefore lead to more contributions. Does anyone know the ratio of Github PRs to p

Re: Test Results Analyzer isn't working

I agree. The batch tests are so slow, partly because they run in sequence. It would be good to make sure they are actually useful tests and add/remove as necessary. I was looking into running them in parallel, and found it easier with gradle. Gradle can also import the existing ant script and see

Re: Controversial topic: Remove internationalization

I don't think translations should be removed. I think they add value to those who do not have a good understanding of English. We don't have any usage metrics so it's hard to tell how much they are used. Regarding it being unprofessional, I agree, but I do not think it is an issue, especially if E

Re: Weird Test failure

If someone implementing the unit tests (and Felix) made that mistake is there a way for us to prevent users making the same mistake? On Sat, 30 Dec 2017 at 23:39 Felix Schumacher < felix.schumac...@internetallee.de> wrote: > > > Am 30. Dezember 2017 16:06:34 MEZ schrieb Philippe Mouawad < > phili

Re: Menu item ordering

the feature, it didn't ordered it. >> >> Maybe it could be no more compatible with some evolutions you planned and >> that avoids it anyway. >> Or we could try to make these approaches complementary too... >> >> Anyway, I stay really interested in JMeter usabi

Re: Menu item ordering

uickly usable. > I hope beiing wrong and I'm waiting for a quicker menu navigation mechanism > even it is not a submenu one ;). > > Thanks for all the work you provide to improve JMeter. > > Vincent > > Le mar. 12 déc. 2017 à 14:29, Graham Russell a écrit : > >>

Re: Menu item ordering

tonio Gomes Rodrigues a >> écrit : >> >> > Hi, >> > >> > About advanced mode, some code has been written and maybe we need to >> remove >> > it and discuss again and finish it. >> > >> > Yes, it's hockey. >> > >>

Re: Menu item ordering

ent we have shortcuts > > +1 for your solution > > Antonio > > > 2017-12-10 19:36 GMT+01:00 Graham Russell : > > > Hi all > > > > Currently the menus are ordered alphabetically, which is fine for > > small menus, and better than not at all for the larg

Menu item ordering

Hi all Currently the menus are ordered alphabetically, which is fine for small menus, and better than not at all for the large ones, however I think we can do better. If the menu has more than 4-5 items in it I think we should split it up into chunks of 5-7 with the most popular (e.g. HTTP Reques

Re: ExternalSampleSorter#sortSamplesParallel

I agree with Felix, however I cannot see where the code is being used. If someone could explain where and how it's being used then I'm happy to help test it, otherwise this is more code to delete. On Tue, 28 Nov 2017 at 21:30 Philippe Mouawad wrote: > Hi Graham, > Resurecting this question from

Re: Screenshot in doc

I don't think it should stop a release, but if someone has the time to re-take most (all) of them, then I think screenshots with the new default LaF would be best. P.S. please make sure pngquant or something like tinypng.com is used to ensure the files are a small as possible - we wouldn't want ou

ExternalSampleSorter

Hi all Does anyone know if org.apache.jmeter.report.processor.ExternalSampleSorter is used? I am trying to unit test it (and think I may have found a small bug in CsvSampleReader) but it doesn't look like ExternalSampleSorter is used in our codebase, nor anyone else's (that Google can see). Can w

Re: Remove comments about object ages in bin/jmeter

+1 to remove the link (or replace with a modern alternative?) +0 to remove the text On Sun, 26 Nov 2017 at 21:35 Antonio Gomes Rodrigues wrote: > Hi, > > In bin/jmeter we have > > # > # Original page has disappeared, it is now only available at: > # > > https://web.archive.org/web/20060614151434

Re: ApacheJMeter_parent.pom test dependencies

Yes, you might be right. It would make sense to add them to the test scope if this doesn't break the maven release as they shouldn't be part of any release. On Sat, 25 Nov 2017 at 17:30 Philippe Mouawad wrote: > Hello, > I am wondering if we don't have an issue with our dependencies: > > Shouldn

Re: Static Analysis Issues

I've raised https://issues.apache.org/jira/browse/INFRA-15530 I guess we can turn it off or tune the gate if we find it too noisy. On 21 November 2017 at 21:48, Philippe Mouawad wrote: > Hi Graham, > My answers below. > Regards > > On Sun, Nov 19, 2017 at 3:09 PM, Graham Rus

Deprecated Classes

I came across the following classes, in org.apache.log, which are deprecated and the comment says will be removed in 3.3, but they still seem to be here: LogEvent ContextMap LogTarget Logger Priority Was this an oversight or should these have been removed? Thanks Graham

Re: Static Analysis Issues

Sun, 19 Nov 2017, 11:11 Philippe Mouawad, wrote: > Hello, > It should be possible by configuring Quality Gate to fail . > Regarding notifications, I think we must open a request towards Infra team. > > Regards > > On Sun, Nov 19, 2017 at 11:56 AM, Graham Russell > wrote:

Re: Mocking Framework

k/docs/1.0/ alongside the tests I've created, it has more detail about Mock/Spy/Stubs in Spock. Thanks Graham On Sun, 22 Jan 2017 at 12:43 Graham Russell wrote: > > I've added a few more tests which make more use of mocks and I've refactored AbstractJDBCTestElement a little:

Static Analysis Issues

All Do we get notifications of sonar issues? I've just noticed that 8 "bugs" were introduced yesterday: https://builds.apache.org/analysis/component_issues?id=org.apache.jmeter%3AJMeter#resolved=false|types=BUG Is it also possible to get it to check PRs as we do with codecov, is this one for ifra

Re: XPath Extractor : Drop Tidy Option

+0 I agree that CSS should be preferred for HTML and, in general, I'm in favour of removing seldom used/broken bits of functionality which don't warrant the cost of keeping them around, but I don't know enough about it nor how often XPath is currently used by people to say +1 for this yet. Maybe

Re: Validate Functionality

_bug.cgi?id=61755 > > Regards > > > On Fri, Nov 10, 2017 at 11:34 PM, Graham Russell wrote: > >> I will list the user steps to see if that is clearer: >> >> 1. User right clicks on thread group (or has one selected, or any >> sub-part, and clicks "

Re: Validate Functionality

PACK Support < supp...@ubikloadpack.com> wrote: > Hi Graham, > My answers below. > Regards > > On Fri, Nov 10, 2017 at 6:27 PM, Graham Russell wrote: > > > I thought I'd start a new thread as not to derail the Workbench one. > > > > You understood correctly, t

Validate Functionality

your answers and feedback. My answers below. Regards On Fri, Nov 10, 2017 at 5:26 PM, Graham Russell wrote: > +1 > > ... > I think to improve the UX would be to enable running of individual thread > groups, single threaded with a tree results view (that you don't have t

Re: Workbench : Let's drop it ?

+1 I think dropping it will simplify the code and the UX in the most efficient way, especially as time is always short for contributors. It seems generally confusing and not especially useful: https://stackoverflow.com/questions/44746278/why-workbench-is-shown-as-default-in-jmeter http://blog.sou

Re: Workbench : Let's drop it ?

I agree. It's confusing/distracting for new users and I've never seen anyone use it (on purpose). It would be best if we had usage data but I'm sure there will be an outpouring of complaints if this is a well used feature. I'm always in favour of removing seldom used features/code it often helps

Re: Drop HTMLAssertion

+1 Sounds good to me too; I only really use the "Response Assertion". I think it's a good thing to remove rarely used features to save effort reading/testing/maintaining/fixing/supporting these. Thanks Graham On 25 February 2017 at 22:17, Philippe Mouawad wrote: > Hello, > I propose to drop HT

Re: Zoom-In/Out

I will attached the screenshot to the bz. Should the icons also scale? On 25 February 2017 at 09:24, Felix Schumacher wrote: > > > Am 24. Februar 2017 23:12:07 MEZ schrieb Graham Russell : >>Felix, I'm using: >>java version "1.8.0_121" >>Java(TM) SE Runti

NPE during GUI launch on latest trunk

Hi all I just tried to run `ant run_gui` on the latest (github) trunk but this results in an NPE - specifically when trying to create the JMeterTreeModel. Any ideas? Thanks Graham The JMeter log is: 2017-02-25 13:26:50,223 INFO o.a.j.u.JMeterUtils: Setting Locale to en_GB 2017-02-25 13:26:50,

Re: Zoom-In/Out

t. I just thought it worth noting that it doesn't behave the same, which might point to a deeper issue? Thanks Graham On Sun, 12 Feb 2017 at 20:49 Felix Schumacher wrote: > > > Am 11. Februar 2017 22:49:56 MEZ schrieb Graham Russell >: > >I've also added a scr

Re: Proposition for contribution

As Philippe said I've started a test for the JDBCSampler and AbstractJDBCTestElement using Spock: https://github.com/ham1/jmeter/blob/spock/test/src/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerSpec.groovy but until we decide which Mocking/testing framework to use it would be great to get som

Re: INFRA-13535

Great, thanks for getting that sorted. How do we see the sonar reports? A quick google and wiki search didn't help. Thanks Graham On 18 February 2017 at 09:51, Philippe Mouawad wrote: > New version has been setup. > False positive on streams have disappeared but it seems analysis has deepen >

Re: Code Style Guidelines

On 11 February 2017 at 23:14, Philippe Mouawad wrote: > On Sat, Feb 11, 2017 at 11:27 PM, Graham Russell wrote: > >> Hi all >> >> Do we have any (written) guidance on code style? >> >> I know we have checkstyle, but this has very few rules. >> >>

Code Style Guidelines

Hi all Do we have any (written) guidance on code style? I know we have checkstyle, but this has very few rules. The reason for asking is that I think having a consistent style is very important for readability (which helps writing new feature or fixing existing code etc.). The main things I thi

Re: Zoom-In/Out

I've also added a screenshot after zooming in (many times to make the changes obvious) on Linux mint. It doesn't seem to work quite as well as the others. On 11 February 2017 at 21:44, Philippe Mouawad wrote: > Hi Felix, > I've attached screenshot to bugzilla for Windows 7 Pro and MacOSX > ElCapi

Re: Wiki Contributors Group

Thank you. On 11 February 2017 at 21:36, sebb wrote: > Should be OK now > > On 11 February 2017 at 20:15, Graham Russell wrote: >> Sorry, I still don't seem to be able to edit the wiki. >> Have I missed a big edit button somewhere or was I added to the wrong group? &g

Re: JAVA 8 interesting

Philippe Good find - thanks for sharing. I think some of those topics might be worth further discussion regarding how/if we use them in the future. * Optional: I like the idea of using Optional for return types (where null is/could be returned) - however it might not be worth the change/effort?

Re: Wiki Contributors Group

Sorry, I still don't seem to be able to edit the wiki. Have I missed a big edit button somewhere or was I added to the wrong group? It says on the front page I need to be part of: https://wiki.apache.org/jmeter/ContributorsGroup Thanks Graham On 11 February 2017 at 20:11, Graham Russell

Re: Wiki Contributors Group

Thank you. On 11 February 2017 at 20:09, Antonio Gomes Rodrigues wrote: > Hi, > > Done > > Antonio > > 2017-02-11 20:59 GMT+01:00 Graham Russell : > >> Hi >> >> Could someone please add me (username: ham1) to the Contributors Group >> in the wi

Wiki Contributors Group

Hi Could someone please add me (username: ham1) to the Contributors Group in the wiki? I'd initially like to remove some dead links from the home page. Many thanks Graham

Re: Test Failures on latest trunk

humacher wrote: > > > Am 11. Februar 2017 17:59:03 MEZ schrieb Graham Russell : >>Hi all >> >>When I run ant test I see ~50 test failures, all with a similar >>message: >>[java] 51) testArguments(org.apache.jmeter.testelement.PackageTest) >> [jav

Test Failures on latest trunk

Hi all When I run ant test I see ~50 test failures, all with a similar message: [java] 51) testArguments(org.apache.jmeter.testelement.PackageTest) [java] java.lang.NoSuchFieldError: log I've tried download_jars as well but this didn't seem to fix the issues. I've also tried: "ant -Djav

Re: svn commit: r1780852 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java

The same failure is happening on Travis as well: https://travis-ci.org/apache/jmeter/jobs/198595940 Graham Graham On 5 February 2017 at 16:40, Milamber wrote: > > > On 29/01/2017 20:35, pmoua...@apache.org wrote: >> >> Modified: >> jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/T

Re: Participate to Google Summer of Code

I think it's a good idea - especially h/2 support. My only suggestion beyond those would be: Study and improve the UX - especially for novice users/basic actions. Thanks Graham Graham On 3 February 2017 at 19:56, Philippe Mouawad wrote: > Hello, > What do you think of submitting a project to

Re: Mocking Framework

anks Graham P.S. Sorry for the extra whitespace fixes/changes, it's just a habit - I could remove it and squash commits if that would help reviewing? On 12 January 2017 at 20:11, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Am 12.01.2017 um 19:47 schrieb Graham R

Re: Mocking Framework

tructure and built-in Mock/Spy/Stubs. It is also possible to mock static Java methods with Spock and PowerMock (see: https://dzone.com/articles/mocking-static-methods-groovy). Thanks Graham On 19 December 2016 at 11:47, Felix Schumacher < felix.schumac...@internetallee.de> wrote: >

Re: Mocking Framework

Felix I really like using spock. I'm not sure how to get it working with ant, but I'm sure it's doable. I should have some time in the new year to try adding some spock tests if that's useful? Please see: https://mechanitis.blogspot.com/2013/12/spock-data-driven-testing.html and the two other po

Re: [GitHub] jmeter pull request: Removing unnecessary (un)boxing

Hi Sebb Thanks for having a look through the PR. I appreciate all the work you do with JMeter! I do not fully understand your argument. Do you have an example of issues to help me understand where explicit (un)boxing would help prevent a problem? My main reason for the PR was to reduce the amoun

Re: JPopupMenu Behaviours

sn't there when using the mouse to click the menu item - I've only tested it on Linux. Is anyone able to take a look? Thanks Graham Graham On 19 October 2014 00:12, Graham Russell wrote: > Hi all > > I've been looking at the below bug about adding test ele

JPopupMenu Behaviours

Hi all I've been looking at the below bug about adding test elements using the keyboard: https://issues.apache.org/bugzilla/show_bug.cgi?id=54784 I've managed to get the popup menu to appear in the expected location when shift + F10 (or the context menu key) is pressed (in JMeterTreeListener.jav

IDEs and Java Formatting

Hi all I've recently started to look at/contribute to the JMeter code and I've noticed that there are quite a few formatting inconstancies, which I find quite distracting (especially those relating to indentation) when trying to efficiently read and understand code. I use Eclipse as my Java IDE.