Hi Tom
My initial thought was that the constructor with config and delegator would be
for testing while the one with config is the one that will be used by MM2.
I can removed one of them and keep only one.
Sent from my iPhone
> On 22 Jun 2022, at 08:15, Tom Bentley wrote:
>
> Hi Omnia,
>
>
Seamus O Ceanainn created KAFKA-13448:
-
Summary: Kafka Producer Client Callback behaviour does not align
with Javadoc
Key: KAFKA-13448
URL: https://issues.apache.org/jira/browse/KAFKA-13448
+1 (non-binding)
On 2021/06/09 15:31:13, Dongjin Lee wrote:
> Bumping up the voting thread.
>
> Please note that today is the KIP freeze day.
>
> Thanks,
> Dongjin
>
> On Mon, Jun 7, 2021 at 9:28 PM Dongjin Lee wrote:
>
> > Bumping up the voting thread.
> >
> >
> > As a reminder: Please not
Continuing to use log4j would leave several known security vulnerabilities in
Apache Kafka, including https://nvd.nist.gov/vuln/detail/CVE-2019-17571. The
Apache log4j team will not fix this vulnerability and is urging an upgrade to
log4j2. See https://logging.apache.org/log4j/1.2/ for further
Anna O created KAFKA-7108:
-
Summary: "Exactly-once" stream breaks production exception handler
contract
Key: KAFKA-7108
URL: https://issues.apache.org/jira/browse/KAFKA-7108
Project: Kafka
Anna O created KAFKA-6825:
-
Summary: DEFAULT_PRODUCTION_EXCEPTION_HANDLER_CLASS_CONFIG is
private
Key: KAFKA-6825
URL: https://issues.apache.org/jira/browse/KAFKA-6825
Project: Kafka
Issue Type
Anna O created KAFKA-6793:
-
Summary: Unnecessary warning log message
Key: KAFKA-6793
URL: https://issues.apache.org/jira/browse/KAFKA-6793
Project: Kafka
Issue Type: Bug
Components
Colm O hEigeartaigh created KAFKA-4771:
--
Summary: NPEs in KerberosLogin due to autoboxing
Key: KAFKA-4771
URL: https://issues.apache.org/jira/browse/KAFKA-4771
Project: Kafka
Issue Type
HI, My Frends:
Sorry,Just send pictures don't show.I change to text.
I come from China??
I had a problem, I try to solve for a long time can not be resolved.
I also found to a similar article, but did not answer.
http://permalink.gmane.org/gmane.comp.apache.kafka.devel/1854
db1b0ee9113215b5ad7fda0f93915f3bdd34ac55
core/src/main/scala/kafka/utils/CoreUtils.scala
168a18d380c200ee566eccb6988dd1ae85ed5b09
Diff: https://reviews.apache.org/r/35880/diff/
Testing
---
Thanks,
Manikumar Reddy O
://reviews.apache.org/r/34805/diff/
Testing
---
Thanks,
Manikumar Reddy O
On Aug. 20, 2015, 11:07 a.m., Edward Ribeiro wrote:
> > Also do want to include patch for second point given in JIRA decription..
just read previous reviews..ignore my comment.
- Manikumar Reddy
---
This is an automatically generated e-
)
<https://reviews.apache.org/r/36578/#comment151144>
The warning message can be : "WARNING: %s has been increased beyond the
default max value of %d, update producer and consumer settings as well"
Also do want to include patch for second point given in JIRA decription..
- Maniku
ached mode. thanks for the review.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35867/#review95902
---
On Aug. 20, 2
/diff/
Testing
---
Thanks,
Manikumar Reddy O
To reply, visit:
https://reviews.apache.org/r/35867/#review92404
---
On Aug. 9, 2015, 9:37 a.m., Manikumar Reddy O wrote:
>
> ---
> This is an automaticall
to explicitly register the app info in the
consumer/producer/broker.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35867/#review92078
------
hanks,
Manikumar Reddy O
d status is
given more preference than in-progress error status.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34641/#review92024
---
view92403
---
On Aug. 5, 2015, 3:19 p.m., Manikumar Reddy O wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
https://reviews.apache.org/r/34641/diff/
Testing
---
Thanks,
Manikumar Reddy O
> brokers/clients are running the same version or not.
Implemented a simple finger print (commitId.hashcode()) mechanism. I felt
commit.hashCode() should be sufficient for our requirement.
- Manikumar Reddy
---
This is an automatically gener
Diff: https://reviews.apache.org/r/35867/diff/
Testing
---
Thanks,
Manikumar Reddy O
org/r/34641/diff/
Testing
---
Thanks,
Manikumar Reddy O
d". However, this is arguably more error prone because
> > the log messages can change between Kafka versions (and oftentimes such
> > changes are not prominently advertised, so you only notice this once your
> > deployment script breaks).
>
> Manikumar Reddy O wrote
org/r/34641/diff/
Testing
---
Thanks,
Manikumar Reddy O
https://reviews.apache.org/r/34641/diff/
Testing
---
Thanks,
Manikumar Reddy O
hen the catch block
> > includes the System.exit(1).
> >
> > Also, I'm afraid that printing the entire stack trace is intimidating
> > to non-developers who use the CLI. Perhaps the stack trace should go under
> > log.error(...)?
>
> Manikumar Red
/diff/
Testing
---
Thanks,
Manikumar Reddy O
?lq=1
log.error() used for printing stackTrace.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34403/#review91310
------
34403/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
Thanks,
Manikumar Reddy O
/
Testing
---
Thanks,
Manikumar Reddy O
/
Testing
---
Thanks,
Manikumar Reddy O
Reddy O
On July 10, 2015, 2:50 p.m., Manikumar Reddy O wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/34805/diff/
Testing
---
Thanks,
Manikumar Reddy O
/main/scala/kafka/common/AppInfo.scala
d642ca555f83c41451d4fcaa5c01a1f86eff0a1c
core/src/main/scala/kafka/server/KafkaServer.scala
18917bc4464b9403b16d85d20c3fd4c24893d1d3
Diff: https://reviews.apache.org/r/35867/diff/
Testing
---
Thanks,
Manikumar Reddy O
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35880/#review90488
---
On July 6, 2015, 6:05 a.m., Manikumar Reddy O wrote:
>
> ---
.java
db1b0ee9113215b5ad7fda0f93915f3bdd34ac55
core/src/main/scala/kafka/utils/CoreUtils.scala
168a18d380c200ee566eccb6988dd1ae85ed5b09
Diff: https://reviews.apache.org/r/35880/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35880/#review90305
-------
On June 25, 2015, 4:25 p.m., Manikumar Reddy O wrote:
>
>
98ccb
core/src/main/scala/kafka/common/AppInfo.scala
d642ca555f83c41451d4fcaa5c01a1f86eff0a1c
core/src/main/scala/kafka/server/KafkaServer.scala
52dc728bb1ab4b05e94dc528da1006040e2f28c9
Diff: https://reviews.apache.org/r/35867/diff/
Testing
---
Thanks,
Manikumar Reddy O
to easily add a "tainted" boolean field? i.e., if there are any
> > additional source files that are untracked or staged but not committed?
It should be posible with some git commands. But do we really need this? most
of us will be running stable release or some tru
/CoreUtils.scala
168a18d380c200ee566eccb6988dd1ae85ed5b09
Diff: https://reviews.apache.org/r/35880/diff/
Testing
---
Thanks,
Manikumar Reddy O
168a18d380c200ee566eccb6988dd1ae85ed5b09
Diff: https://reviews.apache.org/r/35880/diff/
Testing
---
Thanks,
Manikumar Reddy O
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35867/#review89364
---
On June 25, 2015, 10:11 a.m., Manikumar Reddy O wrote:
>
> ---
>
/MetricsTest.java
544e120594de78c43581a980b1e4087b4fb98ccb
core/src/main/scala/kafka/common/AppInfo.scala
d642ca555f83c41451d4fcaa5c01a1f86eff0a1c
Diff: https://reviews.apache.org/r/35867/diff/
Testing
---
Thanks,
Manikumar Reddy O
scala
a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59
Diff: https://reviews.apache.org/r/35503/diff/
Testing
---
Thanks,
Manikumar Reddy O
NewFile()).
So we no need to re-create the LogSegment. Pl check.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35503/#review88470
------
scala
a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59
Diff: https://reviews.apache.org/r/35503/diff/
Testing
---
Thanks,
Manikumar Reddy O
/
Testing
---
Thanks,
Manikumar Reddy O
Diff: https://reviews.apache.org/r/34805/diff/
Testing
---
Thanks,
Manikumar Reddy O
----
On May 29, 2015, 6:55 p.m., Manikumar Reddy O wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34805/
> --
scala
b320ce9f6a12c0ee392e91beb82e8804d167f9f4
core/src/main/scala/kafka/server/OffsetManager.scala
5cca85cf727975f6d3acb2223fd186753ad761dc
Diff: https://reviews.apache.org/r/35454/diff/
Testing
---
Thanks,
Manikumar Reddy O
8e095d652851f05365e1d3bbe3e9e1c3345b7a40
Diff: https://reviews.apache.org/r/35503/diff/
Testing
---
Thanks,
Manikumar Reddy O
2d75186a110075e0c322db4b9f7a8c964a7a3e88
core/src/main/scala/kafka/server/KafkaServer.scala
b320ce9f6a12c0ee392e91beb82e8804d167f9f4
Diff: https://reviews.apache.org/r/35454/diff/
Testing
---
Thanks,
Manikumar Reddy O
903318d15893af08104a97499798c9ad0ba98013
Diff: https://reviews.apache.org/r/35437/diff/
Testing
---
Thanks,
Manikumar Reddy O
912b718ec9ad58b1c2d42337ed85bbb1b88162d6
Diff: https://reviews.apache.org/r/35424/diff/
Testing
---
Thanks,
Manikumar Reddy O
/
Testing
---
Thanks,
Manikumar Reddy O
Reddy O
b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb
Diff: https://reviews.apache.org/r/35418/diff/
Testing
---
Thanks,
Manikumar Reddy O
/LogCleaner.scala
c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
471ddff9bff1bdfa277c071e59e5c6b749b9c74f
Diff: https://reviews.apache.org/r/34805/diff/
Testing
---
Thanks,
Manikumar Reddy O
c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
471ddff9bff1bdfa277c071e59e5c6b749b9c74f
Diff: https://reviews.apache.org/r/34805/diff/
Testing
---
Thanks,
Manikumar Reddy O
tps://reviews.apache.org/r/33049/#comment137140>
Are we using clientID as uniqueKey?. But as of now, clientID is not
mandatory and it need not be unique acorss different producer and consumers.
- Manikumar Reddy O
On May 26, 2015, 6:53 p.m., Aditya Auradkar
der in-progress as "errors". Other option could be returning a
different error code. Let us wait for others suggestions/concerns.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
ht
/diff/
Testing
---
Thanks,
Manikumar Reddy O
://reviews.apache.org/r/34403/diff/
Testing
---
Thanks,
Manikumar Reddy O
://reviews.apache.org/r/34403/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
Thanks,
Manikumar Reddy O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/#review83392
---
On May 18, 2015, 5:29 p.m., Manikumar Reddy O wrote:
>
> -
data produced, 1136608 rows of data consumed (88.6% reduction).
De-duplicating and validating output files...
Validated 899853 values, 0 mismatches.
Thanks,
Manikumar Reddy O
ptions also. updated the log message.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/#review81622
---
/diff/
Testing
---
Thanks,
Manikumar Reddy O
/producer/ProducerConfig.java
ca1c7fedbde7f53d64426da3a1aa3aeeafd2e9ad
Diff: https://reviews.apache.org/r/4/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
Thanks,
Manikumar Reddy O
/
Testing
---
Thanks,
Manikumar Reddy O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30321/#review69813
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 27, 2015, 4:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69534
---
Can you update the README.md document
- Manikumar Reddy O
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69533
---
Ship it!
Non-Binding +1
- Manikumar Reddy O
On Jan. 24, 2015, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30078/#review69532
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 24, 2015, 5:13
/browse/KAFKA-1861
Repository: kafka
Description
---
include clients test jar in maven artifacts
Diffs
-
build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28
Diff: https://reviews.apache.org/r/30128/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
Thanks,
Manikumar Reddy O
88689df718364f5a9bef143d4cb7e807a9251786
Diff: https://reviews.apache.org/r/30022/diff/
Testing
---
Thanks,
Manikumar Reddy O
: https://reviews.apache.org/r/30022/diff/
Testing
---
Thanks,
Manikumar Reddy O
produced, 1136608 rows of data consumed (88.6% reduction).
De-duplicating and validating output files...
Validated 899853 values, 0 mismatches.
Thanks,
Manikumar Reddy O
Reddy O
clients/src/main/java/org/apache/kafka/common/MetricName.java
4e810d56b753b7eeb662b99af5cdf36bcfba7ea7
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I
> >
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29523/#review67314
---
On Jan. 9, 2015, 6:15 p.m., Manikumar Reddy O wrote:
>
> ---
> This is an aut
r perhaps we can define this as a constant
> > and reference it here.
Sender is internal to producer.. So the group name is hard-coded.
- Manikumar Reddy
---
This is an automatically generated e-mail. To reply, visit
twork/SelectorTest.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
twork/SelectorTest.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote:
> > kafka-patch-review.py, line 96
> > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96>
> >
> > Did you tested the failure senario? I did not get error message. I
> >
756/#comment111442>
Did you tested the failure senario? I did not get error message. I think we
will get exception only after invoking jira.issue().
- Manikumar Reddy O
On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote:
>
> ---
me/password"
- Manikumar Reddy O
On Jan. 9, 2015, 8:09 a.m., Jaikiran Pai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29724/#review67376
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 8, 2015, 8:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29738/#review67374
---
Ship it!
Ship It!
- Manikumar Reddy O
On Jan. 9, 2015, 1:22 a.m
7b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
clients/src/test/java/org/apache/kafka/test/MetricsBench.java
9d98c1148255455fd801043b59b98fed9d0b76b3
Diff: https://reviews.apache.org/r/29523/diff/
Testing
---
Thanks,
Manikumar Reddy O
/StringSerializer.java
<https://reviews.apache.org/r/29590/#comment111066>
we should support null values right?. This is required for compaction..
- Manikumar Reddy O
On Jan. 5, 2015, 7:47 p.m., Jun Rao wrote:
>
> ---
1 - 100 of 195 matches
Mail list logo
