Hi
Could someone make a review?
https://github.com/apache/kafka/pull/18293
Issue - https://issues.apache.org/jira/browse/KAFKA-18336
Take a note jmh tests run for approx 15 hours
With best regards
Kuvardin Evgeny
[
https://issues.apache.org/jira/browse/KAFKA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swikar Patel resolved KAFKA-18258.
--
Resolution: Done
> Code Review
> ---
>
> Key:
Swikar Patel created KAFKA-18258:
Summary: Code Review
Key: KAFKA-18258
URL: https://issues.apache.org/jira/browse/KAFKA-18258
Project: Kafka
Issue Type: Sub-task
Reporter
Hello Xiangyuan,
Thanks for your contributions and thanks for raising it to community's
attention. I will take a look at it sooner than later.
On Thu, Jul 27, 2023 at 2:41 AM Xiangyuan LI wrote:
>
> Hi kafka team:
> I raise a pr https://github.com/apache/kafka/pull/13965 to fix
> https://issue
Hi kafka team:
I raise a pr https://github.com/apache/kafka/pull/13965 to fix
https://issues.apache.org/jira/browse/KAFKA-15106,
it mentions some serious bug and no one check it for a long time, plz
help me review if could. thx!
these bugs are
in
org.apache.kafka.clients.consumer.internals.A
ion);
> addressing code review comments
>
>
> Key: KAFKA-9487
> URL: https://issues.apache.org/jira/browse/KAFKA-9487
> Project: Kafka
>
[
https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-679.
---
Resolution: Won't Do
Yes, this can be safely closed.
> Phabricator for cod
Hi Kafka devs,
Checking in again. Can I get a code review on this?
Thanks,
-James
> On Jun 30, 2016, at 1:51 PM, James Cheng wrote:
>
> Hi Kafka devs,
>
> Can I get a code review on my pull request for
> https://issues.apache.org/jira/browse/KAFKA-3809?
>
> The c
Hi Kafka devs,
Can I get a code review on my pull request for
https://issues.apache.org/jira/browse/KAFKA-3809?
The code has been waiting for review for about a week. I think I clicked
everything correctly in JIRA/Github to mark it ready for review, but it’s
possible I missed something
Thanks Gwen, will update the wiki then.
On Wed, Jul 15, 2015 at 1:03 PM, Gwen Shapira wrote:
> The script just runs a git push, it will be with your user (from git
> configuration), so you need privileges to push.
>
> On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang
> wrote:
> > Another question
The script just runs a git push, it will be with your user (from git
configuration), so you need privileges to push.
On Wed, Jul 15, 2015 at 12:59 PM, Guozhang Wang wrote:
> Another questions regarding the "kafka-merge-pr.py" script: once a
> committer gives a LGTM on the PR, could the contributo
Another questions regarding the "kafka-merge-pr.py" script: once a
committer gives a LGTM on the PR, could the contributor use the script to
push to the git repo himself, or it must be executed by the committer? I
thought it is the former case but seems not. If not we need to make it
clear on the w
On Tue, Jul 14, 2015 at 6:15 PM, Jun Rao wrote:
> I made a couple of changes to the new Jenkins job. Could you try again?
>
It's still not working, unfortunately. It may or may not be related to:
https://blogs.apache.org/infra/entry/mirroring_to_github_issues
For b, if we can't easily change t
I made a couple of changes to the new Jenkins job. Could you try again?
For b, if we can't easily change the behavior of pull request bot, we can
also just flip back and forth btw "In Progress" and "Open".
Thanks,
Jun
On Tue, Jul 14, 2015 at 2:13 AM, Ismael Juma wrote:
> Hi Jun,
>
> On Tue, J
Hi Jun,
On Tue, Jul 14, 2015 at 2:09 AM, Jun Rao wrote:
> Ismael,
>
> I followed the instructions in KAFKA-2320 and created a new Jenkins job (
> https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it
> works?
>
Thanks! It seems to be building when trunk changes as opposed t
Ismael,
I followed the instructions in KAFKA-2320 and created a new Jenkins job (
https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it
works?
As for wiki, I have a couple of minor comments.
a. Could we add the following to the wiki?
To avoid conflicts, assign a jira to your
thing). There is
> the squashed commit author, the pull request message, the pull request
> author and the information about the individual commits. Even though Geoff
> worked on this PR by himself, multiple people can collaborate on a feature
> and then it's useful to credit correctly.
can collaborate on a feature
and then it's useful to credit correctly.
The fact that we are keeping all the information encourages a style of
development where a few small commits (each commit should must make sense
on its own and pass the tests) are used in the pull request, which helps a
lot
Hi Ismael,
I have a couple of comments on the wiki pages / merge scripts:
1. In the wiki page it mentions "If the change is new, then it usually
needs a new JIRA. However, trivial changes, where "what should change" is
virtually the same as "how it should change" do not require a JIRA.
Example:
An update on this.
On Thu, Apr 30, 2015 at 2:12 PM, Ismael Juma wrote:
>
>1. CI builds triggered by GitHub PRs (this is supported by Apache
>Infra, we need to request it for Kafka and provide whatever configuration
>is needed)
>
> Filed https://issues.apache.org/jira/browse/KAFKA-232
Parth,
I will take a look.
Thanks,
Jun
On Fri, May 29, 2015 at 10:49 AM, Parth Brahmbhatt <
pbrahmbh...@hortonworks.com> wrote:
> Hi,
>
> Can someone please review the following CRs:
>
> Public entities and interfaces with changes to KafkaAPI and KafkaServer:
> https://reviews.apache.org/r/344
Hi,
Can someone please review the following CRs:
Public entities and interfaces with changes to KafkaAPI and KafkaServer:
https://reviews.apache.org/r/34492/diff/
Actual Implementation: https://reviews.apache.org/r/34493/diff/
CLI: https://reviews.apache.org/r/34494/diff/
Thanks
Parth
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava
wrote:
> One thing I noticed is that when you try to generate a PR it defaults to
> the 0.8.2 branch. Can we fix that up to be trunk by default?
>
I filed an INFRA ticket for this:
https://issues.apache.org/jira/browse/INFRA-9680
Best,
Isma
Yes, it would be great if we can do a final rebase of the branch before
merging. Perhaps the squashing part already does that?
Thanks,
Jun
On Tue, May 5, 2015 at 5:53 AM, Ismael Juma wrote:
> Hi Jun,
>
> On Sat, May 2, 2015 at 2:50 PM, Jun Rao wrote:
>
> > We will also need to figure out if w
Hi Jun,
On Sat, May 2, 2015 at 2:50 PM, Jun Rao wrote:
> We will also need to figure out if we need CONTRIBUTING.md like the
> following to take care of the Apache licensing stuff.
>
> https://github.com/apache/spark/blob/master/CONTRIBUTING.md
Yes indeed. That is in step 3 of the "missing pie
Hi Ewen,
Comments inline.
On Fri, May 1, 2015 at 8:38 AM, Ewen Cheslack-Postava
wrote:
> Also +1. There are some drawbacks to using Github for reviews, e.g. lots of
> emails for each review because they don't let you publish your entire
> review in one go like RB does, but it drastically lowers
+1!
-Jay
On Thu, Apr 30, 2015 at 6:12 AM, Ismael Juma wrote:
> Hi all,
>
> Kafka currently uses a combination of Review Board and JIRA for
> contributions and code review. In my opinion, this makes contribution and
> code review a bit harder than it has to be.
>
> I think
if we can always put the latest changes on
top during the merge.
Thanks,
Jun
On Thu, Apr 30, 2015 at 8:12 AM, Ismael Juma wrote:
> Hi all,
>
> Kafka currently uses a combination of Review Board and JIRA for
> contributions and code review. In my opinion, this makes contributio
t;> stuff for the current review process. Using just github is going to
>>help in
>> quickly submitting the changes.
>>
>> -Jaikiran
>>
>> On Thursday 30 April 2015 06:42 PM, Ismael Juma wrote:
>>
>>> Hi all,
>>>
>>> Kafka currently u
s going to help in
> quickly submitting the changes.
>
> -Jaikiran
>
> On Thursday 30 April 2015 06:42 PM, Ismael Juma wrote:
>
>> Hi all,
>>
>> Kafka currently uses a combination of Review Board and JIRA for
>> contributions and code review. In my opinion, t
help in quickly submitting the changes.
-Jaikiran
On Thursday 30 April 2015 06:42 PM, Ismael Juma wrote:
Hi all,
Kafka currently uses a combination of Review Board and JIRA for
contributions and code review. In my opinion, this makes contribution and
code review a bit harder than it has to be.
I
wrote:
> Hi all,
>
> Kafka currently uses a combination of Review Board and JIRA for
> contributions and code review. In my opinion, this makes contribution and
> code review a bit harder than it has to be.
>
> I think the approach used by Spark would improve the current situ
Hi all,
Kafka currently uses a combination of Review Board and JIRA for
contributions and code review. In my opinion, this makes contribution and
code review a bit harder than it has to be.
I think the approach used by Spark would improve the current situation:
"Generally, Spark uses JI
Also more naming here:
https://issues.apache.org/jira/browse/KAFKA-1251
On Tue, Apr 1, 2014 at 11:06 AM, Jay Kreps wrote:
> Looking for review on
>
> Producer config renaming:
> https://issues.apache.org/jira/browse/KAFKA-1337
>
> Log compaction metrics:
> https://issues.apache.org/jira/browse/
Looking for review on
Producer config renaming:
https://issues.apache.org/jira/browse/KAFKA-1337
Log compaction metrics:
https://issues.apache.org/jira/browse/KAFKA-1327
-Jay
ve a look at it and we can then further discuss on
the pros and cons.
> Phabricator for code review
> ---
>
> Key: KAFKA-679
> URL: https://issues.apache.org/jira/browse/KAFKA-679
> Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriram Subramanian reassigned KAFKA-679:
Assignee: Sriram Subramanian
> Phabricator for code rev
ut it will be great to have someone
look into how easy it is to use and integrate with Apache.
> Phabricator for code review
> ---
>
> Key: KAFKA-679
> URL: https://issues.apache.org/jira/browse/KAFK
[
https://issues.apache.org/jira/browse/KAFKA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539109#comment-13539109
]
Jay Kreps commented on KAFKA-679:
-
This seems kind of all-encompassing (code review,
can have someone else
administer because it is a huge hassle.
> Phabricator for code review
> ---
>
> Key: KAFKA-679
> URL: https://issues.apache.org/jira/browse/KAFKA-679
> Project: Kafka
>
s on ?
> Phabricator for code review
> ---
>
> Key: KAFKA-679
> URL: https://issues.apache.org/jira/browse/KAFKA-679
> Project: Kafka
> Issue Type: New Feature
>Reporter: Neha
Neha Narkhede created KAFKA-679:
---
Summary: Phabricator for code review
Key: KAFKA-679
URL: https://issues.apache.org/jira/browse/KAFKA-679
Project: Kafka
Issue Type: New Feature
42 matches
Mail list logo
