[jira] [Commented] (LUCENE-7485) Better storage for `docsWithField` in Lucene70NormsFormat

2016-10-10 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563393#comment-15563393 ] Ryan Ernst commented on LUCENE-7485: Looks good! A couple minor suggestions: * I would change

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511049#comment-15511049 ] Ryan Ernst commented on LUCENE-7453: bq. this is probably a multicriteria optimisation problem with

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511042#comment-15511042 ] Ryan Ernst commented on LUCENE-7453: bq. I don't like overloading index for this, especially in the

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510784#comment-15510784 ] Ryan Ernst commented on LUCENE-7453: bq. although I do dislike using such an overloaded term Just to

[jira] [Commented] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510719#comment-15510719 ] Ryan Ernst commented on LUCENE-7453: I'm ok with {{docIndex}}, it is at least an improvement over

[jira] [Created] (LUCENE-7453) Change naming of variables/apis from docid to docnum

2016-09-20 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-7453: -- Summary: Change naming of variables/apis from docid to docnum Key: LUCENE-7453 URL: https://issues.apache.org/jira/browse/LUCENE-7453 Project: Lucene - Core

[jira] [Commented] (LUCENE-7314) Graduate InetAddressPoint and LatLonPoint to core

2016-06-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318482#comment-15318482 ] Ryan Ernst commented on LUCENE-7314: Another reason to have good defaults in core is that core is

[jira] [Commented] (LUCENE-7249) LatLonPoint polygon should use tree relate()

2016-04-22 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254411#comment-15254411 ] Ryan Ernst commented on LUCENE-7249: Real polygons are starting to move! +1 > LatLonPoint polygon

[jira] [Commented] (LUCENE-7242) LatLonTree should build a balanced tree

2016-04-22 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254109#comment-15254109 ] Ryan Ernst commented on LUCENE-7242: Glad the idea worked out! +1 > LatLonTree should build a

[jira] [Commented] (LUCENE-7239) Speed up LatLonPoint's polygon queries when there are many vertices

2016-04-21 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252697#comment-15252697 ] Ryan Ernst commented on LUCENE-7239: +1, nice speed up!! > Speed up LatLonPoint's polygon queries

[jira] [Commented] (LUCENE-7229) Improve Polygon.relate

2016-04-18 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246445#comment-15246445 ] Ryan Ernst commented on LUCENE-7229: +1 to the new patch, thanks for the improved var names! >

[jira] [Commented] (LUCENE-7229) Improve Polygon.relate

2016-04-18 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246430#comment-15246430 ] Ryan Ernst commented on LUCENE-7229: +1 to the patch. One suggestion on readability of the main

[jira] [Commented] (LUCENE-7202) Come up with a comprehensive proposal for naming spatial modules and technologies

2016-04-12 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238093#comment-15238093 ] Ryan Ernst commented on LUCENE-7202: bq. If I want to support Hilbert or Moore we add HilbertPoint,

[jira] [Commented] (LUCENE-7155) Script addVersion.py does not detect the new naming convention for bugfix branches

2016-04-11 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235946#comment-15235946 ] Ryan Ernst commented on LUCENE-7155: +1 to the latest patch. > Script addVersion.py does not detect

[jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/

2016-04-11 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235688#comment-15235688 ] Ryan Ernst commented on LUCENE-5325: [~romseygeek] sounds like an interesting idea, a prototype patch

[jira] [Commented] (LUCENE-7155) Script addVersion.py does not detect the new naming convention for bugfix branches

2016-04-04 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224331#comment-15224331 ] Ryan Ernst commented on LUCENE-7155: Ah this is a bug! We don't do major releases often enough. :)

[jira] [Commented] (LUCENE-7155) Script addVersion.py does not detect the new naming convention for bugfix branches

2016-04-01 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222350#comment-15222350 ] Ryan Ernst commented on LUCENE-7155: [~janhoy] The branch type major is used for adding a new major

[jira] [Commented] (LUCENE-6938) Convert build to work with Git rather than SVN.

2016-03-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219107#comment-15219107 ] Ryan Ernst commented on LUCENE-6938: It looks like the branch detection logic isn't working given our

[jira] [Comment Edited] (LUCENE-7150) geo3d public APIs should match the 2D apis?

2016-03-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218211#comment-15218211 ] Ryan Ernst edited comment on LUCENE-7150 at 3/30/16 4:00 PM: - Thanks for the

[jira] [Comment Edited] (LUCENE-7150) geo3d public APIs should match the 2D apis?

2016-03-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218211#comment-15218211 ] Ryan Ernst edited comment on LUCENE-7150 at 3/30/16 4:00 PM: - Thanks for the

[jira] [Commented] (LUCENE-7150) geo3d public APIs should match the 2D apis?

2016-03-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218211#comment-15218211 ] Ryan Ernst commented on LUCENE-7150: Thanks for the patch [~daddywri]! I'm a little confused about

[jira] [Commented] (LUCENE-7150) geo3d public APIs should match the 2D apis?

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216947#comment-15216947 ] Ryan Ernst commented on LUCENE-7150: bq. It escapes me why degrees and distance in meters is a

[jira] [Commented] (LUCENE-7150) geo3d public APIs should match the 2D apis?

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216918#comment-15216918 ] Ryan Ernst commented on LUCENE-7150: bq. One problem at the moment is that all of geo3d works against

[jira] [Resolved] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-7147. Resolution: Fixed Assignee: Ryan Ernst Fix Version/s: 6.1 master

[jira] [Comment Edited] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216218#comment-15216218 ] Ryan Ernst edited comment on LUCENE-7147 at 3/29/16 6:05 PM: - I've attached 2

[jira] [Updated] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-7147: --- Attachment: (was: example-crosses-axis-not-center.html) > Improve disjoint check for geo

[jira] [Updated] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-7147: --- Attachment: example-crosses-axis-not-center.html > Improve disjoint check for geo distance query

[jira] [Updated] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-7147: --- Attachment: example-intersects-bbox-not-circle.html

[jira] [Comment Edited] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215513#comment-15215513 ] Ryan Ernst edited comment on LUCENE-7147 at 3/29/16 6:17 AM: - Here is a patch

[jira] [Comment Edited] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215513#comment-15215513 ] Ryan Ernst edited comment on LUCENE-7147 at 3/29/16 6:16 AM: - Here is a patch

[jira] [Updated] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-7147: --- Attachment: LUCENE-7147.patch Here is a patch which adds the following simple logic: if the rect of

[jira] [Created] (LUCENE-7147) Improve disjoint check for geo distance query traversal

2016-03-29 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-7147: -- Summary: Improve disjoint check for geo distance query traversal Key: LUCENE-7147 URL: https://issues.apache.org/jira/browse/LUCENE-7147 Project: Lucene - Core

[jira] [Commented] (LUCENE-7118) Remove multidimensional arrays from PointRangeQuery

2016-03-20 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203500#comment-15203500 ] Ryan Ernst commented on LUCENE-7118: Shouldn't this line in PointRangeQuery: {quote} +if

[jira] [Commented] (LUCENE-7077) fail precommit on useless assignment

2016-03-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184296#comment-15184296 ] Ryan Ernst commented on LUCENE-7077: +1 > fail precommit on useless assignment >

[jira] [Commented] (LUCENE-7023) Implementation-Version spans 2 lines in MANIFEST.MF in our JARs

2016-02-12 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145113#comment-15145113 ] Ryan Ernst commented on LUCENE-7023: The spec for manifest files has a limit of 72 bytes on a line,

[jira] [Resolved] (LUCENE-7009) Add expectThrows utility to LuceneTestCase

2016-02-03 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-7009. Resolution: Fixed Assignee: Ryan Ernst Fix Version/s: Trunk > Add expectThrows

[jira] [Created] (LUCENE-7009) Add expectThrows utility to LuceneTestCase

2016-02-02 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-7009: -- Summary: Add expectThrows utility to LuceneTestCase Key: LUCENE-7009 URL: https://issues.apache.org/jira/browse/LUCENE-7009 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-7009) Add expectThrows utility to LuceneTestCase

2016-02-02 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-7009: --- Attachment: LUCENE-7009.patch Patch. > Add expectThrows utility to LuceneTestCase >

[jira] [Commented] (LUCENE-6982) throw IAE on illegal bm25 parameter values

2016-01-18 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105695#comment-15105695 ] Ryan Ernst commented on LUCENE-6982: +1 > throw IAE on illegal bm25 parameter values >

[jira] [Commented] (LUCENE-6964) Small changes in expressions module

2016-01-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088078#comment-15088078 ] Ryan Ernst commented on LUCENE-6964: +1 > Small changes in expressions module >

[jira] [Commented] (LUCENE-6965) Expression's JavascriptCompiler to throw ParseExceptions with bad function names or arity

2016-01-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087966#comment-15087966 ] Ryan Ernst commented on LUCENE-6965: ParseException seems fine, but why the intermediate exception?

[jira] [Commented] (LUCENE-6965) Expression's JavascriptCompiler to throw ParseExceptions with bad function names or arity

2016-01-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088092#comment-15088092 ] Ryan Ernst commented on LUCENE-6965: Thanks...looks ok I guess then. > Expression's

[jira] [Commented] (LUCENE-6965) Expression's JavascriptCompiler to throw ParseExceptions with bad function names or arity

2016-01-07 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088236#comment-15088236 ] Ryan Ernst commented on LUCENE-6965: +1 to Uwe's suggestion. I did not know that was possible! >

[jira] [Commented] (LUCENE-6918) LRUQueryCache.onDocIdSetEviction should not be called when nothing is evicted

2015-12-04 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041379#comment-15041379 ] Ryan Ernst commented on LUCENE-6918: +1, looks good. For the changes entry, I think you mean to

[jira] [Commented] (LUCENE-6919) Change the Scorer API to expose an iterator instead of extending DocIdSetIterator

2015-12-04 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042367#comment-15042367 ] Ryan Ernst commented on LUCENE-6919: +1 to the idea > Change the Scorer API to expose an iterator

[jira] [Commented] (SOLR-8363) luceneMatchVerision in solrconfigs under the example directory don't get updated

2015-12-03 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037627#comment-15037627 ] Ryan Ernst commented on SOLR-8363: -- See {{update_example_solrconfigs}} in

[jira] [Commented] (LUCENE-6825) Add multidimensional byte[] indexing support to Lucene

2015-10-06 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945626#comment-14945626 ] Ryan Ernst commented on LUCENE-6825: This looks good. I think this is a great plan, to separate this

[jira] [Commented] (LUCENE-6305) BooleanQuery.equals should ignore clause order

2015-09-27 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909843#comment-14909843 ] Ryan Ernst commented on LUCENE-6305: +1 to enabling all the time > BooleanQuery.equals should ignore

[jira] [Commented] (LUCENE-6773) Always flatten nested conjunctions

2015-09-08 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734291#comment-14734291 ] Ryan Ernst commented on LUCENE-6773: +1 Can you add a test to TestConjunctionDISI? > Always flatten

[jira] [Commented] (LUCENE-6773) Always flatten nested conjunctions

2015-09-08 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735508#comment-14735508 ] Ryan Ernst commented on LUCENE-6773: Test looks good, thanks! > Always flatten nested conjunctions >

[jira] [Commented] (LUCENE-6739) Upgrade ant requirement to 1.9 in trunk (6.0)

2015-08-15 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698472#comment-14698472 ] Ryan Ernst commented on LUCENE-6739: people using MacOSX would have problems (build

[jira] [Commented] (LUCENE-6739) Upgrade ant requirement to 1.9 in trunk (6.0)

2015-08-15 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698473#comment-14698473 ] Ryan Ernst commented on LUCENE-6739: Requiring 1.8 actually makes it *harder* for

[jira] [Commented] (LUCENE-6729) Upgrade ASM version to 5.0.4 (expressions / Solr's TIKA)

2015-08-10 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679659#comment-14679659 ] Ryan Ernst commented on LUCENE-6729: +1 Upgrade ASM version to 5.0.4 (expressions /

[jira] [Commented] (LUCENE-6655) StandardTokenizerFactory constructor fails if the passed in map is immutable

2015-07-02 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612804#comment-14612804 ] Ryan Ernst commented on LUCENE-6655: This is intentional. All of the analysis

[jira] [Updated] (LUCENE-6630) Further improve memory of FieldInfos

2015-06-28 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6630: --- Attachment: LUCENE-6630.patch Patch. Further improve memory of FieldInfos

[jira] [Created] (LUCENE-6630) Further improve memory of FieldInfos

2015-06-28 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-6630: -- Summary: Further improve memory of FieldInfos Key: LUCENE-6630 URL: https://issues.apache.org/jira/browse/LUCENE-6630 Project: Lucene - Core Issue Type: Bug

[jira] [Updated] (LUCENE-6585) Make ConjunctionDISI flatten sub ConjunctionDISI instances

2015-06-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6585: --- Attachment: LUCENE-6585.patch Here's a new patch with {{instanceof}} replaced with {{==}}. I also

[jira] [Resolved] (LUCENE-6585) Make ConjunctionDISI flatten sub ConjunctionDISI instances

2015-06-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-6585. Resolution: Fixed Make ConjunctionDISI flatten sub ConjunctionDISI instances

[jira] [Updated] (LUCENE-6585) Make ConjunctionDISI flatten sub ConjunctionDISI instances

2015-06-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6585: --- Fix Version/s: Trunk 5.3 Make ConjunctionDISI flatten sub ConjunctionDISI

[jira] [Comment Edited] (LUCENE-6585) Make ConjunctionDISI flatten sub ConjunctionDISI instances

2015-06-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600601#comment-14600601 ] Ryan Ernst edited comment on LUCENE-6585 at 6/25/15 3:14 AM: -

[jira] [Updated] (LUCENE-6585) Make ConjunctionDISI flatten sub ConjunctionDISI instances

2015-06-19 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6585: --- Attachment: LUCENE-6585.patch Here is a patch collapsing all subconjunctions (thanks [~jpountz] for

[jira] [Commented] (LUCENE-6591) Never write negative vLongs

2015-06-19 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593603#comment-14593603 ] Ryan Ernst commented on LUCENE-6591: +1 Never write negative vLongs

[jira] [Commented] (LUCENE-6584) Docs on StandardTokenizer don't mention the behaviour change in Version.LUCENE_4_7_0

2015-06-18 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592827#comment-14592827 ] Ryan Ernst commented on LUCENE-6584: StandardTokenizerFactory now handles versioning,

[jira] [Commented] (LUCENE-5954) Store lucene version in segment_N

2015-06-09 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579288#comment-14579288 ] Ryan Ernst commented on LUCENE-5954: +1 to the new patch. I think the inline comment

[jira] [Commented] (LUCENE-5954) Store lucene version in segment_N

2015-06-04 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572843#comment-14572843 ] Ryan Ernst commented on LUCENE-5954: Thanks Mike! This looks great. A couple

[jira] [Commented] (LUCENE-6500) ParallelCompositeReader does not always call closed listeners

2015-05-26 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558887#comment-14558887 ] Ryan Ernst commented on LUCENE-6500: bq. Which is not a problem in your test, but

[jira] [Created] (LUCENE-6497) Allow subclasses of FieldType to check frozen state

2015-05-22 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-6497: -- Summary: Allow subclasses of FieldType to check frozen state Key: LUCENE-6497 URL: https://issues.apache.org/jira/browse/LUCENE-6497 Project: Lucene - Core

[jira] [Updated] (LUCENE-6497) Allow subclasses of FieldType to check frozen state

2015-05-22 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6497: --- Attachment: LUCENE-6497.patch Simple patch. Allow subclasses of FieldType to check frozen state

[jira] [Commented] (LUCENE-6497) Allow subclasses of FieldType to check frozen state

2015-05-22 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556686#comment-14556686 ] Ryan Ernst commented on LUCENE-6497: I spoke with Anshum and will push this to 5.2 as

[jira] [Resolved] (LUCENE-6497) Allow subclasses of FieldType to check frozen state

2015-05-22 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-6497. Resolution: Fixed Fix Version/s: 5.2 Trunk Allow subclasses of

[jira] [Resolved] (LUCENE-5005) Length norm value of DefaultSimilarity for a few terms

2015-05-15 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-5005. Resolution: Not A Problem Lucene encodes norms using 8 bits. This means precision can be lost when

[jira] [Commented] (LUCENE-6465) Add protectiondomain to expressions compiler

2015-05-06 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530102#comment-14530102 ] Ryan Ernst commented on LUCENE-6465: +1 Do we really need to have so many variants

[jira] [Commented] (SOLR-7487) check-example-lucene-match-version is looking in the wrong place - luceneMatchVersion incorrect in 5.1 sample configs

2015-04-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521817#comment-14521817 ] Ryan Ernst commented on SOLR-7487: -- You probably want to update

[jira] [Resolved] (LUCENE-6454) Support Member Methods in VariableContext

2015-04-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-6454. Resolution: Fixed Fix Version/s: 5.2 Trunk Assignee: Ryan Ernst

[jira] [Comment Edited] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment

2015-04-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518752#comment-14518752 ] Ryan Ernst edited comment on LUCENE-6213 at 4/29/15 5:18 AM: -

[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment

2015-04-29 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518752#comment-14518752 ] Ryan Ernst commented on LUCENE-6213: i think that even if there is no official M

[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment

2015-04-28 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518460#comment-14518460 ] Ryan Ernst commented on LUCENE-6213: [~hossman] We already check unsupported indexes

[jira] [Commented] (LUCENE-6457) Create mixed format bwc index for major releases in addBackcompatIndexes.py

2015-04-28 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518459#comment-14518459 ] Ryan Ernst commented on LUCENE-6457: We should also update the smoke tester to verify

[jira] [Comment Edited] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment

2015-04-28 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518460#comment-14518460 ] Ryan Ernst edited comment on LUCENE-6213 at 4/29/15 12:43 AM:

[jira] [Created] (LUCENE-6457) Create mixed format bwc index for major releases in addBackcompatIndexes.py

2015-04-28 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-6457: -- Summary: Create mixed format bwc index for major releases in addBackcompatIndexes.py Key: LUCENE-6457 URL: https://issues.apache.org/jira/browse/LUCENE-6457 Project:

[jira] [Commented] (LUCENE-6213) Add test for IndexFormatTooOldException if a commit has a 3.x segment

2015-04-28 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517480#comment-14517480 ] Ryan Ernst commented on LUCENE-6213: When I added this logic, 5.0 was not yet

[jira] [Resolved] (LUCENE-6451) Support non-static methods in the Javascript compiler

2015-04-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst resolved LUCENE-6451. Resolution: Fixed Fix Version/s: 5.2 Trunk Assignee: Ryan Ernst

[jira] [Commented] (LUCENE-6452) TestBooleanMinShouldMatch.testRandomQueries test failure

2015-04-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511263#comment-14511263 ] Ryan Ernst commented on LUCENE-6452: +1 to the patch.

[jira] [Commented] (LUCENE-6451) Support non-static methods in the Javascript compiler

2015-04-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511429#comment-14511429 ] Ryan Ernst commented on LUCENE-6451: This looks good, thanks for the additional

[jira] [Commented] (LUCENE-6446) Simplify Explanation API

2015-04-20 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504018#comment-14504018 ] Ryan Ernst commented on LUCENE-6446: +1, this is much cleaner! Simplify Explanation

[jira] [Commented] (LUCENE-6442) Add a mockfs with unpredictable but deterministic file listing order

2015-04-20 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504274#comment-14504274 ] Ryan Ernst commented on LUCENE-6442: +1, the mockfs test improvements are great.

[jira] [Commented] (LUCENE-6436) add LuceneTestCase.SuppressFsync

2015-04-18 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501492#comment-14501492 ] Ryan Ernst commented on LUCENE-6436: +1 add LuceneTestCase.SuppressFsync

[jira] [Commented] (LUCENE-6431) Make extrasfs reproducible

2015-04-17 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499244#comment-14499244 ] Ryan Ernst commented on LUCENE-6431: +1! Make extrasfs reproducible

[jira] [Commented] (LUCENE-6432) Add SuppressReproduceLine

2015-04-17 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499327#comment-14499327 ] Ryan Ernst commented on LUCENE-6432: +1 Add SuppressReproduceLine

[jira] [Updated] (LUCENE-6424) DirectoryStreamPath doesnt wrap with FilterPath

2015-04-14 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6424: --- Attachment: LUCENE-6424.patch Here is a patch which fixes FilterDirectoryStream to take the

[jira] [Updated] (LUCENE-6424) DirectoryStreamPath doesnt wrap with FilterPath

2015-04-14 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6424: --- Attachment: LUCENE-6424.patch New patch which fixes the glob test to actually check something, and a

[jira] [Created] (LUCENE-6424) DirectoryStreamPath doesnt wrap with FilterPath

2015-04-14 Thread Ryan Ernst (JIRA)
Ryan Ernst created LUCENE-6424: -- Summary: DirectoryStreamPath doesnt wrap with FilterPath Key: LUCENE-6424 URL: https://issues.apache.org/jira/browse/LUCENE-6424 Project: Lucene - Core Issue

[jira] [Updated] (LUCENE-6271) PostingsEnum should have consistent flags behavior

2015-03-31 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ernst updated LUCENE-6271: --- Attachment: LUCENE-6271.patch Here is a patch against trunk based on the issue branch. All nocommits

[jira] [Commented] (LUCENE-6380) Fix addVersion.py to import methods from scriptutil correctly

2015-03-30 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388007#comment-14388007 ] Ryan Ernst commented on LUCENE-6380: [~anshumg] I don't understand how this patch

[jira] [Commented] (LUCENE-6319) Delegating OneMerge

2015-03-06 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350875#comment-14350875 ] Ryan Ernst commented on LUCENE-6319: [~ebradshaw] Sorry I haven't had time to look. I

[jira] [Comment Edited] (LUCENE-6294) Generalize how IndexSearcher parallelizes collection execution

2015-02-27 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340345#comment-14340345 ] Ryan Ernst edited comment on LUCENE-6294 at 2/27/15 4:23 PM: -

[jira] [Commented] (LUCENE-6294) Generalize how IndexSearcher parallelizes collection execution

2015-02-27 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340345#comment-14340345 ] Ryan Ernst commented on LUCENE-6294: +1 In the javadocs for {{IndexSearch.search}} I

[jira] [Commented] (LUCENE-6302) Adding Date Math support to Lucene Expressions module

2015-02-26 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338957#comment-14338957 ] Ryan Ernst commented on LUCENE-6302: I agree with Robert, we don't need date math.

[jira] [Commented] (LUCENE-6212) Remove IndexWriter's per-document analyzer add/updateDocument APIs

2015-02-26 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339432#comment-14339432 ] Ryan Ernst commented on LUCENE-6212: bq. you want the content to be indexed under the

[jira] [Commented] (LUCENE-6291) Rename TwoPhaseDocIdSetIterator to TwoPhaseIterator

2015-02-24 Thread Ryan Ernst (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335377#comment-14335377 ] Ryan Ernst commented on LUCENE-6291: +1 Rename TwoPhaseDocIdSetIterator to

  1   2   3   4   5   6   >