[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-21 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299740#comment-16299740 ] Martijn van Groningen commented on LUCENE-8104: --- I think for the grouping module, for now,

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-20 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298620#comment-16298620 ] David Smiley commented on LUCENE-8104: -- Yeah at this point the issue transformed itself to be about

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298514#comment-16298514 ] Alan Woodward commented on LUCENE-8104: --- I've committed the patch, shall I change this issue to

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298498#comment-16298498 ] ASF subversion and git services commented on LUCENE-8104: - Commit

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298499#comment-16298499 ] ASF subversion and git services commented on LUCENE-8104: - Commit

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296922#comment-16296922 ] Adrien Grand commented on LUCENE-8104: -- bq. FunctionScoreQuery is also in the queries module Sorry

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296907#comment-16296907 ] David Smiley commented on LUCENE-8104: -- bq. Removing ValueSource entirely would be great, but it's

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296661#comment-16296661 ] Alan Woodward commented on LUCENE-8104: --- FunctionScoreQuery is also in the queries module >

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296577#comment-16296577 ] Adrien Grand commented on LUCENE-8104: -- bq. The facets module also uses a FunctionQuery in

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296505#comment-16296505 ] Alan Woodward commented on LUCENE-8104: --- The facets module also uses a FunctionQuery in

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296426#comment-16296426 ] Alan Woodward commented on LUCENE-8104: --- LUCENE-7889 is a start at implementing this. Removing

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-18 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295653#comment-16295653 ] David Smiley commented on LUCENE-8104: -- CC [~romseygeek] and [~martijn.v.groningen] Note I have no