[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006380#comment-13006380 ] Doron Cohen commented on LUCENE-2958: - Thanks for reviewing Mike! bq. I think we sho

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006378#comment-13006378 ] Michael McCandless commented on LUCENE-2958: Patch looks great! Some small t

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006377#comment-13006377 ] Michael McCandless commented on LUCENE-2958: bq. For example, one DocMaker ca

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006269#comment-13006269 ] Doron Cohen commented on LUCENE-2958: - Rethinking this suggestion, I am afraid it wil

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006251#comment-13006251 ] Shai Erera commented on LUCENE-2958: A thought -- how about we do the following: # Li

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006211#comment-13006211 ] Doron Cohen commented on LUCENE-2958: - bq. So let's keep the current impl as optimize

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006145#comment-13006145 ] Shai Erera commented on LUCENE-2958: I haven't reviewed the patch yet, but I must say

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005653#comment-13005653 ] Shai Erera commented on LUCENE-2958: No, the flexibility is in the ability to have a

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005647#comment-13005647 ] Michael McCandless commented on LUCENE-2958: So the separation we have today

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005612#comment-13005612 ] Shai Erera commented on LUCENE-2958: bq. Really, it would be better if LineDocSource

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005607#comment-13005607 ] Michael McCandless commented on LUCENE-2958: bq. If we do the header idea, th

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005502#comment-13005502 ] Shai Erera commented on LUCENE-2958: If we do the header idea, then we'll need to mov

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005286#comment-13005286 ] Michael McCandless commented on LUCENE-2958: bq. I don't think that matters?

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005259#comment-13005259 ] Shai Erera commented on LUCENE-2958: bq. though we'd still have to set up the Fields

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005218#comment-13005218 ] Michael McCandless commented on LUCENE-2958: That's exactly what I had in min

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005190#comment-13005190 ] Doron Cohen commented on LUCENE-2958: - Thanks for reviewing Mike! No I didn't perf t

[jira] Commented: (LUCENE-2958) WriteLineDocTask improvements

[ https://issues.apache.org/jira/browse/LUCENE-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005169#comment-13005169 ] Michael McCandless commented on LUCENE-2958: It's great to make line file doc