Re: LUCENE-3687: Allow similarity to encode norms other than a single byte

2015-10-05 Thread Ivan Provalov
Mikhail is right.  I was getting hung up on the new API in this LUCENE-3687.   Instead, one could use the existing API and encode up to four different ways of doc length using bytes joining into a long (bitwise).  Thank you, Robert Muir, for pointing this out to me! On Sunday, October 4, 2

Re: LUCENE-3687: Allow similarity to encode norms other than a single byte

2015-10-04 Thread Ivan Provalov
Mikhail, Thank you for your reply. Even though the long is returned from this function, it is always encoded as a single byte lossy representation. In order to change that and add other norms (for using other similarity functions on the same indexed data), there should be a support for multip

Re: LUCENE-3687: Allow similarity to encode norms other than a single byte

2015-10-03 Thread Mikhail Khludnev
Hello, Norms can be long, see org.apache.lucene.search.similarities.TFIDFSimilarity.encodeNormValue(float) /** Encodes a normalization factor for storage in an index. */ public abstract long encodeNormValue(float f); On Sun, Oct 4, 2015 at 6:39 AM, Ivan Provalov wrote: > When does this 4.0-

LUCENE-3687: Allow similarity to encode norms other than a single byte

2015-10-03 Thread Ivan Provalov
When does this 4.0-ALPHA feature going to be included in the released version?   https://issues.apache.org/jira/browse/LUCENE-3687  It's the "Allow similarity to encode norms other than a single byte".    I thought that it would be in the released versions, but it looks like it's only on 4.0-alph

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-16 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186953#comment-13186953 ] Simon Willnauer commented on LUCENE-3687: - bq. Patch looks good! Small typo in Fi

[jira] [Resolved] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-16 Thread Simon Willnauer (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer resolved LUCENE-3687. - Resolution: Fixed Assignee: Simon Willnauer > Allow similarity to encode norms

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-16 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186937#comment-13186937 ] Michael McCandless commented on LUCENE-3687: Patch looks good! Small typo in

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-16 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186923#comment-13186923 ] Simon Willnauer commented on LUCENE-3687: - I plan to commit this soon if nobody o

[jira] [Updated] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-16 Thread Simon Willnauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3687: Attachment: LUCENE-3687.patch here is a new patch with changes.txt and more tests for case

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-15 Thread Michael McCandless (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186638#comment-13186638 ] Michael McCandless commented on LUCENE-3687: This looks great! I love how yo

[jira] [Updated] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-15 Thread Simon Willnauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3687: Attachment: LUCENE-3687.patch new patch * renamed setXXX to setDouble, setFloat etc. * m

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186342#comment-13186342 ] Robert Muir commented on LUCENE-3687: - {quote} yeah we can do that I will look into i

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186340#comment-13186340 ] Robert Muir commented on LUCENE-3687: - {quote} maybe we should. if a user wants to do

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186338#comment-13186338 ] Simon Willnauer commented on LUCENE-3687: - bq. If we are going to have separate c

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186335#comment-13186335 ] Robert Muir commented on LUCENE-3687: - {quote} I kind of like the separation here. Do

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186328#comment-13186328 ] Simon Willnauer commented on LUCENE-3687: - bq. in PreFlexRW and SimpleText's impl

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186320#comment-13186320 ] Robert Muir commented on LUCENE-3687: - Two more questions: In the patch omitNorms is

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-14 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186315#comment-13186315 ] Robert Muir commented on LUCENE-3687: - I think otherwise the patch is great. we real

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185544#comment-13185544 ] Simon Willnauer commented on LUCENE-3687: - I agree, I will change this accordingl

[jira] [Issue Comment Edited] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Uwe Schindler (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185533#comment-13185533 ] Uwe Schindler edited comment on LUCENE-3687 at 1/13/12 10:38 AM: --

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185533#comment-13185533 ] Uwe Schindler commented on LUCENE-3687: --- Why? this is really confusing! I think set

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185524#comment-13185524 ] Robert Muir commented on LUCENE-3687: - I just saw DocValuesField has this same proble

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185520#comment-13185520 ] Robert Muir commented on LUCENE-3687: - {quote} I also remove setByte in favor of setI

[jira] [Updated] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-13 Thread Simon Willnauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3687: Attachment: LUCENE-3687.patch new patch. added some cleanups + javadoc. I now throw a hard

[jira] [Updated] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-12 Thread Simon Willnauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3687: Attachment: LUCENE-3687.patch new patch with setXXX methods on Norm class. I also fixed so

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-11 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184346#comment-13184346 ] Robert Muir commented on LUCENE-3687: - I havent done a full review but with the typo

[jira] [Commented] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-11 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184300#comment-13184300 ] Simon Willnauer commented on LUCENE-3687: - what a typo... s/omit/emit in the patc

[jira] [Updated] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-11 Thread Simon Willnauer (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon Willnauer updated LUCENE-3687: Attachment: LUCENE-3687.patch here is a first patch allowing similarity be more flexible w

[jira] [Created] (LUCENE-3687) Allow similarity to encode norms other than a single byte

2012-01-11 Thread Simon Willnauer (Created) (JIRA)
Allow similarity to encode norms other than a single byte - Key: LUCENE-3687 URL: https://issues.apache.org/jira/browse/LUCENE-3687 Project: Lucene - Java Issue Type: New Feature