Re: Commit / Code Review Policy

2020-03-05 Thread David Smiley
On Wed, Mar 4, 2020 at 8:36 AM Daniel Ruggeri wrote: > I definitely reviewed the email thread, replies, and Confluence wiki > document. In my interpretation of the discussion, a few things stood out: > - There were some synchronous discussions that occurred off the list, > which can lead to

Re: CHANGES.txt and issue categorization

2020-03-05 Thread Houston Putman
+1 to move the entries. I would suggest that we document this organization somewhere though, so that future developers can adhere to the guidelines without finding this thread. I don't have a strong opinion on where this would go, maybe a legend at the top of CHANGES.txt or in the developer docs.

Re: CHANGES.txt and issue categorization

2020-03-05 Thread Bruno Roustant
+1 to move these entries. And I agree with the categories definitions. Le mer. 4 mars 2020 à 10:24, Adrien Grand a écrit : > +1 to move these entries. > > On Wed, Mar 4, 2020 at 4:27 AM David Smiley > wrote: > >> I'll simply move these items around tomorrow this time, unless I hear >> feedback

Updating a Response in the UpdateRequestProcessorChain

2020-03-05 Thread Houston Putman
Hello everyone, As I currently understand it, there is no built in mechanism for UpdateRequestProcessors to add information to the response that is sent back to the user. It is possible to pass in the Response object to the UpdateRequestProcessor, through the corresponding

Re: Do we leverage index sort for filters?

2020-03-05 Thread Varun Thacker
Thanks Adrien for the background IndexSortSortedNumericDocValuesRangeQuery is a neat idea! I imagine the logs use-case where every search has a filter makes this optimization important. In https://github.com/apache/lucene-solr/pull/715 the benchmark indexed 123M docs. The results for - *range

Re: Welcome Nhat Nguyen to the PMC

2020-03-05 Thread Nhat Nguyen
Thank you very much for the warm welcome! On Wed, Mar 4, 2020 at 10:59 AM Jan Høydahl wrote: > Welcome Nhat! > > Jan > > > 3. mar. 2020 kl. 17:34 skrev Adrien Grand : > > > > I am pleased to announce that Nhat Nguyen has accepted the PMC's > invitation to join. > > > > Welcome Nhat! > > > > --

Re: github commit comments not(?) forwarded to list?

2020-03-05 Thread Christine Poerschke (BLOOMBERG/ LONDON)
Great, thank you Jan for the pointers and context! The INFRA tickets you mentioned and their GitBox component labelling led me to discover https://issues.apache.org/jira/browse/INFRA-15296 entitled "Github comments not going to mailing lists" i.e. a JIRA already exists. Christine From:

Re: github commit comments not(?) forwarded to list?

2020-03-05 Thread Jan Høydahl
I think you may find the answer here :) https://github.com/apache/infrastructure-puppet/blob/a66ec4204550ef9cbc89ef65e7cec3f35f39a07a/modules/gitbox/files/cgi-bin/issues.cgi#L358-L361 I made some contributions to that code in INFRA-19263 so I

Re: Do we leverage index sort for filters?

2020-03-05 Thread Adrien Grand
We don't directly take advantage of index sort in this case, but index sorting still makes this faster. I had mentioned it in a presentation a couple years ago https://speakerdeck.com/elastic/get-the-lay-of-the-lucene-land-1?slide=14: querying geonames for TYPE:CITY AND CONTRY_CODE_US ran 1.6x

Re: Do we leverage index sort for filters?

2020-03-05 Thread Varun Thacker
Actually I was thinking in terms of Lucene for this question :) In Solr we have index sorting available via SortingMergePolicyFactory which can be leveraged via param segmentTerminateEarly=true In Lucene, we moved to making index sort a first-class citizen. It records the index sort order on the

github commit comments not(?) forwarded to list?

2020-03-05 Thread Christine Poerschke (BLOOMBERG/ LONDON)
Hello everyone. Yesterday I realised that comments on github.com/apache/lucene-solr commits are possible -- e.g. https://github.com/apache/lucene-solr/commit/def6816f48598ce8e8757239b98969b5e18b21af#diff-755a6c65165611aab0efa0a8e9ff0ac9 -- but are not forwarded to any of our lists it seems?