[jira] [Created] (LUCENE-8928) BKDWriter could make splitting decisions based on the actual range of values

2019-07-19 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8928: Summary: BKDWriter could make splitting decisions based on the actual range of values Key: LUCENE-8928 URL: https://issues.apache.org/jira/browse/LUCENE-8928 Project

Re: Lucene/Solr 8.2.0

2019-07-19 Thread Adrien Grand
ion leaking (Several classes depend on the >> >>> Arc internals today). EG I'd like to make its members private and add >> >>> getters. I know this is a performance-sensitive area, and maybe we had >> >>> a reason for not using them? Do we have so

[jira] [Commented] (LUCENE-8924) Remove Fields Order Checks from CheckIndex?

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887300#comment-16887300 ] Adrien Grand commented on LUCENE-8924: -- We rely on the order for merging, see "MultiF

[jira] [Commented] (LUCENE-8909) Deprecate getFieldNames from IndexWriter

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887291#comment-16887291 ] Adrien Grand commented on LUCENE-8909: -- +1 > Deprecate getFieldNames from IndexWri

[jira] [Commented] (LUCENE-8908) Specified default value not returned for query() when doc doesn't match

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887290#comment-16887290 ] Adrien Grand commented on LUCENE-8908: -- +1 > Specified default value not returned for query() w

[jira] [Commented] (LUCENE-8922) Speed up retrieval of top hits of DisjunctionMaxQuery

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886944#comment-16886944 ] Adrien Grand commented on LUCENE-8922: -- Here is a patch. It uses the first clause that has a score

[jira] [Commented] (LUCENE-8923) Release procedure does not add new version in CHANGES.txt in master

2019-07-17 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886941#comment-16886941 ] Adrien Grand commented on LUCENE-8923: -- +1 Even if some changes are missing I think we'd benefit

[jira] [Created] (LUCENE-8922) Speed up retrieval of top hits of DisjunctionMaxQuery

2019-07-17 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8922: Summary: Speed up retrieval of top hits of DisjunctionMaxQuery Key: LUCENE-8922 URL: https://issues.apache.org/jira/browse/LUCENE-8922 Project: Lucene - Core

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886114#comment-16886114 ] Adrien Grand commented on LUCENE-8883: -- I have a slight preference for having "Optimiza

[jira] [Commented] (LUCENE-8884) Add Directory wrapper to track per-query IO counters

2019-07-16 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886043#comment-16886043 ] Adrien Grand commented on LUCENE-8884: -- I'm not seeing any attachement on this JIRA, did you forget

Re: Lucene/Solr 8.2.0

2019-07-15 Thread Adrien Grand
aybe we had > a reason for not using them? Do we have some experience that suggests > that would be a performance issue? My assumption is that JIT > compilation would make that free, but I haven't tested. > > On Mon, Jul 15, 2019 at 11:36 AM Adrien Grand wrote: > > > > That

Re: Lucene/Solr 8.2.0

2019-07-15 Thread Adrien Grand
ct > addressing is heavily data-dependent. I think we can improve the > situation here by tracking, per-FST instance, the size increase we're > seeing while building (or perhaps do a preliminary pass before > building) in order to decide whether to apply the encoding. > > On Mon, Jul

[jira] [Resolved] (LUCENE-8810) Flattening of nested disjunctions does not take into account number of clause limitation of builder

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8810. -- Resolution: Fixed Fix Version/s: (was: 8.1.1) 8.2 > Flatten

Re: Lucene/Solr 8.2.0

2019-07-15 Thread Adrien Grand
I dug this a bit and suspect that the issue is mostly with one field that is not part of the data but auto-generated: the ID field. It is a slight variant of Flake IDs, so it's not random, it includes a timestamp and a sequence number, and I suspect that its patterns combined with the larger

[jira] [Created] (LUCENE-8917) Remove the "Direct" doc-value format

2019-07-15 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8917: Summary: Remove the "Direct" doc-value format Key: LUCENE-8917 URL: https://issues.apache.org/jira/browse/LUCENE-8917 Project: Lucene - Core

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884944#comment-16884944 ] Adrien Grand commented on LUCENE-8811: -- Thanks! I'll revert this change from 8.x and 8.2

Re: Lucene/Solr 8.2.0

2019-07-15 Thread Adrien Grand
FYI I added a note to https://issues.apache.org/jira/browse/LUCENE-8811, I think it's too breaking for 8.2 and should wait for 9.0. We can mitigate LUCENE-8810 in 8.x by disabling the flattening of inner disjunctions when this would create too many clauses in a single BooleanQuery. I'll work with

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884932#comment-16884932 ] Adrien Grand commented on LUCENE-8811: -- [~atris] If the patch you are thinking of is the one

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884904#comment-16884904 ] Adrien Grand commented on LUCENE-8811: -- I was reviewing the changelog for 8.2, this change looks

[jira] [Resolved] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8311. -- Resolution: Fixed Fix Version/s: 8.2 > Leverage impacts for phrase quer

[jira] [Commented] (LUCENE-8909) Deprecate getFieldNames from IndexWriter

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882325#comment-16882325 ] Adrien Grand commented on LUCENE-8909: -- +1 > Deprecate getFieldNames from IndexWri

[jira] [Resolved] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8875. -- Resolution: Fixed Fix Version/s: 8.2 > Should TopScoreDocCollector Always Popul

[jira] [Commented] (LUCENE-8907) Provide backward compatibility for loading analysis factories

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882074#comment-16882074 ] Adrien Grand commented on LUCENE-8907: -- I have a slight preference for reverting on 8.x and have

Re: 8.1.2 bug fix release

2019-07-10 Thread Adrien Grand
Adrien Grand wrote: > > Agreed with Shalin, we might want to focus on 8.2 at this point. > > On Fri, Jul 5, 2019 at 8:38 AM Shalin Shekhar Mangar > wrote: > > > > Thanks Dat. > > > > I don't think we should release a broken version without a fix for > > S

[jira] [Commented] (LUCENE-8907) Provide backward compatibility for loading analysis factories

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881982#comment-16881982 ] Adrien Grand commented on LUCENE-8907: -- I don't like 2, it feels too breaking to me for a minor

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881967#comment-16881967 ] Adrien Grand commented on LUCENE-8311: -- This made exact phrase queries 3x faster in the nightly

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881541#comment-16881541 ] Adrien Grand commented on LUCENE-8883: -- I did grep "^[A-Z]" CHANGES.txt | sort | uniq -c

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881491#comment-16881491 ] Adrien Grand commented on LUCENE-8069: -- I didn't measure the indexing rate, I can do that next. Yes

[jira] [Resolved] (LUCENE-8900) Simplify MultiSorter

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8900. -- Resolution: Fixed Fix Version/s: 8.2 Thanks [~danmuzi]. > Simplify MultiSor

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-09 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880981#comment-16880981 ] Adrien Grand commented on LUCENE-8883: -- I just looked at the section names that we used at least 10

[jira] [Commented] (LUCENE-4312) Index format to store position length per position

2019-07-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880606#comment-16880606 ] Adrien Grand commented on LUCENE-4312: -- bq. the complexity of query execution would be driven

[jira] [Commented] (LUCENE-4312) Index format to store position length per position

2019-07-08 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880422#comment-16880422 ] Adrien Grand commented on LUCENE-4312: -- Recording position lengths in the index is the easy part

Re: [JENKINS] Lucene-Solr-SmokeRelease-8.x - Build # 142 - Still Failing

2019-07-08 Thread Adrien Grand
For those who haven't followed the 8.1.2 release thread, we are asking infra for help about this issue at https://issues.apache.org/jira/browse/INFRA-18701. On Sun, Jul 7, 2019 at 7:24 PM Apache Jenkins Server wrote: > > Build: https://builds.apache.org/job/Lucene-Solr-SmokeRelease-8.x/142/ > >

Re: [JENKINS] Lucene-Solr-master-Linux (64bit/jdk-11.0.3) - Build # 24366 - Failure!

2019-07-08 Thread Adrien Grand
Does anyone know why we are getting these accessibility issues? On Mon, Jul 8, 2019 at 10:09 AM Policeman Jenkins Server wrote: > > Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/24366/ > Java: 64bit/jdk-11.0.3 -XX:+UseCompressedOops -XX:+UseConcMarkSweepGC > > All tests passed

[jira] [Commented] (LUCENE-8860) LatLonShapeBoundingBoxQuery could make more decisions on inner nodes

2019-07-05 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879116#comment-16879116 ] Adrien Grand commented on LUCENE-8860: -- I made the issue about box queries, but that would actually

Re: 8.1.2 bug fix release

2019-07-05 Thread Adrien Grand
Agreed with Shalin, we might want to focus on 8.2 at this point. On Fri, Jul 5, 2019 at 8:38 AM Shalin Shekhar Mangar wrote: > > Thanks Dat. > > I don't think we should release a broken version without a fix for > SOLR-13413. A workaround for SOLR-13413 exists (forcing http1.1 for > inter-node

[jira] [Commented] (SOLR-12368) in-place DV updates should no longer have to jump through hoops if field does not yet exist

2019-07-04 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878866#comment-16878866 ] Adrien Grand commented on SOLR-12368: - I'm not familiar enough with how Solr routes updates to doc

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877919#comment-16877919 ] Adrien Grand commented on LUCENE-8311: -- I opened https://github.com/apache/lucene-solr/pull/760

[jira] [Commented] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877916#comment-16877916 ] Adrien Grand commented on LUCENE-8762: -- I proposed to change the specialization for docs+freqs

[jira] [Commented] (LUCENE-8311) Leverage impacts for phrase queries

2019-07-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877849#comment-16877849 ] Adrien Grand commented on LUCENE-8311: -- It turns out that part of the reason why the patch

[jira] [Commented] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877185#comment-16877185 ] Adrien Grand commented on LUCENE-8899: -- This sounds very similar to what TermInSetQuery is doing

[jira] [Commented] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877183#comment-16877183 ] Adrien Grand commented on LUCENE-8900: -- Thanks [~danmuzi], I will apply your first suggestion

[jira] [Commented] (LUCENE-8901) Load frequencies lazily for postings and impacts

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877164#comment-16877164 ] Adrien Grand commented on LUCENE-8901: -- Thanks [~mayyas]! > Load frequencies lazily for posti

[jira] [Updated] (LUCENE-8901) Load frequencies lazily for postings and impacts

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8901: - Fix Version/s: 8.2 > Load frequencies lazily for postings and impa

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877157#comment-16877157 ] Adrien Grand commented on LUCENE-8857: -- Double checking, have you run all Solr tests or only

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877155#comment-16877155 ] Adrien Grand commented on LUCENE-8857: -- Thanks [~atris] I'll look into merging now. MIGRATE

[jira] [Reopened] (LUCENE-8069) Allow index sorting by field length

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-8069: -- I've had this idea come back to my mind several times since I opened it. Sorting by norm brings

[jira] [Updated] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8900: - Attachment: LUCENE-8900.patch Status: Open (was: Open) Here is a patch, it does two

[jira] [Created] (LUCENE-8900) Simplify MultiSorter

2019-07-02 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8900: Summary: Simplify MultiSorter Key: LUCENE-8900 URL: https://issues.apache.org/jira/browse/LUCENE-8900 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-8892) Missing closing parens in string representation of MultiBoolFunction

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876712#comment-16876712 ] Adrien Grand commented on LUCENE-8892: -- [~munendrasn] I resolved and gave you permission. It should

[jira] [Updated] (LUCENE-8892) Missing closing parens in string representation of MultiBoolFunction

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8892: - Resolution: Fixed Fix Version/s: 8.2 Status: Resolved (was: Patch Available

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876705#comment-16876705 ] Adrien Grand commented on LUCENE-8857: -- We need to have all changes in the same pull request

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876698#comment-16876698 ] Adrien Grand commented on LUCENE-8857: -- [~atris] Thanks for looking into the grouping failure. I'm

[jira] [Commented] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876689#comment-16876689 ] Adrien Grand commented on LUCENE-8757: -- This change as been reverted from 8.x due to the fact

[jira] [Updated] (LUCENE-8757) Better Segment To Thread Mapping Algorithm

2019-07-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8757: - Fix Version/s: (was: 8.2) > Better Segment To Thread Mapping Algori

Re: [JENKINS] Lucene-Solr-8.x-Linux (64bit/jdk-11.0.3) - Build # 803 - Unstable!

2019-07-02 Thread Adrien Grand
I muted this test and opened https://issues.apache.org/jira/browse/LUCENE-8898, which I made a blocker for 8.2. On Tue, Jul 2, 2019 at 7:27 AM Policeman Jenkins Server wrote: > > Build: https://jenkins.thetaphi.de/job/Lucene-Solr-8.x-Linux/803/ > Java: 64bit/jdk-11.0.3 -XX:-UseCompressedOops

[jira] [Created] (LUCENE-8898) TestRamUsageEstimator.testMap failures

2019-07-01 Thread Adrien Grand (JIRA)
Adrien Grand created LUCENE-8898: Summary: TestRamUsageEstimator.testMap failures Key: LUCENE-8898 URL: https://issues.apache.org/jira/browse/LUCENE-8898 Project: Lucene - Core Issue Type

[jira] [Updated] (LUCENE-8898) TestRamUsageEstimator.testMap failures

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-8898: - Issue Type: Bug (was: Improvement) > TestRamUsageEstimator.testMap failu

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876248#comment-16876248 ] Adrien Grand commented on LUCENE-8857: -- [~atris] Can you look into those failures? I had understood

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876242#comment-16876242 ] Adrien Grand commented on LUCENE-8857: -- Thanks [~munendrasn] I'm reverting now. > Refactor TopD

[jira] [Resolved] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8857. -- Resolution: Fixed Fix Version/s: master (9.0) > Refactor TopDocs#Merge To T

[jira] [Commented] (LUCENE-8882) Add State To QueryVisitor

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876132#comment-16876132 ] Adrien Grand commented on LUCENE-8882: -- Can you elaborate more on how this would help replace

[jira] [Resolved] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-07-01 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8862. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) > Collector Le

[jira] [Commented] (LUCENE-8892) Missing closing parens in string representation of MultiBoolFunction

2019-06-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874962#comment-16874962 ] Adrien Grand commented on LUCENE-8892: -- +1 > Missing closing parens in string representat

[jira] [Commented] (LUCENE-8831) LatLonShapeBoundingBoxQuery hashcode is wrong

2019-06-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874906#comment-16874906 ] Adrien Grand commented on LUCENE-8831: -- [~ivera] This looks like a good candidate for 8.1.2

[jira] [Commented] (LUCENE-8878) Provide alternative sorting utility from SortField other than FieldComparator

2019-06-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874810#comment-16874810 ] Adrien Grand commented on LUCENE-8878: -- [~mikemccand] ImpactsEnum as mostly about exposing maximum

[jira] [Resolved] (LUCENE-8890) Parallel Iteration of Lists

2019-06-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8890. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) Thank you

[jira] [Moved] (LUCENE-8890) Parallel Iteration of Lists

2019-06-28 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand moved SOLR-12736 to LUCENE-8890: - Affects Version/s: (was: 8.0) Lucene Fields: New

[jira] [Resolved] (LUCENE-8889) Remove Dead Code From PointRangeQuery

2019-06-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8889. -- Resolution: Fixed Fix Version/s: 8.2 master (9.0) Oops I had

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

2019-06-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874010#comment-16874010 ] Adrien Grand commented on LUCENE-8871: -- The visibility changes are required because our Javadocs

[jira] [Commented] (LUCENE-8871) Move Kuromoji DictionaryBuilder tool from src/tools to src/

2019-06-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873980#comment-16873980 ] Adrien Grand commented on LUCENE-8871: -- [~sokolov] I tried to address the precommit failures

[jira] [Commented] (LUCENE-8886) TestMutablePointsReaderUtils not doing what it is expected

2019-06-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873941#comment-16873941 ] Adrien Grand commented on LUCENE-8886: -- +1 > TestMutablePointsReaderUtils not doing w

[jira] [Commented] (LUCENE-8855) Add Accountable to some Query implementations

2019-06-27 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873849#comment-16873849 ] Adrien Grand commented on LUCENE-8855: -- [~ab] I'd be in favor of waiting for 8.2, which we could

[jira] [Commented] (LUCENE-8855) Add Accountable to some Query implementations

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873426#comment-16873426 ] Adrien Grand commented on LUCENE-8855: -- [~ab] I'm surprised this went to 8.1, this isn't a bug fix

[jira] [Commented] (LUCENE-8885) Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873323#comment-16873323 ] Adrien Grand commented on LUCENE-8885: -- I don't think backward compatibility should be a concern

[jira] [Commented] (LUCENE-8877) TopDocsCollector Should Not Depend on Priority Queue

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873014#comment-16873014 ] Adrien Grand commented on LUCENE-8877: -- Abstraction increases complexity too, it feels reasonable

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873011#comment-16873011 ] Adrien Grand commented on LUCENE-8855: -- +1 > Add Accountable to Query implementati

[jira] [Commented] (LUCENE-8870) Support numeric value in Field class

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873009#comment-16873009 ] Adrien Grand commented on LUCENE-8870: -- bq. Currently NumericDocValuesField does not support

[jira] [Commented] (LUCENE-8878) Provide alternative sorting utility from SortField other than FieldComparator

2019-06-26 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873003#comment-16873003 ] Adrien Grand commented on LUCENE-8878: -- bq. Is it the case today? I wonder whether the ordinals

[jira] [Commented] (LUCENE-8878) Provide alternative sorting utility from SortField other than FieldComparator

2019-06-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872534#comment-16872534 ] Adrien Grand commented on LUCENE-8878: -- +1 to simplify, even at the cost of some performance

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872532#comment-16872532 ] Adrien Grand commented on LUCENE-8855: -- BytesRefHash has some code commented out that looks like

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2019-06-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872205#comment-16872205 ] Adrien Grand commented on LUCENE-8806: -- Oh, that is interesting. Are you testing on wikibigall

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2019-06-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872156#comment-16872156 ] Adrien Grand commented on LUCENE-8806: -- I'm a bit confused as to why HighPhraseHighTerm and some

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2019-06-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872151#comment-16872151 ] Adrien Grand commented on LUCENE-8806: -- FYI we have an issue for phrases already LUCENE-8311

Re: Propose CHANGES.txt releases begin with the categories (empty)

2019-06-25 Thread Adrien Grand
+1, it's otherwise tempting to reuse an existing category even if it doesn't fit as well as a category that is not listed yet. On Tue, Jun 25, 2019 at 6:40 AM David Smiley wrote: > > Looking at Solr's CHANGES.txt for 8.2 I see we have some sections: "Upgrade > Notes", "New Features", "Bug

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871732#comment-16871732 ] Adrien Grand commented on LUCENE-8875: -- Aggregates don't have this issue since they don't track top

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871560#comment-16871560 ] Adrien Grand commented on LUCENE-8875: -- What do you mean by bucket aggregates? > Sho

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871508#comment-16871508 ] Adrien Grand commented on LUCENE-8875: -- I like pre-populating the hit queue mostly because it makes

[jira] [Commented] (LUCENE-8870) Support numeric value in Field class

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871491#comment-16871491 ] Adrien Grand commented on LUCENE-8870: -- I think this new constructor would be misleading

Re: Welcome Munendra S N as Lucene/Solr committer

2019-06-24 Thread Adrien Grand
Welcome Munendra! On Fri, Jun 21, 2019 at 11:42 AM Ishan Chattopadhyaya wrote: > > Hi all, > > Please join me in welcoming Munendra as a Lucene/Solr committer! > > Munendra has been working on bug fixes and improvements in various > parts of Solr. > > Congratulations and welcome! It is a

[jira] [Commented] (LUCENE-8806) WANDScorer should support two-phase iterator

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871436#comment-16871436 ] Adrien Grand commented on LUCENE-8806: -- +1 Can you run luceneutil on some disjunctions of phrase

[jira] [Commented] (LUCENE-8876) EnglishMinimalStemmer does not implement s-stemmer paper correctly?

2019-06-24 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871408#comment-16871408 ] Adrien Grand commented on LUCENE-8876: -- I agree that the use of "applicable"

[jira] [Commented] (LUCENE-8868) New storing strategy for BKD tree leaves with low cardinality

2019-06-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868334#comment-16868334 ] Adrien Grand commented on LUCENE-8868: -- Is the index-time overhead noticeable? I'm thinking

[jira] [Commented] (LUCENE-8855) Add Accountable to Query implementations

2019-06-20 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868322#comment-16868322 ] Adrien Grand commented on LUCENE-8855: -- Thanks Andrzej this looks like a better trade-off to me

[jira] [Commented] (LUCENE-8858) Migrate Lucene's Moin wiki to Confluence

2019-06-19 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867284#comment-16867284 ] Adrien Grand commented on LUCENE-8858: -- Thanks [~janhoy] and [~hossman]! > Migrate Lucene's M

[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866873#comment-16866873 ] Adrien Grand commented on LUCENE-8867: -- +1 to split > Optimise BKD tree for low cardinality lea

[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866830#comment-16866830 ] Adrien Grand commented on LUCENE-8867: -- Sorry, reading my comment again I realize it wasn't clear

[jira] [Commented] (LUCENE-8867) Optimise BKD tree for low cardinality leaves

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866785#comment-16866785 ] Adrien Grand commented on LUCENE-8867: -- This is only an issue in the case that not all dimensions

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866782#comment-16866782 ] Adrien Grand commented on LUCENE-8769: -- It feels a bit wrong to me to implement support

[jira] [Commented] (LUCENE-8853) FileSwitchDirectory is broken if temp outputs are used

2019-06-18 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866720#comment-16866720 ] Adrien Grand commented on LUCENE-8853: -- I had to change the random directory creation logic to only

<    1   2   3   4   5   6   7   8   9   10   >