[GitHub] [lucene-jira-archive] mocobeta commented on issue #1: Fix markup conversion error

2022-06-29 Thread GitBox
mocobeta commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1169860211 Thanks for reporting. I found Jira's number list (`#`) is not correctly converted and it is interpreted as headers in Markdown. Jira dump ``` "body":

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #3: Create mapping on Jira user id -> GitHub account

2022-06-29 Thread GitBox
mocobeta opened a new issue, #3: URL: https://github.com/apache/lucene-jira-archive/issues/3 To correctly map Jira user ids in issues (reporter/assignee/author) to GitHub account, we need an account mapping file. This could be inferred from https://github.com/orgs/apache/people? --

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #2: Archive all Jira attachments

2022-06-29 Thread GitBox
mocobeta opened a new issue, #2: URL: https://github.com/apache/lucene-jira-archive/issues/2 All attachments should be archived in `attachments/`. They will be referred from the migrated issues in https://github.com/apache/lucene. For files with the same names, we keep the latest

[GitHub] [lucene-jira-archive] dweiss commented on issue #1: Fix markup conversion error

2022-06-29 Thread GitBox
dweiss commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1169793482 ![image](https://user-images.githubusercontent.com/199470/176411524-9d1a8998-09cb-4544-9890-282ba1ff8b31.png) This is what the bold block-issue looks like. -- This is

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #1: Fix markup conversion error

2022-06-29 Thread GitBox
mocobeta opened a new issue, #1: URL: https://github.com/apache/lucene-jira-archive/issues/1 There are various errors in converting Jira markup to Markdown. For example: - tables are broken - bullet lists converted to bold blocks (?) - bullet lists include unnecessary spaces

[GitHub] [lucene] zacharymorn commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-03 Thread GitBox
zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r841312352 ## lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] zacharymorn commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-04-03 Thread GitBox
zacharymorn commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r841309603 ## lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java: ## @@ -31,42 +28,21 @@ /** * A {@link Query} that matches documents that have a

[GitHub] [lucene-solr-sandbox] anshumg opened a new pull request #1: Create .asf.yaml

2021-02-05 Thread GitBox
anshumg opened a new pull request #1: URL: https://github.com/apache/lucene-solr-sandbox/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #179: Migrating CI/CD from travis to github actions.

2021-01-15 Thread GitBox
HoustonPutman opened a new pull request #179: URL: https://github.com/apache/lucene-solr-operator/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene-solr-operator] anshumg commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
anshumg commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760558019 Just to be clear, @HoustonPutman meant 'smooth'  This is an automated message from the Apache Git

[GitHub] [lucene-solr-operator] dalbani commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
dalbani commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760550211 Okay, great, thanks a lot. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
HoustonPutman commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760550041 Great question, I should have addressed it. It looks like we will unfortunately not be able to move to apache/solr-operator for a while. It will eventually

[GitHub] [lucene-solr-operator] dalbani commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
dalbani commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760547409 But, as you said, will the Git project and Helm repo eventually move to `apache/solr-operator` instead of `apache/lucene-solr-operator`?

[GitHub] [lucene-solr-operator] HoustonPutman closed issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
HoustonPutman closed issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #178: Change the repo location to apache

2021-01-14 Thread GitBox
HoustonPutman merged pull request #178: URL: https://github.com/apache/lucene-solr-operator/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg commented on pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760545292 Thanks for taking a look @klaporte :) This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr-operator] anshumg closed issue #175: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg closed issue #175: URL: https://github.com/apache/lucene-solr-operator/issues/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr-operator] anshumg merged pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg merged pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #178: Change the repo location to apache

2021-01-14 Thread GitBox
HoustonPutman opened a new pull request #178: URL: https://github.com/apache/lucene-solr-operator/pull/178 Fixes: #173 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr-operator] HoustonPutman closed pull request #174: Create .asf.yaml

2021-01-14 Thread GitBox
HoustonPutman closed pull request #174: URL: https://github.com/apache/lucene-solr-operator/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #177: Add .asf.yaml

2021-01-14 Thread GitBox
HoustonPutman merged pull request #177: URL: https://github.com/apache/lucene-solr-operator/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #177: Add .asf.yaml

2021-01-14 Thread GitBox
HoustonPutman opened a new pull request #177: URL: https://github.com/apache/lucene-solr-operator/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene-solr-operator] klaporte commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
klaporte commented on pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760495787 Looks good to me. Thanks @anshumg & @HoustonPutman This is an automated message from the Apache

[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg commented on pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760490146 FYI, still waiting for Infra to remove the required checks before I can squash and merge. This is

[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg commented on pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760474459 @HoustonPutman - reading more about the license and the requirements around that. We might be able to remove that too. I'll do that as another PR if needed once I

[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg commented on a change in pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#discussion_r557694683 ## File path: NOTICE.txt ## @@ -0,0 +1,30 @@ +== + Apache Solr + Copyright

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
HoustonPutman commented on a change in pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176#discussion_r557689208 ## File path: NOTICE.txt ## @@ -0,0 +1,30 @@ +== + Apache Solr + Copyright

[GitHub] [lucene-solr-operator] anshumg opened a new pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg opened a new pull request #176: URL: https://github.com/apache/lucene-solr-operator/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr-operator] anshumg opened a new issue #175: Standardize headers to be ASL2.0, move copyright to NOTICE

2021-01-14 Thread GitBox
anshumg opened a new issue #175: URL: https://github.com/apache/lucene-solr-operator/issues/175 As per the discussion here : https://issues.apache.org/jira/browse/LEGAL-553 Standardize the file headers to be ASL2.0 text, and move the copyright to NOTICE.txt

[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #174: Create .asf.yaml

2021-01-14 Thread GitBox
HoustonPutman opened a new pull request #174: URL: https://github.com/apache/lucene-solr-operator/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
HoustonPutman commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760309717 In the meantime, you should be able to use this instead: (Just a fix until the real changes have been made) ``` helm repo add solr-operator

[GitHub] [lucene-solr-operator] HoustonPutman commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
HoustonPutman commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760276148 Hey everyone, sorry about this. I'll try to have it available as soon as possible. Unfortunately the repo was moved to `apache/lucene-solr-operator` instead

[GitHub] [lucene-solr-operator] vladiceanu commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
vladiceanu commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760272753 @bsankara any news on this? thanks This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr-operator] benediktarnold commented on issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
benediktarnold commented on issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173#issuecomment-760132855 I don't know when it happened, but since solr-operator is now an apache project, it makes sense that the chart isn't hosted on bloombergs github page anymore. I'm

[GitHub] [lucene-solr-operator] dalbani opened a new issue #173: Helm repository is not available anymore

2021-01-14 Thread GitBox
dalbani opened a new issue #173: URL: https://github.com/apache/lucene-solr-operator/issues/173 We used to use the Helm repository located at https://bloomberg.github.io/solr-operator/charts, but it seems not to be available anymore. Is there a new location? The documentation still

[GitHub] [lucene-solr] dsmiley closed pull request #855: SOLR-13739: Improve performance on huge schema updates

2019-09-13 Thread GitBox
dsmiley closed pull request #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531276346 Hmm, the precommit failure seems to be coming from `JdbcDataSource.java`?

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531275454 @jimczi Here is the link:

[GitHub] [lucene-solr] iverase commented on issue #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components

2019-09-13 Thread GitBox
iverase commented on issue #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components URL: https://github.com/apache/lucene-solr/pull/627#issuecomment-531271483 See #878 This is an automated

[GitHub] [lucene-solr] iverase closed pull request #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components

2019-09-13 Thread GitBox
iverase closed pull request #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components URL: https://github.com/apache/lucene-solr/pull/627 This is an automated message from the Apache Git

[GitHub] [lucene-solr] iverase opened a new pull request #878: LUCENE-8746: Refactor EdgeTree

2019-09-13 Thread GitBox
iverase opened a new pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878 Another try in refactoring edge tree. This PR splits Edge Tree class into two and adds a new interface: * Component2D: Interface defining an object that knows

[GitHub] [lucene-solr] jimczi commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531266829 Can you run another benchmark now that we propagate the global min score to the scorer ?

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531261223 @jimczi Updated This is an automated message from the Apache

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324221245 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324218422 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324218620 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324216889 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531233493 Thanks! This is an automated message from the

[GitHub] [lucene-solr] msokolov commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
msokolov commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531233209 thanks! merged This is an automated message

[GitHub] [lucene-solr] msokolov merged pull request #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
msokolov merged pull request #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531230646 Thanks, missed the camel casing, fixed now This

[GitHub] [lucene-solr] msokolov commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
msokolov commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531229416 I'll commit it. As I looked at this I couldn't help noticing a little spelling nit; we have {{thresHold}} but

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531228068 @jimczi Updated, please see. One thing we could do is cache the bottom docID (doc + docBase) in BottomValueChecker,

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324181290 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324146082 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324146126 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324162028 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324161934 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold

2019-09-13 Thread GitBox
atris commented on issue #876: Use The Passed In Threshold Value in doConcurrentSearchWithThreshold URL: https://github.com/apache/lucene-solr/pull/876#issuecomment-531226956 Can we merge this one? This is a simple fix to an existing test method.

[GitHub] [lucene-solr] jpountz merged pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible.

2019-09-13 Thread GitBox
jpountz merged pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible. URL: https://github.com/apache/lucene-solr/pull/868 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache

2019-09-13 Thread GitBox
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-531221868 Any further thoughts on this one? This is an automated

[GitHub] [lucene-solr] jpountz commented on issue #875: merge master

2019-09-13 Thread GitBox
jpountz commented on issue #875: merge master URL: https://github.com/apache/lucene-solr/pull/875#issuecomment-531221639 Probably open by mistake. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] jpountz closed pull request #875: merge master

2019-09-13 Thread GitBox
jpountz closed pull request #875: merge master URL: https://github.com/apache/lucene-solr/pull/875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene-solr] jpountz commented on a change in pull request #865: LUCENE-8973: XYRectangle2D should work on float space

2019-09-13 Thread GitBox
jpountz commented on a change in pull request #865: LUCENE-8973: XYRectangle2D should work on float space URL: https://github.com/apache/lucene-solr/pull/865#discussion_r324172772 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/XYRectangle2D.java ## @@ -16,42

[GitHub] [lucene-solr] iverase commented on issue #770: LUCENE-8746: Component2D topology library that works on encoded space

2019-09-13 Thread GitBox
iverase commented on issue #770: LUCENE-8746: Component2D topology library that works on encoded space URL: https://github.com/apache/lucene-solr/pull/770#issuecomment-531219042 Closing this PR. I am opening a new one with narrow scope

[GitHub] [lucene-solr] iverase closed pull request #770: LUCENE-8746: Component2D topology library that works on encoded space

2019-09-13 Thread GitBox
iverase closed pull request #770: LUCENE-8746: Component2D topology library that works on encoded space URL: https://github.com/apache/lucene-solr/pull/770 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324145887 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324141173 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324141301 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] KoenDG commented on a change in pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible.

2019-09-13 Thread GitBox
KoenDG commented on a change in pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible. URL: https://github.com/apache/lucene-solr/pull/868#discussion_r324133535 ## File path: lucene/CHANGES.txt ## @@ -65,6 +65,8 @@ Other *

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130344 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130518 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324125480 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324122789 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130957 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324130644 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324129841 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324116784 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531174857 @jimczi Thanks for the comments -- updated the PR. Please let me know your thoughts

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324105474 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324105474 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324103471 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ## @@

[GitHub] [lucene-solr] atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324103214 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jpountz commented on a change in pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible.

2019-09-13 Thread GitBox
jpountz commented on a change in pull request #868: LUCENE-8975: Code Cleanup: Use entryset for map iteration wherever possible. URL: https://github.com/apache/lucene-solr/pull/868#discussion_r324101947 ## File path: lucene/CHANGES.txt ## @@ -65,6 +65,8 @@ Other *

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324098325 ## File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java ##

[GitHub] [lucene-solr] jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
jimczi commented on a change in pull request #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#discussion_r324097168 ## File path: lucene/core/src/java/org/apache/lucene/search/BottomValueChecker.java ##

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531142523 I ran luceneutil with concurrent mode and wikimedium2m -- no degradation to QPS and some tasks show a reduction of around 30%

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324030543 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/LocalStorageClient.java ##

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324027378 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/BlobCoreMetadataBuilder.java

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385 ## File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385 ## File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324026158 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/BlobCoreMetadata.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323967328 ## File path: solr/core/src/java/org/apache/solr/handler/admin/RequestApplyUpdatesOp.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323982385 ## File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324023752 ## File path: solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323984413 ## File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/IndexSizeTrigger.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323981156 ## File path: solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323974231 ## File path: solr/core/src/java/org/apache/solr/store/blob/provider/BlobStorageProvider.java ##

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323972376 ## File path: solr/core/src/java/org/apache/solr/store/blob/client/S3StorageClient.java ## @@

[GitHub] [lucene-solr] eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud

2019-09-12 Thread GitBox
eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r323974906 ## File path: solr/core/src/java/org/apache/solr/store/blob/provider/BlobStorageProvider.java ##

  1   2   3   4   5   6   7   8   9   10   >