[jira] [Commented] (LUCENE-6572) Highlighter depends on analyzers-common

2018-10-17 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653407#comment-16653407 ] Martijn van Groningen commented on LUCENE-6572: --- > do you have background on why we have

[jira] [Commented] (LUCENE-8152) Simplify conditionals in JoinUtil

2018-02-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350317#comment-16350317 ] Martijn van Groningen commented on LUCENE-8152: --- +1 That is much cleaner > Simplify

[jira] [Resolved] (LUCENE-8120) Fix LatLonBoundingBox's toString() method

2018-01-11 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-8120. --- Resolution: Fixed Fix Version/s: 7.3 master (8.0)

[jira] [Updated] (LUCENE-8120) Fix LatLonBoundingBox's toString() method

2018-01-09 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-8120: -- Attachment: LUCENE-8120.patch bq. Let's maybe just give bounds back in the

[jira] [Updated] (LUCENE-8120) Fix LatLonBoundingBox's toString() method

2018-01-05 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-8120: -- Attachment: LUCENE-8120.patch > Fix LatLonBoundingBox's toString() method >

[jira] [Created] (LUCENE-8120) Fix LatLonBoundingBox's toString() method

2018-01-05 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-8120: - Summary: Fix LatLonBoundingBox's toString() method Key: LUCENE-8120 URL: https://issues.apache.org/jira/browse/LUCENE-8120 Project: Lucene - Core

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-21 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299740#comment-16299740 ] Martijn van Groningen commented on LUCENE-8104: --- I think for the grouping module, for now,

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260581#comment-16260581 ] Martijn van Groningen commented on LUCENE-8055: --- +1 thanks [~simonw]! >

[jira] [Closed] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public

2017-08-11 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen closed LUCENE-7928. - Resolution: Fixed Ok, I agree, that this is an expert use case and that the api

[jira] [Commented] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public

2017-08-11 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123309#comment-16123309 ] Martijn van Groningen commented on LUCENE-7928: --- I agree that these queries should only be

[jira] [Updated] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public

2017-08-11 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7928: -- Attachment: LUCENE_7928.patch > Change LatLonPointDistanceQuery and

[jira] [Created] (LUCENE-7928) Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public

2017-08-11 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7928: - Summary: Change LatLonPointDistanceQuery and LatLonPointInPolygonQuery visibility to public Key: LUCENE-7928 URL:

[jira] [Commented] (LUCENE-7889) Allow grouping on DoubleValuesSource ranges

2017-07-03 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072431#comment-16072431 ] Martijn van Groningen commented on LUCENE-7889: --- Nice addition! Agreed that it lacks jdocs

[jira] [Resolved] (LUCENE-7890) MemoryIndex should allow doc values iterator to be reset to the current docid

2017-06-29 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7890. --- Resolution: Fixed Pushed to master branch. I did not add an entry to

[jira] [Updated] (LUCENE-7890) MemoryIndex should allow doc values iterator to be reset to the current docid

2017-06-28 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7890: -- Attachment: LUCENE-7890.patch Attached patch with fix and a test. >

[jira] [Created] (LUCENE-7890) MemoryIndex should allow doc values iterator to be reset to the current docid

2017-06-28 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7890: - Summary: MemoryIndex should allow doc values iterator to be reset to the current docid Key: LUCENE-7890 URL: https://issues.apache.org/jira/browse/LUCENE-7890

[jira] [Updated] (LUCENE-7304) Doc values based block join implementation

2017-06-22 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7304: -- Attachment: LUCENE-7304.patch Updated the patch. Added a more tests and

[jira] [Commented] (LUCENE-7571) TestJoinUtil.testSingleValueRandomJoin() failure

2017-06-19 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053727#comment-16053727 ] Martijn van Groningen commented on LUCENE-7571: --- The test failed doing a numeric join on a

[jira] [Updated] (LUCENE-7869) MemoryIndex should sort 1d points

2017-06-08 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7869: -- Fix Version/s: 6.6.1 > MemoryIndex should sort 1d points >

[jira] [Resolved] (LUCENE-7869) MemoryIndex should sort 1d points

2017-06-08 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7869. --- Resolution: Fixed > MemoryIndex should sort 1d points >

[jira] [Updated] (LUCENE-7869) MemoryIndex should sort 1d points

2017-06-08 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7869: -- Fix Version/s: 6.7 master (7.0) > MemoryIndex should sort

[jira] [Assigned] (LUCENE-7571) TestJoinUtil.testSingleValueRandomJoin() failure

2017-06-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen reassigned LUCENE-7571: - Assignee: Martijn van Groningen >

[jira] [Updated] (LUCENE-7869) MemoryIndex should sort 1d points

2017-06-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7869: -- Attachment: LUCENE_7869.patch Attached a patch with a fix and a test. >

[jira] [Created] (LUCENE-7869) MemoryIndex should sort 1d points

2017-06-07 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7869: - Summary: MemoryIndex should sort 1d points Key: LUCENE-7869 URL: https://issues.apache.org/jira/browse/LUCENE-7869 Project: Lucene - Core

[jira] [Updated] (LUCENE-7304) Doc values based block join implementation

2017-05-24 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7304: -- Attachment: LUCENE-7304.patch It has been a while, but I had some time to get

[jira] [Commented] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-23 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021681#comment-16021681 ] Martijn van Groningen commented on LUCENE-7810: --- The change has been backported to 6.6

[jira] [Updated] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-23 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7810: -- Fix Version/s: 6.6 > false positive equality: distinctly diff join queries

[jira] [Resolved] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-23 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7810. --- Resolution: Fixed Fix Version/s: 6.7 master (7.0)

[jira] [Updated] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-19 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7810: -- Attachment: LUCENE_7810.patch [~jpountz] I've updated the patch. Score mode is

[jira] [Commented] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-17 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014103#comment-16014103 ] Martijn van Groningen commented on LUCENE-7810: --- > If we want to be able te reuse cache

[jira] [Updated] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-15 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7810: -- Attachment: LUCENE_7810.patch Added patch based on [~hossman]'s patch that

[jira] [Commented] (LUCENE-7810) false positive equality: distinctly diff join queries return equals()==true

2017-05-12 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008212#comment-16008212 ] Martijn van Groningen commented on LUCENE-7810: --- Good catch [~hossman]! If nobody is

[jira] [Commented] (LUCENE-7798) add equals/hashCode to ToParentBlockJoinSortField

2017-04-28 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988351#comment-15988351 ] Martijn van Groningen commented on LUCENE-7798: --- +1 > add equals/hashCode to

[jira] [Commented] (LUCENE-7701) Refactor grouping collectors

2017-04-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960652#comment-15960652 ] Martijn van Groningen commented on LUCENE-7701: --- +1 I think this is a good change. I agree

[jira] [Commented] (LUCENE-7701) Refactor grouping collectors

2017-03-31 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950977#comment-15950977 ] Martijn van Groningen commented on LUCENE-7701: --- Sorry for the late reply [~romseygeek]! I

[jira] [Commented] (LUCENE-7755) Join queries should not reference IndexReaders.

2017-03-28 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945343#comment-15945343 ] Martijn van Groningen commented on LUCENE-7755: --- +1 good catch! > Join queries should not

[jira] [Commented] (LUCENE-7681) Remove LegacyDocValues implementations from MemoryIndex

2017-02-10 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861231#comment-15861231 ] Martijn van Groningen commented on LUCENE-7681: --- +1 looks good! > Remove LegacyDocValues

[jira] [Commented] (LUCENE-7685) Remove equals/rewrite hacks from block join queries

2017-02-10 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861219#comment-15861219 ] Martijn van Groningen commented on LUCENE-7685: --- +1 > Remove equals/rewrite hacks from

[jira] [Commented] (LUCENE-7684) MemoryIndex should store payloads per-field

2017-02-09 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859688#comment-15859688 ] Martijn van Groningen commented on LUCENE-7684: --- +1 looks good! > MemoryIndex should store

[jira] [Commented] (LUCENE-7679) MemoryIndex.addField() ignores some FieldType settings

2017-02-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856116#comment-15856116 ] Martijn van Groningen commented on LUCENE-7679: --- +1 > MemoryIndex.addField() ignores some

[jira] (LUCENE-7665) Remove grouping dependency from the join module

2017-01-30 Thread Martijn van Groningen (JIRA)
Title: Message Title Martijn van Groningen resolved as Fixed

[jira] (LUCENE-7665) Remove grouping dependency from the join module

2017-01-29 Thread Martijn van Groningen (JIRA)
Title: Message Title Martijn van Groningen updated an issue

[jira] (LUCENE-7665) Remove grouping dependency from the join module

2017-01-29 Thread Martijn van Groningen (JIRA)
Title: Message Title Martijn van Groningen updated an issue

[jira] (LUCENE-7665) Remove grouping dependency from the join module

2017-01-29 Thread Martijn van Groningen (JIRA)
Title: Message Title Martijn van Groningen created an issue

[jira] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-29 Thread Martijn van Groningen (JIRA)
Title: Message Title Martijn van Groningen resolved as Fixed

[jira] [Updated] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-28 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-6959: -- Attachment: LUCENE_6959.patch [~mikemccand] I added back the child hit

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-27 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842806#comment-15842806 ] Martijn van Groningen commented on LUCENE-6959: --- bq. I can take a crack at putting back

[jira] [Updated] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-27 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-6959: -- Attachment: LUCENE_6959.patch I've updated the patch. Thanks for reviewing!

[jira] [Updated] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-6959: -- Attachment: LUCENE_6959.patch Removed `origChildQuery ` field. > Remove

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839694#comment-15839694 ] Martijn van Groningen commented on LUCENE-6959: --- I was wrong, it can `origChildQuery` can

[jira] [Comment Edited] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839694#comment-15839694 ] Martijn van Groningen edited comment on LUCENE-6959 at 1/26/17 1:51 PM:

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839635#comment-15839635 ] Martijn van Groningen commented on LUCENE-6959: --- bq. Do we really need the

[jira] [Comment Edited] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839635#comment-15839635 ] Martijn van Groningen edited comment on LUCENE-6959 at 1/26/17 12:26 PM:

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839436#comment-15839436 ] Martijn van Groningen commented on LUCENE-6959: --- I wonder if we should continue using

[jira] [Updated] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-6959: -- Attachment: LUCENE_6959.patch I've changed the ParentChildrenBlockJoinQuery

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839408#comment-15839408 ] Martijn van Groningen commented on LUCENE-6959: --- bq. Can we maybe change the new query to

[jira] [Comment Edited] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837714#comment-15837714 ] Martijn van Groningen edited comment on LUCENE-6959 at 1/25/17 1:19 PM:

[jira] [Updated] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-6959: -- Attachment: LUCENE_6959.patch I've modified Adrien's patch and ported the ES

[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

2017-01-24 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836779#comment-15836779 ] Martijn van Groningen commented on LUCENE-6959: --- +1 To remove this collector in the master

[jira] [Commented] (LUCENE-7617) Improve GroupingSearch API and extensibility

2017-01-06 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805662#comment-15805662 ] Martijn van Groningen commented on LUCENE-7617: --- +1 Thanks for cleaning this up! I found a

[jira] [Commented] (LUCENE-7617) Improve GroupingSearch API and extensibility

2017-01-05 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800777#comment-15800777 ] Martijn van Groningen commented on LUCENE-7617: --- +1 to this change. This should make using

[jira] [Commented] (LUCENE-7418) remove legacy numerics from join/ and queryparser/

2016-08-19 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427829#comment-15427829 ] Martijn van Groningen commented on LUCENE-7418: --- +1 to the changes in join > remove legacy

[jira] [Commented] (LUCENE-7394) Make MemoryIndex immutable

2016-07-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392121#comment-15392121 ] Martijn van Groningen commented on LUCENE-7394: --- bq. We'd still need a way to set a

[jira] [Commented] (LUCENE-7391) MemoryIndexReader.fields() performance regression

2016-07-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391441#comment-15391441 ] Martijn van Groningen commented on LUCENE-7391: --- bq. +1 - freeze() was a hack, and I've

[jira] [Created] (LUCENE-7394) Make MemoryIndex immutable

2016-07-25 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7394: - Summary: Make MemoryIndex immutable Key: LUCENE-7394 URL: https://issues.apache.org/jira/browse/LUCENE-7394 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-7391) MemoryIndexReader.fields() performance regression

2016-07-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391427#comment-15391427 ] Martijn van Groningen commented on LUCENE-7391: --- +1 The filtering cost is deferred to when

[jira] [Resolved] (LUCENE-7389) Validation issue in FieldType#setDimensions?

2016-07-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7389. --- Resolution: Fixed Fix Version/s: 6.2 master (7.0)

[jira] [Commented] (LUCENE-7391) MemoryIndexReader.fields() performance regression

2016-07-22 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389646#comment-15389646 ] Martijn van Groningen commented on LUCENE-7391: --- > is it part of the contract that

[jira] [Commented] (LUCENE-7391) MemoryIndexReader.fields() performance regression

2016-07-22 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389623#comment-15389623 ] Martijn van Groningen commented on LUCENE-7391: --- +1 to count the number of fields with

[jira] [Updated] (LUCENE-7389) Validation issue in FieldType#setDimensions?

2016-07-22 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7389: -- Attachment: LUCENE-7383.patch Attached fix. Luckily this validation was also

[jira] [Commented] (LUCENE-7391) MemoryIndexReader.fields() performance regression

2016-07-22 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389577#comment-15389577 ] Martijn van Groningen commented on LUCENE-7391: --- The reason it filters out field with

[jira] [Created] (LUCENE-7389) Validation issue in FieldType#setDimensions?

2016-07-22 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7389: - Summary: Validation issue in FieldType#setDimensions? Key: LUCENE-7389 URL: https://issues.apache.org/jira/browse/LUCENE-7389 Project: Lucene - Core

[jira] [Resolved] (LUCENE-7383) FieldQueryTest.testFlattenToParentBlockJoinQuery failure

2016-07-15 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7383. --- Resolution: Fixed thanks for raising the issue [~mikemccand]! >

[jira] [Assigned] (LUCENE-7383) FieldQueryTest.testFlattenToParentBlockJoinQuery failure

2016-07-15 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen reassigned LUCENE-7383: - Assignee: Martijn van Groningen >

[jira] [Resolved] (LUCENE-7376) Add ToParentBlockJoinQuery support to FVH's FieldQuery

2016-07-14 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7376. --- Resolution: Fixed Fix Version/s: 6.2 master (7.0)

[jira] [Updated] (LUCENE-7376) Add ToParentBlockJoinQuery support to FVH's FieldQuery

2016-07-13 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7376: -- Attachment: LUCENE_7376.patch > Add ToParentBlockJoinQuery support to FVH's

[jira] [Created] (LUCENE-7376) Add ToParentBlockJoinQuery support to FVH's FieldQuery

2016-07-13 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7376: - Summary: Add ToParentBlockJoinQuery support to FVH's FieldQuery Key: LUCENE-7376 URL: https://issues.apache.org/jira/browse/LUCENE-7376 Project:

[jira] [Updated] (LUCENE-7304) Doc values based block join implementation

2016-06-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7304: -- Attachment: LUCENE_7304.patch Changed the block join query to only require

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-06-07 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318393#comment-15318393 ] Martijn van Groningen commented on LUCENE-7304: --- bq. The last time I tried doc values, I

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-06-06 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317229#comment-15317229 ] Martijn van Groningen commented on LUCENE-7304: --- [~paul.elsc...@xs4all.nl] This is a lot of

[jira] [Resolved] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-03 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7307. --- Resolution: Fixed [~mikemccand] yes! Thanks for reminding me. > Add getters

[jira] [Commented] (LUCENE-7276) Add an optional reason to the MatchNoDocsQuery

2016-06-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312081#comment-15312081 ] Martijn van Groningen commented on LUCENE-7276: --- +1 > Add an optional reason to the

[jira] [Updated] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7307: -- Attachment: LUCENE-7307 I've updated the patch. > Add getters to

[jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311882#comment-15311882 ] Martijn van Groningen commented on LUCENE-7307: --- bq. I think the byte[] version was better

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-06-02 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311868#comment-15311868 ] Martijn van Groningen commented on LUCENE-7304: --- bq. There is a dilemma here: either

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-06-01 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15310055#comment-15310055 ] Martijn van Groningen commented on LUCENE-7304: --- bq. This is only to show a possible

[jira] [Updated] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-01 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7307: -- Attachment: LUCENE_7307.patch Forgot to add an assertion in the test. > Add

[jira] [Updated] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-01 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7307: -- Attachment: LUCENE_7307.patch I've updated the patch and the returned

[jira] [Updated] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-06-01 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7307: -- Attachment: LUCENE_7307.patch bq. Also I don't think

[jira] [Updated] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-05-31 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7307: -- Attachment: LUCENE_7307.patch > Add getters to PointInSetQuery and

[jira] [Created] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes

2016-05-31 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7307: - Summary: Add getters to PointInSetQuery and PointRangeQuery classes Key: LUCENE-7307 URL: https://issues.apache.org/jira/browse/LUCENE-7307 Project:

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-05-31 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307395#comment-15307395 ] Martijn van Groningen commented on LUCENE-7304: --- Having different block join

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-05-30 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306555#comment-15306555 ] Martijn van Groningen commented on LUCENE-7304: --- bq. I still have an EliasFanoDocIdSet that

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-05-27 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304145#comment-15304145 ] Martijn van Groningen commented on LUCENE-7304: --- bq. Does this approach work out to less

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-05-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302697#comment-15302697 ] Martijn van Groningen commented on LUCENE-7304: --- bq. If we switched block joins to use

[jira] [Commented] (LUCENE-7304) Doc values based block join implementation

2016-05-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302569#comment-15302569 ] Martijn van Groningen commented on LUCENE-7304: --- bq. I wonder... instead couldn't we get a

[jira] [Updated] (LUCENE-7304) Doc values based block join implementation

2016-05-26 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen updated LUCENE-7304: -- Attachment: LUCENE_7304.patch Attached a working version of a doc values based

[jira] [Created] (LUCENE-7304) Doc values based block join implementation

2016-05-26 Thread Martijn van Groningen (JIRA)
Martijn van Groningen created LUCENE-7304: - Summary: Doc values based block join implementation Key: LUCENE-7304 URL: https://issues.apache.org/jira/browse/LUCENE-7304 Project: Lucene - Core

[jira] [Resolved] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)

2016-05-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn van Groningen resolved LUCENE-7206. --- Resolution: Fixed Fix Version/s: master (7.0) 6.1

[jira] [Commented] (LUCENE-7206) nest child query explain into ToParentBlockJoinQuery.BlockJoinScorer.explain(int)

2016-05-25 Thread Martijn van Groningen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299976#comment-15299976 ] Martijn van Groningen commented on LUCENE-7206: --- Ilya: Thanks! This looks good. I'll push

  1   2   3   4   5   6   7   >