[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315556#comment-16315556
]
Erick Erickson commented on SOLR-3191:
--
It's pretty obvious I'm not going to take this up before the
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240649#comment-16240649
]
ASF GitHub Bot commented on SOLR-3191:
--
GitHub user sstults opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459626#comment-15459626
]
Gus Heck commented on SOLR-3191:
Folks involved here may also be interested in SOLR-9467
> field exclusion
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235930#comment-15235930
]
Ryan McKinley commented on SOLR-3191:
-
The failure for GeoJSONResponseWriter will most likely have to
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235622#comment-15235622
]
Scott Stults commented on SOLR-3191:
Since this is essentially a wholesale rewrite of SolrReturnFields,
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235425#comment-15235425
]
Erick Erickson commented on SOLR-3191:
--
Ryan responded for <1>, so that's apparently not a problem.
>
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229690#comment-15229690
]
Erick Erickson commented on SOLR-3191:
--
Rats. Trunk has diverged enough that this patch doesn't apply
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203648#comment-15203648
]
Erick Erickson commented on SOLR-3191:
--
I ran this patch over 1,000 times "last night" (well 4 days
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196544#comment-15196544
]
Erick Erickson commented on SOLR-3191:
--
What about Robert's point of having constants in an abstract
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121713#comment-15121713
]
Jan Høydahl commented on SOLR-3191:
---
I saw there were a lot of changes. I can help facilitate this for
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045511#comment-15045511
]
Demian Katz commented on SOLR-3191:
---
I just took another look at this and discovered that the patch no
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004086#comment-15004086
]
Scott Stults commented on SOLR-3191:
Right. The reason I ask is, aliases would be a decent alternative
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003064#comment-15003064
]
Yonik Seeley commented on SOLR-3191:
I think new features should be free to ignore funky field name...
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003020#comment-15003020
]
Erik Hatcher commented on SOLR-3191:
That's a good question about field aliases - a number literal, for
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002827#comment-15002827
]
Scott Stults commented on SOLR-3191:
I'd definitely be up for trimming out funky field name checks in
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002469#comment-15002469
]
Erick Erickson commented on SOLR-3191:
--
bq: Field names should consist of alphanumeric or underscore
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002400#comment-15002400
]
Demian Katz commented on SOLR-3191:
---
Erik,
I'm using the jacoco ant task to test coverage --
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002379#comment-15002379
]
Erik Hatcher commented on SOLR-3191:
Commenting on the latest patch - why is there so much work to test
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002394#comment-15002394
]
Erik Hatcher commented on SOLR-3191:
[~demiankatz] thanks for the review; it got me looking at this
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002627#comment-15002627
]
Erik Hatcher commented on SOLR-3191:
Ok, so [~sstults] - wanna take a stab at adjusting the code and
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14999068#comment-14999068
]
Demian Katz commented on SOLR-3191:
---
I just took a look at test coverage for this patch, and it appears
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553270#comment-14553270
]
Jan Høydahl commented on SOLR-3191:
---
[~kuntalganguly], there is a problem with your last
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547338#comment-14547338
]
Jan Høydahl commented on SOLR-3191:
---
Anyone have been using the patch in production?
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547343#comment-14547343
]
Andrea Gazzarini commented on SOLR-3191:
Hi Jan,
Yes but with an old version of
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14184996#comment-14184996
]
Roman Kliewer commented on SOLR-3191:
-
I think this feature should be higher
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183474#comment-14183474
]
Jan Høydahl commented on SOLR-3191:
---
Are there known issues with this patch? I see a few
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14183984#comment-14183984
]
Andrea Gazzarini commented on SOLR-3191:
Hi Jan,
if you refer to my long comment
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108961#comment-14108961
]
Kuntal Ganguly commented on SOLR-3191:
--
[~ehatcher] Yeah i will upload the patch along
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107996#comment-14107996
]
Andrea Gazzarini commented on SOLR-3191:
I meant additional test methods
field
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106550#comment-14106550
]
Kuntal Ganguly commented on SOLR-3191:
--
I have tried this patch on Solr 4.2.1 and 4.9,
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106821#comment-14106821
]
Kuntal Ganguly commented on SOLR-3191:
--
I modify the code to support inbuilt alias
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106825#comment-14106825
]
Erik Hatcher commented on SOLR-3191:
[~kuntalganguly] - could you attach a full patch
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107018#comment-14107018
]
Andrea Gazzarini commented on SOLR-3191:
Hi guys, I created that patch some time
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832648#comment-13832648
]
Robert Muir commented on SOLR-3191:
---
the abstract ReturnFields should not have constants.
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832698#comment-13832698
]
Andrea Gazzarini commented on SOLR-3191:
the abstract ReturnFields should not have
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832865#comment-13832865
]
Yonik Seeley commented on SOLR-3191:
I like the direction you're going Adrea!
Frankly,
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833025#comment-13833025
]
Andrea Gazzarini commented on SOLR-3191:
Thank you very much Yonik, very happy to
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833064#comment-13833064
]
Ryan Ernst commented on SOLR-3191:
--
{quote}
a) ReturnFields as interface
{quote}
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833084#comment-13833084
]
Yonik Seeley commented on SOLR-3191:
bq. I agree with you regarding the abstract class:
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833553#comment-13833553
]
Andrea Gazzarini commented on SOLR-3191:
bq. Heh - I see my use of interface was
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832384#comment-13832384
]
Andrea Gazzarini commented on SOLR-3191:
Hi all, I attached a patch for the fl
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763116#comment-13763116
]
David Morana commented on SOLR-3191:
This is exactly one of the features I was looking
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763190#comment-13763190
]
Erick Erickson commented on SOLR-3191:
--
No body has put up any kind of patch for this,
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763224#comment-13763224
]
Andrea Gazzarini commented on SOLR-3191:
Hi, Some days ago I built a working
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747346#comment-13747346
]
Andrea Gazzarini commented on SOLR-3191:
Hi all, I'm going to complete the
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736056#comment-13736056
]
Bill Bell commented on SOLR-3191:
-
This is a very useful feature I have 80 fields and
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582700#comment-13582700
]
Jan Høydahl commented on SOLR-3191:
---
[~lucacavanna], now that SOLR-2719 is fixed, I think
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221855#comment-13221855
]
Luca Cavanna commented on SOLR-3191:
Thanks for your feedbacks!
I had thought about the
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221713#comment-13221713
]
Yonik Seeley commented on SOLR-3191:
+1, looks great Jan!
field
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221006#comment-13221006
]
Luca Cavanna commented on SOLR-3191:
I previously left a comment on the SOLR-2444
[
https://issues.apache.org/jira/browse/SOLR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13221533#comment-13221533
]
Jan Høydahl commented on SOLR-3191:
---
I think by definition a field name cannot start with
51 matches
Mail list logo
