[GitHub] madlib issue #345: Typos

2019-01-10 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/345 @kinow Thanks for the PR . LGTM ---

[GitHub] madlib pull request #339: Build: Add PG11 Support

2018-11-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/339#discussion_r237326034 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -407,6 +407,15 @@ def set_client_min_messages(new_level): return

[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/338#discussion_r234052747 --- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in --- @@ -0,0 +1,119

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051398 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051252 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051503 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -487,10 +487,16 @@ class MiniBatchDocumentation

[GitHub] madlib pull request #334: Minibatch Preprocessor: Update online doc

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/334#discussion_r234051175 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -508,8 +514,13 @@ class MiniBatchDocumentation

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-24 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r227919519 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #332: Update Dockerfile to use ubuntu 16.04

2018-10-24 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/332#discussion_r227918905 --- Diff: tool/docker/base/Dockerfile_ubuntu16_postgres10 --- @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] madlib pull request #331: Build: Include preflight and postflight scripts fo...

2018-10-09 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/331 Build: Include preflight and postflight scripts for mac Commit #441f16bd55d2a26e4dd59df6129c6092f099cbca introduced a bug where the preflight and postflight scripts for mac were not getting

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-03 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/330#discussion_r222415826 --- Diff: src/ports/postgres/modules/regress/marginal.py_in --- @@ -522,9 +520,8 @@ def margins_mlogregr(schema_madlib, source_table, out_table

[GitHub] madlib pull request #330: Margins: Copy summary table instead of renaming

2018-10-03 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/330#discussion_r222418291 --- Diff: src/ports/postgres/modules/regress/marginal.py_in --- @@ -522,9 +520,8 @@ def margins_mlogregr(schema_madlib, source_table, out_table

[GitHub] madlib issue #318: Madpack: Add a script for automating changelist creation

2018-09-14 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/318 @orhankislal The new changes look good. Apart from the 2 minor comments LGTM +1 ---

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-14 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217842978 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,239 @@ +#!/usr/bin/python

[GitHub] madlib pull request #319: Allocator: Remove 16-byte alignment for pointers i...

2018-09-13 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/319#discussion_r217498702 --- Diff: src/ports/greenplum/dbconnector/dbconnector.hpp --- @@ -32,6 +32,24 @@ extern "C" { #include "Co

[GitHub] madlib issue #318: Madpack: Add a script for automating changelist creation

2018-09-12 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/318 I tested the utility with the new changes but I am still reviewing the code.Here are my observations so far: 1. I noticed that there were a few indentation changes. I am assuming

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-12 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217152555 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/python

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-12 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r217143101 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,229 @@ +#!/usr/bin/python

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-10 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r216443402 --- Diff: src/madpack/create_changelist.py --- @@ -0,0 +1,132 @@ +#!/usr/bin/python

[GitHub] madlib pull request #318: Madpack: Add a script for automating changelist cr...

2018-09-10 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/318#discussion_r216438294 --- Diff: src/madpack/diff_udf.sql --- @@ -142,9 +142,12 @@ DROP TABLE IF EXISTS functions_madlib_new_version; SELECT get_functions('madlib_old_vers

[GitHub] madlib issue #318: Madpack: Add a script for automating changelist creation

2018-09-10 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/318 I ran the utility with 1.13 and 1.14 as the release tags and noticed that the output file created by this utility isn't the same as the one checked in `changelist_1.13_1.14.yaml`. For ex, all

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-08-21 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/313#discussion_r211725199 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -192,18 +189,23 @@ MLP::getLossAndUpdateModel( // 1. normalize to per row update // 2

[GitHub] madlib pull request #313: MLP: Simplify momentum and Nesterov updates

2018-08-21 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/313#discussion_r211725456 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -192,18 +189,23 @@ MLP::getLossAndUpdateModel( // 1. normalize to per row update // 2

[GitHub] madlib pull request #310: Build: Download compatible Boost if version >= 1.6...

2018-08-13 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/310#discussion_r209718447 --- Diff: src/CMakeLists.txt --- @@ -103,21 +103,29 @@ set(MAD_MODULE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/modules) # -- Third-party dependencies: Find

[GitHub] madlib-site pull request #13: Add notebook for deep learning with keras

2018-08-10 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib-site/pull/13 Add notebook for deep learning with keras This iPython notebook walks the user through training and testing a deep learning model built with tensorflow and keras in Greenplum 5.X

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-06-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199006902 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -853,6 +857,34 @@ def validate_module_input_params(source_table, output_table

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-06-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199019606 --- Diff: src/ports/postgres/modules/utilities/test/utilities.sql_in --- @@ -0,0 +1,77

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-06-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199002937 --- Diff: src/ports/postgres/modules/utilities/test/utilities.sql_in --- @@ -0,0 +1,77

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-06-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199002193 --- Diff: src/ports/postgres/modules/utilities/test/utilities.ic.sql_in --- @@ -0,0 +1,58

[GitHub] madlib pull request #282: Utilites: Add CTAS while dropping some columns

2018-06-28 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/282#discussion_r199005872 --- Diff: src/ports/postgres/modules/utilities/utilities.py_in --- @@ -853,6 +857,34 @@ def validate_module_input_params(source_table, output_table

[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/283#discussion_r198641216 --- Diff: src/ports/postgres/modules/crf/test/crf_train_large.sql_in --- @@ -234,26 +234,40 @@ INSERT INTO train_new_segmenttbl VALUES (30, 7, 'years

[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF

2018-06-27 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/283#discussion_r198644242 --- Diff: src/ports/postgres/modules/crf/test/crf_test_small.sql_in --- @@ -90,7 +90,7 @@ (18,'PRP$'),(19,'RB'), (20,'RBR'), (21,'RBS'), (22

[GitHub] madlib pull request #281: Support special characters in MLP, minibatch prepr...

2018-06-21 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/281 Support special characters in MLP, minibatch preprocessor and encode_categorical Support special characters in MLP, minibatch preprocessor and encode_categorical JIRA: MADLIB-1237

[GitHub] madlib pull request #279: KNN: make install check asserts deterministic

2018-06-14 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/279 KNN: make install check asserts deterministic knn install check had a couple of array_agg asserts which were not deterministic. This commit adds order by to the array agg function to make

[GitHub] madlib issue #278: Upgrade: add changelist file and bug fixes and changelist...

2018-06-13 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/278 @iyerr3 yes we will have to rename it. ---

[GitHub] madlib pull request #278: Upgrade: add changelist file and bug fixes and cha...

2018-06-11 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/278 Upgrade: add changelist file and bug fixes and changelist file This PR adds a changelist file for testing 1.14 to 1.15 upgrade and addresses 2 bugs we found during upgrade testing. 1. Commit

[GitHub] madlib pull request #272: MLP: Add momentum and nesterov to gradient updates...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/272#discussion_r191945714 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -197,6 +244,7 @@ MLP::loss( const model_type, const

[GitHub] madlib pull request #272: MLP: Add momentum and nesterov to gradient updates...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/272#discussion_r191942290 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -1781,7 +1799,7 @@ class MLPMinibatchPreProcessor: summary_table_columns

[GitHub] madlib pull request #272: MLP: Add momentum and nesterov to gradient updates...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/272#discussion_r191942284 --- Diff: src/ports/postgres/modules/convex/mlp.sql_in --- @@ -1474,13 +1480,15 @@ CREATE AGGREGATE MADLIB_SCHEMA.mlp_minibatch_step

[GitHub] madlib issue #271: Madpack: Make install, reinstall and upgrade atomic

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/271 A few other observations from madpack output 1. While uninstalling , this message is printed on the console’ `madpack.py: INFO : Installing MADlib modules` We should instead say

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191608985 --- Diff: src/madpack/madpack.py --- @@ -824,6 +873,246 @@ def parse_arguments(): # Get the arguments return parser.parse_args

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191595833 --- Diff: src/madpack/madpack.py --- @@ -559,71 +650,59 @@ def _db_rename_schema(from_schema, to_schema

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191601387 --- Diff: src/madpack/madpack.py --- @@ -987,275 +1276,42 @@ def main(argv): error_(this, "Missing -p/--platform parameter.&q

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191604335 --- Diff: src/madpack/upgrade_util.py --- @@ -1299,18 +1303,19 @@ def _clean_function(self): pattern = re.compile(r"""CREA

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191592112 --- Diff: src/madpack/madpack.py --- @@ -238,6 +311,88 @@ def _run_sql_file(schema, maddir_mod_py, module, sqlfile, return retval

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191587755 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191580503 --- Diff: src/madpack/utilities.py --- @@ -33,6 +33,23 @@ this = os.path.basename(sys.argv[0])# name of this script +class

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191609335 --- Diff: src/madpack/madpack.py --- @@ -537,9 +629,8 @@ def _db_upgrade(schema, dbrev): ch.drop_changed_udf() ch.drop_changed_udt

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191587596 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191589562 --- Diff: src/madpack/madpack.py --- @@ -238,6 +311,88 @@ def _run_sql_file(schema, maddir_mod_py, module, sqlfile, return retval

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191603261 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191608639 --- Diff: src/madpack/madpack.py --- @@ -824,6 +873,246 @@ def parse_arguments(): # Get the arguments return parser.parse_args

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191588071 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191607552 --- Diff: src/madpack/madpack.py --- @@ -824,6 +873,246 @@ def parse_arguments(): # Get the arguments return parser.parse_args

[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

2018-05-30 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191586806 --- Diff: src/madpack/madpack.py --- @@ -131,10 +141,73 @@ def _get_relative_maddir(maddir, port): return maddir

[GitHub] madlib pull request #268: DT: Don't use NULL value to get dep_var type

2018-05-25 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/268#discussion_r185970102 --- Diff: src/ports/postgres/modules/utilities/validate_args.py_in --- @@ -368,8 +375,10 @@ def get_expr_type(expr, tbl): SELECT pg_typeof({0

[GitHub] madlib pull request #272: MLP: Add momentum and nesterov to gradient updates...

2018-05-24 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/272 MLP: Add momentum and nesterov to gradient updates. JIRA: MADLIB-1210 We refactored the minibatch code to separate out the momentum and model update functions. We initially were using

[GitHub] madlib pull request #260: minibatch preprocessor improvements

2018-04-11 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/260#discussion_r180851151 --- Diff: src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in --- @@ -387,6 +397,7 @@ class MiniBatchStandardizer

[GitHub] madlib pull request #260: minibatch preprocessor improvements

2018-04-10 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/260 minibatch preprocessor improvements This PR makes two improvements to the preprocessor code 1. Check for all character types for dependent col 2. Create temp table for standardization

[GitHub] madlib pull request #253: MLP: Add install check tests for minibatch with gr...

2018-03-29 Thread kaknikhil
Github user kaknikhil closed the pull request at: https://github.com/apache/madlib/pull/253 ---

[GitHub] madlib issue #253: MLP: Add install check tests for minibatch with grouping

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/253 Closed by ab7166ff4fc55311ec29bb8b54d17becd9bb1750 ---

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177912997 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177912480 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177913869 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table, data_table, id_col_name

[GitHub] madlib pull request #253: MLP: Add install check tests for minibatch with gr...

2018-03-28 Thread kaknikhil
GitHub user kaknikhil opened a pull request: https://github.com/apache/madlib/pull/253 MLP: Add install check tests for minibatch with grouping This PR adds install check tests for MLP minibatch with grouping. You can merge this pull request into a Git repository by running

[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-27 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/249 The changes look good. +1 for adding an install check test. I noticed that `con_features` is populated by `decision_tree.py:_classify_features` which does something like `con_types

[GitHub] madlib issue #247: SVM: Revert minibatch-related work

2018-03-22 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/247 @iyerr3 Thanks for the detailed explanation. I agree, we should avoid a redundant commit and take care of this in a future commit. ---

[GitHub] madlib issue #247: SVM: Revert minibatch-related work

2018-03-22 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/247 @iyerr3 I compared this PR with the original commit and it looks good. Just a couple of minor questions 1. This change to model.hpp was not reverted. It looks like it's not related

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-21 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r176262391 --- Diff: src/ports/postgres/modules/convex/test/mlp.sql_in --- @@ -340,6 +181,51 @@ INSERT INTO iris_data VALUES (149,ARRAY[6.2,3.4,5.4,2.3],'Iris

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175888098 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -590,51 +664,103 @@ def _validate_warm_start(output_table, summary_table

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175893520 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -1457,3 +1660,85 @@ def mlp_predict_help(schema_madlib, message): return

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175891761 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -72,107 +73,127 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175627412 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175872591 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP<Model, Tuple>::lamb

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175923655 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -33,11 +34,12 @@ from convex.utils_regularization import __utils_normalize_data_grouping

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175894372 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -1457,3 +1660,85 @@ def mlp_predict_help(schema_madlib, message): return

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175923217 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -292,26 +329,33 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175889157 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -590,51 +664,103 @@ def _validate_warm_start(output_table, summary_table

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175921215 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175628144 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175877947 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP<Model, Tuple>::lamb

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175929883 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -292,26 +329,33 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175620624 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD<State, ConstState, Task>::transition(state_type , for (int curr

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175871655 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -170,6 +289,24 @@ mlp_igd_final::run(AnyType ) { return state

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175917822 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175895832 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -72,107 +73,127 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175873168 --- Diff: src/modules/convex/task/mlp.hpp --- @@ -111,6 +117,57 @@ class MLP { template double MLP<Model, Tuple>::lamb

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175626817 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -130,6 +145,90 @@ mlp_igd_transition::run(AnyType ) { return state

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175625333 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD<State, ConstState, Task>::transition(state_type , for (int curr

[GitHub] madlib pull request #243: MLP: Add minibatch gradient descent solver

2018-03-20 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/243#discussion_r175621915 --- Diff: src/modules/convex/algo/igd.hpp --- @@ -90,20 +90,27 @@ IGD<State, ConstState, Task>::transition(state_type , for (int curr

[GitHub] madlib pull request #240: MLP: Fix step size initialization based on learnin...

2018-03-16 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/240#discussion_r175224785 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -112,6 +112,7 @@ def mlp(schema_madlib, source_table, output_table, independent_varname

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165529067 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165523942 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165737045 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165736819 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165526039 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165527448 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165479832 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165505215 --- Diff: src/ports/postgres/modules/sample/balance_sample.sql_in --- @@ -0,0 +1,355

[GitHub] madlib pull request #230: Balanced sets final

2018-02-02 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/230#discussion_r165530126 --- Diff: src/ports/postgres/modules/sample/balance_sample.py_in --- @@ -0,0 +1,748 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

  1   2   >