On March 20, 2014, 9:21 p.m., Vinod Kone wrote:
src/master/master.hpp, line 421
https://reviews.apache.org/r/19383/diff/1/?file=526626#file526626line421
Why cache instead of a circular buffer?
Ben Mahler wrote:
What's the issue here?
Circular buffer does not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19575/
---
(Updated March 24, 2014, 6:40 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19575/
---
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-1131
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19575/#review38280
---
Patch looks great!
Reviews applied: [19575]
All tests passed.
-
On March 21, 2014, 11:59 p.m., Ben Mahler wrote:
Looks like we forgot to split apart this change between stout and Mesos. We
typically break apart commits to libprocess, stout as they are libraries
that are also maintained on github.
There were also some hard tabs here, where we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17567/#review38287
---
Patch looks great!
Reviews applied: [18403, 17567]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/#review38289
---
Bad patch!
Reviews applied: [19545]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review38291
---
Bad patch!
Reviews applied: [18718, 19499]
Failed command: make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19504/#review38293
---
Bad patch!
Reviews applied: [18718, 19504]
Failed command: make
On March 21, 2014, 5:12 p.m., Vinod Kone wrote:
src/logging/logging.cpp, lines 120-135
https://reviews.apache.org/r/19357/diff/2/?file=527984#file527984line120
how about a switch statement instead?
In C++ you can use switch statement just on primitives such as int, char and
enum.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19580/
---
Review request for mesos.
Repository: mesos-git
Description
---
Fix
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/
---
(Updated March 24, 2014, 12:51 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/#review38295
---
Patch looks great!
Reviews applied: [19357]
All tests passed.
-
[
https://issues.apache.org/jira/browse/MESOS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945139#comment-13945139
]
Till Toenshoff commented on MESOS-1102:
---
After some more evaluations and tests using
Benjamin Hindman created MESOS-1141:
---
Summary: Add a 'user' field to CommandInfo.
Key: MESOS-1141
URL: https://issues.apache.org/jira/browse/MESOS-1141
Project: Mesos
Issue Type:
Benjamin Hindman created MESOS-1143:
---
Summary: Add a TASK_ERROR task status.
Key: MESOS-1143
URL: https://issues.apache.org/jira/browse/MESOS-1143
Project: Mesos
Issue Type: Improvement
Benjamin Hindman created MESOS-1142:
---
Summary: Add a 'roles' field to FrameworkInfo.
Key: MESOS-1142
URL: https://issues.apache.org/jira/browse/MESOS-1142
Project: Mesos
Issue Type:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/#review38304
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19383/#review37792
---
This was the beginning of a review on an old diff that I never
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19248/
---
(Updated March 24, 2014, 4:37 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review38308
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19248/#review38321
---
rebase?
- Vinod Kone
On March 24, 2014, 4:37 p.m., Ian Downes
[
https://issues.apache.org/jira/browse/MESOS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charlie Carson closed MESOS-1129.
-
fix stats endpoint to go to stats code
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/
---
(Updated March 24, 2014, 10:40 a.m.)
Review request for mesos, Benjamin
On March 21, 2014, 3:10 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/metrics/metric.cpp, lines 18-22
https://reviews.apache.org/r/18718/diff/8/?file=530659#file530659line18
Looks like the pointer ownership semantics here are not safe, you're
removing yourself from the metrics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/
---
(Updated March 24, 2014, 10:42 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/
---
(Updated March 24, 2014, 11:09 a.m.)
Review request for mesos and Ben Mahler.
On March 21, 2014, 3:10 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 12-14
https://reviews.apache.org/r/18718/diff/8/?file=530663#file530663line12
Odds are that the majority of Gauge functions we set up will be through
defer() on a libprocess
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/#review38329
---
Patch looks great!
Reviews applied: [19416, 19162, 19164]
All
On March 21, 2014, 12:03 p.m., Jie Yu wrote:
3rdparty/libprocess/include/process/metrics/counter.hpp, line 21
https://reviews.apache.org/r/18718/diff/8/?file=530656#file530656line21
I don't think we need the __sync call here. Simply to the following is
sufficient:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/
---
(Updated March 24, 2014, 11:11 a.m.)
Review request for mesos, Benjamin
On March 18, 2014, 6:39 p.m., Ian Downes wrote:
3rdparty/libprocess/src/subprocess.cpp, line 165
https://reviews.apache.org/r/19259/diff/2/?file=520576#file520576line165
what about either exec command *or* call child function (which can
choose to exec{l,le,...})
I like this idea
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/#review38333
---
Bad patch!
Reviews applied: [18718, 19545]
Failed command: make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/#review38335
---
What does this patch/refactor do? :) The description is a bit
On March 18, 2014, 8:01 a.m., Timothy St. Clair wrote:
So before this gets leveraged, is there an outline of the use-cases? See
comment below.
There are existing examples and proposed use-cases in the JIRA ticket linked
above, and those related to it.
On March 18, 2014, 8:01 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19259/#review38337
---
Bad patch!
Reviews applied: [19416, 19162, 19259]
Failed command:
Hi,
I tried to build Mesos on Mac OSX 10.9
However, when I run 'make check', one of the test fails and the whole
process hangs. The log can be found here:
http://collabedit.com/g8chc
How can I fix this?
Thank you for your time.
Best Regards,
--
*Ritwik Yadav*
Department of Computer Science
I wonder if I should rather post this to the users' section.
On 25 March 2014 00:08, Mesos ReviewBot dev@mesos.apache.org wrote:
---
This is an automatically generated e-mail. To reply, visit:
Hey Ritwik,
go ahead and try to run that individual test with enhanced verbosity as drafted
in our upcoming FAQ
https://issues.apache.org/jira/browse/MESOS-1137
see: When running make check one of the tests fails, what now?
Till
On Mar 24, 2014, at 7:38 PM, Ritwik ritwik.ya...@gmail.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19361/#review38341
---
A few questions about the tests:
1. Why are you forking and using
On March 24, 2014, 9:39 a.m., Benjamin Hindman wrote:
src/slave/slave.cpp, line 238
https://reviews.apache.org/r/19499/diff/2/?file=530732#file530732line238
Do we ever delete these? They will leak in tests.
in Slave::finalize.
On March 24, 2014, 9:39 a.m., Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
---
(Updated March 24, 2014, noon)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/
---
(Updated March 24, 2014, 12:21 p.m.)
Review request for mesos and Ben Mahler.
[
https://issues.apache.org/jira/browse/MESOS-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945582#comment-13945582
]
Vinod Kone commented on MESOS-1137:
---
Maybe we could also leverage SO for FAQ?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review38346
---
Patch looks great!
Reviews applied: [18718, 19499]
All tests
[
https://issues.apache.org/jira/browse/MESOS-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945591#comment-13945591
]
Till Toenshoff commented on MESOS-1137:
---
Yes, that is a very good idea as users will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19383/
---
(Updated March 24, 2014, 7:35 p.m.)
Review request for mesos, Benjamin Hindman
[
https://issues.apache.org/jira/browse/MESOS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945593#comment-13945593
]
Dominic Hamon commented on MESOS-750:
-
Current master has the following semantics for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19504/
---
(Updated March 24, 2014, 12:16 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19575/#review38347
---
3rdparty/libprocess/include/process/base64.hpp
Hi Till,
Thank you for your response. I tried to run that individual test in verbose
mode using sudo. Here is the most recent log that I got :
http://collabedit.com/8skww
The above results from the following invocations:
1) sudo make check
2) sudo ./bin/mesos-tests.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38349
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19501/#review38348
---
Looks great! Just some small cleanup below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/#review38351
---
Did you look at the diff before you published? ;)
- Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/
---
(Updated March 24, 2014, 12:51 p.m.)
Review request for mesos, Benjamin
[
https://issues.apache.org/jira/browse/MESOS-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone resolved MESOS-1067.
---
Resolution: Fixed
Fix Version/s: 0.19.0
commit 7c366bad61e8c241797ef5c92562e0539c0dd02a
Dear Dev-List,
I have just enabled a filter-forwarding of StackExchange questions on anything
tagged “mesos” into this list. This will send a daily digest of all of those
into the list.
Hope that helps in our mutual goal to increase awareness, solve issues and
support the community.
Note
On March 20, 2014, 9:46 a.m., Benjamin Hindman wrote:
Just so I understand clearly, do we not want to allow people to try and use
system installed libraries but fall back on what's bundled otherwise?
Consider someone who has leveldb installed with snappy, so they'd like to
use the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
---
(Updated March 24, 2014, 8:45 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19162/#review38361
---
3rdparty/libprocess/src/subprocess.cpp
Benjamin Hindman created MESOS-1144:
---
Summary: Refactor Registrar into a generic State operations
abstraction
Key: MESOS-1144
URL: https://issues.apache.org/jira/browse/MESOS-1144
Project: Mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38370
---
Bad patch!
Reviews applied: [19556]
Failed command: make -j3
On March 22, 2014, 8:14 a.m., Adam B wrote:
configure.ac, line 250
https://reviews.apache.org/r/18957/diff/2/?file=522715#file522715line250
+1 on making this easier to read. Just decoded it and here's my
pseudocode interpretation:
if (enable-proper) {
if (with-foo)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/#review38376
---
ping
- Dominic Hamon
On Feb. 25, 2014, 3:31 p.m., Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
---
(Updated March 24, 2014, 10:16 p.m.)
Review request for mesos, Benjamin
Cool! Would it be better suited for the user@ list though?
On Mon, Mar 24, 2014 at 1:01 PM, Till Toenshoff toensh...@me.com wrote:
Dear Dev-List,
I have just enabled a filter-forwarding of StackExchange questions on
anything tagged mesos into this list. This will send a daily digest of
all
[
https://issues.apache.org/jira/browse/MESOS-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945849#comment-13945849
]
Jason Dusek edited comment on MESOS-1128 at 3/24/14 11:15 PM:
--
[
https://issues.apache.org/jira/browse/MESOS-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945849#comment-13945849
]
Jason Dusek commented on MESOS-1128:
Another good reason to avoid colon is that it
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1738/changes
Dear Devs/Committers,
after having developed the ExternalContainerizer, I am now obviously eager to
get it committed. After receiving and addressing a couple of comments (thanks
@all who commented - that helped a lot), I now am once again in a stage of
waiting and keeping fingers crossed that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19383/#review38364
---
Ship it!
Add a TODO for adding a state variable in Slave struct
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/#review38382
---
src/logging/flags.hpp
[
https://issues.apache.org/jira/browse/MESOS-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945915#comment-13945915
]
Till Toenshoff commented on MESOS-1071:
---
We seem to have reached a point where
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38399
---
Patch looks great!
Reviews applied: [19556]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38398
---
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
[
https://issues.apache.org/jira/browse/MESOS-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945915#comment-13945915
]
Till Toenshoff edited comment on MESOS-1071 at 3/25/14 12:41 AM:
[
https://issues.apache.org/jira/browse/MESOS-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945969#comment-13945969
]
Timothy St. Clair commented on MESOS-1071:
--
Comments re above:
1.
[
https://issues.apache.org/jira/browse/MESOS-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945969#comment-13945969
]
Timothy St. Clair edited comment on MESOS-1071 at 3/25/14 1:24 AM:
On March 24, 2014, 4:18 p.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, line 486
https://reviews.apache.org/r/18730/diff/6/?file=532713#file532713line486
Can you share this in JSON so we can get an idea of what it looks like?
I logged the JSON for each of the ACLs set in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18718/#review38400
---
Looking pretty good, can you do a style audit on this patch? I see
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19383/#review38409
---
Patch looks great!
Reviews applied: [19383]
All tests passed.
-
On March 25, 2014, 1:59 a.m., Ben Mahler wrote:
3rdparty/libprocess/include/process/metrics/gauge.hpp, line 24
https://reviews.apache.org/r/18718/diff/11/?file=534292#file534292line24
We really should not be blocking implicitly when we call Gauge::get.
I see two paths
On March 25, 2014, 12:42 a.m., Vinod Kone wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 172
https://reviews.apache.org/r/19556/diff/4/?file=534342#file534342line172
Do you expect this to be used outside tests?
Yes, it will be used when we create filters
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
---
(Updated March 25, 2014, 5:29 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
---
(Updated March 25, 2014, 5:31 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19602/
---
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19602/
---
(Updated March 25, 2014, 5:35 a.m.)
Review request for mesos, Benjamin
87 matches
Mail list logo
