On Aug. 7, 2014, 6:02 a.m., Timothy Chen wrote:
Ship It!
I thought we had this fix already as well.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24440/#review49868
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24440/#review49868
---
Ship it!
Ship It!
- Timothy Chen
On Aug. 7, 2014, 2:30 a.m.,
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2289/changes
Changes:
[yan] Fixed mesos-style.py errors.
[vinodkone] Re-enabled low level scheduler tests.
[niklas] Made doxygen recursive to include nested files.
[vinodkone] Added
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/
---
(Updated Aug. 6, 2014, 11:26 p.m.)
Review request for mesos, Ben Mahler and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2033/changes
See https://builds.apache.org/job/mesos-reviewbot/1288/changes
Changes:
[niklas] Made doxygen recursive to include nested files.
[vinodkone] Added 'process::inject::exited()' to simulate exited events in
tests.
--
[...truncated 5393 lines...]
rm -f
at
slave(200)@67.195.81.187:56582 (pomona.apache.org) with id
20140807-081940-3142697795-56582-21640-0
I0807 08:19:40.430075 21669 registrar.cpp:422] Attempting to update the
'registry'
I0807 08:19:40.431555 21669 log.cpp:680] Attempting to append 334 bytes to the
log
I0807 08:19:40.431617
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review49886
---
Ready for another review from @vinodkone (and others)?
- Adam B
...]
I0807 10:08:00.362571 28782 slave.cpp:971] Will retry registration in
15.253129ms if necessary
W0807 10:08:00.362627 28782 master.cpp:2942] Slave at
slave(70)@140.211.11.27:51596 (hemera.apache.org) is being allowed to
re-register with an already in use id (20140807-100759-453759884-51596-27572
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2034/changes
Changes:
[yan] Improved framework rate limiting by imposing the max number of
outstanding messages per framework principal.
--
[...truncated 54976 lines...]
13718 master.cpp:2827] Registering slave at
slave(128)@67.195.81.187:52767 (pomona.apache.org) with id
20140807-104107-3142697795-52767-13689-0
I0807 10:41:07.178484 13718 registrar.cpp:422] Attempting to update the
'registry'
I0807 10:41:07.180132 13689 sched.cpp:139] Version: 0.20.0
I0807 10:41
See https://builds.apache.org/job/mesos-reviewbot/1289/changes
Changes:
[yan] Improved framework rate limiting by imposing the max number of
outstanding messages per framework principal.
--
[...truncated 5582 lines...]
rm -f logging/*.lo
rm -f
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2300/changes
Changes:
[yan] Improved framework rate limiting by imposing the max number of
outstanding messages per framework principal.
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/
---
(Updated Aug. 7, 2014, 2:56 p.m.)
Review request for mesos.
Bugs: MESOS-1662
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24440/#review49896
---
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 7, 2014, 2:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review49897
---
Ship it!
Any reason not to nest Volume in ContainerInfo?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/#review49898
---
Ship it!
See my comment in the test below, otherwise this looks
master.cpp:2827] Registering slave at
slave(78)@140.211.11.27:53862 (hemera.apache.org) with id
20140807-173036-453759884-53862-403-0
I0807 17:30:36.787086 690 registrar.cpp:422] Attempting to update the
'registry'
I0807 17:30:36.788794 690 log.cpp:680] Attempting to append 328 bytes
I0807 10:41:07.178369 13718 master.cpp:2827] Registering slave at
slave(128)@67.195.81.187:52767 (pomona.apache.org) with id
20140807-104107-3142697795-52767-13689-0
I0807 10:41:07.178484 13718 registrar.cpp:422] Attempting to update the
'registry'
I0807 10:41:07.180132 13689 sched.cpp:139
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2035/changes
Changes:
[yujie.jay] Fixed a bug in slave when launching container.
--
[...truncated 4532 lines...]
test ../.. = .. || \
On Aug 6, 2014 4:33 PM, Niklas Nielsen n...@qni.dk wrote:
Hi guys,
I think it is in communities interest to lower the barrier to entry for new
contributors to the project. Not only in terms of process (as BenH has been
putting a lot of effort into - bravo!) but also in terms of making it
See https://builds.apache.org/job/mesos-reviewbot/1290/
--
[...truncated 5566 lines...]
rm -f state/.dirstamp
rm -f tests/.deps/.dirstamp
rm -f tests/.dirstamp
rm -f log/tool/*.lo
rm -f usage/.deps/.dirstamp
rm -f logging/*.o
rm -f usage/.dirstamp
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review49925
---
Getting close! Thanks Anton!
On Aug. 7, 2014, 3:10 p.m., Benjamin Hindman wrote:
Any reason not to nest Volume in ContainerInfo?
Didn't have a use case so didn't include that. Do you think it makes sense to
have that up front? I was thinking a list of volume maps is suffice
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/
---
(Updated Aug. 7, 2014, 6:10 p.m.)
Review request for mesos, Benjamin Hindman
On Aug. 5, 2014, 10:22 a.m., Adam B wrote:
Some minor feedback, but I think it's about ready to commit. I'll let
@vinodkone (shepherd) give the final word.
Vinod Kone wrote:
i'll take a look once adam's comments are addressed.
Hi Vinod, I addressed Adam's comments, PTAL! Thanks!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/
---
(Updated Aug. 7, 2014, 11:27 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24461/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review49936
---
src/docker/docker.cpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2291/changes
Changes:
[yujie.jay] Fixed a bug in slave when launching container.
--
[...truncated 3873 lines...]
mv -f .deps/stout_tests-signals_tests.Tpo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/
---
(Updated Aug. 7, 2014, 7 p.m.)
Review request for mesos and Benjamin Hindman.
On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote:
mpi/mpiexec-mesos.in, line 32
https://reviews.apache.org/r/24264/diff/2/?file=652335#file652335line32
Can we throw a comment above this block to explain what it is that
you're doing? It's starting to get more and more
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/257/changes
@140.211.11.27:45707
I0807 19:42:11.468621 1160 slave.cpp:971] Will retry registration in
7.034119ms if necessary
I0807 19:42:11.468679 1160 master.cpp:2837] Registering slave at
slave(199)@140.211.11.27:45707 (hemera.apache.org) with id
20140807-194211-453759884-45707-32388-0
I0807 19:42:11.468781
Inlined.
On 7 August 2014 10:46, Dominic Hamon dha...@twitter.com.invalid wrote:
On Aug 6, 2014 4:33 PM, Niklas Nielsen n...@qni.dk wrote:
Hi guys,
I think it is in communities interest to lower the barrier to entry for
new
contributors to the project. Not only in terms of process
On June 19, 2014, 7:42 a.m., Adam B wrote:
include/mesos/mesos.proto, lines 527-528
https://reviews.apache.org/r/22526/diff/11/?file=611738#file611738line527
Why do you need both old new resources? In case multiple resize tasks
come through at a time, or to handle resource
I disagree with the assertion that more code documentation is better.
The doxygen documentation, when taken to its full extent, duplicates the
code it references. This encourages bad practices such as relying on
documentation instead of ensuring the code itself is readable and
understandable. It
I don't think we need to take the doxygen documentation to its full
extent, or even enforce documenting every public class/method. I
personally get annoyed at unhelpful @params and @returns. But I agree that
having the existing class/method comments published in a source-browsable
format would be
On Aug. 7, 2014, 6:41 p.m., Jie Yu wrote:
src/docker/docker.cpp, line 512
https://reviews.apache.org/r/24464/diff/1/?file=654883#file654883line512
What if 'docker logs' fails? For example, the containerName is not
valid? How are we gonna detect that?
Right now I'm assuming
On Aug. 7, 2014, 6:41 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, line 583
https://reviews.apache.org/r/24464/diff/1/?file=654884#file654884line583
Who is gonna stop the log subprocess? Worth commenting on that?
It will automatically be stopped when the docker container
See https://builds.apache.org/job/mesos-reviewbot/1291/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24197/#review49950
---
Patch looks great!
Reviews applied: [24197]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24469/
---
Review request for mesos and Benjamin Hindman.
Bugs: mesos-1016
I've gone through and done a ton of updates to the CLI tools. If you'd
like to give them a try, there's a review posted and you can check out
the readme here:
https://reviews.apache.org/r/24469/diff/#11
(tldr. `pip install mesos.cli`)
Please take the time to read the README if you are at
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2036/changes
Changes:
[yan] Reverted a refactor that broke the build.
--
[...truncated 3762 lines...]
copying src/mesos.interface.egg-info/SOURCES.txt -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/
---
(Updated Aug. 7, 2014, 9:09 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24469/
---
(Updated Aug. 7, 2014, 9:49 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
---
(Updated Aug. 7, 2014, 9:56 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/
---
Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/
---
(Updated Aug. 7, 2014, 10:01 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/#review49961
---
Ship it!
can you convert 1-2 CI jobs to use this script?
- Vinod
On Aug. 7, 2014, 3:10 p.m., Vinod Kone wrote:
can you convert 1-2 CI jobs to use this script?
Sure.
- Jiang Yan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/#review49961
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2292/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24469/
---
(Updated Aug. 7, 2014, 10:55 p.m.)
Review request for mesos and Benjamin
Hi all,
I just added http://mesos.apache.org/api/latest/c++/ since there was
consensus on getting doxygen hosted (while the style and extent of doxygen
comments still are in flux) and just wanted to share the steps needed to
generate and publish those.
Assuming that you have a svn checkout of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24356/
---
(Updated Aug. 7, 2014, 11:02 p.m.)
Review request for mesos, Adam B and
On Aug. 7, 2014, 3:23 p.m., Benjamin Hindman wrote:
src/tests/allocator_tests.cpp, lines 405-407
https://reviews.apache.org/r/24356/diff/3/?file=654288#file654288line405
This makes me feel like you're assuming there is going to be a time
delay between when the resources are
On Aug. 7, 2014, 3:39 p.m., Adam B wrote:
Have you done any simulations or performance tests on a test cluster? I'd
love to see some numbers that prove that this is more fair in some scenario
than the previous algorithm. Not sure I can blindly trust a unit test.
Not yet. I'll have to
Looking good!
Do you think we should also include libprocess/stout in there?
On Thu, Aug 7, 2014 at 4:00 PM, Niklas Nielsen nik...@mesosphere.io wrote:
Hi all,
I just added http://mesos.apache.org/api/latest/c++/ since there was
consensus on getting doxygen hosted (while the style and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/
---
(Updated Aug. 7, 2014, 4:20 p.m.)
Review request for Aurora, Joe Smith, Kevin
This is really awesome. I love it!
Can't wait to use it in production.
On Thu, Aug 7, 2014 at 1:57 PM, Thomas Rampelberg tho...@saunter.org
wrote:
I've gone through and done a ton of updates to the CLI tools. If you'd
like to give them a try, there's a review posted and you can check out
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24481/
---
Review request for mesos, Adam B and Dominic Hamon.
Repository: mesos-git
Sweet. LGTM. Although its a bit odd that the main page looks empty.
+1 to add it to the default rake target.
On Thu, Aug 7, 2014 at 4:00 PM, Niklas Nielsen nik...@mesosphere.io wrote:
Hi all,
I just added http://mesos.apache.org/api/latest/c++/ since there was
consensus on getting doxygen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24481/#review49972
---
Ship it!
Ship It!
- Dominic Hamon
On Aug. 7, 2014, 4:28 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24461/#review49973
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 7, 2014, 6:27 p.m., Jie
Very nice!
On Thu, Aug 7, 2014 at 4:28 PM, Vinod Kone vinodk...@gmail.com wrote:
Sweet. LGTM. Although its a bit odd that the main page looks empty.
+1 to add it to the default rake target.
On Thu, Aug 7, 2014 at 4:00 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Hi all,
I just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24485/
---
Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and
This is really quite awesome, I too have found myself needing something
like this...!
On 8 August 2014 00:26, Vinod Kone vinodk...@gmail.com wrote:
This is really awesome. I love it!
Can't wait to use it in production.
On Thu, Aug 7, 2014 at 1:57 PM, Thomas Rampelberg tho...@saunter.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24343/#review49979
---
I realize this is already committed, had a few questions around
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24469/
---
(Updated Aug. 8, 2014, 12:37 a.m.)
Review request for mesos and Benjamin
On Aug. 5, 2014, 5:37 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, line 1925
https://reviews.apache.org/r/24316/diff/1/?file=652057#file652057line1925
Let's not put the fall-back logic into this utility function. The
fall-back logic should be done at a higher level (i.e., in the
Along with this, I'd like to write some docs up on situational
debugging (frequently encountered errors?) eg:
- My framework says a task isn't working, now what?
If anyone has a situation that they experience on a regular basis, let
me know so that I can get it added to the list!
On Thu, Aug 7,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review49980
---
src/tests/slave_tests.cpp
On Aug. 5, 2014, 9:29 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 1337
https://reviews.apache.org/r/23912/diff/3/?file=643812#file643812line1337
s/executor is running/it was launched/
doesn't look like this was addressed.
On Aug. 5, 2014, 9:29 p.m., Vinod Kone wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2303/changes
Changes:
[yan] Added 'timed_tests.sh' script to help investigate the cause of hanging
tests.
[niklas] Added libprocess and stout to doxyfile.
[yujie.jay] Modified the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review50002
---
Ship it!
Please update the diff. I'll get it committed tomorrow!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24316/#review50004
---
src/slave/flags.hpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2037/changes
Changes:
[yan] Added 'timed_tests.sh' script to help investigate the cause of hanging
tests.
[niklas] Added libprocess and stout to doxyfile.
[yujie.jay] Modified the default for ephemeral ports per
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2293/changes
Changes:
[yan] Added 'timed_tests.sh' script to help investigate the cause of hanging
tests.
[niklas] Added libprocess and stout to doxyfile.
[yujie.jay] Modified the default for ephemeral ports
On Aug. 7, 2014, 5:33 p.m., Ben Mahler wrote:
I realize this is already committed, had a few questions around doing this
more cleanly. Let me know your thoughts!
I appreciate these comments and let's chat about what could be done to improve
this!
On Aug. 7, 2014, 5:33 p.m., Ben Mahler
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/258/changes
Changes:
[yan] Added 'timed_tests.sh' script to help investigate the cause of hanging
tests.
[niklas] Added libprocess and stout to doxyfile.
[yujie.jay] Modified the default for ephemeral ports per container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50010
---
Bad patch!
Reviews applied: [24349]
Failed command: git apply
See https://builds.apache.org/job/mesos-reviewbot/1294/changes
84 matches
Mail list logo
