Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78149 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated March 28, 2015, 2:25 a.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) > > Vinod Kone wrote: > Can you or @till let me know what the race and temporal issue here was? > And how this fixes it? > > Till Toenshoff wrote: > There was one major probl

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) > > Vinod Kone wrote: > Can you or @till let me know what the race and temporal issue here was? > And how this fixes it? There was one major problem in these lines: ``` // Start

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On March 27, 2015, 10:46 p.m., Adam B wrote: > > Fix looks good to me. Buildbot, please take another look. ;) Can you or @till let me know what the race and temporal issue here was? And how this fixes it? - Vinod --- This is an autom

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/#review78124 --- Patch looks great! Reviews applied: [32550, 32151, 32152] All test

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review78123 --- Fix looks good to me. Buildbot, please take another look. ;) - Adam

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

> On March 27, 2015, 6:51 p.m., Benjamin Hindman wrote: > > src/java/jni/org_apache_mesos_state_AbstractState.cpp, line 249 > > > > > > Can we confirm that we can make a jclass be static? > > Michael Park wrote: >

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/ --- (Updated March 27, 2015, 10:43 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32151: Add MESOS_{MAJOR|MINOR|PATCH}_VERSION to libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32151/ --- (Updated March 27, 2015, 10:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

> On March 27, 2015, 6:51 p.m., Benjamin Hindman wrote: > > src/java/jni/org_apache_mesos_state_AbstractState.cpp, line 249 > > > > > > Can we confirm that we can make a jclass be static? I believe this can't be made

Re: Review Request 31276: Added cgroup memory pressure listening tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31276/#review78101 --- Ship it! Ship It! - Jie Yu On March 27, 2015, 3:20 a.m., Chi Zha

Re: Splitting reviews and build emails into their own mailing lists

Awesome Vinod, I'm fully on board with this idea. I think the dev discussions in specific sometimes get drowned by the reviews and other "noise" that's conflated into this mailing list. Thanks for taking the steps on this! MPark. On 27 March 2015 at 15:19, Vinod Kone wrote: > Hi, > > What do

Splitting reviews and build emails into their own mailing lists

Hi, What do you guys think about moving the review and build (CI) emails to their own mailing lists (reviews@ and builds@). Quite a few people that I have talked to have mentioned that there is too much noise on our dev list to get at the signal (dev discussions, release announcements, API change

Re: Review Request 32151: Add MESOS_{MAJOR|MINOR|PATCH}_VERSION to libmesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32151/#review78081 --- Ship it! src/common/version.cpp

Re: Review Request 32152: Fix memory corruption in AbstractState JNI bindings. MESOS-2161.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32152/#review78092 --- Ship it! src/java/jni/org_apache_mesos_state_AbstractState.cpp

Re: Review Request 32579: Fix Attributes and Resources documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32579/#review78087 --- Patch looks great! Reviews applied: [32579] All tests passed. - M

Re: Review Request 32579: Fix Attributes and Resources documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32579/#review78083 --- Ship it! Ship It! - Niklas Nielsen On March 27, 2015, 9:54 a.m.,

Re: Review Request 31268: Wired up test allocator to allocator tests.

> On March 24, 2015, 2:49 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, lines 123-126 > > > > > > Could we indent this similar to this example from > > `src/tests/isolator_tests.cpp`: > > >

Re: Review Request 32550: Add major, minor, and patch accessors to stout's Version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32550/#review78080 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/version.

Re: Review Request 32579: Fix Attributes and Resources documentation.

> On March 27, 2015, 5:20 p.m., Joerg Schad wrote: > > lgtm P.S. checked with Markdown Preview - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32579/#review78076 -

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/#review77511 --- src/master/allocator/mesos/allocator.hpp

Re: Review Request 32579: Fix Attributes and Resources documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32579/#review78076 --- lgtm - Joerg Schad On March 27, 2015, 4:54 p.m., Michael Park wro

Re: Review Request 31268: Wired up test allocator to allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/#review78074 --- Patch looks great! Reviews applied: [31775, 31776, 31266, 31267, 31

Jenkins build is back to normal : mesos-reviewbot #4865

See

Review Request 32579: Fix Attributes and Resources documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32579/ --- Review request for mesos. Bugs: MESOS-2566 https://issues.apache.org/jira/b

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78071 --- src/slave/flags.cpp

Re: Review Request 31267: Added a test allocator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/#review78070 --- src/tests/module.cpp

Re: Review Request 31265: Provided a factory for allocator in tests.

> On March 24, 2015, 2:41 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, line 97 > > > > > > 1. Do we need this to be `virtual` right now? > > 2. `s/createAllocatorInstance/CreateAllocator/` > >

Re: Review Request 31268: Wired up test allocator to allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31268/ --- (Updated March 27, 2015, 4:27 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31263: Refactored TestAllocator and allocator text fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/ --- (Updated March 27, 2015, 4:27 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31265: Provided a factory for allocator in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ --- (Updated March 27, 2015, 4:27 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31262: Moved allocator actions before TestAllocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31262/ --- (Updated March 27, 2015, 4:26 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31267: Added a test allocator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/ --- (Updated March 27, 2015, 4:26 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31776: Moved allocator to public headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31776/ --- (Updated March 27, 2015, 4:25 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31266: Added support for allocator modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31266/ --- (Updated March 27, 2015, 4:25 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31775: Removed Master::Flags dependency from Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31775/ --- (Updated March 27, 2015, 4:23 p.m.) Review request for mesos, Kapil Arya, Micha

Re: Review Request 31776: Moved allocator to public headers.

> On March 23, 2015, 10:27 p.m., Michael Park wrote: > > include/mesos/master/allocator.proto, lines 20-21 > > > > > > `s/breaking the backward compatibility/breaking backwards > > compatibility/` > > > > Also

Re: Review Request 31266: Added support for allocator modules.

> On March 24, 2015, 5:55 a.m., Michael Park wrote: > > > > Michael Park wrote: > Hm, upon looking at other files in `include/mesos/module/` it looks like > the 2 style issues I mentioned below is apparent in all of them. Is there a > reason for this? or shoud they be fixed as a batch in a

Build failed in Jenkins: mesos-reviewbot #4864

See -- [...truncated 5581 lines...] rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs rm -rf state/.libs state/_libs rm -rf usage/.libs usage/_libs rm -rf watcher/.libs watcher/_libs

Re: Review Request 31268: Wired up test allocator to allocator tests.

> On March 24, 2015, 2:49 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, lines 123-126 > > > > > > Could we indent this similar to this example from > > `src/tests/isolator_tests.cpp`: > > >

Build failed in Jenkins: mesos-reviewbot #4863

See -- [...truncated 5624 lines...] rm -f watcher/*.o rm -f watcher/*.lo rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs rm -f zookeeper/*.o rm -f zookeeper/*.lo rm -rf state/.libs

Re: Review Request 31265: Provided a factory for allocator in tests.

> On March 24, 2015, 2:41 p.m., Michael Park wrote: > > src/tests/master_allocator_tests.cpp, line 97 > > > > > > 1. Do we need this to be `virtual` right now? > > 2. `s/createAllocatorInstance/CreateAllocator/` > >

Jenkins build is back to normal : mesos-reviewbot #4861

See

Re: Review Request 32505: Added SHUTDOWN scheduler call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32505/#review78050 --- src/master/master.cpp

Re: Review Request 31267: Added a test allocator module.

> On March 24, 2015, 6:07 a.m., Michael Park wrote: > > src/tests/module.cpp, line 135 > > > > > > Can we take `Modules*` here instead to keep consistency with > > `addAnonymousModules`, etc? or perhaps a patch before

Re: Review Request 31267: Added a test allocator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31267/ --- (Updated March 27, 2015, 3:08 p.m.) Review request for mesos, Kapil Arya, Micha

Build failed in Jenkins: mesos-reviewbot #4860

See -- [...truncated 5566 lines...] rm -rf scheduler/.libs scheduler/_libs rm -rf slave/.libs slave/_libs rm -f tests/common/*.o rm -f usage/*.o rm -f usage/*.lo rm -f watcher/*.o rm -rf slave/containeriz

Re: Review Request 31266: Added support for allocator modules.

> On March 24, 2015, 5:55 a.m., Michael Park wrote: > > > > Michael Park wrote: > Hm, upon looking at other files in `include/mesos/module/` it looks like > the 2 style issues I mentioned below is apparent in all of them. Is there a > reason for this? or shoud they be fixed as a batch in a

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 27, 2015, 2:49 p.m.) Review request for mesos. Changes ---

Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings.

> On March 27, 2015, 9:17 a.m., Adam B wrote: > > docs/upgrades.md, line 15 > > > > > > Is there some new behavior in Mesos 0.22 that just caused this issue to > > start occurring? Or could this have happened with Meso

Re: Review Request 30931: Added flags to logs at master and slave startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review78046 --- Ship it! Ship It! - Alexander Rojas On March 26, 2015, 12:20 a.m

Re: Review Request 32543: Documented problem and solution with slave recovery and systemd settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32543/ --- (Updated March 27, 2015, 2:09 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review78044 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/fl

Re: Review Request 31776: Moved allocator to public headers.

> On March 23, 2015, 10:27 p.m., Michael Park wrote: > > include/mesos/master/allocator.proto, lines 20-21 > > > > > > `s/breaking the backward compatibility/breaking backwards > > compatibility/` > > > > Also

Re: Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32504/#review78038 --- src/examples/low_level_scheduler_libprocess.cpp

Re: Review Request 32502: Updated RECONCILE call to always specifiy slave id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32502/#review78035 --- I have to say, given the description and summary of the patch and it

Re: Review Request 32558: Improve compile time of mesos by splitting flags

> On March 27, 2015, 11:43 a.m., Joerg Schad wrote: > > LGTM > > Great effort! > > On my machine (Apple LLVM version 6.0 (clang-600.0.56)) on the current > > master this reduced 'make -j8' from > > real5m8.217s, user 25m56.168s, sys 2m47.850s > > to > > real4m28.660s, user 23m

Re: Review Request 32558: Improve compile time of mesos by splitting flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32558/#review78031 --- LGTM Great effort! On my machine (Apple LLVM version 6.0 (clang-600.

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review78030 --- Ship it! Ship It! - Alexander Rojas On March 26, 2015, 12:07 a.m

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

> On Feb. 18, 2015, 11:38 a.m., Niklas Nielsen wrote: > > Let's get tests wired up before committing this :) > > Adam B wrote: > Sure thing. Adding tests in my subsequent patch where we will pass the > master's timeout values on to the slave. Will post that very soon. > > Ben Mahler wrote:

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

> On March 6, 2015, 5:19 a.m., Joerg Schad wrote: > > src/master/flags.hpp, line 383 > > > > > > Shouldn't this also be added to the documentation (i.e. > > http://mesos.apache.org/documentation/latest/configuration/)

Re: Review Request 32543: Document problem and solution encountered in Mesos-2419.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32543/#review78025 --- Great. It reads well and explains the issue. Just a couple of questi