---
On April 21, 2015, 2:44 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/
---
(Updated April 21
On Feb. 11, 2015, 5:27 a.m., Adam B wrote:
src/examples/test_hook_module.cpp, line 120
https://reviews.apache.org/r/29947/diff/7/?file=837750#file837750line120
Why would this get called multiple times?
Kapil Arya wrote:
If for example, someone writes a test case
2f2da1c5ef85af06c7f366d38ce5b64f39d0076f
src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378
Diff: https://reviews.apache.org/r/29947/diff/
Testing
---
make check
Thanks,
Kapil Arya
:-).
src/authentication/cram_md5/authenticatee.hpp
https://reviews.apache.org/r/32850/#comment129768
I think this `#include` can be moved to the cpp file as well.
- Kapil Arya
On April 9, 2015, 10:58 p.m., Till Toenshoff wrote
://reviews.apache.org/r/32850/#comment129850
According to our style guide, this is okay but we keep seeing issues being
raised about this. Should we just update the style guide instead?
- Kapil Arya
On April 14, 2015, 10:20 a.m., Till Toenshoff wrote
On April 14, 2015, 10:16 a.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
According
/32583/#review79798
---
On April 7, 2015, 12:59 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32583
/
The previous slave has already been killed on line 161. We do need to kill
the prev_master though, otherwise it complains about address being in use when
launching the new master.
- Kapil Arya
On March 2, 2015, 6:44 p.m., Niklas Nielsen wrote
---
On April 7, 2015, 12:59 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32585/
---
(Updated April 7, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32967/#review79348
---
Ship it!
Ship It!
- Kapil Arya
On April 8, 2015, 9:35 a.m
://reviews.apache.org/r/32586/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
11e88330dd50913ab00da79054225d113541e83e
Diff: https://reviews.apache.org/r/32587/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
35ce70b6702473a3100991372f3ba36bcad391c0
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
97c45c01dfcea38b1ae555c036d61e10c152c2c8
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32583/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
TODO: Test for upgrade path.
Thanks,
Kapil Arya
5f0c39afd2fe9a89eb1df0052af8ab422306f30e
src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32585/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
---
On April 7, 2015, 12:59 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32583
97c45c01dfcea38b1ae555c036d61e10c152c2c8
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32583/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
35ce70b6702473a3100991372f3ba36bcad391c0
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
19e6b44bc344c0ca509674803f401cbb4e1f47ae
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32585/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
://reviews.apache.org/r/32585/#review78496
---
On March 31, 2015, 4:29 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32583/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
TODO: Test for upgrade path.
Thanks,
Kapil Arya
/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32585/diff/
Testing (updated)
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
---
On March 31, 2015, 4:30 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587/
---
(Updated March
11e88330dd50913ab00da79054225d113541e83e
Diff: https://reviews.apache.org/r/32587/diff/
Testing (updated)
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/32700/diff/
Testing
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32584/
---
(Updated March 31, 2015, 4:28 p.m.)
Review
://reviews.apache.org/r/32586/diff/
Testing (updated)
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8
src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16
Diff: https://reviews.apache.org/r/32583/diff/
Testing (updated)
---
make check.
TODO: Test for upgrade path.
Thanks,
Kapil Arya
(updated)
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
+1.
On Sun, Mar 29, 2015 at 9:16 AM, Anirudha Jadhav aniru...@nyu.edu wrote:
+1 please
On Sun, Mar 29, 2015 at 8:55 AM, haosdent haosd...@gmail.com wrote:
+1
On Sun, Mar 29, 2015 at 12:56 PM, Yan Xu y...@jxu.me wrote:
+1
--
Jiang Yan Xu y...@jxu.me @xujyan
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/
---
(Updated March 23, 2015, 10:02 a.m.)
Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
Bugs: MESOS-2160
https://issues.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review77401
---
Ship it!
Ship It!
- Kapil Arya
On March 23, 2015, 10:06 a.m
On March 17, 2015, 4:58 p.m., Kapil Arya wrote:
src/master/allocator/allocator.hpp, line 39
https://reviews.apache.org/r/31776/diff/3/?file=894463#file894463line39
Why do we have a separate allocator namespace? Wouldn't it be better to
just put the Allocator class in `mesos
put the Allocator class in `mesos::master`?
src/master/allocator/mesos/allocator.hpp
https://reviews.apache.org/r/31776/#comment124464
Same as above. Why not kill the allocator namespace? Afterall, everything
in this file has an Allocator suffix.
- Kapil Arya
On March 13, 2015, 5:42 p.m
the are used/before they are used/
- Kapil Arya
On March 13, 2015, 5:49 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262
://reviews.apache.org/r/31028/#comment124486
s/MergeFrom/CopyFrom/
- Kapil Arya
On March 13, 2015, 7:04 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31028
://reviews.apache.org/r/30961/#comment124474
s/MergeFrom/CopyFrom
- Kapil Arya
On March 13, 2015, 7:04 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31263/#review76814
---
Ship it!
Ship It!
- Kapil Arya
On March 13, 2015, 5:49 p.m
://reviews.apache.org/r/30962/#comment124479
s/MergeFrom/CopyFrom
- Kapil Arya
On March 13, 2015, 7:04 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31266/#review76808
---
Ship it!
Ship It!
- Kapil Arya
On March 13, 2015, 5:44 p.m
/test_allocator_module.cpp
https://reviews.apache.org/r/31267/#comment124467
s/HierarchicalDRFAllocator/HierarchicalDRFAllocator()/
- Kapil Arya
On March 13, 2015, 5:48 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review76801
---
Ship it!
Ship It!
- Kapil Arya
On March 13, 2015, 3:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76438
---
Ship it!
Can we do similar thing to libprocess?
- Kapil Arya
On March 13, 2015, 5:31 p.m., Kapil Arya wrote:
Can we do similar thing to libprocess?
Cody Maloney wrote:
We don't currently ship libprocess as a .so / link against it ever, so it
doesn't come up. It is treated as part of libmesos, or linked into the
binaries of the tests
,
Kapil Arya
, 2015, 5:49 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/
---
(Updated March 11, 2015, 5:49 p.m
33f8738fa229b42ebacfd75b762c977b33191b65
src/slave/slave.cpp 71ae84bbfcef208cc2ee603f3c8a79225e48a7d5
src/tests/hook_tests.cpp b5d776a55b6b205394469c176ac6be6702c218f3
Diff: https://reviews.apache.org/r/31889/diff/
Testing
---
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
.
Thanks,
Kapil Arya
,
Kapil Arya
. To reply, visit:
https://reviews.apache.org/r/31889/#review76079
---
On March 11, 2015, 3:08 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit
'` with
`test $FOO = 'baz'` and surely, the test failed.
Thanks,
Kapil Arya
---
On March 11, 2015, 7:34 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889
'` with
`test $FOO = 'baz'` and surely, the test failed.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/#review76147
---
On March 11, 2015, 6:51 p.m., Kapil Arya wrote
'` with
`test $FOO = 'baz'` and surely, the test failed.
Thanks,
Kapil Arya
'` and surely, the test failed.
Thanks,
Kapil Arya
$FOO = 'baz'` and surely, the test failed.
Thanks,
Kapil Arya
://reviews.apache.org/r/31889/#review76049
---
On March 10, 2015, 10:15 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889
33f8738fa229b42ebacfd75b762c977b33191b65
src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
---
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
---
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/#review76029
---
On March 10, 2015, 10:15 p.m., Kapil Arya wrote
not been performed yet.
Thanks,
Kapil Arya
364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
---
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
---
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
On Feb. 26, 2015, 8:05 a.m., Kapil Arya wrote:
src/slave/state.cpp, line 621
https://reviews.apache.org/r/31480/diff/1/?file=878304#file878304line621
Should we also add strerror(errno) to inform about the lseek error?
Just realized that it's using ErrnoError :-).
- Kapil
it if there is no
precedence in the codebase.
src/slave/state.cpp
https://reviews.apache.org/r/31480/#comment120803
Should we also add strerror(errno) to inform about the lseek error?
src/slave/state.cpp
https://reviews.apache.org/r/31480/#comment120804
Same as above
- Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31027/#review74426
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 26, 2015, 8:55 p.m
7d1a36e41e5e19be6e1dd0f06b6521edc9084e8f
Diff: https://reviews.apache.org/r/31301/diff/
Testing
---
make check
Thanks,
Kapil Arya
541de7a45a467fa97750eec5fed0c12d1500d23c
src/tests/isolator.hpp 7d1a36e41e5e19be6e1dd0f06b6521edc9084e8f
Diff: https://reviews.apache.org/r/31301/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31325/#review73672
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 23, 2015, 4:33 p.m
On Feb. 23, 2015, 1:06 p.m., Jie Yu wrote:
src/tests/port_mapping_tests.cpp, line 67
https://reviews.apache.org/r/31308/diff/3/?file=872983#file872983line67
Can you paste what the error is?
I am curious why we still need `using namespace mesos::internal::tests`
when
all code are under this namespace?
Kapil Arya wrote:
We shouldn't need `using namespace mesos::internal` as well. Further,
the `using namespace mesos::internal::slave` is somewhat redundant with a
bunch of `using mesos::internal::slave::*` below.
It would be helpful to see
`?
- Kapil Arya
On Feb. 23, 2015, 12:37 p.m., Evelina Dumitrescu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/
---
(Updated
c674767181e7885e2f1ce05bfe2c1c39daa34e8a
Diff: https://reviews.apache.org/r/31310/diff/
Testing
---
Thanks,
Kapil Arya
---
Thanks,
Kapil Arya
Yes. This is the RR https://reviews.apache.org/r/31301 .
On Mon, Feb 23, 2015 at 3:26 PM, Vinod Kone vinodk...@gmail.com wrote:
kapil, has this been fixed?
On Sun, Feb 22, 2015 at 10:01 PM, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See
38a6f781d6a0b4618a14e1681420564d78b840a8
Diff: https://reviews.apache.org/r/31331/diff/
Testing
---
make check.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31017/#review73451
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 13, 2015, 6:28 p.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961/
---
(Updated Feb. 13, 2015, 6:28 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Bugs: MESOS-2351
https
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961/
---
(Updated Feb. 13, 2015, 6:28 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Bugs: MESOS-2351
https
and Kapil Arya.
Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351
Repository: mesos
Description
---
See summary.
Diffs
-
include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef
src/examples/test_hook_module.cpp
40081efa7ee6c498fa07cd06391480deb752b6ea
Diff: https://reviews.apache.org/r/31279/diff/
Testing
---
make check.
Thanks,
Kapil Arya
654a27d7cac16ceaa5081a58c667b86b050c4e29
src/watcher/whitelist_watcher.cpp e00b5c80aa388ba33ea73ab7e746ae795554d2b5
Diff: https://reviews.apache.org/r/31236/diff/
Testing (updated)
---
make check after the follow-up patch (https://reviews.apache.org/r/31279/)
succeeds.
Thanks,
Kapil Arya
/#comment119788
s/executorInfo/executorInfo_
- Kapil Arya
On Feb. 13, 2015, 6:28 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31236/#review73463
---
On Feb. 22, 2015, 4:39 p.m., Kapil Arya wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31286/#review73466
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 22, 2015, 5:55 p.m
machine and so when I saw
the failure, I ignored it. Sorry about that.
- Kapil Arya
On Feb. 22, 2015, 6:57 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31287/#review73474
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 22, 2015, 6:57 p.m
://reviews.apache.org/r/31016/#comment119796
const ref?
- Kapil Arya
On Feb. 13, 2015, 6:28 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31016
, visit:
https://reviews.apache.org/r/31016/
---
(Updated Feb. 13, 2015, 6:28 p.m.)
Review request for mesos, Ben Mahler and Kapil Arya.
Repository: mesos
Description
---
Added decorator which gets invoked on start
Thanks Vinod! This is clear now. Should we also add this to mesos-style
guide? I can create a RR.
On Fri, Feb 20, 2015 at 3:23 PM, Vinod Kone vinodk...@apache.org wrote:
A1 - Single
A2 - Double
B - Single
On Fri, Feb 20, 2015 at 12:20 PM, Kapil Arya ka...@mesosphere.io wrote:
What
/usage/usage.cpp 4ddf075153669baa1073a20ccd7e027254a123ab
src/watcher/whitelist_watcher.hpp 654a27d7cac16ceaa5081a58c667b86b050c4e29
src/watcher/whitelist_watcher.cpp e00b5c80aa388ba33ea73ab7e746ae795554d2b5
Diff: https://reviews.apache.org/r/31236/diff/
Testing
---
Thanks,
Kapil Arya
What is the preferred amount of blank lines before the first function
definition inside a namespace? I have a seen single blank line as well as
two blank lines in our code base.
For example, in the following snippet from a cpp file, how many blank lines
should be inserted at A1, A2 and B?
2158cfea98d238d462abeebd3d5fe2dec4f96470
Diff: https://reviews.apache.org/r/31162/diff/
Testing
---
make check.
Also tested with master running HEAD with this patch, and slave running 0.21.0
with src/test-framework.
Thanks,
Kapil Arya
b30812322dd8ae507e1d45912ab559940ac5ee73
src/tests/status_update_manager_tests.cpp
2158cfea98d238d462abeebd3d5fe2dec4f96470
Diff: https://reviews.apache.org/r/31162/diff/
Testing
---
make check.
Also tested with master running HEAD with this patch, and slave running 0.21.0
with src/test-framework.
Thanks,
Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31162/#review73066
---
On Feb. 19, 2015, 5:59 p.m., Kapil Arya wrote
-framework is running from the same version as
the slave. If I run src/test-framework from the master version, it doesn't
succeed and errors out with unexpected TASK_LOST.
Thanks,
Kapil Arya
101 - 200 of 802 matches
Mail list logo
