check (note that the tests currently do not cover this scenario)
Thanks,
Till Toenshoff
+1
Fedora 20 (Heisenbug), g++ (GCC) 4.8.2 20131212 (Red Hat 4.8.2-7)
Ubuntu 13.10, g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1
OSX 10.9.2, Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
configure && make check => all passed
[
https://issues.apache.org/jira/browse/MESOS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997116#comment-13997116
]
Till Toenshoff commented on MESOS-1364:
---
There are at least two possible way
[
https://issues.apache.org/jira/browse/MESOS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997226#comment-13997226
]
Till Toenshoff commented on MESOS-1364:
---
https://reviews.apache.org/r/2
+1
On May 13, 2014, at 8:55 PM, Vinod Kone wrote:
> +1
>
>
> On Tue, May 13, 2014 at 10:54 AM, Benjamin Hindman
> wrote:
> +1!
>
>
> On Tue, May 13, 2014 at 9:51 AM, Niklas Nielsen wrote:
> Hey everyone,
>
> First and foremost, I apologize for the radio silence on my part with regards
>
Till Toenshoff created MESOS-1363:
-
Summary: ExternalContainerizer 'wait' invocations that survive a
slave restart pile up
Key: MESOS-1363
URL: https://issues.apache.org/jira/browse/
[
https://issues.apache.org/jira/browse/MESOS-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997228#comment-13997228
]
Till Toenshoff commented on MESOS-1364:
---
So I reverted my initial patch tow
phase.
Diffs
-
src/slave/containerizer/external_containerizer.cpp 2ff19b1
Diff: https://reviews.apache.org/r/21424/diff/
Testing
---
make check (note that the tests currently do not cover this scenario)
Thanks,
Till Toenshoff
Till Toenshoff created MESOS-1364:
-
Summary: ExternalContainerizer 'recover' should destroy orphaned
ContainerIDs
Key: MESOS-1364
URL: https://issues.apache.org/jira/browse/MESOS-1364
Proj
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995876#comment-13995876
]
Till Toenshoff edited comment on MESOS-1257 at 5/13/14 12:3
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995876#comment-13995876
]
Till Toenshoff commented on MESOS-1257:
---
Quick update; I am still working on
Diff: https://reviews.apache.org/r/21040/diff/
Testing
---
make (tests are currently disabled)
Thanks,
Till Toenshoff
xternal_containerizer.hpp 8fdf097
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21130/diff/
Testing
---
make (test is currently inactive)
Thanks,
Till Toenshoff
without additionally invoking the ECP.
Diffs
-
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21328/diff/
Testing
---
make
Thanks,
Till Toenshoff
eviews.apache.org/r/21040/diff/
Testing
---
make (tests are currently disabled)
Thanks,
Till Toenshoff
on when getting exercised via SlaveRecoverTests - great catch,
thanks Ben!
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21040/#review42084
-----
xternal_containerizer.hpp 8fdf097
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21130/diff/
Testing
---
make (test is currently inactive)
Thanks,
Till Toenshoff
he.org/r/21040/diff/
Testing
---
make (tests are currently disabled)
Thanks,
Till Toenshoff
est is currently inactive)
Thanks,
Till Toenshoff
s/python/test_containerizer.py 7bebfee
src/slave/containerizer/external_containerizer.hpp 8fdf097
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21040/diff/
Testing
---
make (tests are currently disabled)
Thanks,
Till Toenshoff
[
https://issues.apache.org/jira/browse/MESOS-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990141#comment-13990141
]
Till Toenshoff edited comment on MESOS-1243 at 5/6/14 12:3
[
https://issues.apache.org/jira/browse/MESOS-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990141#comment-13990141
]
Till Toenshoff commented on MESOS-1243:
---
Recovery:
Right now {{recover}} is
Till Toenshoff created MESOS-1290:
-
Summary: Unable to find mvn on your path.
Key: MESOS-1290
URL: https://issues.apache.org/jira/browse/MESOS-1290
Project: Mesos
Issue Type: Improvement
rnal_containerizer.hpp eb3ff96
src/slave/containerizer/external_containerizer.cpp e51ac66
Diff: https://reviews.apache.org/r/21040/diff/
Testing
---
make (tests are currently disabled)
Thanks,
Till Toenshoff
n the master in the interim. I'll let you
>>> make the call.
>>>
>>>
>>> On Wed, Apr 30, 2014 at 3:47 PM, Benjamin Hindman >>> wrote:
>>>
>>>> Thanks for the update Till!
>>>>
>>>>
>>>> On
> On May 2, 2014, 2:13 p.m., Till Toenshoff wrote:
> > Diff appears to be missing?
>
> Steven Phung wrote:
> The diff is downloadable but for some reason it doesn't show up inline in
> the review request. I'm not sure why... I tried recreating the request to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/#review42014
---
Diff appears to be missing?
- Till Toenshoff
On May 2, 2014, 6
ng my head for a while. So
even though I think I got a perfect plan to solve this in a non hacky way, that
way currently does not work as expected, hence this delay. Sorry for that -
will keep you updated!
On Apr 30, 2014, at 6:00 PM, Till Toenshoff wrote:
> I think that is the sa
refactorings of the
ExternalContainerizer. Will definitely come up with a fix for that.
- Till
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20893/#review41847
-
orted<>()
>@ 0xd6b27f
> testing::internal::HandleExceptionsInMethodIfSupported<>()
>@ 0xd5d426 testing::UnitTest::Run()
>@ 0xb37712 main
>@ 0x7f7ca85679c4 __libc_start_main
>@ 0x7d84f9 (unknown)
&
-
src/examples/python/test_containerizer.py 7bebfee
Diff: https://reviews.apache.org/r/20893/diff/
Testing
---
make check
Thanks,
Till Toenshoff
luster.hpp:450
447 copy) {
448
449 process::Future > containers =
-> 450slave.containerizer->containers();
451 AWAIT_READY(containers);
452
453 foreach (const ContainerID& containerId, containers.get()) {
On Apr 30, 2014, at
I am also having a peek…
On Apr 30, 2014, at 2:32 AM, Ian Downes wrote:
> This looks more like something I introduced. I'm looking into it.
>
> On Apr 29, 2014, at 5:26 PM, Vinod Kone wrote:
>
>> Is someone looking into this? Till?
>>
>>
>> On Tue, Apr 29, 2014 at 3:38 PM, Apache Jenkins Se
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984677#comment-13984677
]
Till Toenshoff commented on MESOS-1257:
---
Yeah, sorry for this issue - the fix i
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984671#comment-13984671
]
Till Toenshoff commented on MESOS-1257:
---
[~idownes] Did you use --disable-py
has been disabled.
Diffs (updated)
-
src/tests/external_containerizer_test.cpp 6f7b13e
Diff: https://reviews.apache.org/r/20823/diff/
Testing
---
../configure --disable-python
make check
../configure
make check
Thanks,
Till Toenshoff
: https://reviews.apache.org/r/20823/diff/
Testing
---
../configure --disable-python
make check
../configure
make check
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20823/#review41716
-------
On April 29, 2014, 1:39 a.m., Till Toenshoff wrote:
>
> --
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983888#comment-13983888
]
Till Toenshoff commented on MESOS-1257:
---
I would like to wait a day or two no
Turned out that the issue is not strictly related to MESOS-1257.
This specific problem was triggered by a build configured with —disable-python.
I have proposed a fix at https://reviews.apache.org/r/20823/
The issue visible in
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983861#comment-13983861
]
Till Toenshoff commented on MESOS-1257:
---
So this would be the fix for (2):
h
/
Testing
---
../configure --disable-python
make check
../configure
make check
Thanks,
Till Toenshoff
--disable-python
make check
../configure
make check
Thanks,
Till Toenshoff
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983793#comment-13983793
]
Till Toenshoff commented on MESOS-1257:
---
Three issues have been identified so
://reviews.apache.org/r/20819/diff/
Testing
---
make check
Thanks,
Till Toenshoff
: mesos-git
Description
---
see subject.
Diffs
-
src/examples/python/test_containerizer.py 57b4bb6
Diff: https://reviews.apache.org/r/20819/diff/
Testing
---
make check
Thanks,
Till Toenshoff
Am looking into it already - thanks for bringing it to my attention!
On Apr 29, 2014, at 12:34 AM, Jie Yu wrote:
> Should be related to
> https://issues.apache.org/jira/browse/MESOS-1257
>
>
> On Mon, Apr 28, 2014 at 3:32 PM, Vinod Kone wrote:
> +till
>
> can't seem to figure out what the e
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Toenshoff reassigned MESOS-1257:
-
Assignee: Till Toenshoff
> ExternalContainerizerTest.Launch is fl
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983527#comment-13983527
]
Till Toenshoff commented on MESOS-1257:
---
I am still trying to replicate this i
[
https://issues.apache.org/jira/browse/MESOS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983232#comment-13983232
]
Till Toenshoff commented on MESOS-1257:
---
[~jieyu] Thanks for reporting,
summary.
Diffs
-
src/Makefile.am d2e006d
Diff: https://reviews.apache.org/r/20784/diff/
Testing
---
make distcheck
Thanks,
Till Toenshoff
> I0428 16:00:02.520180 12912 external_containerizer.cpp:804] Invoking external
> containerizer for method 'launch'
> I0428 16:00:02.520216 12912 external_containerizer.cpp:818] user: jenkins
> I0428 16:00:02.530993 12902 leveldb.cpp:341] Persisting action (16 bytes) to
> leveldb took 12.432026m
> /home/jenkins/tools/java/jdk1.6.0_20-64/bin/jar cf examples.jar -C
> examples/java .
> make[4]: *** No rule to make target `examples/python/test_containerizer.py',
> needed by `mesos-tests'. Stop.
I will be looking into this in a jiffy.
Till
work!
Will propose an RR for this.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17567/#review41569
---
On April 26, 2014, 1:14 a.
[
https://issues.apache.org/jira/browse/MESOS-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981830#comment-13981830
]
Till Toenshoff commented on MESOS-1251:
---
Thanks for looking into this Ian. I
ews.apache.org/r/17567/diff/
Testing
---
make check and functional testing.
Thanks,
Till Toenshoff
7; on previous line and indent as though it
> > was a continued argument. Can you please do a quick pass and clean this up
> > everywhere? Thanks Till!
>
> Till Toenshoff wrote:
> return Failure("Cannot start already running container '" +
>
Till Toenshoff created MESOS-1251:
-
Summary: Slave should make sure that the containerizer::launch
returned Future is ready
Key: MESOS-1251
URL: https://issues.apache.org/jira/browse/MESOS-1251
be needed for the ExternalContainerizer and possibly other
containerizers as well.
Diffs (updated)
-
include/mesos/mesos.proto 37f8a7f
src/slave/containerizer/mesos_containerizer.cpp 4a5dfa7
Diff: https://reviews.apache.org/r/20080/diff/
Testing
---
make check
Thanks,
Till
nt 'wait' will return a failed future as well which the slave knows
> > to treat as a "terminated" container. This makes me think that 'wait'
> > should have really returned an Option to distinguish the case
> > when it doesn't know about a co
://reviews.apache.org/r/20080/diff/
Testing
---
make check
Thanks,
Till Toenshoff
[
https://issues.apache.org/jira/browse/MESOS-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980316#comment-13980316
]
Till Toenshoff commented on MESOS-1243:
---
I have taken this from a comment o
Till Toenshoff created MESOS-1243:
-
Summary: Containerizer::wait return type should be
Option
Key: MESOS-1243
URL: https://issues.apache.org/jira/browse/MESOS-1243
Project: Mesos
Issue Type
.
Diffs (updated)
-
include/mesos/mesos.proto 37f8a7f
src/slave/containerizer/mesos_containerizer.cpp 4a5dfa7
Diff: https://reviews.apache.org/r/20080/diff/
Testing
---
make check
Thanks,
Till Toenshoff
Testing
---
make check and functional testing.
Thanks,
Till Toenshoff
extending those messages in the
future, where needed.
Diffs
-
include/mesos/containerizer/containerizer.proto 6ecd82e
Diff: https://reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
ed)
-
include/mesos/containerizer/containerizer.proto 6ecd82e
Diff: https://reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20668/#review41332
---
On April 24, 2014, 5:22 p.m., Till Toenshoff wrote:
>
> --
ed)
-
include/mesos/containerizer/containerizer.proto 6ecd82e
Diff: https://reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
/containerizer.proto 6ecd82e
Diff: https://reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
ed.
Diffs (updated)
-
include/mesos/containerizer/containerizer.proto 6ecd82e
Diff: https://reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20668/#review41325
-------
On April 24, 2014, 4:15 p.m., Till Toenshoff wrote:
>
> ---
>
reviews.apache.org/r/20668/diff/
Testing
---
make check
Thanks,
Till Toenshoff
> > killing the process that is waiting from the 'wait' subcommand. Just want
> > to make sure that is what you expect as well, and if that's the case then
> > how about we clean up some of the comments here (and where 'terminate' gets
> > c
PRE-CREATION
Diff: https://reviews.apache.org/r/17567/diff/
Testing
---
make check and functional testing.
Thanks,
Till Toenshoff
---
make check
Thanks,
Till Toenshoff
-git
Description
---
See subject.
Diffs
-
src/Makefile.am 32f6338
Diff: https://reviews.apache.org/r/20508/diff/
Testing
---
make check, make distcheck, make install (+ checking results)
Thanks,
Till Toenshoff
gs.hpp d5c54c0
src/tests/external_containerizer_test.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/17567/diff/
Testing
---
make check and functional testing.
Thanks,
Till Toenshoff
ust:
> >
> > JAVA_PROTOS = \
> > java/generated/org/apache/mesos/Protos.java \
> > java/generated/org/apache/mesos/containerizer/Protos.java
> >
> >
> > And then below you should be able to define the Java targets like what
> > was do
slave.hpp 1e98795
src/slave/slave.cpp d6ec87c
src/tests/containerizer.hpp a9f1531
src/tests/containerizer.cpp bfb9341
Diff: https://reviews.apache.org/r/20141/diff/
Testing
---
make check
Thanks,
Till Toenshoff
[
https://issues.apache.org/jira/browse/MESOS-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973475#comment-13973475
]
Till Toenshoff commented on MESOS-1220:
---
Perfect, works flawlessly - thanks a
[
https://issues.apache.org/jira/browse/MESOS-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973449#comment-13973449
]
Till Toenshoff commented on MESOS-1220:
---
[~bmahler] Thanks for following up on
[
https://issues.apache.org/jira/browse/MESOS-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973380#comment-13973380
]
Till Toenshoff commented on MESOS-1220:
---
Reverting the following fixes the pro
Till Toenshoff created MESOS-1220:
-
Summary: Make check failure on OSX - IO error: Too many open files
Key: MESOS-1220
URL: https://issues.apache.org/jira/browse/MESOS-1220
Project: Mesos
ere instead, i.e.,
> > 'mesos/containerizer/containerizer.hpp' (as we do with mesos/mesos.hpp).
Silly me :) should be fixed by introducing the wrapping header which will
get installed, so this becomes
#include
- Till
---
icitly document the to/from and direction of these messages.
Will update that comment.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20141/#review40323
[
https://issues.apache.org/jira/browse/MESOS-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967081#comment-13967081
]
Till Toenshoff commented on MESOS-1205:
---
+1 - as I understand, we are having
<https://reviews.apache.org/r/19487/#comment72993>
Remove trailing whitespace.
src/jvm/jvm.cpp
<https://reviews.apache.org/r/19487/#comment72994>
Explicit compare - the mesos way :)
if (fn_JNI_createJavaVM == NULL) {
- Till Toenshoff
On April 7, 2014, 2:02 p.m.
nt 'wait' will return a failed future as well which the slave knows
> > to treat as a "terminated" container. This makes me think that 'wait'
> > should have really returned an Option to distinguish the case
> > when it doesn't know about a c
; > when it doesn't know about a container ID! But that's for another review.
Added a verbose comment.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20080/
at should help explaining this.
Deimos does e.g. use 'image' this way: "docker:///ubuntu" as a scheme for
pinning docker use and selecting a registered image.
- Till
---
This is an automatically generated e-mail. To reply,
visit:
https://reviews.apache.org/r/20080/#review39696
---
On April 11, 2014, 2:57 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generat
/
Testing
---
make check
Thanks,
Till Toenshoff
/containerizer.cpp bfb9341
Diff: https://reviews.apache.org/r/20141/diff/
Testing
---
make check
Thanks,
Till Toenshoff
visit:
https://reviews.apache.org/r/20141/#review40061
-------
On April 9, 2014, 12:25 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generate
p:68-74), hence I thought that their explicit definitions
would not add any value.
For 'Termination', that seems to make sense indeed. Will update accordingly.
- Till
---
This is an automatically generated e-mai
Description
---
See summary.
Diffs
-
src/slave/state.cpp 21d1fb7
Diff: https://reviews.apache.org/r/20237/diff/
Testing
---
make check
Thanks,
Till Toenshoff
diff/
Testing
---
make check
Thanks,
Till Toenshoff
state.cpp.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20216/#review40076
-------
On April 10, 2014, 3:51 p.m., Till Toens
f.hpp 36b7f1a
Diff: https://reviews.apache.org/r/20216/diff/
Testing
---
make check
Thanks,
Till Toenshoff
501 - 600 of 893 matches
Mail list logo
