Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-30 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-28 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION src/tests/utils.hpp 5c86fd4 Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
--- On June 17, 2014, 4:47 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/ --- (Updated June 17, 2014, 4

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION src/tests/utils.hpp 5c86fd4 Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46726 --- On June 27, 2014, 11:24 p.m., Timothy Chen wrote

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
, 2014, 11:24 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/ --- (Updated June 27, 2014, 11:24 p.m

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION src/tests/utils.hpp 5c86fd4 Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-27 Thread Timothy Chen
/#comment82498 sorry about it, let me remove - Timothy Chen On June 27, 2014, 11:50 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734

[jira] [Commented] (MESOS-1533) HealthCheck tests are flaky

2014-06-24 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041810#comment-14041810 ] Timothy Chen commented on MESOS-1533: - Also it's odd that HTTP health check error msg

Re: Review Request 22851: Updated mesos to adapt to the new Subprocess interfaces.

2014-06-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22851/#review46555 --- Ship it! Ship It! - Timothy Chen On June 23, 2014, 11:36 p.m

[jira] [Assigned] (MESOS-186) Resource offers should be rescinded after some configurable timeout

2014-06-21 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-186: -- Assignee: Timothy Chen (was: Kapil Arya) Resource offers should be rescinded after some

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-20 Thread Timothy Chen
d57fc7d Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-20 Thread Timothy Chen
d57fc7d Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-20 Thread Timothy Chen
. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46313 --- On June 17, 2014, 4:47 a.m., Timothy Chen wrote

[jira] [Commented] (MESOS-1503) Improve slave health checking to prevent rapid widespread slave removals.

2014-06-20 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039590#comment-14039590 ] Timothy Chen commented on MESOS-1503: - I'm thinking about the design of the single

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-19 Thread Timothy Chen
/external_containerizer.cpp 96c434b src/slave/slave.cpp ed3483f src/tests/health_check_tests.cpp PRE-CREATION src/tests/script.cpp d57fc7d Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

[jira] [Commented] (MESOS-186) Resource offers should be rescinded after some configurable timeout

2014-06-19 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038161#comment-14038161 ] Timothy Chen commented on MESOS-186: I added more tests and fix issue found as well

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-19 Thread Timothy Chen
/slave.cpp ed3483f src/tests/health_check_tests.cpp PRE-CREATION src/tests/script.cpp d57fc7d Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-18 Thread Timothy Chen
generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review45845 --- On June 17, 2014, 5:59 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-18 Thread Timothy Chen
/health_check_tests.cpp PRE-CREATION src/tests/script.cpp 9f1be63 Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-18 Thread Timothy Chen
! - Timothy Chen On June 17, 2014, 4:47 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/ --- (Updated June

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Timothy Chen
unit tests and make check. Thanks, Timothy Chen

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review45845 --- On June 17, 2014, 5:59 p.m., Timothy Chen wrote: --- This is an automatically generated e

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-16 Thread Timothy Chen
/launcher/executor.cpp 3d55d93 src/messages/messages.proto 8aecc8b src/slave/http.cpp cd7f692 src/slave/slave.cpp 643c088 src/tests/health_check_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22579/diff/ Testing --- Added unit tests and make check. Thanks, Timothy Chen

[jira] [Commented] (MESOS-741) Add health checking for tasks

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032793#comment-14032793 ] Timothy Chen commented on MESOS-741: We decided to do this since the health checker

[jira] [Commented] (MESOS-390) Slave should support file:/// URIs for executor path

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032842#comment-14032842 ] Timothy Chen commented on MESOS-390: https://reviews.apache.org/r/21734/ Slave should

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-16 Thread Timothy Chen
PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

[jira] [Commented] (MESOS-741) Add health checking for tasks

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033094#comment-14033094 ] Timothy Chen commented on MESOS-741: Hi Ben, thanks for the notes that's helpful

[jira] [Created] (MESOS-1489) Task health checker to output protobuf via stdout

2014-06-16 Thread Timothy Chen (JIRA)
Timothy Chen created MESOS-1489: --- Summary: Task health checker to output protobuf via stdout Key: MESOS-1489 URL: https://issues.apache.org/jira/browse/MESOS-1489 Project: Mesos Issue Type

[jira] [Created] (MESOS-1491) Allow subprocess to accept arguments

2014-06-16 Thread Timothy Chen (JIRA)
Timothy Chen created MESOS-1491: --- Summary: Allow subprocess to accept arguments Key: MESOS-1491 URL: https://issues.apache.org/jira/browse/MESOS-1491 Project: Mesos Issue Type: Improvement

[jira] [Updated] (MESOS-1491) Improve subprocess executing command with arguments

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated MESOS-1491: Summary: Improve subprocess executing command with arguments (was: Allow subprocess to accept

[jira] [Updated] (MESOS-1491) Improve subprocess executing command with arguments

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated MESOS-1491: Description: The current way for subprocess to execute commands with arguments is to build up

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review45850 --- On June 16, 2014, 8:21 p.m., Timothy Chen wrote

[jira] [Commented] (MESOS-1491) Improve subprocess executing command with arguments

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033219#comment-14033219 ] Timothy Chen commented on MESOS-1491: - Sounds great! That this is not needed then once

[jira] [Closed] (MESOS-1491) Improve subprocess executing command with arguments

2014-06-16 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen closed MESOS-1491. --- Resolution: Not a Problem Will be handled by future abstractions work in Mesos Improve subprocess

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-16 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 22519: Add grace period to health check and move health check into TaskInfo

2014-06-13 Thread Timothy Chen
. Repository: mesos-git Description --- Add grace period to health check and move health check into TaskInfo Diffs (updated) - include/mesos/mesos.proto 102289b Diff: https://reviews.apache.org/r/22519/diff/ Testing --- make check Thanks, Timothy Chen

Re: Review Request 22519: Add grace period to health check and move health check into TaskInfo

2014-06-13 Thread Timothy Chen
/#comment80562 Ah yes I thought I fixed the typo but somehow it wasn't. Good catch. - Timothy Chen On June 13, 2014, 7:55 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 22589: Fix typo in health check grace periods field

2014-06-13 Thread Timothy Chen
Description --- Fix typo in health check grace periods field Diffs - include/mesos/mesos.proto 833f70a Diff: https://reviews.apache.org/r/22589/diff/ Testing --- make check Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-10 Thread Timothy Chen
/fetcher.cpp c4425eb src/tests/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-09 Thread Timothy Chen
/tests/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21499: Added healthy field to TaskUpdate.

2014-06-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21499/#review45120 --- Ship it! Ship It! - Timothy Chen On June 9, 2014, 7:53 p.m

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-09 Thread Timothy Chen
/tests/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-08 Thread Timothy Chen
/tests/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-08 Thread Timothy Chen
src/launcher/fetcher.cpp c4425eb src/tests/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-05 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-05 Thread Timothy Chen
/r/21734/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-06-05 Thread Timothy Chen
/fetcher_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/21734/diff/ Testing (updated) --- Added unit tests to test file:// and file://localhost. make check. Thanks, Timothy Chen

Mesos wiki

2014-06-02 Thread Timothy Chen
Hi all, Can someone grant me (tnachen) permissions to add/edit pages to the Mesos wiki? I'd like to add design doc for Mesos stories I'm going to work on. Thanks, Tim

[jira] [Assigned] (MESOS-1441) Move HealthCheck from CommandInfo to TaskInfo

2014-05-30 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-1441: --- Assignee: Timothy Chen Move HealthCheck from CommandInfo to TaskInfo

[jira] [Assigned] (MESOS-1442) Adding grace_period_seconds to the health check protobuf

2014-05-30 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-1442: --- Assignee: Timothy Chen Adding grace_period_seconds to the health check protobuf

[jira] [Assigned] (MESOS-62) Report actual resource usage to master

2014-05-23 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-62: - Assignee: (was: Timothy Chen) Report actual resource usage to master

Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-05-21 Thread Timothy Chen
Description --- Handling file:// in the fetcher, and also handle case when localhost is used. Diffs - src/launcher/fetcher.cpp 8c9e20d Diff: https://reviews.apache.org/r/21734/diff/ Testing --- Thanks, Timothy Chen

Re: Review Request 21734: MESOS-390 Handle file:// in fetcher

2014-05-21 Thread Timothy Chen
generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review43700 --- On May 22, 2014, 3:29 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail

[jira] [Assigned] (MESOS-468) mesos-slave should clean ENV vars before invoking executors

2014-05-18 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-468: -- Assignee: Timothy Chen mesos-slave should clean ENV vars before invoking executors

[jira] [Assigned] (MESOS-62) Report actual resource usage to master

2014-05-18 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen reassigned MESOS-62: - Assignee: Timothy Chen Report actual resource usage to master

[jira] [Commented] (MESOS-390) Slave should support file:/// URIs for executor path

2014-05-15 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996835#comment-13996835 ] Timothy Chen commented on MESOS-390: I would like to work on this issue, can someone

Assigning issues

2014-05-14 Thread Timothy Chen
Hi all, I'm looking to start contributing to Mesos, and I wasn't able to assign myself the jira issue I want to start with: https://issues.apache.org/jira/browse/MESOS-390 I wonder if I can be added to contributor status, or be helped assigning the issue? Thanks, Tim

Re: Mesos ReviewBot

2014-03-04 Thread Timothy Chen
really going to replace Review Board with GitHub at Apache? I'm not really a big fan of their review tools. RB's is so much better. On Tue, Mar 4, 2014 at 1:24 PM, Timothy Chen tnac...@gmail.com wrote: Just chiming in as a lurker on this list. Drill is planning to utilize the github

<    5   6   7   8   9   10