---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33111/#review79896
---
Ship it!
Ship It!
- Timothy St. Clair
On April 12, 2015, 9:33
whether they
are used or not.
- Timothy St. Clair
On March 13, 2015, 12:10 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76416
---
Ship it!
Provided builds are clean, +1
- Timothy St. Clair
On Jan. 23, 2015, 10:38 p.m., Timothy St. Clair wrote:
3rdparty/libprocess/configure.ac, line 178
https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178
maybe I'm missing something, but isn't 'test -d' to check directories?
Kapil Arya wrote:
Yeah, that's
On Jan. 23, 2015, 10:38 p.m., Timothy St. Clair wrote:
3rdparty/libprocess/configure.ac, line 178
https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178
maybe I'm missing something, but isn't 'test -d' to check directories?
Kapil Arya wrote:
Yeah, that's
On Jan. 23, 2015, 10:42 p.m., Timothy St. Clair wrote:
configure.ac, line 260
https://reviews.apache.org/r/29595/diff/3/?file=819045#file819045line260
Do you have system details?
Could you provide ldd and version of the system in question.
Kapil Arya wrote
On Jan. 23, 2015, 10:38 p.m., Timothy St. Clair wrote:
3rdparty/libprocess/configure.ac, line 178
https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178
maybe I'm missing something, but isn't 'test -d' to check directories?
Kapil Arya wrote:
Yeah, that's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/#review69484
---
Ship it!
Ship It!
- Timothy St. Clair
On Jan. 12, 2015, 11:40
On Jan. 23, 2015, 10:12 p.m., Timothy St. Clair wrote:
Ship It!
My only comment might be to that JIRA cross ref is always nice for history, but
this is a minor change.
- Timothy
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review69488
---
Ship it!
Ship It!
- Timothy St. Clair
On Jan. 19, 2015, 7:32
/30048/#comment114184
maybe I'm missing something, but isn't 'test -d' to check directories?
- Timothy St. Clair
On Jan. 19, 2015, 7:32 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Same comment as the other review.. why 'test -d'?
- Timothy St. Clair
On Jan. 19, 2015, 7:32 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30049
Do you have system details?
Could you provide ldd and version of the system in question.
- Timothy St. Clair
On Jan. 13, 2015, 6:47 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28082/#review63801
---
Ship it!
Ship It!
- Timothy St. Clair
On Nov. 15, 2014, 2:17
On Nov. 3, 2014, 9:59 p.m., Timothy St. Clair wrote:
src/launcher/fetcher.cpp, line 77
https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line77
we should probably bail here, if somehow the return is != 0 (isError()
|| false)
Ankur Chauhan wrote:
My
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59806
---
Ship it!
Ship It!
- Timothy St. Clair
On Nov. 4, 2014, 6:25 p.m
/#comment100942
we should probably bail here, if somehow the return is != 0 (isError() ||
false)
- Timothy St. Clair
On Nov. 3, 2014, 1:52 a.m., Ankur Chauhan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment100948
It seems weird that we would always try and fail on HDFS if the user had
specified http pulls. Given that we prefix check for curl pulls, perhaps we
should switch the case order, as the cost is low for a string check but the
cost is high for a HDFS check.
- Timothy St. Clair
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27252/#review58817
---
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 27, 2014, 11:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27252/#review58836
---
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 27, 2014, 11:22
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho
either
[action-if-not-given], or [action-if-give] but we should probably do both.
- Timothy St. Clair
On Oct. 23, 2014, 8:59 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
a push.
- Timothy St. Clair
On Oct. 14, 2014, 11:07 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426
e-mail. To reply, visit:
https://reviews.apache.org/r/25184/
---
(Updated Oct. 15, 2014, 2:23 a.m.)
Review request for mesos, Adam B and Timothy St. Clair.
Bugs: MESOS-1746
https://issues.apache.org/jira/browse/MESOS-1746
, and it passed my make check.
Could you please elaborate on your testing in the review.
- Timothy St. Clair
On Oct. 9, 2014, 2 p.m., Chengwei Yang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
On Oct. 14, 2014, 2:21 p.m., Timothy St. Clair wrote:
I tested locally but not to any great extent, and it passed my make check.
Could you please elaborate on your testing in the review.
On second ship-it + updated test comment I'll push post haste.
- Timothy
then nothing.
So I think we want all three modes, stripping all debug information is not
really idea.
- Timothy St. Clair
On Oct. 7, 2014, 10:38 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply
/
---
(Updated Oct. 14, 2014, 11:07 p.m.)
Review request for mesos, Benjamin Hindman and Timothy St. Clair.
Repository: mesos-git
Description
---
Reworks building mesos in debug vs. release. By default, mesos is now
built
On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote:
configure.ac, line 281
https://reviews.apache.org/r/26426/diff/1/?file=714874#file714874line281
Is there a reason you want to leave debug symbols out of optimized
builds?
cmake has the pattern correct imho
dylibs (symlink and regular) look
like compared to the previous style? Is it backwards compatible or needs
re-linking?
Timothy St. Clair wrote:
Right now it would work, but it will likely shift.
It would need relinking.
Given that the semantics may shift, perhaps the cleanest
---
Update docs to call out instructions for downstream packages.
Diffs
-
docs/getting-started.md 1602914
Diff: https://reviews.apache.org/r/26421/diff/
Testing
---
Thanks,
Timothy St. Clair
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26352/#review55678
---
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 6, 2014, 1:50 p.m
generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review54699
---
On Sept. 26, 2014, 3:31 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review54753
---
On Sept. 26, 2014, 3:31 p.m., Timothy St. Clair wrote
On Oct. 6, 2014, 1:30 p.m., Till Toenshoff wrote:
3rdparty/libprocess/configure.ac, line 99
https://reviews.apache.org/r/26352/diff/1/?file=714029#file714029line99
Is there a reason you are not adhering to that without_bundled_xxx
scheme we are using for other bundled libraries?
://reviews.apache.org/r/25865/#comment95626
Why not use api's and MS_REMOUNT?
- Timothy St. Clair
On Oct. 2, 2014, 6:23 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26273/#review55244
---
Ship it!
Ship It!
- Timothy St. Clair
On Oct. 2, 2014, 6:15 p.m
for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen,
and Timothy St. Clair.
Bugs: MESOS-1384
https://issues.apache.org/jira/browse/MESOS-1384
Repository: mesos-git
Description
---
Adding a first class primitive, abstraction and process for dynamic library
writing
On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
src/module/manager.cpp, line 173
https://reviews.apache.org/r/25848/diff/5/?file=701887#file701887line173
You could probably stick the json parsing into a separate sub-class.
I'm all for breaking out a small JIRA tree from
for phase 1. Thanks for
all the work guys!
We can open new JIRA's where needed.
- Timothy St. Clair
On Sept. 26, 2014, 11:26 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
.
Diffs (updated)
-
configure.ac 86d448c
src/Makefile.am 27c42df
Diff: https://reviews.apache.org/r/25551/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
St. Clair
On Sept. 6, 2014, 3:38 a.m., Chengwei Yang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25184/
---
(Updated Sept
a JIRA +
review.
- Timothy St. Clair
On July 11, 2014, 4:19 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22994
/r/25848/#comment94572
same comment as above.
src/module/manager.cpp
https://reviews.apache.org/r/25848/#comment94587
You could probably stick the json parsing into a separate sub-class. I'm
all for breaking out a small JIRA tree from the comments.
- Timothy St. Clair
On Sept. 23
On Sept. 24, 2014, 8:05 p.m., Timothy St. Clair wrote:
include/mesos/module.hpp, line 73
https://reviews.apache.org/r/25848/diff/5/?file=701882#file701882line73
Perhaps we can breakout in another JIRA, but I would to denote both
some form of AUTHORING as well as define api's
/r/25551/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
such that they
are = ?
- Timothy St. Clair
On Sept. 20, 2014, 12:21 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54165
---
Ship it!
Ship It!
- Timothy St. Clair
On Sept. 20, 2014, 12:21
/#review53837
---
On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695
On Sept. 18, 2014, 6:31 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, lines 1778-1792
https://reviews.apache.org/r/25695/diff/2/?file=690745#file690745line1778
So you never cleanup other cgroups (like memory) on machines with
systemd?
Timothy St. Clair wrote:
Correct, *never
` is used.
Timothy St. Clair wrote:
Could we determine what the root cause is before we through it out? I
would like to know why it is an issue.
Jie Yu wrote:
Yeah, we tried but couldn't find out the cause. That's the reason we have
the following patches:
```
commit
.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25695/#review53837
---
On Sept. 16, 2014, 6:19 p.m., Timothy St. Clair wrote
/containerizer/isolators/cgroups/cpushare.cpp b1cad47
Diff: https://reviews.apache.org/r/25695/diff/
Testing
---
systemctl start mesos-master mesos-slave
several runs of 'mesos execute' to verify creation and cleanup.
systemctl stop mesos-master mesos-slave
make check
Thanks,
Timothy St
/#comment93731
It would be nice to have metrics that are easy to gather, similar to what
is done on openstack. With one snapshot you can see details about the user.
The idea of spreading around reviews may be a bit difficult for folks who
are new to the project.
- Timothy St. Clair
On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote:
src/exec/exec.cpp, line 82
https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line82
Maybe I'm missing something, but is there a reason we don't check
before a delay? If ShutdownProcess is spawned, it's
Diff: https://reviews.apache.org/r/25695/diff/
Testing
---
systemctl start mesos-master mesos-slave
several runs of 'mesos execute' to verify creation and cleanup.
systemctl stop mesos-master mesos-slave
make check
Thanks,
Timothy St. Clair
://reviews.apache.org/r/25695/#review53534
---
On Sept. 16, 2014, 3:03 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
mesos-master mesos-slave
make check
Thanks,
Timothy St. Clair
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote:
src/master/hierarchical_allocator_process.hpp, line 837
https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837
What happens in the case where all CPUs are taken but memory is
available? It looks like
is consumed by the executor.
- Timothy St. Clair
On Sept. 13, 2014, 7:10 p.m., Martin Weindel wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035
', 'cpuacct']. In that way, whenever you want to
create/destroy a cgroup, we can do:
foreach (const string subsystem, subsystems) {
hierarchy = hierarchies[subsystem];
// create/destroy cgroup.
// ...
}
Let me know your thoughts or comments.
Timothy St. Clair wrote
class | struct to encapsulate.
This appears to be a general theme.
src/tests/containerizer.cpp
https://reviews.apache.org/r/25434/#comment92408
Manifest constant please.
- Timothy St. Clair
On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote
check
Thanks,
Timothy St. Clair
/#review53099
---
On Sept. 11, 2014, 7:56 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551
,
Timothy St. Clair
---
On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52898
---
Ship it!
Ship It!
- Timothy St. Clair
On Sept. 9, 2014, 2:49
of leveldb instead of
its git tree?
Timothy St. Clair wrote:
You're probably right. I didn't want to rethunk a tarball though.
Vinod Kone wrote:
can you try with replacing the bundled leveldb.tar.gz with this?
git archive -o leveldb.tar.gz --prefix=leveldb/ HEAD (# run
clean -xdf now removes the leveldb subdir.
- Timothy St. Clair
On Sept. 10, 2014, 4:30 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25508
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52717
---
Could you please rebase for clean apply.
- Timothy St. Clair
, 2014, 4:48 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25447/
---
(Updated Sept. 8, 2014, 4:48 p.m
On Sept. 9, 2014, 12:55 a.m., Vinod Kone wrote:
This probably needs a call out in the CHANGELOG so that people are not
surprised by it. Also, do you know of anyone using/depending on it? If yes,
this probably needs to go through a deprecation cycle.
Timothy St. Clair wrote
src/deploy/mesos-start-masters.sh.in 36641ec
src/deploy/mesos-start-slaves.sh.in 8661c8d
src/deploy/mesos-stop-masters.sh.in c85c977
src/deploy/mesos-stop-slaves.sh.in ea5b26a
Diff: https://reviews.apache.org/r/25447/diff/
Testing
---
make check make install
Thanks,
Timothy St
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25439/#review52610
---
Ship it!
Ship It!
- Timothy St. Clair
On Sept. 8, 2014, 2:27
/#comment91110
Don't you want --host= and --bridge=br(x), in the case where folks
configure bridges for vlans?
- Timothy St. Clair
On Sept. 2, 2014, 8:47 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply
: MESOS-1764
https://issues.apache.org/jira/browse/MESOS-1764
Repository: mesos-git
Description
---
Minor update to include package config file
Diffs
-
Makefile.am e4ffa35
Diff: https://reviews.apache.org/r/25355/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
/25355/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
On Aug. 26, 2014, 12:56 a.m., Timothy St. Clair wrote:
Sorry for the lag, I'm still catching up post #MesosCon
You can mark as submitted.
commit a56be86b950c2f64fa98d7f55488afbc7c68e468
Author: Chris Heller hellert...@gmail.com
Date: Tue Aug 26 11:08:01 2014 -0500
- Timothy
On Aug. 26, 2014, 12:39 a.m., Timothy St. Clair wrote:
Provided the license is ok, I'm a ship it!
Jie Yu wrote:
It has the same license as m4/acx_pthread.m4 which already exists in the
repo.
However, all of them are GNU with AC exception, do you think that's ok
Can we just do the compile check?
- Timothy St. Clair
On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25030
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25031/#review51469
---
Provided the license is ok, I'm a ship it!
- Timothy St. Clair
- Timothy St. Clair
On Aug. 15, 2014, 9:14 p.m., Chris Heller wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24407
. 20, 2014, 8:29 p.m.)
Review request for mesos, Ben Mahler and Timothy St. Clair.
Bugs: MESOS-1208
https://issues.apache.org/jira/browse/MESOS-1208
Repository: mesos-git
Description
---
Fixes `MESOS-1208`. The issue is that starting from GCC 4.8, `-Wall` includes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24816/#review51213
---
Ship it!
Ship It!
- Timothy St. Clair
On Aug. 20, 2014, 8:29
installations so I would not
change this one, it's a distribution only constraint at this point.
configure.ac
https://reviews.apache.org/r/24734/#comment88583
This needs to be here or else the includes fail on distributions.
- Timothy St. Clair
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote
://reviews.apache.org/r/20983/#review50690
---
On May 5, 2014, 7:13 p.m., Timothy St. Clair wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/24734/#comment88584
We could add a LIB check, but it's not critical at this point.
- Timothy St. Clair
On Aug. 15, 2014, 6:36 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50712
---
On Aug. 15, 2014, 1:07 a.m., Timothy St. Clair wrote:
---
This is an automatically
On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote:
configure.ac, line 283
https://reviews.apache.org/r/24734/diff/1/?file=661315#file661315line283
This needs to be here or else the includes fail on distributions.
Jie Yu wrote:
Are you saying that I should do
/
---
(Updated Aug. 15, 2014, 5:19 p.m.)
Review request for mesos, Timothy St. Clair and Vinod Kone.
Repository: mesos-git
Description
---
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other issues.
Also, did a few consistency/style fix
/
---
(Updated Aug. 15, 2014, 5:19 p.m.)
Review request for mesos, Timothy St. Clair and Vinod Kone.
Repository: mesos-git
Description
---
Merged the fix in https://reviews.apache.org/r/24714/
Fixed a few other
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24734/#review50772
---
Ship it!
Ship It!
- Timothy St. Clair
On Aug. 15, 2014, 6:58
=/opt/gmock make check
Thanks,
Timothy St. Clair
--disable-bundled make check
For prefixed installs require updated PYTHON_PATH.
Thanks,
Timothy St. Clair
/include/process/internal.hpp 9f478ec
3rdparty/libprocess/src/process.cpp c2bee98
configure.ac 321f09d
Diff: https://reviews.apache.org/r/24563/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
.
3rdparty/Makefile.am
https://reviews.apache.org/r/24264/#comment88486
should wrap with new build mechanics for checking system
configure.ac
https://reviews.apache.org/r/24264/#comment88485
We have a .m4 that can check python mods
- Timothy St. Clair
On Aug. 11, 2014, 6:09 p.m
/process/internal.hpp 9f478ec
3rdparty/libprocess/src/process.cpp c2bee98
configure.ac 321f09d
Diff: https://reviews.apache.org/r/24563/diff/
Testing
---
make check
Thanks,
Timothy St. Clair
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50590
---
On Aug. 14, 2014, 6:38 p.m., Timothy St. Clair wrote
.
Repository: mesos-git
Description
---
Fixes on glog check to support mac.
Diffs
-
3rdparty/libprocess/configure.ac f552e60
configure.ac 30a7e26
Diff: https://reviews.apache.org/r/24714/diff/
Testing
---
./configure --with-glog=/opt/local make check
Thanks,
Timothy St
installation.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24714/#review50639
---
On Aug. 14, 2014, 9:01 p.m., Timothy St. Clair
1 - 100 of 536 matches
Mail list logo
