Re: Review Request 22579: Add task health check and integrate with command executor

2014-07-11 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review47668 --- src/launcher/executor.cpp

Re: Review Request 22579: Add task health check and integrate with command executor

2014-07-11 Thread Timothy Chen
On July 11, 2014, 6:49 p.m., Connor Doyle wrote: src/launcher/executor.cpp, line 320 https://reviews.apache.org/r/22579/diff/9/?file=614436#file614436line320 Here, when Mesos kills an unhealthy task on the framework's behalf, it emits a StatusUpdate with a task state of

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-23 Thread Benjamin Hindman
On June 20, 2014, 6:57 p.m., Benjamin Hindman wrote: I've committed this! Thanks Tim! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review46301

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 20, 2014, 8:35 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-20 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review46301 --- Ship it! src/common/status_utils.hpp

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 20, 2014, 10:58 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 19, 2014, 6:26 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 20, 2014, 12:30 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-18 Thread Timothy Chen
On June 17, 2014, 7:57 p.m., Benjamin Hindman wrote: src/tests/health_check_tests.cpp, line 121 https://reviews.apache.org/r/22579/diff/3/?file=610312#file610312line121 Is this comment a relic from a copy-paste? If anything I think what you want to say here is something along the

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 18, 2014, 7:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review46102 --- Bad patch! Reviews applied: [22579] Failed command: make -j3

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review45938 --- Bad patch! Reviews applied: [22579] Failed command:

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 17, 2014, 5:59 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/#review45845 --- Awesome to see this Tim! I gave a really thorough review. Please

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-17 Thread Timothy Chen
On June 17, 2014, 7:57 p.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 588 https://reviews.apache.org/r/22579/diff/3/?file=610308#file610308line588 Just an FYI, the mesos-executor should get installed in the same place as mesos-health-checker so you should just be

Re: Review Request 22579: Add task health check and integrate with command executor

2014-06-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22579/ --- (Updated June 16, 2014, 6:23 p.m.) Review request for mesos and Niklas