Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-23 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Oct. 23, 2014, 10:39 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-20 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Oct. 20, 2014, 11:49 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review57407 --- Ship it! LGTM. Please add a comment about why ```isolate``` calls

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-17 Thread Ian Downes
On Oct. 7, 2014, 11:54 a.m., Jie Yu wrote: src/slave/containerizer/mesos/containerizer.cpp, lines 991-1002 https://reviews.apache.org/r/25861/diff/2/?file=711202#file711202line991 Can you use f.onAny here so that you don't need to change the signature of `___destroy`? Appears to

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-15 Thread Ian Downes
On Oct. 14, 2014, 1:51 p.m., Timothy Chen wrote: src/slave/containerizer/mesos/containerizer.cpp, line 1022 https://reviews.apache.org/r/25861/diff/3/?file=721061#file721061line1022 Not sure if I'm missing something, but if you chain all lambdas with .then, only the last one will

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-14 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Oct. 14, 2014, 1:34 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review56569 --- src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review55674 --- src/slave/containerizer/mesos/containerizer.cpp

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Oct. 3, 2014, 10:05 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-10-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- (Updated Oct. 2, 2014, 11:22 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review54619 --- lgtm, modulo comments. i'll let jie give the final shipit.

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-09-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review54307 --- src/slave/containerizer/mesos/containerizer.hpp

Re: Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-09-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review54462 --- Have you considered using an accumulator function so that you can

Review Request 25861: Serialize isolator prepare and cleanup (reversed).

2014-09-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git