---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60136
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60139
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60142
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60147
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60159
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60163
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60173
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60182
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60192
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60008
---
src/launcher/fetcher.cpp
On Nov. 5, 2014, 7:29 a.m., Timothy Chen wrote:
src/tests/fetcher_tests.cpp, line 121
https://reviews.apache.org/r/27483/diff/9/?file=750212#file750212line121
How does this test work with a bogus url?
Ankur Chauhan wrote:
I used it because it was mentioned in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 5, 2014, 7:57 p.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60020
---
src/launcher/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60032
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 5, 2014, 9:24 p.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60040
---
looking goood. minor fixes and i'll get this committed.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 5, 2014, 10:07 p.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60049
---
Ship it!
Thanks! I'll get this committed once 0.21.0 is cut.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60054
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
On Nov. 5, 2014, 10:12 p.m., Vinod Kone wrote:
Thanks! I'll get this committed once 0.21.0 is cut.
Thanks! And really appreciate all the input, help and hand holding. It's been a
long time since I touched C++. Future patches would probably require less
handholding.
Thanks everyone..
On Nov. 5, 2014, 10:12 p.m., Vinod Kone wrote:
Thanks! I'll get this committed once 0.21.0 is cut.
Ankur Chauhan wrote:
Thanks! And really appreciate all the input, help and hand holding. It's
been a long time since I touched C++. Future patches would probably require
less
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60091
---
src/launcher/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 6, 2014, 3:18 a.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60102
---
Bad patch!
Reviews applied: [27483]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60105
---
Bad patch!
Reviews applied: [27483]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 6, 2014, 4:12 a.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60107
---
Hey Ankur. Can you send a new review instead of re-opening this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60116
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60123
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60127
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review60131
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
On Nov. 3, 2014, 9:59 p.m., Timothy St. Clair wrote:
src/launcher/fetcher.cpp, line 77
https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line77
we should probably bail here, if somehow the return is != 0 (isError()
|| false)
Ankur Chauhan wrote:
My
On Nov. 3, 2014, 9:59 p.m., Timothy St. Clair wrote:
src/launcher/fetcher.cpp, line 77
https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line77
we should probably bail here, if somehow the return is != 0 (isError()
|| false)
Ankur Chauhan wrote:
My
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 6:25 p.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59798
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59806
---
Ship it!
Ship It!
- Timothy St. Clair
On Nov. 4, 2014, 6:25
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 7:47 p.m.)
Review request for mesos, Timothy Chen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59819
---
Ship it!
Ship It!
src/launcher/fetcher.cpp
On Nov. 4, 2014, 8:07 p.m., Timothy Chen wrote:
Ship It!
Vinod you have any more comments?
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59819
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59842
---
src/launcher/fetcher.cpp
On Nov. 4, 2014, 9:46 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, line 223
https://reviews.apache.org/r/27483/diff/7/?file=748389#file748389line223
Why fall through if result.isError()?
The way I am thinking of the logic of fetchers is on the lines of we try all
fetchers one
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 10:20 p.m.)
Review request for mesos, Timothy Chen,
On Nov. 4, 2014, 9:46 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, line 223
https://reviews.apache.org/r/27483/diff/7/?file=748389#file748389line223
Why fall through if result.isError()?
Ankur Chauhan wrote:
The way I am thinking of the logic of fetchers is on the lines
On Nov. 4, 2014, 9:46 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, line 223
https://reviews.apache.org/r/27483/diff/7/?file=748389#file748389line223
Why fall through if result.isError()?
Ankur Chauhan wrote:
The way I am thinking of the logic of fetchers is on the lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 5, 2014, 6:39 a.m.)
Review request for mesos, Timothy Chen,
On Nov. 4, 2014, 9:46 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, line 223
https://reviews.apache.org/r/27483/diff/7/?file=748389#file748389line223
Why fall through if result.isError()?
Ankur Chauhan wrote:
The way I am thinking of the logic of fetchers is on the lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59934
---
This may be a side issue but I noticed in a run of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59935
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59644
---
src/launcher/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59653
---
src/launcher/fetcher.cpp
On Nov. 3, 2014, 10:10 p.m., Timothy St. Clair wrote:
src/launcher/fetcher.cpp, line 219
https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line219
It seems weird that we would always try and fail on HDFS if the user
had specified http pulls. Given that we prefix
On Nov. 3, 2014, 9:59 p.m., Timothy St. Clair wrote:
src/launcher/fetcher.cpp, line 77
https://reviews.apache.org/r/27483/diff/1/?file=746870#file746870line77
we should probably bail here, if somehow the return is != 0 (isError()
|| false)
My thinking here was: In case of a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 3, 2014, 11:09 p.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59673
---
src/hdfs/hdfs.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59674
---
src/launcher/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 3, 2014, 11:42 p.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59681
---
src/launcher/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 12:02 a.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59682
---
src/hdfs/hdfs.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59693
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
On Nov. 4, 2014, 12:12 a.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, line 230
https://reviews.apache.org/r/27483/diff/3/?file=747858#file747858line230
Why the fall through to HDFS here?
My reasoning is that if hadoop client is configured with some
ftp/ftps/http/https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 1 a.m.)
Review request for mesos and Timothy St. Clair.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 4, 2014, 1:04 a.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59723
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 3, 2014, 1:52 a.m.)
Review request for mesos and Timothy St.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
Review request for mesos.
Summary (updated)
-
Fetcher uses
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/
---
(Updated Nov. 2, 2014, 3:55 a.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27483/#review59515
---
Patch looks great!
Reviews applied: [27483]
All tests passed.
-
68 matches
Mail list logo
