---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80659
---
Ship it!
LGTM, assuming we reach a consensus on the style issues.
On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80018
---
Ship it!
LGTM assuming the changes only involve code move only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---
(Updated April 14, 2015, 2:20 p.m.)
Review request for mesos, Adam B, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80072
---
src/authentication/cram_md5/authenticatee.cpp
On April 14, 2015, 7:22 p.m., Kapil Arya wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
According to our style guide, this is okay but we keep seeing issues
being raised about this. Should
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---
(Updated April 15, 2015, 12:44 a.m.)
Review request for mesos, Adam B, Joris
On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
Kapil
On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
Thanks a bunch for your review Alex, much appreciated.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80020
---
src/authentication/cram_md5/authenticatee.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80082
---
src/authentication/cram_md5/authenticatee.cpp
On April 14, 2015, 10:16 a.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
According
On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
src/authentication/cram_md5/authenticatee.cpp, line 33
https://reviews.apache.org/r/32850/diff/4/?file=927033#file927033line33
Actually according to Google's styleguide this should be the first
include, shouldn't it?
On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
src/authentication/cram_md5/authenticatee.cpp, line 33
https://reviews.apache.org/r/32850/diff/4/?file=927033#file927033line33
Actually according to Google's styleguide this should be the first
include, shouldn't it?
On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review78876
---
Patch looks great!
Reviews applied: [32850]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
---
Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.
17 matches
Mail list logo