Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-145392109
Please see #56 ... Tried many things, and yes it was reproducable on my Mac
:-)
---
If your project is set up for it, you can reply to this email and have your
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101294
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java ---
@@ -78,7 +87,24 @@ public ExcelDataContext getDataContext() {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101201
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java ---
@@ -209,13 +205,13 @@ protected void onSchemaCacheRefreshed() {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101077
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java ---
@@ -209,13 +205,13 @@ protected void onSchemaCacheRefreshed() {
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101020
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java ---
@@ -209,13 +205,13 @@ protected void onSchemaCacheRefreshed() {
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41100980
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java ---
@@ -78,7 +87,24 @@ public ExcelDataContext getDataContext() {
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-139346801
Yeah, but I'm pretty sure it is somehow timing related, so I'll bet that
users will see it too. There's nothing that should be Travis specific.
---
If your project is se
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-139346283
Damn. And we only see this happen on Travis, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-139151999
Okay, I'm officially giving up on this approach. I'm not sure, but the main
issue seems to be the mixing of write-only SXSSFWorkbook and read-write
XSSFWorkbook.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-13902
Seems Travis is exploding. JVM segfaults in both 7 and 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-138859494
Added :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-138859162
+1
Code looks good to me.
Nice findings wrt. memory improvement and "good enough" documentation for
me to prove it.
Minor: I am missing a J
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/49#issuecomment-138855818
Memory usage on a huge file, 50 MB/ ~100 million records (Excel max).
InputStream:
