Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/857
Got busy with too many things happening around me, will yield this a
conclusion next week.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/830
@nickwallen resolve the conflicts
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/857
@merrimanr renamed the variable POLLING_DEFAULT_STATE to DISABLE_POLLING
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/857#discussion_r155219994
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -38,5 +38,6 @@ export let TREE_SUB_GROUP_SIZE = 5;
export let
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/857
@merrimanr
- I removed the node version check in the ui code
- The browser.sleep is used in following areas
- When we are using methods like waitForText, few times I see the
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/857
METRON-1340: Improve e2e tests for metron alerts
## Contributor Comments
This PR aims to improve the existing e2e tests of metro-alerts in the areas
mentioned below. The PR doesn'
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen This is unfortunate I am not seeing these failures
Spec started
login to application
â should display error message for invalid credentials
â should
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Added the test case for searching an alert inside meta-alert.
Also took the liberty to fix the timezone issue it was a one-liner.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I will raise a jira to track this. Even if we are able to
reproduce this issue it is unlikely bcoz this PR.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen can you raise a jira to track this. I guess even if we are able
to reproduce I highly doubt if it is bcoz of changes in this PR.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen That looks wicked can you share your manual steps that lead to
this?
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Thanks for
https://github.com/iraghumitra/incubator-metron/pull/5. It was a pretty
significant issue. I merged the fix ð
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen I am not refreshing on purpose. If I refresh the UI after any
operation users would lose the current context and see new alerts (If
available). If you think this is not a major
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I noticed that when I am running e2e test's, the comments that were added
in the previous run are still visible at times. The e2e tests delete's all the
comments that it added and th
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet Thanks for taking time to test the PR. I was using an incorrect
index to find the alert to delete when I implemented the new API's I fixed it
now. Also added tests for all the i
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet my bad. The search query to fetch all the alerts in a group was
returning a nested object since I was passing 'source: type' twice in the
fields. I don't know why
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet my bad. The search query to fetch all the alerts in a group was
returning a nested object since I was passing 'source: type' twice in the
fields. I don't know why
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
Merged the PR with master and used new API's for creating meta-alerts.
Please feel free to review and let me know the feedback.
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r151964471
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.scss
---
@@ -143,3 +167,12 @@ textarea {
.comment
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
+1 for functionality all the API's are working fine. Great job @merrimanr
ð
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
@merrimanr @justinleet tested the new API's they are working fine the only
issue I see is
>>When a meta alert is created the meta alert is returned as part of the
group api wh
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/832
@nickwallen really liked the way you annotated the PR with your comments.
You made it really easy to understand and saved a lot of time for me. As you
rightly pointed out I will wait till all
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/825
+1 for functionality, tested on full dev when status is changed on a
meta-alert all the alerts in the meta-alert are updated with the correct status
---
GitHub user iraghumitra reopened a pull request:
https://github.com/apache/metron/pull/830
METRON-1298: TimeRange Picker doesn't work on Safari
## Contributor Comments
The Time Range component is not working in mac Safri b'coz of the way
Safari handles stri
Github user iraghumitra closed the pull request at:
https://github.com/apache/metron/pull/830
---
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/830
METRON-1298: TimeRange Picker doesn't work on Safari
## Contributor Comments
The Time Range component is not working in mac Safri b'coz of the way
Safari handles string to date c
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
I have tested the rest-api I am able to see the alert details for all
alerts under meta alerts
I see a couple of new issues:
- When a meta alert is created the meta alert is
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr Looks like the following rest-api's are not working as expected
- When a meta alert is created and when we try to group by an IP
address(ip_dst_addr/ip_src_addr) the IP addre
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr is HBase running these errors are typically seen when HBase is
down.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@merrimanr METRON-1272 has broken few of our assertions and these are
cascaded failures bcoz of them. I am working on fixing them.
---
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/819
METRON-1267: Alerts UI returns a 404 when refreshing the alerts-list page
Fixed the 404 error when refreshing alerts-ui(added the missing base-dir
path).
Looks like the last fix didn&#
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I had to force push the last merge since I was facing issues with github.
---
GitHub user iraghumitra reopened a pull request:
https://github.com/apache/metron/pull/803
Metron-1252: Build ui for grouping alerts into meta alerts
## Contributor Comments
The purpose of the PR is to provide GUI for grouping multiple alerts into a
meta alert, the rest api for
Github user iraghumitra closed the pull request at:
https://github.com/apache/metron/pull/803
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146991821
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -337,12 +343,67 @@ export class
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr I have added e2e tests as suggested and merged your PR too. Plz,
let me know if I missed anything. I had to omit assertions for a couple of
quick ranges as they can cause trouble when
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr @james-sirota There was a bug in handling the recent searches
that were in old format can you check it now. Sorry for the trouble
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr can you clear browser cache and try? There is a change in save
query model my bad I missed mentioning it.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
I added a single test case which covers the entire workflow of meta-alert.
I couldn't think of a way to decompose it into smaller cases without making
them dependent on each other
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/803
@nickwallen your observation is right. As mentioned in the Limitations
section of CC, as of now we are not displaying the meta-alerts in the group
view. Hence I didn't see a need to f
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr plz find my replies
- when I open the date/time range picker why does it say "now/d"? I would
expect just "now" or "Now" - Changed to now
- when
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146216800
--- Diff: metron-interface/metron-alerts/src/styles.scss ---
@@ -259,4 +259,61 @@ hr {
padding: 0;
}
-
+/** Custom Radio box
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146216580
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed to the
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146205835
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -38,22 +41,27 @@ export class UpdateService {
constructor
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146205224
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed to the
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146204676
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts
---
@@ -175,7 +175,7 @@ describe('metron-alerts tree
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/803
Metron-1252: Build ui for grouping alerts into meta alerts
## Contributor Comments
The purpose of the PR is to provide GUI for grouping multiple alerts into a
meta alert, the rest api for
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
Fixed conflicts and added test cases for comments in the tree view.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/710
@nickwallen we can make the fields configurable too.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/710
@nickwallen The idea is to have the Facets and Groups in sync with the
table column names at the same time avoid the ones that might be too discrete.
I will have a discussion around what'
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/710
@nickwallen The PR was raised before I go to know about the concept of
squash commits mind me for my ignorance. I had to make few modifications since
a PR that was raised after this got in to
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r144592599
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r144372796
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -32,13 +33,31 @@ export class UpdateService
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/788#discussion_r144335342
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -133,6 +173,40 @@ export class
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@ottobackwards that's a good suggestion can you create a ticket with some
more details about new quick filters and any design that you have in mind. I
would be happy to pick it up as a follow-on
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/787
@nickwallen @mmiklavc @merrimanr replies are inline in the review
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r143772168
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -32,13 +33,31 @@ export class UpdateService
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r143771524
--- Diff:
metron-interface/metron-alerts/src/app/shared/directives/alert-search.directive.ts
---
@@ -130,7 +130,7 @@ export class AlertSearchDirective
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r143731034
--- Diff:
metron-interface/metron-alerts/src/app/shared/directives/alert-search.directive.ts
---
@@ -130,7 +130,7 @@ export class AlertSearchDirective
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@nickwallen I kind of agree with @justinleet here. The rest api is should
handle empty values in a better way.
Though we can circumvent the empty values issue in groups by assuming all
the
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r143715850
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/796
Initial commit for time-range selection for search
## Contributor Comments
This PR adds a time-range selector for search bar in alerts-ui. The
time-range selectors have the following
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@merrimanr Added e2e tests for escalation actions in tree view
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@merrimanr oops missed the comment thanks for letting me know again. I will
add a test case for tree bulk actions. Looks like e2e for drag-drop is going to
be tough I tried a bit but could not
Github user iraghumitra closed the pull request at:
https://github.com/apache/metron/pull/787
---
GitHub user iraghumitra reopened a pull request:
https://github.com/apache/metron/pull/787
METRON-1232: Alert status changes are not reflected in list view
## Contributor Comments
The Jira has all the description of the issue.
In addition, the e2e test for removing search
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/788
METRON-1223: Support for adding comments to alerts
## Contributor Comments
This PR adds support for adding arbitrary text notes to an alert. This can
be achieved by using METRON-1051.The
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/787
METRON-1232: Alert status changes are not reflected in list view
## Contributor Comments
The Jira has all the description of the issue.
In addition, the e2e test for removing search
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards & @merrimanr Fixed the following
- Disabling the ungroup button when no groups are selected
- Fixed issue with select all alerts in tree view
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r142671246
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts
---
@@ -0,0 +1,183 @@
+///
+/**
+ * Licensed to
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@merrimanr I will check the escalation actions, I guess I missed something
there.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards Good to hear the build issue is out of the way I was going
nowhere in figuring out the build failure.
- The ungroup button does nothing when alerts are not grouped. I feel we
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards If you dont mind can you give me exact steps to simulate the
installation issue. I seem to miss something here.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
Looks like the problem is not with the build but with starting
metron-config ui on the VM. Are you using fedora instead of centos by any
chance?.
AFAIU some script is missing shell
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards can u check it now I merged master again looks like mpack is
in now.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/771
+1 works as described ...
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards Done please have a look ...
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
+1
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
I wanted to suggest as a follow-on PR too, my bad missed it during the
first round of review.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/771
Tested, the UI redirects to log-in after the timeout. Should we show a
message on the login page that session timeout happened ?.
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/762#discussion_r140751012
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-details.po.ts ---
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
@merrimanr I uncovered the issue when I was trying to integrate METRON-1189
to METRON-1123. I handled it in PR #768, the fix is to empty the selection list
whenever we get new data. This would
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/768
Metron 1123: Add group by option using faceted search capabilities of
metron-rest-api
## Contributor Comments
This PR extends the Metron Alerts GUI capabilities to do group by on Alerts
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
Should we use saveRefreshState() and restoreRefreshState() when the
escalation rest API's are in progress? This will ensure that the page doesn't
get refreshed and users would not los
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/762
@merrimanr tested the UI works as explained in the comments
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/762#discussion_r139988431
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts
---
@@ -0,0 +1,58
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/756
METRON-1182: Refactored AlertList View to abstract displaying of individual
alertsâ¦
â¦, this will help us to have different views for displaying individual
alerts
## Contributor
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/700
@merrimanr I have made services similar to rest classes. I had to rename
few files, classes and variables.
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137454070
--- Diff: metron-interface/metron-alerts/src/app/service/alert.service.ts
---
@@ -39,21 +41,31 @@ export class AlertService {
private
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137454061
--- Diff:
metron-interface/metron-alerts/src/app/service/cluster-metadata.service.ts ---
@@ -16,14 +16,20 @@
* limitations under the License
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137454065
--- Diff:
metron-interface/metron-alerts/src/app/utils/metron-rest-api-utils.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/700
@merrimanr I moved the rest-api calls to services
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/699
@merrimanr Updated readme with login instructions. Thanks for taking time
for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/699#discussion_r134542101
--- Diff: metron-interface/metron-alerts/e2e/login/login.e2e-spec.ts ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/702
@merrimanr Does the group by support pagination?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/710
Metron-1083: Add filters using faceted search capabilities of
metron-rest-api
## Contributor Comments
This PR is on top of
[METRON-1068](https://github.com/apache/metron/pull/699). This PR
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r134166875
--- Diff: metron-interface/metron-alerts/src/app/service/rest-api-impl.ts
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/699#discussion_r134088663
--- Diff: metron-interface/metron-alerts/e2e/login/login.e2e-spec.ts ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user iraghumitra closed the pull request at:
https://github.com/apache/metron/pull/526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user iraghumitra reopened a pull request:
https://github.com/apache/metron/pull/526
Metron-846: Add E2E tests for metron management ui
## Contributor Comments
This PR adds e2e test support for management ui. We have few e2e tests in
management ui but they do not work on
1 - 100 of 153 matches
Mail list logo
