Re: [VOTE] release of MyFaces Core 2.1.8

2012-06-13 Thread Martin Koci
+1 Leonardo Uribe píše v St 13. 06. 2012 v 18:41 +0200: Hi, I was running the needed tasks to get the 2.1.8 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group

Re: [core] steps for release of myfaces core 2.1.8 / 2.0.14

2012-06-12 Thread Martin Koci
Hi, it would be nice to solve https://issues.apache.org/jira/browse/MYFACES-3191 - users ask for it, topic Weird partial-response behavior with 2 partial-response tags in user list. And a trivial one: https://issues.apache.org/jira/browse/MYFACES-3243 Leonardo Uribe píše v Po 11. 06. 2012 v

Re: [VOTE] Release of Extensions CDI (CODI) 1.0.5

2012-04-05 Thread Martin Koci
+1 Gerhard Petracek píše v Čt 05. 04. 2012 v 10:36 +0200: Hi, I was running the needed tasks to get the 12th release of Apache MyFaces Extensions CDI (aka MyFaces CODI) out. The artifacts are deployed to Nexus [1] (and [2]). The release contains the following modules: - CODI Core

Re: [VOTE] release of myfaces core 2.1.7

2012-04-05 Thread Martin Koci
+1 Leonardo Uribe píše v St 04. 04. 2012 v 00:42 -0500: Hi, I was running the needed tasks to get the 2.1.7 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group

Re: [core] performance: cache infos for views without build time modifications

2012-02-21 Thread Martin Koci
implementation and that can minimize String allocation in stateless/thread safe cases. Regards, Kočičák regards, Leonardo Uribe 2012/2/20 Martin Koci martin.kocicak.k...@gmail.com: Same situation for clientId: in stable component tree is clientId always the same (state saving depends

Re: [core] discussion about stateless jsf implementation

2012-02-21 Thread Martin Koci
Leonardo Uribe píše v Po 20. 02. 2012 v 19:04 -0500: Hi Hi, I did check only the original source code from blog some time ago and it I have found practically same problems as you. I have been studying the proposed code attached to MYFACES-3465. Unfortunately, I have found some issues with

Re: [core] performance: cache infos for views without build time modifications

2012-02-21 Thread Martin Koci
always find others 10 minor ;) (in every code) Leonardo Uribe píše v Út 21. 02. 2012 v 11:32 -0500: Hi 2012/2/21 Martin Koci martin.kocicak.k...@gmail.com: Leonardo Uribe píše v Po 20. 02. 2012 v 17:51 -0500: Hi Unfortunately we can't cache facelets generated unique ids

Re: [core] performance: cache infos for views without build time modifications

2012-02-20 Thread Martin Koci
and involves: findParentNamingContainer namingContainer.getContainerClientId stringBuilder appends renderer.convertClientId Martin Koci píše v Pá 17. 02. 2012 v 18:56 +0100: Hi, in situation, where no build-time tags (c:if, co:foreach, ...) and no ui:include src=#{} are used (and no direct

[core] performance: cache infos for views without build time modifications

2012-02-17 Thread Martin Koci
Hi, in situation, where no build-time tags (c:if, co:foreach, ...) and no ui:include src=#{} are used (and no direct component.getChildren() manipulation of course), builds VDL.buildView every time the same component structure (same graph). In this case compute myfaces some informations again

Re: [VOTE] Release of Extensions CDI (CODI) 1.0.4

2012-02-13 Thread Martin Koci
+1 Gerhard Petracek píše v Po 13. 02. 2012 v 17:59 +0100: Hi, I was running the needed tasks to get the 11th release of Apache MyFaces Extensions CDI (aka MyFaces CODI) out. The artifacts are deployed to Nexus [1] (and [2]). The release contains the following modules: - CODI Core

Re: [VOTE] release for myfaces master pom v 13

2012-01-23 Thread Martin Koci
+1 Leonardo Uribe píše v St 18. 01. 2012 v 09:18 -0500: Hi, I was running the needed tasks to get the version 13 release of Apache MyFaces Master POM. This release is necessary to update the site information about MyFaces contributors. Please note that this vote concerns all of the

Re: [VOTE] Release of Extensions CDI (CODI) 1.0.3

2012-01-09 Thread Martin Koci
+1 Gerhard Petracek píše v Ne 08. 01. 2012 v 21:21 +0100: Hi, I was running the needed tasks to get the 10th release of Apache MyFaces Extensions CDI (aka MyFaces CODI) out. The artifacts are deployed to Nexus [1] (and [2]). The release contains the following modules: - CODI Core

Re: [VOTE] release of myfaces core 2.1.2

2011-08-24 Thread Martin Koci
+1 Leonardo Uribe píše v Po 22. 08. 2011 v 23:28 -0500: Hi, I was running the needed tasks to get the 2.1.2 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group

Re: [core] performance: custom implicit objects

2011-08-09 Thread Martin Koci
Professional Support for Apache MyFaces 2011/8/8 Martin Koci martin.kocicak.k...@gmail.com Gerhard Petracek píše v Po 08. 08. 2011 v 16:36 +0200: hi martin, i think most users will be fine with the OpenWebBeansELResolverComparator [1] yes, this comparator moves OWB

[core] performance: custom implicit objects

2011-08-08 Thread Martin Koci
Hi, if user uses plain old JSF style with managed beans like: #{sessionScope.mySessionScopedBean} or #{requestScope.myRequestScopedBean} or #{requestScope.varFromDataTable.property} it can achieve excellent performance during render response phase, because every EL resolution takes only two

Re: [core] performance: custom implicit objects

2011-08-08 Thread Martin Koci
powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/8/8 Martin Koci martin.kocicak.k...@gmail.com Hi, if user uses plain old JSF style with managed beans like

Re: [core] performance: custom implicit objects

2011-08-08 Thread Martin Koci
://cwiki.apache.org/confluence/display/MYFACES/ELResolver +ordering http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/8/8 Martin Koci martin.kocicak.k...@gmail.com Hi

[core] performance: synchronized access for java.beans.PropertyDescriptor.getReadMethod()

2011-08-04 Thread Martin Koci
Hi, I'm testing a view where hundreds of concurrent users are expected. I noticed that java.beans.PropertyDescriptor.getReadMethod() is sychronized method and many times are other threads blocked with same lock (java.beans.PropertyDescriptor instance). Myfaces use it in _ComponentAttributesMap:

Re: [core] dynamic script before /body (an equivalent for DialogRequest from Trinidad)

2011-08-03 Thread Martin Koci
3, 2011, at 11:39 AM, Jakob Korherr wrote: Hi, Nope, I don't think so. Maybe you can achieve it via a javascript event-handler on the client, but I actually don't know for sure. Maybe Werner can help you out! Regards, Jakob 2011/8/2 Martin Koci martin.kocicak.k...@gmail.com

[core] dynamic script before /body (an equivalent for DialogRequest from Trinidad)

2011-08-02 Thread Martin Koci
Hi, has JSF an official API to achieve similar functionality as [1] ? Purpose and use case: 1) JSF process partially view 2) JSF artifact creates and queues a request render this script ... before /body 3) new element script is created and rendered before /body this is not same same

[core] lock profiling results for current myfaces

2011-07-27 Thread Martin Koci
Hi, I'm doing some profiling for a view, where thousand of concurrent users is planned. Configuration myfaces trunk, juel, tomcat 6.0.26, OWB trunk Here are the top blocking locks: 1) java.util.Collections$SynchronizedMap.get(Object) de.odysseus.el.tree.impl.Cache.get(String)

Re: MyFaces PMC += Martin Kočičák

2011-07-25 Thread Martin Koci
Hi, thanks Gerhard, but I'm not now sure if this += change is valid because my full (and real) name not Martin Kočičák :) :) but only Martin Kočí (haha). It is explained here: http://www.mail-archive.com/dev@myfaces.apache.org/msg48802.html Kočičák is only nickname, because Martin Kočí is

Re: [core] pushComponentToEL and #{component}

2011-07-25 Thread Martin Koci
between MyFaces and Mojarra. In my opinion what patches propose is correct, but we should ping the EG to see what they think about it and if it is valid to apply these changes on 2.0.x / 2.1.x branches. regards, Leonardo Uribe 2011/7/24 Martin Koci martin.kocicak.k...@gmail.com: Hi

Re: [core] pushComponentToEL and #{component}

2011-07-25 Thread Martin Koci
is not rendered (wrong) Leonardo Uribe píše v Po 25. 07. 2011 v 14:09 -0500: Hi 2011/7/25 Martin Koci martin.kocicak.k...@gmail.com: Hi, how can I help to ping EG? It seems that JSF-spec team has own working plan and no time for issues with no vote. About interoperability: I've double

[core] pushComponentToEL and #{component}

2011-07-24 Thread Martin Koci
Hi, please review patches for: https://issues.apache.org/jira/browse/MYFACES-3157 https://issues.apache.org/jira/browse/MYFACES-3126 Thanks, Kočičák

[core] code in ConverterTagHandlerDelegate.applyAttachedObject

2011-07-24 Thread Martin Koci
Hi, I'm doing some logging improvements for f:converter tag and I noticed folowing weird code - line 157: Object lv = vh.getLocalValue(); FacesContext faces = faceletContext.getFacesContext(); if (lv instanceof String) { vh.setValue(c.getAsObject(faces, parent, (String) lv)); } What

Re: [core] Improve error reporting and logging / General ErrorPage improvements (MYFACES-3213)

2011-07-11 Thread Martin Koci
Summary of proposed changes for ErrorPage: In header: - viewId, - location of facelet in filesystem - PhaseId In body: - info about component (that triggered the problem) - EL expression being evaluated, it's location, name of attribute/value pair - caused by: output first line of StackTrace

Re: [core] Purpose and usage of AbortProcessingException (MYFACES-3199)

2011-07-11 Thread Martin Koci
can introduce new param rethrowEveryListenerExceptionAsAPE to preserve current behaviour. Martin Koci píše v Čt 07. 07. 2011 v 14:10 +0200: Hi, what is purpose of AbortProcessingException in JSF API? Please see https://issues.apache.org/jira/browse/MYFACES-3199 Currently

[core] Improve error reporting and logging / General ErrorPage improvements (MYFACES-3213)

2011-07-08 Thread Martin Koci
Hi, please see attached screenshots at [1] and let me know what you think. What info do you find useful during development (and debugging) ? Thanks, Kočičák [1] https://issues.apache.org/jira/browse/MYFACES-3213

[core] Purpose and usage of AbortProcessingException (MYFACES-3199)

2011-07-07 Thread Martin Koci
Hi, what is purpose of AbortProcessingException in JSF API? Please see https://issues.apache.org/jira/browse/MYFACES-3199 Currently specification and myfaces work with it unconsistently. Do you have example of usage in your JSF applications? Regards, Kočičák

Re: [core] three issues with ViewExpiredException navigation

2011-06-29 Thread Martin Koci
Leonardo Uribe píše v Út 28. 06. 2011 v 16:11 -0500: Hi 2011/6/28 Martin Koci martin.kocicak.k...@gmail.com: Hi, to make things not so easy: https://issues.apache.org/jira/browse/MYFACES-3191 Maybe it is related, maybe not, but now it is not possible to perform navigation

Re: [core] three issues with ViewExpiredException navigation

2011-06-28 Thread Martin Koci
an ExceptionHandler handle exceptions thrown by itself without the risk of get stuck in a loop? regards, Leonardo Uribe 2011/6/27 Leonardo Uribe lu4...@gmail.com: Hi 2011/6/27 Martin Koci martin.kocicak.k...@gmail.com: Hi, Leonardo Uribe píše v Ne 26. 06. 2011 v 21:29 -0500: Hi I

Re: [core] three issues with ViewExpiredException navigation

2011-06-27 Thread Martin Koci
, but anyway we can expect more reports about ViewExpiredException in the future, because it is a common exception that occur in typical scenarios. regards, Leonardo Uribe 2011/6/26 Martin Koci martin.kocicak.k...@gmail.com: Hi, MYFACES-3189 and MYFACES-3188 are reproducible : please see

[core] h:form in h:form detection

2011-06-27 Thread Martin Koci
Hi, common problem: in multilevel templating developer losts context easily and puts a new h:form into exiting one. T thought that was already solved in myfaces codebase with some warning but I cannot find in now. Can you point me to the right direction? Thanks, Kočičák

Re: [core] three issues with ViewExpiredException navigation

2011-06-26 Thread Martin Koci
2011/6/25 Martin Koci martin.kocicak.k...@gmail.com Hi, please take a look at: https://issues.apache.org/jira/browse/MYFACES-3189 https://issues.apache.org/jira/browse/MYFACES-3188 https://issues.apache.org/jira/browse

[core] three issues with ViewExpiredException navigation

2011-06-25 Thread Martin Koci
Hi, please take a look at: https://issues.apache.org/jira/browse/MYFACES-3189 https://issues.apache.org/jira/browse/MYFACES-3188 https://issues.apache.org/jira/browse/MYFACES-3105 I'm not very familiar with navigation implementation - I cannot provide meaningful patches here. Thanks,

Re: [core] Firefox 4 - script in XHR executed 2x?

2011-06-21 Thread Martin Koci
Hi, ok, I'll investigate it more; I'll try isolate the problem in small reproducible example, if possible. Most likely is problem in my code. Thanks, Kočičák Werner Punz píše v Po 20. 06. 2011 v 22:33 +0200: Am 20.06.11 21:18, schrieb Martin Koci: Hi, I'm not very familiar

[core] Firefox 4 - script in XHR executed 2x?

2011-06-20 Thread Martin Koci
Hi, I'm not very familiar with JavaScript, so I ask first if it is bug or not: If script element is in XHR response, who is responsible for execute that script? I found [1] so I suppose that runScripts function does it in MyFaces. With Firefox 4 it seems that script is executed 2x: first time

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-06-18 Thread Martin Koci
); component.pushComponentToEL(context, null); Will be the same component pushed twice on stack? Regards, Kočičák Martin Koci píše v St 25. 05. 2011 v 22:12 +0200: Hi, there are such cases but not many of them: in myfaces code after quick search I guess about 10 such cases. The main

[core] performance: preinitialize facelets and analyze views (during startup)

2011-06-13 Thread Martin Koci
Hi, Can we find a way how to pre-initialize all .xhtml (Facelet instances) during startup? I think that can bring many improvements, for example: -- Minimize sychronized: populate all cached Value|MethodExpression on TagAttributeImpl (MYFACES-3160) - than we can remove volatile keyword

Re: [core] best way for editable table

2011-06-09 Thread Martin Koci
of the lifecycle to avoid unnecessary saves and restores. Werner Am 07.06.11 21:29, schrieb Martin Koci: Hi, how to do editable table in JSF? Not with all rows/cell in editable state, only with those ones which user switch with icon to update state

Re: [VOTE] release for myfaces core 2.1.1

2011-06-08 Thread Martin Koci
+1 Gerhard Petracek píše v St 08. 06. 2011 v 11:30 +0200: +1 regards, gerhard 2011/6/8, Werner Punz werner.p...@gmail.com: +1 Am 08.06.11 08:04, schrieb Leonardo Uribe: Hi, I was running the needed tasks to get the 2.1.1 release of Apache MyFaces core out. This is a

Re: Problem with Trinidad's uploads

2011-06-08 Thread Martin Koci
forward from us...@myfaces.apache.org: Hi, I tried you project and: 1) faces-config.xml is wrong, it needs faces-config as root element, not root 2) trinidad-config is wrong, it has filter element - this one belongs to web.xml and element uploaded-file-processor-settings with children does not

Re: Upload of folder content

2011-06-08 Thread Martin Koci
I think upload of folder is not possible with HTML4, so you must zip it. With HTML5 there will be some support for folder upload (I hope) and dragdrop upload. You can try also Cagatay's excellent primefaces - they have multiple Flash-based upload I think. Regards, Kočíčák jitechno píše v So

[core] best way for editable table

2011-06-07 Thread Martin Koci
Hi, how to do editable table in JSF? Not with all rows/cell in editable state, only with those ones which user switch with icon to update state. Example: a:column id=emailColumn a:inputText id=email value=#{rowData.email} / /a:column a:column h:commandButton value=Switch to update

Re: [core] best way for editable table

2011-06-07 Thread Martin Koci
Hi, yes I use 1. for small tables, but consider table 200 x 200. Then you must have required, displayValueOnly, disabled etc for each component - that means 200x200x3 evaluated expression during *one* JSF phase. Regards, Kočičák Werner Punz píše v Út 07. 06. 2011 v 22:05 +0200: opted

Re: [core] performance: avoid wrapped EL Expressions

2011-06-05 Thread Martin Koci
Hi, Leonardo Uribe píše v Pá 03. 06. 2011 v 15:38 -0500: Hi 2011/6/3 Martin Koci martin.kocicak.k...@gmail.com: Hi, the idea seems very good - but when is decided that expression does not uses some variable resolved by VariableResolver? Inside VariableMapperWrapper.resolveVariable

Re: [core] performance: avoid wrapped EL Expressions

2011-06-05 Thread Martin Koci
Hi, what problem is it? I know about excessive rendered evaluation: JAVASERVERFACES_SPEC_PUBLIC-941. value at EditableValueHolder can be evaluated 2x during one request/response. If it is another problem, can you create a jira issue, please? Thanks, Kočičák Kito Mann píše v Pá 03. 06. 2011

[core] EL improvements - summary

2011-06-03 Thread Martin Koci
Hi, summary of ExpressionLanguage-related improvements (done or in progress) 1) ELResolvers sorting: https://cwiki.apache.org/MYFACES/elresolver-ordering.htm 2) EL Resolvers filtering: MYFACES-3075 3) Disable JSP (and javax.faces.el) support: MYFACES-3078 4) cache ELExpressions:

Re: [core] performance: avoid wrapped EL Expressions

2011-06-03 Thread Martin Koci
Hi, the idea seems very good - but when is decided that expression does not uses some variable resolved by VariableResolver? TagAttributeImpl.getValue/MethodExpression methods are called in VDL.buildView - how is the check done? String parsing? Yes, I didn't look in the patch, its friday :)

[core] performance: avoid wrapped EL Expressions

2011-06-02 Thread Martin Koci
Hi, as discussed here: http://markmail.org/message/kca64ojdvb6em367?q=[core]+performance: +TagAttributeImpl+part+II:+object+allocations#query:[core]%20performance %3A%20TagAttributeImpl%20part%20II%3A%20object%20allocations+page:1 +mid:kca64ojdvb6em367+state:results and here:

Re: [core] TagAttributeImpl part II: object allocations (cache ELExpressions)

2011-05-31 Thread Martin Koci
. Additionally, use a volatile variable to store expressions. The patch adds a new web config param called org.apache.myfaces.CACHE_EL_EXPRESSIONS to enable/disable this feature. @Martin Koci: since you was the one proposing this optimization, it could be good if you can check if it is worth

Re: Clear Input Values

2011-05-30 Thread Martin Koci
Hi, javax.faces.component.EditableValueHolder.resetValue() and/or listener like http://myfaces.apache.org/trinidad/trinidad-api/tagdoc/tr_resetActionListener.html does not solve it? Kočičák Mark Struberg píše v Po 30. 05. 2011 v 13:19 +0100: Sounds like a good idea. But shouldn't that be

[core] support implicit object 'component' in renderers where getRendersChildren is true

2011-05-30 Thread Martin Koci
Hi, problem described in MYFACES-3157 applies for all cases where renderer reads property from child component. I think that only correct way in push child to EL before: child.pushComponentToEL() Object value = child.getValue(); String style = child.getStyle(); child.popComponentFromEL() Is

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-05-26 Thread Martin Koci
Martin Koci píše v St 25. 05. 2011 v 22:12 +0200: Hi, there are such cases but not many of them: in myfaces code after quick search I guess about 10 such cases. The main is in UIComponentBase.encodeChildren and in RendererUtils.renderChild (well, there was, but I removed it incorrectly as part

[core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-05-25 Thread Martin Koci
Hi, h:form h:panelGroup h:inputText id=testId rendered=#{component.id eq 'testId'} value=#{bean.value} / /h:panelGroup /h:form please notice the expression: rendered=#{component.id eq 'testId'} that is clearly

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-05-25 Thread Martin Koci
/JAVASERVERFACES_SPEC_PUBLIC but fix it on myfaces code. regards, Leonardo Uribe 2011/5/25 Martin Koci martin.kocicak.k...@gmail.com: Hi, h:form h:panelGroup h:inputText id=testId rendered=#{component.id eq 'testId

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

2011-05-25 Thread Martin Koci
that the context is setup and torn down around each call to isRendered. -- Blake Sullivan On 5/25/11 11:27 AM, Martin Koci wrote: Hi, for spec I've created bug few days ago: http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1002 but I didn't realize how deep impact

Re: [VOTE] release for myfaces core 2.1.0

2011-05-24 Thread Martin Koci
+1 Leonardo Uribe píše v Út 24. 05. 2011 v 13:29 -0500: +1 2011/5/24 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.1.0 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the

Re: [core] do not check for duplicate ids when saving view on production stage

2011-05-19 Thread Martin Koci
. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter

Re: [myfaces] ideas and things to do

2011-05-17 Thread Martin Koci
Gerhard Petracek píše v Út 17. 05. 2011 v 11:59 +0200: hi, imo we should prototype some jsf 2.2 features (at least in a branch). that would help the eg to specify some of the new features (like the window-id) easily and we can get the feedback of the whole community and we would have the

[core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

2011-05-13 Thread Martin Koci
Hi, two questions : 1) can UIComponent.rendererType be ValueExpression? If yes, in which situation is useful to use it? 2) should be rendereType saved during state saving? Each component has setRendererType(com.foo.renderer) in constructor and/or VDL calls setRendererType() after calling

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

2011-05-13 Thread Martin Koci
and rendererType I found nothing. Jakob Korherr píše v Pá 13. 05. 2011 v 16:11 +0200: Hi Martin, Have you checked the JSF 2.1 and 2.0 specs yet? Regards, Jakob 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Hi, two questions : 1) can UIComponent.rendererType

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

2011-05-13 Thread Martin Koci
, IceFaces) and search in their code for something like this? If you don't find anything there, then it should be pretty safe to remove the ValueExpression support from rendererType! Regards, Jakob 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Hi, from spec: .. Because

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

2011-05-13 Thread Martin Koci
to detect this component will be rendered in this lifecycle and cache renderer even for getClientId? stateManagement calls getClientId (checkIds) before component.encodeBegin. Can we use visitTree method for that? Kočičák regards, Leonardo 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

2011-05-13 Thread Martin Koci
component with clientId from renderer1! Is that ok? Leonardo Uribe píše v Pá 13. 05. 2011 v 15:45 -0500: Hi 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Leonardo Uribe píše v Pá 13. 05. 2011 v 14:59 -0500: Hi +1 to both changes. That means: replace StateHelper

Re: [core] do not check for duplicate ids when saving view on production stage

2011-05-11 Thread Martin Koci
+1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards,

[core] performance: use indices instead of iterator (MYFACES-3130)

2011-05-10 Thread Martin Koci
Hi, in current codebase, myfaces use mostly enhanced loop for iterating over chidren: for (UIComponent child: getChildren()) that creates new instance of iterator. After change to plain old indices: for (i = 0; i childCount; i++) child = getChildren().get(i); I achieved following results

Re: [core] performance: use indices instead of iterator (MYFACES-3130)

2011-05-10 Thread Martin Koci
of List. On Tue, May 10, 2011 at 4:11 PM, Martin Koci martin.kocicak.k...@gmail.com wrote: Hi, in current codebase, myfaces use mostly enhanced loop for iterating over chidren: for (UIComponent child: getChildren()) that creates new instance of iterator. After change to plain

Re: [core] tasks for release myfaces core 2.0.6 and 2.1.0-rc

2011-05-09 Thread Martin Koci
Hi, I see one big issue: https://issues.apache.org/jira/browse/MYFACES-3117 That may require a change in server state management, so I suggest solve it before first 2.1 release Another one is a big performance improvement: https://issues.apache.org/jira/browse/MYFACES-3130 that needs discussion.

Re: [core] performance: performance hints

2011-04-26 Thread Martin Koci
Hi, Leonardo Uribe píše v Po 25. 04. 2011 v 12:45 +0200: Hi 2011/4/19 Martin Koci martin.kocicak.k...@gmail.com Hi, is it possible to introduce performance hints in myfaces-core? Hints similar to javax.faces.component.visit.VisitHint but related

[core] performance: performance hints

2011-04-19 Thread Martin Koci
Hi, is it possible to introduce performance hints in myfaces-core? Hints similar to javax.faces.component.visit.VisitHint but related to performance improvements. Example: For dataTable like: a:dataTable a:column #{aExpression} it's completely unnecessary to save per-row state. Currently

Re: [VOTE] release for myfaces core 2.0.5

2011-04-05 Thread Martin Koci
+1 Regards, Kočičák Leonardo Uribe píše v Út 05. 04. 2011 v 01:02 -0500: +1 2011/4/5 Leonardo Uribe lu4...@gmail.com Hi, I was running the needed tasks to get the 2.0.5 release of Apache MyFaces core out. The artifacts passed

Re: [core] performance: ELResolvers filtering

2011-04-04 Thread Martin Koci
://issues.apache.org/jira/browse/MYFACES-3104 MyFaces 2 with EL ? 2.2 in Websphere 7 regards, Leonardo Uribe 2011/3/17 Martin Koci martin.kocicak.k...@gmail.com This approach cannot filter two resolvers: 1. org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver

Re: [core] performance: an optimal ELResolvers chain for POJO-based apps

2011-03-29 Thread Martin Koci
,sort,filter and transform. Then we can provide a lenient BeanELResolver implementation with behaviour: if base does not have the property returns null and allows next resolver to take charge of getValue. WDYT? Kočičák Martin Koci píše v Po 28. 03. 2011 v 20:50 +0200: Hi, I'm optimizing render

[core] performance: an optimal ELResolvers chain for POJO-based apps

2011-03-28 Thread Martin Koci
Hi, I'm optimizing render response on a large view (takes over 3 secs to render) and below you can see results of unsorted and unfiltered ELResolvers chain. The most important info is that BeanELResolver resolves property over 4x from 64000 invocations. The second place belongs to

Re: [core] performance: an optimal ELResolvers chain for POJO-based apps

2011-03-28 Thread Martin Koci
the number for ImplicitObjectResolver, not for BeanELResolver. Regards, Kočičák Mark Struberg píše v Po 28. 03. 2011 v 19:57 +0100: your numbers imply that one uses JSF @ManagedBeans, isn't? LieGrue, strub --- On Mon, 3/28/11, Martin Koci martin.kocicak.k...@gmail.com wrote: From: Martin Koci

Re: [core] performance: ELResolvers filtering

2011-03-17 Thread Martin Koci
be achieved by filtering out the unwanted resolver with predicate and adding own in faces-config (and sort it to proper position in chain) Regards, Kočičák Martin Koci píše v St 16. 03. 2011 v 11:29 +0100: Hi, after few months I have time to do some performance optimalization for myfaces

[core] performance: ELResolvers filtering

2011-03-16 Thread Martin Koci
Hi, after few months I have time to do some performance optimalization for myfaces. This one is related to topic http://www.mail-archive.com/dev@myfaces.apache.org/msg49177.html Problem: how to disable ELResolver smartly? Adding a context-param for each is an overkill. But we have

Re: [core] performance: ELResolvers filtering

2011-03-16 Thread Martin Koci
, 3/16/11, Martin Koci martin.kocicak.k...@gmail.com wrote: From: Martin Koci martin.kocicak.k...@gmail.com Subject: [core] performance: ELResolvers filtering To: dev@myfaces.apache.org Date: Wednesday, March 16, 2011, 10:29 AM Hi, after few months I have time to do some

Re: submittedValue vs. Converter.getAsObject

2011-03-03 Thread Martin Koci
Uribe Martin Koci píše v Čt 23. 09. 2010 v 21:40 +0200: Hi, I've just read Leonardo's post at jsr-314-open about this problem. FYI: I have finished prototype of JSF server side solution with non-String communication. It's based on custom renderkit and ResponseWriter implementation. I

Re: [VOTE] Release of Extensions CDI (CODI) 0.9.3

2011-02-28 Thread Martin Koci
+1 Regards, Martin Kočí Gerhard Petracek píše v Po 28. 02. 2011 v 14:22 +0100: Hi, I was running the needed tasks to get the 4th release of Apache MyFaces Extensions CDI (aka MyFaces CODI) out. The artifacts are deployed to Nexus [1] (and [2]). The release contains the following

Re: [VOTE] release for myfaces core 2.0.4

2011-02-09 Thread Martin Koci
+1 Leonardo Uribe píše v St 09. 02. 2011 v 01:07 -0500: Hi, I was running the needed tasks to get the 2.0.4 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group

Re: [core] ajax @this with non trivial component

2011-01-20 Thread Martin Koci
Hi Andy, thank you for explanation. Myfaces do only the first part: (1) This value will (or, well, should) be passed in as thefirst argument to jsf.ajax.request() but the second (2) and used as the replacement for @this targets. in not implemented yet:

[core] ajax @this with non trivial component

2011-01-14 Thread Martin Koci
Hi, if component is represented on client like: span id=clientId label id=clientId_label for=clientId_input a Label /label input id=clientId_input onchange=jsf.ajax.request(...execute: '@this' ...) /span what will be in HTTP reuqest? execute = clientId_input - but this is only

Re: [core] Improve error reporting and logging

2011-01-11 Thread Martin Koci
Hi, I will do it for Czech and Slovak: MYFACES-3014. Not very frequent languages, though - but 10 491 492 (CZ) + approx 5 mil (SK) inhabitants (samt Kindern und Rentnern) of Czech + Slovak Republic will appreciate it :) Werner Punz píše v Út 11. 01. 2011 v 15:13 +0100: Btw. I did some work

Re: [core] Improve error reporting and logging

2011-01-11 Thread Martin Koci
about parent and path to component, phase id etc. Kočičák Werner Punz píše v Út 11. 01. 2011 v 15:12 +0100: ++1 Werner Am 10.01.11 20:06, schrieb Martin Koci: Hi, the most wanted feature which our coders want is more consistent and human-readable error reporting and logging

[core] Improve error reporting and logging

2011-01-10 Thread Martin Koci
Hi, the most wanted feature which our coders want is more consistent and human-readable error reporting and logging. Here is a example: If user specifies f:ajax without eventName for a component without defaultEventName, myfaces throw a execption: Now (myfaces 2.0.3): eventName could not be

[core] UISelectItem(s) questions

2010-11-24 Thread Martin Koci
Hi, following things are specified by spec, but maybe someone will know reasons: 1) why UISelectOne/Many classes don't have method like ListSelectItem getSelectItems currently each renderkit has own method with similar purpose but with different quality and bugs :) for example, myfaces have

[test] testNG and EL impl in myfaces-test

2010-11-01 Thread Martin Koci
Hi, two questions: 1) 12 test cases in myfaces-api and myfaces-impl use @Test from org.testng.annotations, 56 test cases use @org.junit.Test. What is the primary test engine for myfaces? I'm trying to provide patch for MYFACES-2882 and UIViewRootTest uses TestNG: how to use

Re: EL method invocation performance

2010-10-28 Thread Martin Koci
2010/10/19 Martin Koci martin.kocicak.k...@gmail.com Hi, some news about EL method invocations: 1) Geronimo EL API implementation has this problem too: https://issues.apache.org/jira/browse/GERONIMO-5657 2) UEL bug

Re: [core] performance: TagAttributeImpl part II: object allocations

2010-10-25 Thread Martin Koci
. Suggestions are welcome! Regards, Jakob 2010/10/21 Martin Koci martin.kocicak.k...@gmail.com: Hi, another performance related problem in TagAttributeImpl: ValueExpression instances

[core] performance: TagAttributeImpl part II: object allocations

2010-10-21 Thread Martin Koci
Hi, another performance related problem in TagAttributeImpl: ValueExpression instances. Consider a facelets view with 3000 attributes. Then during buildView method TagAttributeImpl.getValueExpression allocates: 1) one instance of ValueExpression via ExpressionFactory.createValueExpression 2)

[core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Martin Koci
Hi, a issue to consider in org.apache.myfaces.view.facelets.tag.TagAttributeImpl: Methods TagAttributeImpl.getMethodExpression and TagAttributeImpl.getValueExpression use CompositeComponentELUtils.isCompositeComponentXYZ methods to detect if current #{} contains cc expression. But consider

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Martin Koci
in this area by better utilization of the improved tree walking api jsf2 provides. Werner Am 20.10.10 15:54, schrieb Martin Koci: Hi, a issue to consider

Re: EL method invocation performance

2010-10-19 Thread Martin Koci
for details. Maybe we should put a warning about these two issues at http://wiki.apache.org/myfaces/HowToEnableEl22 ? Regards, Kocicak Martin Koci píše v St 25. 08. 2010 v 20:52 +0200: Hi, I'll try it but not today :) Optimization is my priority task for next few months and certainly I'll compare

Re: Myfaces vs. mojarra restore view performance

2010-09-30 Thread Martin Koci
Hi, Leonardo, can you please review : https://issues.apache.org/jira/browse/MYFACES-2922 https://issues.apache.org/jira/browse/MYFACES-2862 and apply them if they are suitable? Thanks, Kočičák Martin Koci píše v Út 14. 09. 2010 v 23:05 +0200: Hi, please review https://issues.apache.org

[core] FacesEL vs. UEL vs. UEL 2.2

2010-09-30 Thread Martin Koci
Hi, there is a disorder in Expression Lauguage names in myfaces core. Currently myfaces (method javax.faces.validator._ExternalSpecifications.isUnifiedELAvailable() for example) output a log: MyFaces Unified EL support enabled But this is a little misleading: there should be Unified EL 2.2

[core] performance: disabling old technologies

2010-09-24 Thread Martin Koci
Hi, since JSF 2.0 JSP support and managed-bean are deprecated. Since 1.2 same for javax.faces.el. For performace reasons I suggest find a way how disable following: 1) Managed Bean support (o.a.m.SUPPORT_MANAGED_BEANS=false) if this flag is false, myfaces will not install ManagedBeanResolver

Re: submittedValue vs. Converter.getAsObject

2010-09-23 Thread Martin Koci
Hi, I've just read Leonardo's post at jsr-314-open about this problem. FYI: I have finished prototype of JSF server side solution with non-String communication. It's based on custom renderkit and ResponseWriter implementation. I found only one major problem: this one discussed in this mail

  1   2   3   >