Fix for "Use @NbBundle.messages" hint regression; file corruption (was: Debugging CasualDiff.java)

2020-05-02 Thread Ernie Rael
https://github.com/apache/netbeans/pull/2126 Small fix, but should have expert review. -ernie On 5/1/2020 6:50 PM, Ernie Rael wrote: I've run into a problem that gets a CasualDiff error, https://issues.apache.org/jira/browse/NETBEANS-4299, and mangles the source file. It's easily reproduced

Re: JDK-14 Multi-line Strings show with wrong colour on NB 11.3

2020-05-02 Thread Scott Palmer
Ah, I see it now under "Fonts & Colors" -> "Syntax" -> "Java" -> "Text Block". It would be nice if the preview area had a multiline example. Note that the editor window doesn't paint it in the new colour after hitting Apply or Ok. You have to close and re-open the editor - this makes it tedious

Re: JDK-14 Multi-line Strings show with wrong colour on NB 11.3

2020-05-02 Thread Geertjan Wielenga
Note though that you can change the color of the textblock yourself to your liking in the Options window. Gj On Sat, 2 May 2020 at 18:43, Scott Palmer wrote: > I just started using the new multiline strings literals in JDK-14 and > noticed that with a dark look and feel like either "Dark

JDK-14 Multi-line Strings show with wrong colour on NB 11.3

2020-05-02 Thread Scott Palmer
I just started using the new multiline strings literals in JDK-14 and noticed that with a dark look and feel like either "Dark Nimbis" or "FlatLaf Dark" on Windows 10, the text in multiline string has a white background. Can anyone else confirm? I've file NETBEANS-4301 - Multiline string literals

Re: About NetBeans build quality

2020-05-02 Thread Hector Espert
Hi, About a pull request with an invalid mail or an invalid name. I've started experimenting with GitHub actions and I've created a simple action to check commit author name and email. Currently anly check if commit is not created using a GitHub private email, like

Re: Congratulations to Geertjan and Neil, new ASF Members!

2020-05-02 Thread Junichi Yamamoto
Congratulations! Junichi On Thu, Apr 30, 2020 at 10:02 PM Bertrand Delacretaz wrote: > > Hi, > > I'm pleased to announce that two NetBeans PMC members, Geertjan > Wielenga and Neil C Smith have recently been elected as Members of the > Apache Software Foundation. > > Congratulations and that's

Re: Congratulations to Geertjan and Neil, new ASF Members!

2020-05-02 Thread Anthony Goubard
Congratulation both of you! Anthony Le jeu. 30 avr. 2020 à 15:02, Bertrand Delacretaz a écrit : > Hi, > > I'm pleased to announce that two NetBeans PMC members, Geertjan > Wielenga and Neil C Smith have recently been elected as Members of the > Apache Software Foundation. > > Congratulations

Re: About NetBeans build quality

2020-05-02 Thread Neil C Smith
On Sat, 2 May 2020, 10:02 Matthias Bläsing, wrote: > a) an external change causes test failures - the recent failure of the > vscode extension build is one such sample > b) an external outage causes test failures - neighther github, nor > apache apache gitbox, nor the ousol, nor maven central

Re: About NetBeans build quality

2020-05-02 Thread Matthias Bläsing
Hi, Am Samstag, den 02.05.2020, 09:49 +0100 schrieb Neil C Smith: > If master testing is broken, that should be fixed before other > merges. If it's a flaky test, and we have a few, then it should be > retriggered to see if it passes. I'm not a fan of "this is always right in all situations",

Re: About NetBeans build quality

2020-05-02 Thread Neil C Smith
On Sat, 2 May 2020 at 08:20, Benjamin Graf wrote: > Yes, and they are green because work has been done to get them green > again. :-) Thanks! :-) > The problem is the big bunch of PRs based on old master > snapshots that where unstable in time of creation. That's the reason > their Travis

Re: About NetBeans build quality

2020-05-02 Thread Neil C Smith
On Sat, 2 May 2020 at 08:01, Matthias Bläsing wrote: > Am Samstag, den 02.05.2020, 00:57 +0200 schrieb Eric Barboni: > > For what I encounter since 2 months I guess, travis job is not more > > re triggerable (partial job too). > > I saw that in the past, what helped was logging out of travis-ci

Re: About NetBeans build quality

2020-05-02 Thread Benjamin Graf
Hi Eric, > Travis Master build has the same testing rule that a PR build has ? because > it's green and the sync to release too. Yes, and they are green because work has been done to get them green again. :-) The problem is the big bunch of PRs based on old master snapshots that where unstable

Re: About NetBeans build quality

2020-05-02 Thread Matthias Bläsing
Hi Eric, Am Samstag, den 02.05.2020, 00:57 +0200 schrieb Eric Barboni: > For what I encounter since 2 months I guess, travis job is not more > re triggerable (partial job too). I saw that in the past, what helped was logging out of travis-ci and logging back in. I don't know how they