Re: Calling selenium from the build XML was jquey

2010-12-05 Thread Erwan de FERRIERES
Le 05/12/2010 13:02, Sascha Rodekamp a écrit : Hi BJ, sorry for the late response, but i was not at home yesterday. :-). That was more or less a POC. I tried to create a showcase to test standard Application Screens (i.e. a standard ecommerce module). Therefore i created the unit tests with th

Re: Calling selenium from the build XML was jquey

2010-12-05 Thread Erwan de FERRIERES
Le 05/12/2010 13:02, Sascha Rodekamp a écrit : Hi BJ, sorry for the late response, but i was not at home yesterday. :-). That was more or less a POC. I tried to create a showcase to test standard Application Screens (i.e. a standard ecommerce module). Therefore i created the unit tests with th

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
Scott Gray wrote: > On 6/12/2010, at 6:21 PM, Adam Heath wrote: > >> Adrian Crum wrote: >>> I agree with David. An example is the advice he gave me during the >>> development of temporal expressions. >>> >>> I wanted to cache the temporal expression Java structures in memory. David >>> suggested

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Scott Gray
On 6/12/2010, at 6:21 PM, Adam Heath wrote: > Adrian Crum wrote: >> I agree with David. An example is the advice he gave me during the >> development of temporal expressions. >> >> I wanted to cache the temporal expression Java structures in memory. David >> suggested getting the persisted expr

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread David E Jones
On Dec 5, 2010, at 9:26 PM, Adrian Crum wrote: > --- On Sun, 12/5/10, Adam Heath wrote: >> Again, why are people pushing back on this? It hurts >> no one, and >> could find cases where caching actually would help. >> Really, what is >> the harm? > > I can only speak for myself. I push back on

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adrian Crum
--- On Sun, 12/5/10, Adam Heath wrote: > Adrian Crum wrote: > > I agree with David. An example is the advice he gave > me during the development of temporal expressions. > > > > I wanted to cache the temporal expression Java > structures in memory. David suggested getting the persisted > expressi

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adrian Crum
--- On Sun, 12/5/10, Adam Heath wrote: > Again, why are people pushing back on this?  It hurts > no one, and > could find cases where caching actually would help.  > Really, what is > the harm? I can only speak for myself. I push back on entity caching stuff because I feel it is redundant. Datab

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
Adrian Crum wrote: > I agree with David. An example is the advice he gave me during the > development of temporal expressions. > > I wanted to cache the temporal expression Java structures in memory. David > suggested getting the persisted expressions from the entity cache instead. > Thinking a

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
David E Jones wrote: > On Dec 5, 2010, at 8:47 PM, Adam Heath wrote: > >> David E Jones wrote: >>> On Dec 5, 2010, at 8:11 PM, Adam Heath wrote: >>> David E Jones wrote: > There are other reasons why you might not want to cache something. Quite > a few of them, even without trying to

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread David E Jones
On Dec 5, 2010, at 8:47 PM, Adam Heath wrote: > David E Jones wrote: >> On Dec 5, 2010, at 8:11 PM, Adam Heath wrote: >> >>> David E Jones wrote: There are other reasons why you might not want to cache something. Quite a few of them, even without trying to be too creative.

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adrian Crum
I agree with David. An example is the advice he gave me during the development of temporal expressions. I wanted to cache the temporal expression Java structures in memory. David suggested getting the persisted expressions from the entity cache instead. Thinking about it, that made sense - temp

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
David E Jones wrote: > On Dec 5, 2010, at 8:11 PM, Adam Heath wrote: > >> David E Jones wrote: >>> There are other reasons why you might not want to cache something. Quite a >>> few of them, even without trying to be too creative. >>> >>> For example: memory use. Why cache things like contact mec

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread David E Jones
On Dec 5, 2010, at 8:11 PM, Adam Heath wrote: > David E Jones wrote: >> There are other reasons why you might not want to cache something. Quite a >> few of them, even without trying to be too creative. >> >> For example: memory use. Why cache things like contact mech or order >> information t

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
David E Jones wrote: > There are other reasons why you might not want to cache something. Quite a > few of them, even without trying to be too creative. > > For example: memory use. Why cache things like contact mech or order > information that isn't likely to be read a very many times, but if c

Re: findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread David E Jones
There are other reasons why you might not want to cache something. Quite a few of them, even without trying to be too creative. For example: memory use. Why cache things like contact mech or order information that isn't likely to be read a very many times, but if cached would take up memory un

findFoo(cache=false), without modification, in a transaction, issue warning

2010-12-05 Thread Adam Heath
I've noticed several places in the code that issue a findOne(or other find method), without using a cache, but then don't do any modifications to the returned value. Such call sites should really use a caching variant of the delegator. What I'd like to work on, is a feature, only used during deve

[jira] Commented: (OFBIZ-4021) Adding columns filtering fields in form widget

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967037#action_12967037 ] Jacques Le Roux commented on OFBIZ-4021: Hi Bruno, Yes, but I did not get a chance

Re: GenericValue.getRelatedOne/Cache

2010-12-05 Thread Adam Heath
Jacques Le Roux wrote: > I'm quite sure Adrian and I will not be the only ones interested... Figured as much. I just started working on it.

[jira] Closed: (OFBIZ-4023) Wrong product displayed as associated product

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4023. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 10.04

[jira] Closed: (OFBIZ-4025) Is Empty for text-find widget broken

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4025. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 10.04

[jira] Closed: (OFBIZ-4029) commit r1033717 breaks authorize.net processing.

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4029. -- Close on Rohit's demand > commit r1033717 breaks authorize.net processing. > -

Re: GenericValue.getRelatedOne/Cache

2010-12-05 Thread Jacques Le Roux
I'm quite sure Adrian and I will not be the only ones interested... Thanks Jacques From: "Adrian Crum" +1 -Adrian On 12/2/2010 10:39 PM, Adam Heath wrote: A while back, I started adding more variants of GenericDelegator.findByPrimaryKey. The outcome of that was to remove those variants, a

Leaks suspect

2010-12-05 Thread Jacques Le Roux
Hi, From a heap dump automatically created at demo stable crash (using -XX:+HeapDumpOnOutOfMemoryError), I have created a Jira "Memory leaks in (at least) stable demo" at https://issues.apache.org/jira/browse/OFBIZ-4043 Help appreciated, thanks Jacques

[jira] Updated: (OFBIZ-4043) Memory leaks in (at least) stable demo

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4043: --- Description: Using [Mat|http://www.eclipse.org/mat/] I generated these report 110 542 insta

[jira] Updated: (OFBIZ-4043) Memory leaks in (at least) stable demo

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4043: --- Attachment: Leaks Suspect .jpg > Memory leaks in (at least) stable demo > ---

[jira] Created: (OFBIZ-4043) Memory leaks in (at least) stable demo

2010-12-05 Thread Jacques Le Roux (JIRA)
Memory leaks in (at least) stable demo -- Key: OFBIZ-4043 URL: https://issues.apache.org/jira/browse/OFBIZ-4043 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 09.04 Environmen

[jira] Updated: (OFBIZ-4027) Product Store Email Setting with PARTY_EMAIL

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4027: --- Component/s: product Issue Type: Improvement (was: Bug) > Product Store Email Setting w

[jira] Closed: (OFBIZ-4027) Product Store Email Setting with PARTY_EMAIL

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4027. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Eric, Your patch is in trunk at r1042

[jira] Closed: (OFBIZ-4022) Collapse all broken if hyperlink in pane

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4022. -- Resolution: Fixed Fix Version/s: SVN trunk jQuery R

[jira] Updated: (OFBIZ-3490) Create theme build script

2010-12-05 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-3490: -- Issue Type: Sub-task (was: New Feature) Parent: OFBIZ-635 > Create theme build script > --

[jira] Commented: (OFBIZ-3490) Create theme build script

2010-12-05 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966941#action_12966941 ] BJ Freeman commented on OFBIZ-3490: --- yup. to organize my energy I have decided to use the

Re: Ofbiz Doc book help

2010-12-05 Thread Jacques Le Roux
Ha OK! Then please forgot my related user message then Jacques From: "BJ Freeman" not much effort to change just wanted input before I put effort into it. I have made a decision to convert the wikis to docbook and put in appropriate sections. to that end i am also looking at what in ofbiz I c

Re: Ofbiz Doc book help

2010-12-05 Thread BJ Freeman
not much effort to change just wanted input before I put effort into it. I have made a decision to convert the wikis to docbook and put in appropriate sections. to that end i am also looking at what in ofbiz I can use to write a top level converter from wiki markup (or rtf) to Dockbook format. s

Re: Calling selenium from the build XML was jquey

2010-12-05 Thread Sascha Rodekamp
Hi BJ, sorry for the late response, but i was not at home yesterday. :-). That was more or less a POC. I tried to create a showcase to test standard Application Screens (i.e. a standard ecommerce module). Therefore i created the unit tests with the selenium firefox plugin, modifyed the tests for

[jira] Closed: (OFBIZ-4042) ecommerce keyword search - Non-breaking space displayed as literal ampersand-nbsp-semicolon

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4042. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 10.04

[jira] Assigned: (OFBIZ-3579) Tenant ecommerce effort

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-3579: -- Assignee: Jacques Le Roux > Tenant ecommerce effort > --- > >

[jira] Commented: (OFBIZ-3490) Create theme build script

2010-12-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966924#action_12966924 ] Jacques Le Roux commented on OFBIZ-3490: Ping... > Create theme build script > ---

Re: jquey

2010-12-05 Thread Bruno Busco
+1 ;-) 2010/12/5 Jacques Le Roux > Hi Bruno, > > OK, then a tag should be sufficient. What about beforejQuery? > > Jacques > > From: "Bruno Busco" > > Hi All, > I am sorry if my suggestion to create a release branch has delayed somehow > the merging of the great work that Jacques and Sasha have

Re: Ofbiz Doc book help

2010-12-05 Thread Jacques Le Roux
This seems reasonnable to me, but does it need much work? My 2cts Jacques From: "BJ Freeman" looking at the main Doc URL (cmssite/cms/APACHE_OFBIZ_HTML)for Apache OFBiz official documentation. it seems we should go up one level and have the different doc groups called out. Apache OFBiz User

Re: jquey

2010-12-05 Thread Jacques Le Roux
Hi Bruno, OK, then a tag should be sufficient. What about beforejQuery? Jacques From: "Bruno Busco" Hi All, I am sorry if my suggestion to create a release branch has delayed somehow the merging of the great work that Jacques and Sasha have done. This was not my intention at all. The idea was

[jira] Reopened: (OFBIZ-4037) Moving the user SignUp feature from MyPortal to the Framework

2010-12-05 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-4037: The commit has been reverted as suggested by Adam. The reason was that the patch adds in the framework

Re: jquey

2010-12-05 Thread Bruno Busco
Hi All, I am sorry if my suggestion to create a release branch has delayed somehow the merging of the great work that Jacques and Sasha have done. This was not my intention at all. The idea was just to create a release branch; this, IMO, should not have delayed the merging. The reason of the branc