Re: Slim-down effort: current situation

2013-01-05 Thread Jacques Le Roux
Because it's possibly easier for committers to follow the work done and not get a big patch at the end. With Git you tend to receive either a burst of patches or a big one, both in one shoot. Then it's hard to review the work done. By steps it's easier I don't use GitHub, I have enough to do

[jira] [Closed] (OFBIZ-5119) Implementing Try-Catch while Adding UiLabel Resources

2013-01-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5119. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Praveen, Your patch is in R10.04 at

Re: svn commit: r1429234 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/OrderServices.java

2013-01-05 Thread Adrian Crum
Why were the label files changed in this commit? This commit makes the order component dependent on a special purpose component. -Adrian On 1/5/2013 8:34 AM, jler...@apache.org wrote: Author: jleroux Date: Sat Jan 5 08:34:12 2013 New Revision: 1429234 URL:

Re: svn commit: r1429234 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/O rderServices.java

2013-01-05 Thread Jacques Le Roux
Nope, they did not change, just a try-catch block around We could do better like was done with OFBIZ-3969 (see my comment in OFBIZ-5119), but it's enough for me today Jacques From: Adrian Crum adrian.c...@sandglass-software.com Why were the label files changed in this commit? This commit makes

Re: svn commit: r1429234 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/O rderServices.java

2013-01-05 Thread Adrian Crum
Please look again: -uiLabelMap.addBottomResourceBundle(CommonUiLabels); + uiLabelMap.addBottomResourceBundle(EcommerceUiLabels); -Adrian On 1/5/2013 11:26 AM, Jacques Le Roux wrote: Nope, they did not change, just a try-catch block around We could do better like was done with

Re: svn commit: r1429234 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/O rderServices.java

2013-01-05 Thread Jacques Le Roux
They are just reversed Jacques From: Adrian Crum adrian.c...@sandglass-software.com Please look again: -uiLabelMap.addBottomResourceBundle(CommonUiLabels); + uiLabelMap.addBottomResourceBundle(EcommerceUiLabels); -Adrian On 1/5/2013 11:26 AM, Jacques Le Roux wrote: Nope,

Re: svn commit: r1429234 - /ofbiz/branches/release10.04/applications/order/src/org/ofbiz/order/order/O rderServices.java

2013-01-05 Thread Adrian Crum
Okay, now I see. Sorry. -Adrian On 1/5/2013 12:06 PM, Jacques Le Roux wrote: They are just reversed Jacques From: Adrian Crum adrian.c...@sandglass-software.com Please look again: -uiLabelMap.addBottomResourceBundle(CommonUiLabels); +

[jira] [Closed] (OFBIZ-2761) Add inventory items used for the task

2013-01-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2761. -- Resolution: Later Add inventory items used for the task

[jira] [Closed] (OFBIZ-4937) In version 10.04 - After clicking on lookup, display login page again

2013-01-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4937. -- Resolution: Fixed Thanks Raghavendra, Your patch is in R10.04 at r1429273

Comparing with OpenERP

2013-01-05 Thread Jacques Le Roux
Interesting, notably the numbers of committers https://www.ohloh.net/p/compare?project_0=Open+For+Business+Project+%28Apache+OFBiz%29project_1=OpenERP Of course quantity is not quality, but it seems OpenERP has a better momentum than OFBiz, at the business level, I mean... Jacques

Re: Comparing with OpenERP

2013-01-05 Thread Ean Schuessler
Some confusing things there. Most strangely, 4,909,882 lines added in the last 30 days yet 679,749 lines total project size? Something seems to be amiss. To me, we should be creaming these guys on the AGPL license alone. I understand that many businesses are small enough to just not care.

Re: Slim-down effort: current situation

2013-01-05 Thread Ean Schuessler
I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted. I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository. The nice thing about GIT is that the chaff

Re: Slim-down effort: current situation

2013-01-05 Thread Jacques Le Roux
From: Ean Schuessler e...@brainfood.com I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted. I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository.

Re: Comparing with OpenERP

2013-01-05 Thread Jacques Le Roux
From: Ean Schuessler e...@brainfood.com Some confusing things there. Most strangely, 4,909,882 lines added in the last 30 days yet 679,749 lines total project size? Something seems to be amiss. It's not quite clear indeed, maybe it does not represent well the activity. This is certainly

Re: Slim-down effort: current situation

2013-01-05 Thread dejc
On Jan 5, 2013, at 1:47 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: From: Ean Schuessler e...@brainfood.com I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted. I think the complication with handing out SVN branches is

Re: Comparing with OpenERP

2013-01-05 Thread dejc
On Jan 5, 2013, at 2:10 PM, Jacques Le Roux jacques.le.r...@les7arts.com wrote: I'm not quire sure what you mean, but anyway I don't sell OpenErp ;) My primary intention was just to note that they have much more committers(?) doing much more commits(?) When you look into details numbers

Re: Comparing with OpenERP

2013-01-05 Thread Ean Schuessler
Agreed. One thing that immediately jumps out is how much of their codebase is in Javascript. That may imply at least two functional teams right there. It makes me wonder if they are approach things as more of a REST/HTTP-RPC server written in Python that services a client written in JavaScript.