[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509298#comment-14509298 ] Gareth Carter commented on OFBIZ-6291: -- int i = foo.compareTo(baz); return i = 0;

[jira] [Assigned] (OFBIZ-6294) Have configuration options for workeffort

2015-04-23 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-6294: --- Assignee: Pierre Smits Have configuration options for workeffort

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 04:22 AM, Scott Gray wrote: I'm just saying my current project has been using it for 18 months and it's been a long time now since we've lost any changes. This is 15-30 devs that were all new to git. In my experience most issues come from: - Reverting merge commits and picking

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509305#comment-14509305 ] Adam Heath commented on OFBIZ-6291: --- int i = foo... isn't the part that is slower. The

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509267#comment-14509267 ] Adam Heath commented on OFBIZ-6291: --- * The patch introduces new blank lines; that should

[jira] [Created] (OFBIZ-6294) Have configuration options for workeffort

2015-04-23 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6294: --- Summary: Have configuration options for workeffort Key: OFBIZ-6294 URL: https://issues.apache.org/jira/browse/OFBIZ-6294 Project: OFBiz Issue Type: Sub-task

Re: Fwd: Re: Maven

2015-04-23 Thread Adam Heath
As for deploying of artifacts, I've already done a mvn install locally, which copies the built files into $HOME/.m2/; so I know that eventually when everything is done, we could deploy into the global shared repo. On 04/22/2015 09:03 PM, Ron Wheeler wrote: Just to let everyone know that we

[jira] [Updated] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6291: - Attachment: minilang_compare_r1675655.patch Update code to check for types rather than throw

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 03:28 AM, Scott Gray wrote: I am thoroughly familiar with Git. Git always screws things up. If git always screwed things up, then those other 3 projects wouldn't be using it. ps: I realize this was a quote from Adrian, and not Scott. These two statements are complete

[jira] [Assigned] (OFBIZ-6171) Replace 'Open for Business' references with 'Apache OFBiz'

2015-04-23 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-6171: --- Assignee: Pierre Smits Replace 'Open for Business' references with 'Apache OFBiz'

[jira] [Commented] (OFBIZ-6171) Replace 'Open for Business' references with 'Apache OFBiz'

2015-04-23 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509406#comment-14509406 ] Jacopo Cappellato commented on OFBIZ-6171: -- As a side/minor note: I have noticed

Re: Fwd: Re: Maven

2015-04-23 Thread Ron Wheeler
I was just trying to point out that we are not the only Apache project that is grappling with the build process. If we ever decide to support the framework as a separate product, the question of Maven Central comes into play. I don't see any useful way or need to include OFBiz as a whole as

[jira] [Commented] (OFBIZ-6146) LookupInventoryItem not functional

2015-04-23 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509770#comment-14509770 ] Nicolas Malin commented on OFBIZ-6146: -- Hello Christian, I review your patch and

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

2015-04-23 Thread Ean Schuessler (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509726#comment-14509726 ] Ean Schuessler commented on OFBIZ-6270: --- Is the deprecation policy documented? Is it

[jira] [Updated] (OFBIZ-6146) LookupInventoryItem not functional

2015-04-23 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-6146: - Attachment: OFBIZ-6146.patch LookupInventoryItem not functional

[jira] [Commented] (OFBIZ-5169) Removing Javolution from framework components

2015-04-23 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509884#comment-14509884 ] Nicolas Malin commented on OFBIZ-5169: -- I also agree with you (really it's not a

[jira] [Updated] (OFBIZ-6171) Replace 'Open for Business' references with 'Apache OFBiz'

2015-04-23 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-6171: Attachment: OFBIZ-6171-OpenForBusiness.patch This patch addresses the issue. Replace 'Open for

[jira] [Created] (OFBIZ-6295) Shoppingcart checkout shipping rules can be hacked

2015-04-23 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-6295: --- Summary: Shoppingcart checkout shipping rules can be hacked Key: OFBIZ-6295 URL: https://issues.apache.org/jira/browse/OFBIZ-6295 Project: OFBiz Issue

Re: Proposal: redefining the components' directory layout for source files

2015-04-23 Thread Scott Gray
+1 Regards Scott On 21 January 2015 at 00:41, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: In my opinion it would be nice to review how we organize the code in our components and switch to a directory layout that is more inline with what other projects are doing, for example:

[jira] [Created] (OFBIZ-6296) updateOrderItemShipGroup allows updating to rule breaking shipment method without error

2015-04-23 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-6296: --- Summary: updateOrderItemShipGroup allows updating to rule breaking shipment method without error Key: OFBIZ-6296 URL: https://issues.apache.org/jira/browse/OFBIZ-6296

[jira] [Commented] (OFBIZ-6295) Shoppingcart checkout shipping rules can be hacked

2015-04-23 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509668#comment-14509668 ] Christian Carlow commented on OFBIZ-6295: - OFBIZ-6297 and OFBIZ-6296 are related

Re: move to git.

2015-04-23 Thread Adam Heath
On 04/23/2015 06:00 PM, David E. Jones wrote: An FYI for all committers: create an account on GitHub (if you don't already have one) and add your @apache.org email address to it, and within a few hours you'll show up in the contributor graphs. I tried this and am now showing up there:

[jira] [Commented] (OFBIZ-6085) Add support for production run inventory tracking

2015-04-23 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509110#comment-14509110 ] Christian Carlow commented on OFBIZ-6085: - Thanks for the info Pierre. So adding

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

2015-04-23 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508515#comment-14508515 ] Jacopo Cappellato commented on OFBIZ-6270: -- I restate that traditionally OFBiz is

[jira] [Commented] (OFBIZ-6085) Add support for production run inventory tracking

2015-04-23 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508517#comment-14508517 ] Pierre Smits commented on OFBIZ-6085: - ProductStore is not the application. Catalog is

[jira] [Updated] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6291: - Attachment: LocalizedConverters.patch LocalizedConverters.patch fixes ObjectType.java and

Re: move to git.

2015-04-23 Thread Adrian Crum
They are contradictions because they have been taken out of context. I was responding to the suggestion that I don't like Git because I have never used it. I have used it on three projects, and there have been problems - even when Git experts use it. So, my dislike is based on my experiences

[jira] [Created] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
Gareth Carter created OFBIZ-6291: Summary: Update code to check for types rather than throw ClassCastException Key: OFBIZ-6291 URL: https://issues.apache.org/jira/browse/OFBIZ-6291 Project: OFBiz

Re: move to git.

2015-04-23 Thread Scott Gray
I am thoroughly familiar with Git. Git always screws things up. These two statements are complete contradictions. Outcomes in git only appear strange while you're still unfamiliar with it. I've been using the git-svn bridge to commit to OFBiz for about 4 years and using a git repo on my current

[jira] [Created] (OFBIZ-6292) If enable multitenant, none-ASCII characters within a from are incorrectly encode/decoded after posted

2015-04-23 Thread Leon (JIRA)
Leon created OFBIZ-6292: --- Summary: If enable multitenant, none-ASCII characters within a from are incorrectly encode/decoded after posted Key: OFBIZ-6292 URL: https://issues.apache.org/jira/browse/OFBIZ-6292

Re: move to git.

2015-04-23 Thread Scott Gray
I'm just saying my current project has been using it for 18 months and it's been a long time now since we've lost any changes. This is 15-30 devs that were all new to git. In my experience most issues come from: - Reverting merge commits and picking the wrong mainline - Pushing to the wrong

Re: Renaming OFBiz artefacts

2015-04-23 Thread Adrian Crum
I have a feeling that the R15.x branch will not be backward compatible due to all of the refactoring going on. People will complain that the package rename will break local modifications - but so will a bunch of other things that are going on. Adrian Crum Sandglass Software

[jira] [Updated] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gareth Carter updated OFBIZ-6291: - Attachment: minilang_compare.patch minilang_compare.patch fixes Compare.java. I have remove

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508680#comment-14508680 ] Adrian Crum commented on OFBIZ-6291: As the code comment states, the current

[jira] [Updated] (OFBIZ-6292) If enable multitenant, none-ASCII characters within a from are incorrectly encode/decoded after posted

2015-04-23 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-6292: Description: Everything is ok if you leave multitenant configuration untouched (the default value is N) in file

Re: move to git.

2015-04-23 Thread Adrian Crum
I can imagine the mess someone might make trying to rewrite history on the remote repo. That is what I am imagining also. When/if the vote occurs to make the change, I will vote +0 - because I don't like using Git, but I don't want to stand in the way of others using it. I'm looking

[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException

2015-04-23 Thread Gareth Carter (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508686#comment-14508686 ] Gareth Carter commented on OFBIZ-6291: -- Just realised minilang_compare.patch does not

Re: move to git.

2015-04-23 Thread Martin Becker
Strange occurrences stopped happening for me after a couple of months and generally stopped once all developers either stopped using git client UIs that used settings they didn't understand or they started using the command line… That’s my experience, too, and therefore one of my reasons to

Re: move to git.

2015-04-23 Thread Jacopo Cappellato
On Apr 23, 2015, at 11:42 AM, Martin Becker martin.bec...@ecomify.de wrote: Maybe it’s necessary to think about which processes and workflows maybe the ones that are expected by the current and especially future audience/clients/contributors from a state of the art, living and ongoing open

[jira] [Created] (OFBIZ-6293) If a party is both a contact and a lead, then SFA profile renders screens for both

2015-04-23 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-6293: --- Summary: If a party is both a contact and a lead, then SFA profile renders screens for both Key: OFBIZ-6293 URL: https://issues.apache.org/jira/browse/OFBIZ-6293

[jira] [Commented] (OFBIZ-6085) Add support for production run inventory tracking

2015-04-23 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509059#comment-14509059 ] Christian Carlow commented on OFBIZ-6085: - I'm fine with the configuration option

[jira] [Commented] (OFBIZ-6085) Add support for production run inventory tracking

2015-04-23 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509077#comment-14509077 ] Pierre Smits commented on OFBIZ-6085: - Currently no functionality exists in

Re: move to git.

2015-04-23 Thread David E. Jones
An FYI for all committers: create an account on GitHub (if you don't already have one) and add your @apache.org email address to it, and within a few hours you'll show up in the contributor graphs. I tried this and am now showing up there: https://github.com/apache/ofbiz/graphs/contributors

[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window

2015-04-23 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510491#comment-14510491 ] Jacopo Cappellato commented on OFBIZ-6270: -- [~e...@brainfood.com] please read my

[jira] [Commented] (OFBIZ-5169) Removing Javolution from framework components

2015-04-23 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510494#comment-14510494 ] Jacopo Cappellato commented on OFBIZ-5169: -- Thank you Nicolas for your feedback.

Re: Proposal: redefining the components' directory layout for source files

2015-04-23 Thread Ron Wheeler
+1 Any change of breaking the project up into components that are compiled separately? Ron On 23/04/2015 11:42 PM, Scott Gray wrote: +1 Regards Scott On 21 January 2015 at 00:41, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: In my opinion it would be nice to review how we

Re: Proposal: redefining the components' directory layout for source files

2015-04-23 Thread David E. Jones
On 21 Jan 2015, at 09:24, Jacques Le Roux jacques.le.r...@les7arts.com wrote: Le 21/01/2015 15:45, Jacques Le Roux a écrit : 5) moving a step forward in the direction of allowing the adoption of Maven like tools (Maven, Gradle etc..) that could make it easier to share external