[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512784
]
Jacques Le Roux commented on OFBIZ-1041:
It's finally done :o)
When I did the changes I was a bit puzzled
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512787
]
Jacques Le Roux commented on OFBIZ-1041:
And it seemed to me a simple issue ;o)
Finally(?) in trunk rev.
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512788
]
Jacques Le Roux commented on OFBIZ-1041:
? in Finally(?) above was premonition :
Put test in place of Y.
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512790
]
Krzysztof Podejma commented on OFBIZ-1041:
--
I had to leave on weekend. Is it done now, or needs test?
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512795
]
Jacques Le Roux commented on OFBIZ-1041:
It should be done, but of course more tests are always welcome...
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512719
]
Adrian Crum commented on OFBIZ-1041:
Jacques,
I reviewed your commits and they are still not quite right.
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512737
]
Jacques Le Roux commented on OFBIZ-1041:
Adrian,
Yes I know you are right, I laready read your comment
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512623
]
Krzysztof Podejma commented on OFBIZ-1041:
--
so it will not be fixed?
various values in allowSolicitation
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512629
]
Adrian Crum commented on OFBIZ-1041:
The problem still exists. From line 224 of
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504250
]
Si Chen commented on OFBIZ-1041:
I don't know about this one. For a Chinese user, for example, Y or N might not
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504267
]
Krzysztof Podejma commented on OFBIZ-1041:
--
i.e. in crmsfa in viewprofile.ftl you have
#if
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504331
]
David E. Jones commented on OFBIZ-1041:
---
I'm totally with Si on this one, and it's important as this sort of
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504346
]
Adrian Crum commented on OFBIZ-1041:
Maybe something is getting lost in the translation. It seems to me that the
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504349
]
David E. Jones commented on OFBIZ-1041:
---
Thanks Adrian, just after writing that while I was reading other
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504351
]
Krzysztof Podejma commented on OFBIZ-1041:
--
I think checking my patch will make you sure that we have the
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504366
]
Oleg Andreyev commented on OFBIZ-1041:
--
Thanks Krzysztof for pointing this error out. Current code in
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504387
]
Krzysztof Podejma commented on OFBIZ-1041:
--
code :
select name=allowSolicitation
#if
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504394
]
David E. Jones commented on OFBIZ-1041:
---
Okay, I was just looking at the code and it looks like this breaks
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504398
]
Krzysztof Podejma commented on OFBIZ-1041:
--
in ofbiz trunk you have
select name=allowSolicitation
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504400
]
David E. Jones commented on OFBIZ-1041:
---
Yeah, but that will actually break things more. As soon as you submit
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504405
]
Krzysztof Podejma commented on OFBIZ-1041:
--
maybe you haven't noticed. This patch adds
!--
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504408
]
David E. Jones commented on OFBIZ-1041:
---
Okay, yeah. That's the exact point though.
We don't want to
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504419
]
Krzysztof Podejma commented on OFBIZ-1041:
--
this select could look like this
select
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504424
]
Jacques Le Roux commented on OFBIZ-1041:
David,
Can you elaborate on this, please ?
I understand that
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504429
]
Scott Gray commented on OFBIZ-1041:
---
Hi Jacques
I think David means front end to be user interface and back end
[
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504438
]
Adrian Crum commented on OFBIZ-1041:
It's a good idea to keep a sharp line drawn between the service layer and
Adrian Crum (JIRA) wrote:
Also, a UI pattern I have been using lately is to have the current data select
the correct list element, instead of displaying it twice. Example:
select name=allowSolicitation
#assign allowSolicitation =
(mechMap.partyContactMech.allowSolicitation)?default(N)
Very good points! Thank you for the insight.
David E Jones wrote:
Adrian Crum (JIRA) wrote:
Also, a UI pattern I have been using lately is to have the current
data select the correct list element, instead of displaying it twice.
Example:
select name=allowSolicitation
#assign
Thanks for clarification David.
Jacques
De : Adrian Crum [EMAIL PROTECTED]
Very good points! Thank you for the insight.
David E Jones wrote:
Adrian Crum (JIRA) wrote:
Also, a UI pattern I have been using lately is to have the current
data select the correct list element, instead
29 matches
Mail list logo
