Re: Backport for OWB 1.7.x

VOTE is up and binaries ready for review. Hope it helps Le lun. 17 déc. 2018 à 17:07, Daniel Cunha a écrit : > +1. Thanks Jean-Louis! :D > > Em seg, 17 de dez de 2018 às 11:50, Jonathan Gallimore < > jonathan.gallim...@gmail.com> escreveu: > > > +1, thanks Jean-Louis! > > > > On Mon, 17 Dec 201

Re: Backport for OWB 1.7.x

+1. Thanks Jean-Louis! :D Em seg, 17 de dez de 2018 às 11:50, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > +1, thanks Jean-Louis! > > On Mon, 17 Dec 2018, 14:36 Jean-Louis MONTEIRO > > Hey, > > > > Are we ready to roll it out then? > > I ca do it whenever it's needed this week.

Re: Backport for OWB 1.7.x

+1, thanks Jean-Louis! On Mon, 17 Dec 2018, 14:36 Jean-Louis MONTEIRO Hey, > > Are we ready to roll it out then? > I ca do it whenever it's needed this week. > > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha a écrit > : > > > Hi Thomas, > > > > Sure, I'll close. > > Thank you too! > > > > Em seg, 3

Re: Backport for OWB 1.7.x

Great. Thanks guys. I'll give it a try today Le lun. 17 déc. 2018 à 15:46, Romain Manni-Bucau a écrit : > +1 > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog > | Github < > https:/

Re: Backport for OWB 1.7.x

+1 Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Backport for OWB 1.7.x

Yup, i think so. Am Mo., 17. Dez. 2018 um 15:36 Uhr schrieb Jean-Louis MONTEIRO < jeano...@gmail.com>: > Hey, > > Are we ready to roll it out then? > I ca do it whenever it's needed this week. > > Le lun. 3 déc. 2018 à 11:13, Daniel Cunha a écrit > : > > > Hi Thomas, > > > > Sure, I'll close. >

Re: Backport for OWB 1.7.x

Hey, Are we ready to roll it out then? I ca do it whenever it's needed this week. Le lun. 3 déc. 2018 à 11:13, Daniel Cunha a écrit : > Hi Thomas, > > Sure, I'll close. > Thank you too! > > Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko < > andraschko.tho...@gmail.com> escreveu: > > > Mer

Re: Backport for OWB 1.7.x

Hi Thomas, Sure, I'll close. Thank you too! Em seg, 3 de dez de 2018 às 07:11, Thomas Andraschko < andraschko.tho...@gmail.com> escreveu: > Merged it. Thank you Daniel for the patch! > Also "resolved" the JIRA ticket. > > @Daniel Could you please close your PR then? > > Am Sa., 1. Dez. 2018 um 1

Re: Backport for OWB 1.7.x

Merged it. Thank you Daniel for the patch! Also "resolved" the JIRA ticket. @Daniel Could you please close your PR then? Am Sa., 1. Dez. 2018 um 17:14 Uhr schrieb Romain Manni-Bucau < rmannibu...@gmail.com>: > Yes, looks good > > Le sam. 1 déc. 2018 14:28, Thomas Andraschko > a écrit : > > > Ca

Re: Backport for OWB 1.7.x

Yes, looks good Le sam. 1 déc. 2018 14:28, Thomas Andraschko a écrit : > Can i merge it romain? > > > Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha > geschrieben: > > > Ok. patch updated again. :) > > > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha > > escreveu: > > > > > Ah.. > > > > > >

Re: Backport for OWB 1.7.x

Can i merge it romain? Am Do., 22. Nov. 2018, 14:39 hat Daniel Cunha geschrieben: > Ok. patch updated again. :) > > Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha > escreveu: > > > Ah.. > > > > Ok, I get it! > > Thanks Thomas and Jon > > > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Galli

Re: Backport for OWB 1.7.x

Ok. patch updated again. :) Em qui, 22 de nov de 2018 às 10:32, Daniel Cunha escreveu: > Ah.. > > Ok, I get it! > Thanks Thomas and Jon > > Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore < > jonathan.gallim...@gmail.com> escreveu: > >> I think you can keep ASM 7, but leave this: >> >> ht

Re: Backport for OWB 1.7.x

Ah.. Ok, I get it! Thanks Thomas and Jon Em qui, 22 de nov de 2018 às 10:30, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > I think you can keep ASM 7, but leave this: > > https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069a

Re: Backport for OWB 1.7.x

I think you can keep ASM 7, but leave this: https://github.com/apache/openwebbeans/pull/13/commits/cb600aada79427ab7eff31e7da92038b6af6ed19#diff-f58069aef7df21dd8d4b0bd3546a747aR104 as `return Opcodes.V1_6;`. Hope that helps. Jon On Thu, Nov 22, 2018 at 1:26 PM Romain Manni-Bucau wrote: > +1

Re: Backport for OWB 1.7.x

+1 Thomas Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Backport for OWB 1.7.x

Hi Daniel, not sure if i didn't understand it correclty but IMO we should upgrade to ASM7 - BUT - default the bytecode version to Java6 or Java7 in AbstractProxyFactory#determineDefaultJavaVersion. Could you please clarify Romain? Best regards, Thomas Am Do., 22. Nov. 2018 um 13:48 Uhr schrieb D

Re: Backport for OWB 1.7.x

hi folks, patch updated again: https://github.com/apache/openwebbeans/pull/13 :) Em qui, 22 de nov de 2018 às 08:14, Daniel Cunha escreveu: > Ok, in this case I'll back the asm changes. I'll update the patch. > > Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko < > andraschko.tho...@gmail.c

Re: Backport for OWB 1.7.x

Ok, in this case I'll back the asm changes. I'll update the patch. Em qua, 21 de nov de 2018 7:02 AM, Thomas Andraschko < andraschko.tho...@gmail.com escreveu: > +1 to not change the old default > > Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau < > rmannibu...@gmail.com>: > > > Ex

Re: Backport for OWB 1.7.x

+1 to not change the old default Am Di., 20. Nov. 2018 um 21:27 Uhr schrieb Romain Manni-Bucau < rmannibu...@gmail.com>: > Except the default to bytecode for java 8 - fear we have to stick to j6 or > 7 if we want to change here - it looks good. > > Le mar. 20 nov. 2018 20:59, Thomas Andraschko >

Re: Backport for OWB 1.7.x

Except the default to bytecode for java 8 - fear we have to stick to j6 or 7 if we want to change here - it looks good. Le mar. 20 nov. 2018 20:59, Thomas Andraschko a écrit : > @Romain could you do a short review? I could apply it tomorrow then. > > Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Da

Re: Backport for OWB 1.7.x

@Romain could you do a short review? I could apply it tomorrow then. Am Di., 20. Nov. 2018 um 20:37 Uhr schrieb Daniel Cunha < daniels...@gmail.com>: > Hi Thomas, > > I've updated the patch[1], please review it. > Thank you. > > [1] https://github.com/apache/openwebbeans/pull/13 > > Em ter, 20 de

Re: Backport for OWB 1.7.x

Hi Thomas, I've updated the patch[1], please review it. Thank you. [1] https://github.com/apache/openwebbeans/pull/13 Em ter, 20 de nov de 2018 às 14:06, Daniel Cunha escreveu: > Hi Thomas, > > sure. I'll working on it. In the same patch. > > Em ter, 20 de nov de 2018 às 14:03, Thomas Andrasch

Re: Backport for OWB 1.7.x

Hi Thomas, sure. I'll working on it. In the same patch. Em ter, 20 de nov de 2018 às 14:03, Thomas Andraschko < andraschko.tho...@gmail.com> escreveu: > Yep. Could you please provide a PR (or even a patch - i have to merge it > manually), so i can commit both? > > Am Di., 20. Nov. 2018 um 17:41

Re: Backport for OWB 1.7.x

Yep. Could you please provide a PR (or even a patch - i have to merge it manually), so i can commit both? Am Di., 20. Nov. 2018 um 17:41 Uhr schrieb Daniel Cunha < daniels...@gmail.com>: > Hi Thomas, > > Good catch! if we want to have support for java 11 (officially) on OWB > 1.7.x, maybe is bett

Re: Backport for OWB 1.7.x

Hi Thomas, Good catch! if we want to have support for java 11 (officially) on OWB 1.7.x, maybe is better to move it to use asm7 as well. Em ter, 20 de nov de 2018 às 12:28, Thomas Andraschko < andraschko.tho...@gmail.com> escreveu: > I could merge it, too but does it really make sense to apply i

Re: Backport for OWB 1.7.x

I could merge it, too but does it really make sense to apply it without migrating to asm7? Am Mo., 19. Nov. 2018 um 16:34 Uhr schrieb Daniel Cunha < daniels...@apache.org>: > Hi Romain, > > Do we have plan to merge it? > Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau < > rmannibu...@gmail.

Re: Backport for OWB 1.7.x

Hi Romain, Do we have plan to merge it? Em ter, 6 de nov de 2018 às 13:13, Romain Manni-Bucau escreveu: > Hello Daniel, > > it is ok for me > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog >

Re: Backport for OWB 1.7.x

Hello Daniel, it is ok for me Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Backport for OWB 1.7.x

Hi Romain, So, the change sounds good to go? Or you still see something to be changed? Em seg, 5 de nov de 2018 3:47 PM, Daniel Cunha Hi Romain, > > You right, the backport include other things which are important as well > like: > changes on NormalScopeProxyFactory and InterceptorDecoratorProx

Re: Backport for OWB 1.7.x

Hi Romain, You right, the backport include other things which are important as well like: changes on NormalScopeProxyFactory and InterceptorDecoratorProxyFactory. But yes, the backport includes the commit that you refer. :) Thank you for your review. Em seg, 5 de nov de 2018 às 15:41, Romain Ma

Re: Backport for OWB 1.7.x

Ok I get it now, so this is not *this* commit you want but one before - likely https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513 - but it was included in the commit you backported ;). makes sense to include that in 1.7 branch IMHO Romain Manni-Bucau @rmannibuc

Re: Backport for OWB 1.7.x

Of course, the issue happening when I'm using JDK11 :) Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha escreveu: > Hi Romain, > > Well... that change make me possible to continue create my singleton > startup like it: > > import javax.annotation.PostConstruct; > import javax.annotation.PreDestro

Re: Backport for OWB 1.7.x

Hi Romain, Well... that change make me possible to continue create my singleton startup like it: import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.ejb.Singleton; import javax.ejb.Startup; @Singleton @Startup public class KernelShutdownListener { @PostCo

Re: Backport for OWB 1.7.x

Hi Daniel, Do you know which part implies the "need", this commit was not suppose to change anything since the code was already supporting java 11, it was just intended to prepare potential change later on. Did a small change in the behavior was introduced - if so it was not intended from my part?