[GitHub] [orc] stiga-huang commented on a change in pull request #934: ORC-1024: [C++] Fix inconsistent bloom filter hashing for numeric values

stiga-huang commented on a change in pull request #934: URL: https://github.com/apache/orc/pull/934#discussion_r727665977 ## File path: c++/src/Reader.cc ## @@ -363,7 +381,7 @@ namespace orc { throw ParseError("Failed to parse the row index"); }

[GitHub] [orc] stiga-huang commented on a change in pull request #934: ORC-1024: [C++] Fix inconsistent bloom filter hashing for numeric values

stiga-huang commented on a change in pull request #934: URL: https://github.com/apache/orc/pull/934#discussion_r727665795 ## File path: c++/src/Reader.cc ## @@ -243,6 +249,18 @@ namespace orc { footer->rowindexstride(),

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

dongjoon-hyun commented on a change in pull request #936: URL: https://github.com/apache/orc/pull/936#discussion_r727582834 ## File path: java/core/src/java/org/apache/orc/impl/filter/FilterFactory.java ## @@ -74,11 +96,6 @@ public static BatchFilter createBatchFilter(Reader.Op

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

dongjoon-hyun commented on a change in pull request #936: URL: https://github.com/apache/orc/pull/936#discussion_r727582243 ## File path: java/core/src/java/org/apache/orc/impl/filter/FilterFactory.java ## @@ -46,16 +49,35 @@ * @param isSchemaCaseAware identifies if the sch

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

dongjoon-hyun commented on a change in pull request #936: URL: https://github.com/apache/orc/pull/936#discussion_r727581686 ## File path: java/core/src/java/org/apache/orc/Reader.java ## @@ -637,6 +639,15 @@ public Options useSelected(boolean newValue) { this.useSelected

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

dongjoon-hyun commented on a change in pull request #936: URL: https://github.com/apache/orc/pull/936#discussion_r727580541 ## File path: java/core/src/java/org/apache/orc/OrcConf.java ## @@ -176,6 +176,15 @@ + "must have the filter\n"

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

dongjoon-hyun commented on a change in pull request #936: URL: https://github.com/apache/orc/pull/936#discussion_r727580287 ## File path: java/core/src/java/org/apache/orc/OrcConf.java ## @@ -176,6 +176,15 @@ + "must have the filter\n"

[GitHub] [orc] pavibhai opened a new pull request #936: ORC-1027: Allows the discovery of filters via the plugin interface.

pavibhai opened a new pull request #936: URL: https://github.com/apache/orc/pull/936 ### What changes were proposed in this pull request? Allow injection of filters to be applied during read via a PluginService using the Java ServiceLoader. ### Why are the changes needed? T

[jira] [Created] (ORC-1027) Filter processing to allow filter injections that cannot be represented via SArgs

Pavan Lanka created ORC-1027: Summary: Filter processing to allow filter injections that cannot be represented via SArgs Key: ORC-1027 URL: https://issues.apache.org/jira/browse/ORC-1027 Project: ORC

[GitHub] [orc] wgtmac commented on a change in pull request #934: ORC-1024: [C++] Fix inconsistent bloom filter hashing for numeric values

wgtmac commented on a change in pull request #934: URL: https://github.com/apache/orc/pull/934#discussion_r727185159 ## File path: c++/src/Reader.cc ## @@ -243,6 +249,18 @@ namespace orc { footer->rowindexstride(),

[GitHub] [orc] jiaoqingbo closed pull request #935: ORC-1026: remove traversing the dictionary when flushDictionary method is called

jiaoqingbo closed pull request #935: URL: https://github.com/apache/orc/pull/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@o

[GitHub] [orc] jiaoqingbo opened a new pull request #935: ORC-1026: remove traversing the dictionary when flushDictionary method is called

jiaoqingbo opened a new pull request #935: URL: https://github.com/apache/orc/pull/935 ### What changes were proposed in this pull request? when write string type column,there is no need to traversing the dictionary when flushDictionary method is called ### Why are the changes