Joe Orton wrote:
> On Wed, Sep 29, 2004 at 11:43:27PM -0400, Stas Bekman wrote:
>
>>Joe Schaefer wrote:
>>
>t/api/aplog.t 351 2.86% 24
>
>
> I wrote a fix for this one the other day since it was easy.
>
committed, thanks!
--Geoff
-
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
> Looks good, I am going to give it a spin shortly. Only one note
> after looking over this patch. I'd keep the definition of
> mpxs_pool_account_t at the top
>
> typedef struct {
> SV *sv;
> #ifdef USE_ITHREADS
> PerlInterpreter *perl;
Joe Schaefer wrote:
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
I've tested it hapilly and it is both a simpler implementation
and gets away with quite an annoying bug, so I'd like to see
it integrated with a few tweaks.
OK, I've cleaned it up with a few macros as you
suggested. Patch be
> +# the APR_EGENERAL error string changed for APR 1.0
> +my $egeneral = "Error string not specified yet";
> +$egeneral = "Internal error"
> +if need_min_apache_version('2.1.0');
this should be have_min_apache_version() instead. basically, use the need*
varian
On Wed, Sep 29, 2004 at 11:43:27PM -0400, Stas Bekman wrote:
> Joe Schaefer wrote:
> >>>t/api/aplog.t 351 2.86% 24
I wrote a fix for this one the other day since it was easy.
--- response/TestAPI/aplog.pm 24 Sep 2004 19:55:35 - 1.21
+++ response/
Joe Schaefer wrote:
Stas Bekman <[EMAIL PROTECTED]> writes:
Joe Schaefer wrote:
... That doesn't mean all the tests pass,
Failed Test Stat Wstat Total Fail Failed List of Failed
---
t/apache/content
Philippe M. Chiasson wrote:
Joe Orton wrote:
On Tue, Sep 28, 2004 at 06:55:32PM -0400, Stas Bekman wrote:
Joe Orton wrote:
Index: modperl_filter.c
===
RCS file:
/home/cvspublic/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrievi
Stas Bekman <[EMAIL PROTECTED]> writes:
> Joe Schaefer wrote:
> >... That doesn't mean all the tests pass,
> > Failed Test Stat Wstat Total Fail Failed List of Failed
> > ---
> > t/apache/content_le
Joe Schaefer wrote:
... That doesn't mean all the tests pass,
Failed Test Stat Wstat Total Fail Failed List of Failed
---
t/apache/content_length_header.t 273 11.11% 2 5 17
t/api/
Stas Bekman <[EMAIL PROTECTED]> writes:
> Joe Schaefer wrote:
>
> > Looks good. It tests fine, so I tried to include it in the patch,
> > but alas:
> > $ cvs add pool_lifetime.t
> > cvs [server aborted]: "add" requires write access to the repository
>
> Right, but you should run:
>
> perl
Joe Schaefer wrote:
Looks good. It tests fine, so I tried to include it
in the patch, but alas:
$ cvs add pool_lifetime.t
cvs [server aborted]: "add" requires write access to the repository
Right, but you should run:
perl util/getdiff.pl newfile1 newfile2 ...
and it'll create a diff for new
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
> I've tested it hapilly and it is both a simpler implementation
> and gets away with quite an annoying bug, so I'd like to see
> it integrated with a few tweaks.
OK, I've cleaned it up with a few macros as you
suggested. Patch below...
> - At
Joe Schaefer wrote:
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
Forgot to mention I want to test this patch and look
thru it carefully before it goes in.
Thanks Phillippe! Keep in mind I threw it together rather
hastily, so if you still like it after testing,
I've tested it hapilly and i
Joe Orton wrote:
On Tue, Sep 28, 2004 at 06:55:32PM -0400, Stas Bekman wrote:
Joe Orton wrote:
Index: modperl_filter.c
===
RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.98
diff -u -r1.
On Tue, Sep 28, 2004 at 06:55:32PM -0400, Stas Bekman wrote:
> Joe Orton wrote:
> >Index: modperl_filter.c
> >===
> >RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/modperl_filter.c,v
> >retrieving revision 1.98
> >diff -u -r1.9
"Philippe M. Chiasson" <[EMAIL PROTECTED]> writes:
> Forgot to mention I want to test this patch and look
> thru it carefully before it goes in.
Thanks Phillippe! Keep in mind I threw it together rather
hastily, so if you still like it after testing, I'll gladly
clean it up a bit (sync the comm
Joe Orton wrote:
On Tue, Sep 28, 2004 at 12:32:36PM -0400, Joe Schaefer wrote:
Stas Bekman <[EMAIL PROTECTED]> writes:
[...]
Any ideas about how to fix the segfaults at startup time too?
I'll try to reproduce it now.
I'm able to get these segfults now, but not reliably.
BTW it was useful to have
Forgot to mention I want to test this patch and look thru it carefully
before it goes in. Won't have time to get to it today, but I'll get around
it tomorrow.
Joe Schaefer wrote:
? config.nice
? pool.patch
? t/core.21302
Index: xs/APR/Pool/APR__Pool.h
===
Yes, I have seen exactly the problem you are describing hapenning, and
getting away without pool userdata would have fixed it for me.
After just a cursory looking over this patch (not tested or anything)
it looks good.
Joe Schaefer wrote:
Index: xs/APR/Pool/APR__Pool.h
=
? config.nice
? pool.patch
? t/core.21302
Index: xs/APR/Pool/APR__Pool.h
===
RCS file: /home/cvspublic/modperl-2.0/xs/APR/Pool/APR__Pool.h,v
retrieving revision 1.17
diff -u -r1.17 APR__Pool.h
--- xs/APR/Pool/APR__Pool.h 14 Jul 2004 23
On Tue, Sep 28, 2004 at 12:32:36PM -0400, Joe Schaefer wrote:
> Stas Bekman <[EMAIL PROTECTED]> writes:
>
> [...]
>
> > > Any ideas about how to fix the segfaults at startup time too?
> >
> > I'll try to reproduce it now.
>
> I'm able to get these segfults now, but not reliably.
BTW it was use
Joe Schaefer wrote:
Stas Bekman <[EMAIL PROTECTED]> writes:
[...]
Any ideas about how to fix the segfaults at startup time too?
I'll try to reproduce it now.
I'm able to get these segfults now, but not reliably.
My first impression is that some APR::Pool SV object
created during post-config, and
Stas Bekman <[EMAIL PROTECTED]> writes:
[...]
> > Any ideas about how to fix the segfaults at startup time too?
>
> I'll try to reproduce it now.
I'm able to get these segfults now, but not reliably.
My first impression is that some APR::Pool SV object
created during post-config, and points at
Joe Orton wrote:
Let's continue this on [EMAIL PROTECTED] since it doesn't seem like there's an
httpd bug currently.
On Mon, Sep 27, 2004 at 01:49:29PM -0400, Joe Schaefer wrote:
Joe Orton <[EMAIL PROTECTED]> writes:
[...]
when it did start up it would segfault consistently when running the
tests
Joe Orton <[EMAIL PROTECTED]> writes:
[...]
> Yes, that fixed the segfaults triggered by the test cases for me. Any
> ideas about how to fix the segfaults at startup time too?
Reposting the backtrace: http://www.apache.org/~jorton/startup.perl
I'm not able to reproduce the startup segfaults yet
Let's continue this on [EMAIL PROTECTED] since it doesn't seem like there's an
httpd bug currently.
On Mon, Sep 27, 2004 at 01:49:29PM -0400, Joe Schaefer wrote:
> Joe Orton <[EMAIL PROTECTED]> writes:
>
> [...]
>
> > when it did start up it would segfault consistently when running the
> > tests
26 matches
Mail list logo
