[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233263#comment-15233263 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user JamesRTaylor commented on the pull

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread JamesRTaylor
Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/156#issuecomment-207677080 +1. Looks great, @chrajeshbabu. Thanks for the excellent work. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (PHOENIX-2156) Support drop of column from table with views

2016-04-08 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233258#comment-15233258 ] Thomas D'Silva commented on PHOENIX-2156: - I will move the tests that require

[jira] [Commented] (PHOENIX-2156) Support drop of column from table with views

2016-04-08 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233225#comment-15233225 ] James Taylor commented on PHOENIX-2156: --- Awesome job, [~tdsilva]. One question: for AlterTableIT

Re: [ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread Nick Dimiduk
Nice work! The Josh maffia is growing. On Friday, April 8, 2016, rajeshb...@apache.org wrote: > Congratulations Josh!! > > On Sat, Apr 9, 2016 at 12:17 AM, Ankit Singhal > > wrote: > > > Congrats Josh!! > > > > On Fri, Apr 8,

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233134#comment-15233134 ] Sergey Soldatov commented on PHOENIX-2535: -- I've pushed renaming stuff for query server/client

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233086#comment-15233086 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user ss77892 commented on a diff in the pull

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233084#comment-15233084 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user ss77892 commented on a diff in the pull

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59098738 --- Diff: pom.xml --- @@ -27,9 +27,11 @@ phoenix-flume phoenix-pig phoenix-server-client -phoenix-server --- End diff

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233082#comment-15233082 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user ss77892 commented on a diff in the pull

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59098717 --- Diff: phoenix-server-client/pom.xml --- @@ -26,29 +26,126 @@ ${project.basedir}/.. +org.apache.phoenix.shaded

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59098646 --- Diff: phoenix-assembly/pom.xml --- @@ -31,76 +32,30 @@ phoenix-assembly Phoenix Assembly Assemble Phoenix artifacts - pom +

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233052#comment-15233052 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user enis commented on a diff in the pull

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread enis
Github user enis commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59096272 --- Diff: pom.xml --- @@ -27,9 +27,11 @@ phoenix-flume phoenix-pig phoenix-server-client -phoenix-server --- End diff --

[jira] [Resolved] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain resolved PHOENIX-2822. --- Resolution: Fixed > Tests that extend BaseHBaseManagedTimeIT are very slow >

[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233048#comment-15233048 ] Hudson commented on PHOENIX-2822: - FAILURE: Integrated in Phoenix-master #1189 (See

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233044#comment-15233044 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user enis commented on a diff in the pull

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread enis
Github user enis commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59095759 --- Diff: phoenix-server-client/pom.xml --- @@ -26,29 +26,126 @@ ${project.basedir}/.. +org.apache.phoenix.shaded

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233037#comment-15233037 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user enis commented on a diff in the pull

[jira] [Updated] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] churro morales updated PHOENIX-2822: Attachment: PHOENIX-2822-98.patch patch for the 98 branch > Tests that extend

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread enis
Github user enis commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59095560 --- Diff: phoenix-query-server/pom.xml --- @@ -0,0 +1,116 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread enis
Github user enis commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59094621 --- Diff: phoenix-assembly/pom.xml --- @@ -31,76 +32,30 @@ phoenix-assembly Phoenix Assembly Assemble Phoenix artifacts - pom +

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233024#comment-15233024 ] ASF GitHub Bot commented on PHOENIX-2535: - Github user enis commented on a diff in the pull

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233020#comment-15233020 ] Nick Dimiduk commented on PHOENIX-2535: --- bq. 4.8 RM should especially check whether the publish is

[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232955#comment-15232955 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on the pull request:

[jira] [Updated] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] churro morales updated PHOENIX-2822: Attachment: PHOENIX-2822.patch here is the rebased patch > Tests that extend

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread churrodog
Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207610636 @samarthjain rebased and put patch up here: https://issues.apache.org/jira/browse/PHOENIX-2822 . Thanks for the review. --- If your project is set up for it, you

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232934#comment-15232934 ] Enis Soztutar commented on PHOENIX-2535: bq. Possible we need to rename it to

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232931#comment-15232931 ] Enis Soztutar commented on PHOENIX-2535: bq. Once the dust settles here, it would be great to

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232919#comment-15232919 ] Sergey Soldatov commented on PHOENIX-2535: -- I created a pull request for easier review.

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232913#comment-15232913 ] ASF GitHub Bot commented on PHOENIX-2535: - GitHub user ss77892 opened a pull request:

[GitHub] phoenix pull request: PHOENIX-2535 Create shaded clients (thin + t...

2016-04-08 Thread ss77892
GitHub user ss77892 opened a pull request: https://github.com/apache/phoenix/pull/159 PHOENIX-2535 Create shaded clients (thin + thick) Shaded client + PHOENIX-2267 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ss77892/phoenix

[jira] [Updated] (PHOENIX-2156) Support drop of column from table with views

2016-04-08 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-2156: Attachment: PHOENIX-2156-v3.patch [~jamestaylor] Thanks for the review. I modified the

[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232883#comment-15232883 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on the pull

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread samarthjain
Github user samarthjain commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207594418 @churrodog - can you please post a rebased patch on the jira. The current patch doesn't apply on master. Thanks! --- If your project is set up for it, you can

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread samarthjain
Github user samarthjain commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207591521 Thanks @churrodog. Nice work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232872#comment-15232872 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user samarthjain commented on the pull

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232841#comment-15232841 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r59082461 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -265,12 +332,18 @@ public

[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232836#comment-15232836 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user chrajeshbabu commented on the pull

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/156#issuecomment-207582047 @JamesRTaylor Thanks for the review. Committed the changes handling the review comments. Refactored the code and added code comments where ever possible.

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232822#comment-15232822 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user JamesRTaylor commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r59080730 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java --- @@ -265,12 +332,18 @@ public

[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232770#comment-15232770 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user chrajeshbabu commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59078097 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java --- @@ -56,6 +57,7 @@ private final MutationState

[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232780#comment-15232780 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user chrajeshbabu commented on a diff in the

[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232775#comment-15232775 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user chrajeshbabu commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59077866 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java --- @@ -402,8 +405,8 @@ private RegionScanner

[GitHub] phoenix pull request: PHOENIX-2628 Ensure split when iterating thr...

2016-04-08 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/156#discussion_r59077569 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java --- @@ -337,6 +384,22 @@ public boolean

[jira] [Commented] (PHOENIX-2628) Ensure split when iterating through results handled correctly

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232766#comment-15232766 ] ASF GitHub Bot commented on PHOENIX-2628: - Github user chrajeshbabu commented on a diff in the

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232740#comment-15232740 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

Re: [ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread rajeshb...@apache.org
Congratulations Josh!! On Sat, Apr 9, 2016 at 12:17 AM, Ankit Singhal wrote: > Congrats Josh!! > > On Fri, Apr 8, 2016 at 10:29 PM, Marek Wiewiorka < > marek.wiewio...@gmail.com> > wrote: > > > Congrats! > > 8 kwi 2016 6:57 PM "Josh Mahonin"

Re: [ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread Ankit Singhal
Congrats Josh!! On Fri, Apr 8, 2016 at 10:29 PM, Marek Wiewiorka wrote: > Congrats! > 8 kwi 2016 6:57 PM "Josh Mahonin" napisał(a): > > > Welcome aboard and congrats (fellow) Josh! > > > > On Fri, Apr 8, 2016 at 12:52 PM, James Taylor

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232675#comment-15232675 ] Josh Elser commented on PHOENIX-2535: - bq. Yep, at the beginning we have discussed what exactly need

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232672#comment-15232672 ] Sergey Soldatov commented on PHOENIX-2535: -- [~elserj] {quote} Ok. Yeah, if we're doing things

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232647#comment-15232647 ] Josh Elser commented on PHOENIX-2535: - bq. phoenix-assembly is generating tarball exactly at the

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232595#comment-15232595 ] Sergey Soldatov commented on PHOENIX-2535: -- [~elserj] {quote} Why make this change in

[jira] [Commented] (PHOENIX-2822) Tests that extend BaseHBaseManagedTimeIT are very slow

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232499#comment-15232499 ] ASF GitHub Bot commented on PHOENIX-2822: - Github user churrodog commented on the pull request:

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread churrodog
Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207521158 made the changes you requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Resolved] (PHOENIX-2201) Support UNNEST in Phoenix/Calcite integration

2016-04-08 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue resolved PHOENIX-2201. -- Resolution: Fixed > Support UNNEST in Phoenix/Calcite integration >

[jira] [Resolved] (PHOENIX-2203) Support UNNEST WITH ORDINALITY in Calcite-Phoenix

2016-04-08 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue resolved PHOENIX-2203. -- Resolution: Fixed > Support UNNEST WITH ORDINALITY in Calcite-Phoenix >

Re: [ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread Marek Wiewiorka
Congrats! 8 kwi 2016 6:57 PM "Josh Mahonin" napisał(a): > Welcome aboard and congrats (fellow) Josh! > > On Fri, Apr 8, 2016 at 12:52 PM, James Taylor > wrote: > > > On behalf of the Apache Phoenix PMC, I'm pleased to announce that Josh > > Elser has

Re: [ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread Josh Mahonin
Welcome aboard and congrats (fellow) Josh! On Fri, Apr 8, 2016 at 12:52 PM, James Taylor wrote: > On behalf of the Apache Phoenix PMC, I'm pleased to announce that Josh > Elser has accepted our invitation to become a committer on the Apache > Phoenix project. He's done

[ANNOUNCE] New Apache Phoenix committer - Josh Elser

2016-04-08 Thread James Taylor
On behalf of the Apache Phoenix PMC, I'm pleased to announce that Josh Elser has accepted our invitation to become a committer on the Apache Phoenix project. He's done an excellent job moving the Phoenix Query Server[1] forward, helping us with maven issues, and being an all around good citizen by

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232444#comment-15232444 ] Nick Dimiduk commented on PHOENIX-2535: --- bq. +1 to rename query server jar yeah, this should have

[jira] [Created] (PHOENIX-2829) queryserver fails with InvalidProtocolBufferException when connecting from thinclient

2016-04-08 Thread Eric Daigneault (JIRA)
Eric Daigneault created PHOENIX-2829: Summary: queryserver fails with InvalidProtocolBufferException when connecting from thinclient Key: PHOENIX-2829 URL: https://issues.apache.org/jira/browse/PHOENIX-2829

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232376#comment-15232376 ] Josh Elser commented on PHOENIX-2535: - (sorry, this is getting long. Do we have reviewboard or

[jira] [Resolved] (PHOENIX-2828) Ordinality should be 1-based in UNNEST WITH ORDINALITY

2016-04-08 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue resolved PHOENIX-2828. -- Resolution: Fixed Fixed in

[jira] [Created] (PHOENIX-2828) Ordinality should be 1-based in UNNEST WITH ORDINALITY

2016-04-08 Thread Maryann Xue (JIRA)
Maryann Xue created PHOENIX-2828: Summary: Ordinality should be 1-based in UNNEST WITH ORDINALITY Key: PHOENIX-2828 URL: https://issues.apache.org/jira/browse/PHOENIX-2828 Project: Phoenix

[jira] [Created] (PHOENIX-2827) Support OFFSET in Calcite-Phoenix

2016-04-08 Thread Maryann Xue (JIRA)
Maryann Xue created PHOENIX-2827: Summary: Support OFFSET in Calcite-Phoenix Key: PHOENIX-2827 URL: https://issues.apache.org/jira/browse/PHOENIX-2827 Project: Phoenix Issue Type: Task

[jira] [Updated] (PHOENIX-2203) Support UNNEST WITH ORDINALITY in Calcite-Phoenix

2016-04-08 Thread Maryann Xue (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maryann Xue updated PHOENIX-2203: - Summary: Support UNNEST WITH ORDINALITY in Calcite-Phoenix (was: Track Calcite support for

[jira] [Commented] (PHOENIX-2535) Create shaded clients (thin + thick)

2016-04-08 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232287#comment-15232287 ] Josh Elser commented on PHOENIX-2535: - bq. I have a suggestion. At the moment there is an ambiguous

[jira] [Commented] (PHOENIX-2722) support mysql "limit,offset" clauses

2016-04-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231911#comment-15231911 ] Hadoop QA commented on PHOENIX-2722: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231862#comment-15231862 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58994358 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java --- @@ -96,6 +97,7 @@ public void testUpsertSelectDoesntSeeUpsertedData()

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231858#comment-15231858 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58994197 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java --- @@ -632,6 +645,16 @@ public static ExecutionCommand

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231854#comment-15231854 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58994035 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java --- @@ -63,6 +64,10 @@ public static

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231849#comment-15231849 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58993926 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java --- @@ -26,7 +28,8 @@ public PTableKey(PName tenantId, String

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58993453 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -631,7 +664,7 @@ private boolean

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231846#comment-15231846 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231832#comment-15231832 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58992390 --- Diff: phoenix-core/src/main/java/org/apache/hadoop/hbase/ipc/controller/MetadataRpcController.java --- @@ -36,7 +37,16 @@

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231823#comment-15231823 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user ankitsinghal commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58991938 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java --- @@ -190,14 +190,8 @@ public void

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231807#comment-15231807 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58990926 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/tx/TxCheckpointIT.java --- @@ -96,6 +97,7 @@ public void testUpsertSelectDoesntSeeUpsertedData()

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231803#comment-15231803 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58990747 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java --- @@ -632,6 +645,16 @@ public static ExecutionCommand

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231800#comment-15231800 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58990594 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsCollectorFactory.java --- @@ -63,6 +64,10 @@ public static

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58990540 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableKey.java --- @@ -26,7 +28,8 @@ public PTableKey(PName tenantId, String

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231789#comment-15231789 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58989689 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -631,7 +664,7 @@ private boolean

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231786#comment-15231786 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58989498 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java --- @@ -133,11 +135,13 @@ // latency and client-side

[jira] [Commented] (PHOENIX-1311) HBase namespaces surfaced in phoenix

2016-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231782#comment-15231782 ] ASF GitHub Bot commented on PHOENIX-1311: - Github user samarthjain commented on a diff in the

[GitHub] phoenix pull request: PHOENIX-1311 HBase namespaces surfaced in ph...

2016-04-08 Thread samarthjain
Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r58989392 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2387,8 +2452,27 @@ public Void call() throws

  1   2   >