Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-207677080
+1. Looks great, @chrajeshbabu. Thanks for the excellent work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-207582047
@JamesRTaylor Thanks for the review. Committed the changes handling the
review comments.
Refactored the code and added code comments where ever possible.
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59078097
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ChunkedResultIterator.java
---
@@ -56,6 +57,7 @@
private final MutationState
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077866
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r59077569
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58642550
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58642188
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641527
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641320
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641238
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641031
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -326,11 +325,12 @@ private static void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640990
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58641009
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640818
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640786
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640556
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640455
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58640276
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -121,8 +170,21 @@ public synchronized void
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639974
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639989
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639956
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639845
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19 @@
};
-
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639358
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638911
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638946
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638661
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58638568
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -423,7 +426,14 @@ private RegionScanner
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58637933
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58637402
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58636239
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58632305
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485551
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485360
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -157,6 +162,7 @@ public Reader
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-205637233
Thanks for the patch, @chrajeshbabu. This is a big improvement over your
initial approach. It's still complex, though. There's an on going cost to
complicating
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484354
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484328
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484293
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484006
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483863
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19 @@
};
-
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483665
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483591
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483357
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483341
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483244
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -326,11 +325,12 @@ private static void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483157
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java ---
@@ -209,7 +209,11 @@ protected ResultIterator
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58482201
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java ---
@@ -196,26 +196,31 @@ public Expression getDynamicFilter() {
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58482075
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481927
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -423,7 +426,14 @@ private RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481858
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481703
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481542
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481362
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58479273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -165,7 +183,7 @@ public RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58478944
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58478608
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -157,6 +162,7 @@ public Reader
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58477862
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -86,8 +98,8 @@ public static void doSetup() throws
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r5845
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
@@ -727,7 +727,7 @@ public void
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/156
PHOENIX-2628 Ensure split when iterating through results handled corrâ¦
The patch fixes issues with splits and merges while scanning local indexes.
You can merge this pull request into a
59 matches
Mail list logo
