chrisdutz opened a new pull request #55: Hopefully the last to get PRs working
URL: https://github.com/apache/incubator-plc4x/pull/55
- Removed plc4c as this is empty
- Added the driver bases to the build
This is an
chrisdutz opened a new pull request #51: Added the content for Sebastian Rühl
to the team page.
URL: https://github.com/apache/incubator-plc4x/pull/51
New PR to test the hopefully fixed syncing issues.
This is an automated
chrisdutz merged pull request #51: Added the content for Sebastian Rühl to the
team page.
URL: https://github.com/apache/incubator-plc4x/pull/51
This is an automated message from the Apache Git Service.
To respond to the
gg587998 opened a new pull request #58: Feature/example poll loop
URL: https://github.com/apache/incubator-plc4x/pull/58
example which can be used to fetch data in a continuous loop
This is an automated message from the
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270390474
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270349354
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270348761
##
File path:
JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108
ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270356174
##
File path:
timbo2k merged pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
timbo2k commented on a change in pull request #57: Feature/plc4 x 108 ping
method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270352832
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270367844
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270368233
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270367740
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270366988
##
File path:
sruehl commented on a change in pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270368552
##
File path:
JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108
ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270379357
##
File path:
JulianFeinauer commented on a change in pull request #57: Feature/plc4 x 108
ping method
URL: https://github.com/apache/incubator-plc4x/pull/57#discussion_r270379294
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821317
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ResultHandler.java
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823035
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827655
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821901
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperImpl.java
##
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827260
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262823550
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822210
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822363
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826904
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821540
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScrapeJob.java
##
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827288
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822320
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262827814
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822739
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821820
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java
##
@@
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822268
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262826702
##
File path:
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822036
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/ScraperTaskImpl.java
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262821681
##
File path:
plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/Scraper.java
##
@@
JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470009105
Hey @timbo2k I'm pretty impressed by your work (especially I like the syntax
we now have for the triggering modes).
I added a lot
JulianFeinauer commented on issue #45: Minor changes on getting-involved.adoc
URL: https://github.com/apache/incubator-plc4x/pull/45#issuecomment-47693
This is an automated message from the Apache Git Service.
To
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263058883
##
File path:
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263046032
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add
Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263054168
##
File path: plc4j/utils/scraper/pom.xml
##
@@ -65,6 +65,11 @@
plc4j-connection-pool
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263079012
##
File path:
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to
PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263058508
##
File path:
timbo2k commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470257889
changed most of the issue from @JulianFeinauer
for refactoring and rework to be more generic i created issues PLC4X-89 and
PLC4X-90
timbo2k edited a comment on issue #46: PLC4X-88:
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-469853081
Hi everybody
I had worked on the triggered scraper as stated on the list.
The pushed branch is the current version to retrieve your opinion ... so
handle
timbo2k opened a new pull request #46: PLC4X-88:
URL: https://github.com/apache/incubator-plc4x/pull/46
- introduced TriggeredScraper and belonging classes
- made classes of old scraper deprecated
- added scheduled and S7-variable trigger (boolean and numeric)
- java-docs
chrisdutz commented on issue #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471326798
If it works, … merge it (my opinion)
Chris
Von: timbo2k
Antworten an: apache/incubator-plc4x
Datum: Sonntag, 10. März
JulianFeinauer commented on issue #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471328401
+1 (I even heard the original pr author is a very good looking guy...).
Go merge it
Julian
Von meinem Mobiltelefon
timbo2k commented on issue #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471316217
Hey ... i made a few changes so that Scraper isn't dependent on S7 and added
a scraper yml and test for Modbus that has been working fine ... so
timbo2k merged pull request #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
timbo2k merged pull request #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log
timbo2k commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470495212
I will close discussion and merge PR into master
This is an automated
JulianFeinauer commented on issue #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-470423361
Hey, from my perspective all issues are adressed (either directly or via the
new Jira Issues) so I feel fine with this PR.
So feel
JulianFeinauer opened a new pull request #47: Extend field with type information
URL: https://github.com/apache/incubator-plc4x/pull/47
Heyho, this PR refers to the mail exchange with the driver specificality of
the (new) scraper (PR #46 ).
Please check if this change is acceptable for
justinmclean merged pull request #48: Correcting two typos in contributing.adoc
URL: https://github.com/apache/incubator-plc4x/pull/48
This is an automated message from the Apache Git Service.
To respond to the message,
cptblaubaer opened a new pull request #48: Correcting two typos in
contributing.adoc
URL: https://github.com/apache/incubator-plc4x/pull/48
This is an automated message from the Apache Git Service.
To respond to the
chrisdutz merged pull request #49: INFRA-18056
URL: https://github.com/apache/incubator-plc4x/pull/49
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chrisdutz opened a new pull request #50: Preparing a little more complex PR for
figuring out the Sync issues.
URL: https://github.com/apache/incubator-plc4x/pull/50
- Removing the "Community" menu and merging it's content to other parts of
the site.
clambertus opened a new pull request #49: INFRA-18056
URL: https://github.com/apache/incubator-plc4x/pull/49
whitespace commit test PR for referenced infra issue
This is an automated message from the Apache Git Service.
To
chrisdutz opened a new pull request #59: Feature/alternate plc4 x 108
URL: https://github.com/apache/incubator-plc4x/pull/59
Hi,
in this alternate implementation, I added a "ping" method to the default API
and moved the code for the TCP ping into the classes actually involved in TCP
sruehl commented on a change in pull request #59: Feature/alternate plc4 x 108
URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273873825
##
File path:
plc4j/protocols/driver-bases/base/src/main/java/org/apache/plc4x/java/base/connection/AbstractPlcConnection.java
JulianFeinauer commented on issue #59: Feature/alternate plc4 x 108
URL: https://github.com/apache/incubator-plc4x/pull/59#issuecomment-481596726
@chrisdutz thank you for the PR! I will try to review it this week and start
some tests with our S7 PLC here, to see if it works.
chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x
108
URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273877508
##
File path:
chrisdutz commented on a change in pull request #59: Feature/alternate plc4 x
108
URL: https://github.com/apache/incubator-plc4x/pull/59#discussion_r273874554
##
File path:
shivaylamba opened a new pull request #1: Added Meta description and keywords
URL: https://github.com/apache/plc4x-website/pull/1
Added a list of meta keywords and description for plc4x - project summary
page
This is an
shivaylamba commented on issue #1: Added Meta description and keywords
URL: https://github.com/apache/plc4x-website/pull/1#issuecomment-488647749
Ok sir, I will do that. But thanks for the information
This is an automated
chrisdutz commented on issue #1: Added Meta description and keywords
URL: https://github.com/apache/plc4x-website/pull/1#issuecomment-488645600
Unfortunately we can't accept this PR as the content of this repo is 100%
automatically generated from the build in plc4x git repo. Would be great
dominikriemer opened a new pull request #2: PLC4X landing page
URL: https://github.com/apache/plc4x-build-tools/pull/2
This PR adds some improvements to the PLC4X homepage:
- teaser image + teaser text
- improved layout of the feature sections
- carousel to show integrations on the
chrisdutz merged pull request #2: PLC4X landing page
URL: https://github.com/apache/plc4x-build-tools/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
NiklasMerz opened a new pull request #1: Remove headline border and background
URL: https://github.com/apache/plc4x-build-tools/pull/1
I would remove the background for all `h` tags to make it look more "clean"
and "modern"
See mail to mailing list.
splatch opened a new pull request #4: More content about MSpec, its use and
overall structure.
URL: https://github.com/apache/plc4x-build-tools/pull/4
Main intention is to provide a description to someone who is unfamiliar with
protocol development and knows nothing about MSpec.
splatch commented on issue #3: [WIP] PLC4X-193 Support for little endian types
in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613112539
@chrisdutz I didn't do any grouping cause `Protocol` itself doesn't have any
marks which indicate its byte order.
chrisdutz commented on issue #3: [WIP] PLC4X-193 Support for little endian
types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613245404
Hi Lukasz ... well this protocol level switch is already there ... if you
initialize the Read and WriteBuffers as
ottobackwards opened a new pull request #144:
URL: https://github.com/apache/plc4x/pull/144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ottobackwards opened a new pull request #142:
URL: https://github.com/apache/plc4x/pull/142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ottobackwards opened a new pull request #143:
URL: https://github.com/apache/plc4x/pull/143
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
splatch opened a new pull request #3: [WIP] PLC4X-193 Support for little endian
types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3
This is work in progress.
This is an automated message from the
chrisdutz commented on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-619862104
Oh gee .. I can't believe how long this has been open .. I am extremely
sorry for that.
I just had a look and to me it seems as if the same thing you are addressing
here is
chrisdutz commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-619862951
Any progress on bringing this to mspec?
This is an automated message from the Apache Git Service.
To respond to
chrisdutz commented on pull request #119:
URL: https://github.com/apache/plc4x/pull/119#issuecomment-619860506
I'm going to close this one as the problem is no longer applicable to the
new S7 driver.
This is an automated
glcj commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-620280905
>
>
> Any progress on bringing this to mspec?
Hi Chris,
At this moment I am migrating Merlot to use the PLC4X driver model, as soon
as I finish I will carry out
ottobackwards opened a new pull request #146:
URL: https://github.com/apache/plc4x/pull/146
- fixed some of the list stuff
- changed to use lists for parameters
added note: the response items are created in the driver and opaque, they
must be given back to the driver to free().
ottobackwards opened a new pull request #145:
URL: https://github.com/apache/plc4x/pull/145
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ottobackwards opened a new pull request #150:
URL: https://github.com/apache/plc4x/pull/150
… to plc4_connection and plc4c_system to start
clang-format changes
add ability to look up an element from a void*
fix some bugs around cleanup.
logic to destroy connections
ottobackwards opened a new pull request #147:
URL: https://github.com/apache/plc4x/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
splatch commented on pull request #3:
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-624355650
This PR is not relevant any more due to mentioned ability of `ReadBuffer`
and `WriteBuffer`.
This is an
splatch commented on pull request #141:
URL: https://github.com/apache/plc4x/pull/141#issuecomment-624355174
I'm closing this one since it is not required to get ADS handling. Basic
fields which are assembled to bit, byte or int types can be mapped using a
receiving order without need to
ottobackwards opened a new pull request #149:
URL: https://github.com/apache/plc4x/pull/149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ottobackwards opened a new pull request #148:
URL: https://github.com/apache/plc4x/pull/148
Use plc4c_data not void*
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ottobackwards opened a new pull request #152:
URL: https://github.com/apache/plc4x/pull/152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629273548
never mind
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ottobackwards closed pull request #156:
URL: https://github.com/apache/plc4x/pull/156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629213899
OK, I'll add that.
This is an automated message from the Apache Git Service.
To respond to the message,
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095469
Perhaps inverting the logic and allowing to disable tests would be an option
...
This is an automated message
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095235
The thing with this is that now you can't build without tests ... I
intentionally built it that way, that you can do a maven build and skip tests
...
ottobackwards opened a new pull request #156:
URL: https://github.com/apache/plc4x/pull/156
If you are just working on c, and in CLion or something, the dependency on
BUILD_PHASE for the maven caller doesn't make sense.
Changes so that you can work only in C.
note: you still
ottobackwards opened a new pull request #151:
URL: https://github.com/apache/plc4x/pull/151
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
JulianFeinauer opened a new pull request #157:
URL: https://github.com/apache/plc4x/pull/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
asfgit merged pull request #157:
URL: https://github.com/apache/plc4x/pull/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch opened a new pull request #185:
URL: https://github.com/apache/plc4x/pull/185
Comments might occur after field, so rule for next one will catch it.
However this does not work in case of last field. It will confuse parser with
unexpected input.
201 - 300 of 2116 matches
Mail list logo