[GitHub] [qpid-proton] astitcher commented on pull request #265: PROTON-2247 Raw connection API for proactor (epoll implementation)

2020-07-16 Thread GitBox
astitcher commented on pull request #265: URL: https://github.com/apache/qpid-proton/pull/265#issuecomment-659773351 > pn_raw_connection_free is not yet implemented in the pull request and the documentation about ownership of the raw connection is perhaps out of date, but I presume you

[jira] [Commented] (PROTON-2247) [c] Proactor API to support 'raw' TCP connections using the proactor event loop

2020-07-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159588#comment-17159588 ] ASF GitHub Bot commented on PROTON-2247: astitcher commented on pull request #265: URL:

[jira] [Commented] (PROTON-2247) [c] Proactor API to support 'raw' TCP connections using the proactor event loop

2020-07-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159493#comment-17159493 ] ASF GitHub Bot commented on PROTON-2247: cliffjansen commented on pull request #265: URL:

[GitHub] [qpid-proton] cliffjansen commented on pull request #265: PROTON-2247 Raw connection API for proactor (epoll implementation)

2020-07-16 Thread GitBox
cliffjansen commented on pull request #265: URL: https://github.com/apache/qpid-proton/pull/265#issuecomment-659671286 Very nice. +1 on the API. pn_raw_connection_free is not yet implemented in the pull request and the documentation about ownership of the raw connection is perhaps

[jira] [Resolved] (DISPATCH-1686) system_tests_policy_oversize_compound fails with new ASAN leak

2020-07-16 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1686. - Resolution: Cannot Reproduce > system_tests_policy_oversize_compound fails with new

[jira] [Commented] (QPID-8455) [Broker-J]Use allow/deny list terminology for existing attributes and context variables

2020-07-16 Thread Robert Godfrey (Jira)
[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159176#comment-17159176 ] Robert Godfrey commented on QPID-8455: -- [~orudyy] Personally I think it's acceptable to simply do the

[jira] [Commented] (QPID-8454) [Broker-J] Expose configured object statistics in prometheus format

2020-07-16 Thread Alex Rudyy (Jira)
[ https://issues.apache.org/jira/browse/QPID-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159082#comment-17159082 ] Alex Rudyy commented on QPID-8454: -- [~rgodfrey], I like the ideas of defining metric names as {{qpid_}}

[jira] [Comment Edited] (QPID-8455) [Broker-J]Use allow/deny list terminology for existing attributes and context variables

2020-07-16 Thread Alex Rudyy (Jira)
[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159072#comment-17159072 ] Alex Rudyy edited comment on QPID-8455 at 7/16/20, 9:46 AM: [~rgodfrey], I

[jira] [Commented] (QPID-8455) [Broker-J]Use allow/deny list terminology for existing attributes and context variables

2020-07-16 Thread Alex Rudyy (Jira)
[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159072#comment-17159072 ] Alex Rudyy commented on QPID-8455: -- [~rgodfrey], I completely agree that the renaming of attributes

[jira] [Commented] (QPID-8454) [Broker-J] Expose configured object statistics in prometheus format

2020-07-16 Thread Robert Godfrey (Jira)
[ https://issues.apache.org/jira/browse/QPID-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159065#comment-17159065 ] Robert Godfrey commented on QPID-8454: -- [~orudyy] I've not thought *hugely* about this... but my gut

[jira] [Commented] (QPID-8455) [Broker-J]Use allow/deny list terminology for existing attributes and context variables

2020-07-16 Thread Robert Godfrey (Jira)
[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159045#comment-17159045 ] Robert Godfrey commented on QPID-8455: -- [~orudyy] I worry the "alternative names" could lead to a

[jira] [Commented] (QPIDJMS-499) Update to Netty 4.1.50.Final

2020-07-16 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159004#comment-17159004 ] Robbie Gemmell commented on QPIDJMS-499: The last commit above was actually meant for

[jira] [Commented] (PROTON-2208) Change base C language/compiler requirements to C99 or equivalent

2020-07-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158967#comment-17158967 ] ASF subversion and git services commented on PROTON-2208: - Commit

[jira] [Commented] (PROTON-2080) cc1plus: warning: -Wformat-security ignored without -Wformat [-Wformat-security]

2020-07-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158968#comment-17158968 ] ASF subversion and git services commented on PROTON-2080: - Commit