[jira] [Comment Edited] (QPIDJMS-534) BalancedProviderFuture.sync stuck forever during connection recovery

2021-04-22 Thread Ravi Nirmal (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330007#comment-17330007 ] Ravi Nirmal edited comment on QPIDJMS-534 at 4/23/21, 6:31 AM: ---

[jira] [Commented] (QPIDJMS-534) BalancedProviderFuture.sync stuck forever during connection recovery

2021-04-22 Thread Ravi Nirmal (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330007#comment-17330007 ] Ravi Nirmal commented on QPIDJMS-534: - I quickly checked and it looks that jms.reque

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329372#comment-17329372 ] ASF GitHub Bot commented on PROTON-2377: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
DreamPearl commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618682920 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety re

[GitHub] [qpid-jms] stephennimmo commented on pull request #40: Remove InetAddress.getByName lookup for compare

2021-04-22 Thread GitBox
stephennimmo commented on pull request #40: URL: https://github.com/apache/qpid-jms/pull/40#issuecomment-825125144 Not sure why the "Travis CI - Pull Request Cancelled after 11m — Build Canceled" happened. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [qpid-jms] stephennimmo opened a new pull request #40: Remove InetAddress.getByName lookup for compare

2021-04-22 Thread GitBox
stephennimmo opened a new pull request #40: URL: https://github.com/apache/qpid-jms/pull/40 URIs should be able to resolve to the same IP address, as the brokers may be running behind a proxy. For example, I have a container-based broker setup running in Kubernetes and I am exposing

[jira] [Resolved] (DISPATCH-2040) Some details missing on dispositions forwarded by router on transacted sessions

2021-04-22 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2040. - Assignee: Ganesh Murthy Resolution: Fixed > Some details missing on dispositions

[jira] [Commented] (DISPATCH-2040) Some details missing on dispositions forwarded by router on transacted sessions

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329329#comment-17329329 ] ASF GitHub Bot commented on DISPATCH-2040: -- asfgit closed pull request #1115:

[jira] [Commented] (DISPATCH-2040) Some details missing on dispositions forwarded by router on transacted sessions

2021-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329328#comment-17329328 ] ASF subversion and git services commented on DISPATCH-2040: ---

[GitHub] [qpid-dispatch] asfgit closed pull request #1115: DISPATCH-2040 - For link routes, even if there is no change in dispos…

2021-04-22 Thread GitBox
asfgit closed pull request #1115: URL: https://github.com/apache/qpid-dispatch/pull/1115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329294#comment-17329294 ] ASF GitHub Bot commented on PROTON-2377: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618593227 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329292#comment-17329292 ] ASF GitHub Bot commented on PROTON-2377: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618594097 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329291#comment-17329291 ] ASF GitHub Bot commented on PROTON-2377: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618593227 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329259#comment-17329259 ] ASF GitHub Bot commented on PROTON-2377: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
astitcher commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618556498 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety req

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329256#comment-17329256 ] ASF GitHub Bot commented on PROTON-2377: astitcher commented on a change in pull

[GitHub] [qpid-proton] astitcher commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
astitcher commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618554739 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety req

[jira] [Commented] (DISPATCH-2055) AddressSanitizer: heap-use-after-free in write_log during system_tests_qdmanage

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329245#comment-17329245 ] ASF GitHub Bot commented on DISPATCH-2055: -- codecov-commenter edited a commen

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1146: DISPATCH-2055: Eliminated log_lock and used the log_source_lock instead

2021-04-22 Thread GitBox
codecov-commenter edited a comment on pull request #1146: URL: https://github.com/apache/qpid-dispatch/pull/1146#issuecomment-824404746 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1146?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329214#comment-17329214 ] ASF GitHub Bot commented on PROTON-2370: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
gemmellr commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618517799 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: For later reference, the new JIR

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329212#comment-17329212 ] ASF GitHub Bot commented on PROTON-2377: gemmellr commented on a change in pull

[GitHub] [qpid-proton] gemmellr commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
gemmellr commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618516574 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety requ

[jira] [Comment Edited] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Sebastiaan la Fleur (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329190#comment-17329190 ] Sebastiaan la Fleur edited comment on PROTON-2378 at 4/22/21, 3:14 PM: ---

[jira] [Commented] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Sebastiaan la Fleur (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329190#comment-17329190 ] Sebastiaan la Fleur commented on PROTON-2378: - [~robbie] Thank you for the q

[GitHub] [qpid-dispatch] asfgit closed pull request #1153: DO NOT MERGE - extend travis timeouts hugely

2021-04-22 Thread GitBox
asfgit closed pull request #1153: URL: https://github.com/apache/qpid-dispatch/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Assigned] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned PROTON-2378: -- Assignee: (was: Ken Giusti) > [Python] AMQP client with only sender gets stuck on select

[jira] [Assigned] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Ken Giusti (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned PROTON-2378: -- Assignee: Ken Giusti > [Python] AMQP client with only sender gets stuck on select timing out

[jira] [Commented] (DISPATCH-2041) TSan data race reported from qd_connection_free in system_tests_edge_router

2021-04-22 Thread Ganesh Murthy (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329179#comment-17329179 ] Ganesh Murthy commented on DISPATCH-2041: - I am thinking that this problem mig

[jira] [Commented] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329166#comment-17329166 ] Robbie Gemmell commented on PROTON-2378: Python is not my thing, but would I be

[jira] [Created] (QPID-8520) ReadPendingException thrown by Broker-J intermittently

2021-04-22 Thread Kyrre (Jira)
Kyrre created QPID-8520: --- Summary: ReadPendingException thrown by Broker-J intermittently Key: QPID-8520 URL: https://issues.apache.org/jira/browse/QPID-8520 Project: Qpid Issue Type: Bug Com

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1153: DO NOT MERGE - extend travis timeouts hugely

2021-04-22 Thread GitBox
jiridanek commented on a change in pull request #1153: URL: https://github.com/apache/qpid-dispatch/pull/1153#discussion_r618452376 ## File path: .travis.yml ## @@ -204,7 +212,7 @@ script: - popd # Workaround on macOS for PROTON-808 Binaries have their library locations stri

[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1153: DO NOT MERGE - extend travis timeouts hugely

2021-04-22 Thread GitBox
kgiusti commented on a change in pull request #1153: URL: https://github.com/apache/qpid-dispatch/pull/1153#discussion_r618456683 ## File path: .travis.yml ## @@ -204,7 +212,7 @@ script: - popd # Workaround on macOS for PROTON-808 Binaries have their library locations stripp

[jira] [Commented] (QPIDJMS-534) BalancedProviderFuture.sync stuck forever during connection recovery

2021-04-22 Thread Robbie Gemmell (Jira)
[ https://issues.apache.org/jira/browse/QPIDJMS-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329143#comment-17329143 ] Robbie Gemmell commented on QPIDJMS-534: I didnt spot your initial report. It l

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1153: DO NOT MERGE - extend travis timeouts hugely

2021-04-22 Thread GitBox
kgiusti opened a new pull request #1153: URL: https://github.com/apache/qpid-dispatch/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [qpid-dispatch] grs commented on pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-22 Thread GitBox
grs commented on pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#issuecomment-824779284 > Problem: This branch hangs if there is no server I believe I have a fix for this in https://github.com/ChugR/qpid-dispatch/pull/81 > On the connector side serve

[jira] [Updated] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Sebastiaan la Fleur (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastiaan la Fleur updated PROTON-2378: Component/s: proton-c > [Python] AMQP client with only sender gets stuck on select

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327985#comment-17327985 ] ASF GitHub Bot commented on PROTON-2377: DreamPearl commented on a change in pul

[jira] [Updated] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Sebastiaan la Fleur (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastiaan la Fleur updated PROTON-2378: Description: Python version: 3.6.8 Unfortunately not yet tested on proton-c-0.34.

[jira] [Created] (PROTON-2378) [Python] AMQP client with only sender gets stuck on select timing out

2021-04-22 Thread Sebastiaan la Fleur (Jira)
Sebastiaan la Fleur created PROTON-2378: --- Summary: [Python] AMQP client with only sender gets stuck on select timing out Key: PROTON-2378 URL: https://issues.apache.org/jira/browse/PROTON-2378 P

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17328646#comment-17328646 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on pull request #11

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17328504#comment-17328504 ] ASF GitHub Bot commented on DISPATCH-1878: -- ChugR commented on pull request #

[GitHub] [qpid-dispatch] ChugR commented on pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-22 Thread GitBox
ChugR commented on pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#issuecomment-824774480 Problem: This branch hangs if there is no server There is no useful comparison between main branch, which does not hang, and this branch. Main branch closes the client con

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327603#comment-17327603 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
DreamPearl commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618314415 ## File path: cpp/include/proton/delivery.hpp ## @@ -64,6 +65,9 @@ class delivery : public transfer { /// Settle with MODIFIED state. PN_CP

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327874#comment-17327874 ] ASF GitHub Bot commented on PROTON-2377: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
jiridanek commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618311500 ## File path: cpp/src/sender.cpp ## @@ -60,14 +61,20 @@ class target sender::target() const { } namespace { -// TODO: revisit if thread safety req

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327894#comment-17327894 ] ASF GitHub Bot commented on PROTON-2377: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
jiridanek commented on a change in pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#discussion_r618311040 ## File path: cpp/include/proton/delivery.hpp ## @@ -64,6 +65,9 @@ class delivery : public transfer { /// Settle with MODIFIED state. PN_CPP

[jira] [Commented] (DISPATCH-1878) Client app not getting a response through tcpListener

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327599#comment-17327599 ] ASF GitHub Bot commented on DISPATCH-1878: -- grs commented on a change in pull

[GitHub] [qpid-proton] codecov-commenter commented on pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
codecov-commenter commented on pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#issuecomment-824744524 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/310?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-22 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r618302219 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327593#comment-17327593 ] ASF GitHub Bot commented on PROTON-2377: codecov-commenter edited a comment on p

[GitHub] [qpid-dispatch] grs commented on a change in pull request #1129: DISPATCH-1878: Handle half-closed TCP connections - DO NOT MERGE

2021-04-22 Thread GitBox
grs commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r618302065 ## File path: src/adaptors/tcp_adaptor.c ## @@ -1257,13 +1489,17 @@ static void qdr_tcp_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327589#comment-17327589 ] ASF GitHub Bot commented on PROTON-2377: codecov-commenter commented on pull req

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
codecov-commenter edited a comment on pull request #310: URL: https://github.com/apache/qpid-proton/pull/310#issuecomment-824744524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327255#comment-17327255 ] ASF GitHub Bot commented on PROTON-2377: DreamPearl opened a new pull request #3

[GitHub] [qpid-proton] DreamPearl opened a new pull request #310: PROTON-2377: [cpp] Make tag_counter in sender.cpp atomic

2021-04-22 Thread GitBox
DreamPearl opened a new pull request #310: URL: https://github.com/apache/qpid-proton/pull/310 Issue: https://issues.apache.org/jira/browse/PROTON-2377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (DISPATCH-2046) Panic in handle due to deleted connector.

2021-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327247#comment-17327247 ] Jiri Daněk commented on DISPATCH-2046: -- [~gmurthy] I might've seen the issue this

[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327236#comment-17327236 ] ASF GitHub Bot commented on DISPATCH-848: - jiridanek edited a comment on pull r

[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init

2021-04-22 Thread GitBox
jiridanek edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824703443 https://issues.apache.org/jira/browse/DISPATCH-1917, already known issue https://travis-ci.com/github/apache/qpid-dispatch/jobs/500384328#L6074 ``` 45: =

[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327230#comment-17327230 ] ASF GitHub Bot commented on DISPATCH-848: - jiridanek commented on pull request

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init

2021-04-22 Thread GitBox
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824703443 https://travis-ci.com/github/apache/qpid-dispatch/jobs/500384328#L6074 ``` 45: == 45: WARNING: ThreadSanitizer: data race (pid=17221) 45:

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327223#comment-17327223 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on pull request #3

[GitHub] [qpid-proton] DreamPearl commented on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
DreamPearl commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-824701452 > @DreamPearl Now close the Jira, PROTON-2370. It should have yourself as assignee, the next upcoming release as the Fix Version and status should be **Resolved** (not Clos

[jira] [Resolved] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread Rakhi Kumari (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakhi Kumari resolved PROTON-2370. -- Resolution: Fixed > [cpp] An accessor for the delivery tag > -

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327215#comment-17327215 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on a change in pull

[GitHub] [qpid-proton] jiridanek commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
jiridanek commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618251505 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327209#comment-17327209 ] ASF GitHub Bot commented on PROTON-2370: jiridanek edited a comment on pull requ

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327208#comment-17327208 ] ASF GitHub Bot commented on PROTON-2370: jiridanek commented on pull request #30

[GitHub] [qpid-proton] jiridanek edited a comment on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
jiridanek edited a comment on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-824691409 @DreamPearl Now close the Jira, PROTON-2370. It should have yourself as assignee, the next upcoming release as the Fix Version and status should be **Resolved** (not

[GitHub] [qpid-proton] jiridanek commented on pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
jiridanek commented on pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#issuecomment-824691409 @DreamPearl Now close the Jira, PROTON-2370. It should have yourself as assignee, the next upcoming release as the Fix Version and status should be **Resolved*** (not Closed

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327205#comment-17327205 ] ASF subversion and git services commented on PROTON-2370: - Commi

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327206#comment-17327206 ] ASF GitHub Bot commented on PROTON-2370: jiridanek merged pull request #309: URL

[GitHub] [qpid-proton] jiridanek merged pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
jiridanek merged pull request #309: URL: https://github.com/apache/qpid-proton/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Created] (QPID-8519) Improve broker logs for SSL handshake failure caused by invalid SNI

2021-04-22 Thread Dedeepya (Jira)
Dedeepya created QPID-8519: -- Summary: Improve broker logs for SSL handshake failure caused by invalid SNI Key: QPID-8519 URL: https://issues.apache.org/jira/browse/QPID-8519 Project: Qpid Issue Typ

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327200#comment-17327200 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618232507 ## File path: cpp/src/delivery_test.cpp ## @@ -0,0 +1,139 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[jira] [Commented] (PROTON-2370) [cpp] An accessor for the delivery tag

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327199#comment-17327199 ] ASF GitHub Bot commented on PROTON-2370: DreamPearl commented on a change in pul

[GitHub] [qpid-proton] DreamPearl commented on a change in pull request #309: PROTON-2370: [cpp] An accessor for the delivery tag

2021-04-22 Thread GitBox
DreamPearl commented on a change in pull request #309: URL: https://github.com/apache/qpid-proton/pull/309#discussion_r618229224 ## File path: cpp/src/sender.cpp ## @@ -64,10 +64,18 @@ namespace { uint64_t tag_counter = 0; Review comment: Okay. Done! -- This is an

[jira] [Created] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

2021-04-22 Thread Rakhi Kumari (Jira)
Rakhi Kumari created PROTON-2377: Summary: [cpp] tag_counter is not used in a thread safe way in sender.cpp Key: PROTON-2377 URL: https://issues.apache.org/jira/browse/PROTON-2377 Project: Qpid Proton

[jira] [Commented] (DISPATCH-2072) [macOS] test_same_name_route_receivers_through_C timeout in system_tests_link_routes

2021-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327186#comment-17327186 ] Jiri Daněk commented on DISPATCH-2072: -- There is a similar issue in test system_t

[jira] [Created] (DISPATCH-2072) [macOS] test_same_name_route_receivers_through_C timeout in system_tests_link_routes

2021-04-22 Thread Jira
Jiri Daněk created DISPATCH-2072: Summary: [macOS] test_same_name_route_receivers_through_C timeout in system_tests_link_routes Key: DISPATCH-2072 URL: https://issues.apache.org/jira/browse/DISPATCH-2072

[jira] [Commented] (DISPATCH-1787) system_tests_edge_router failure with Timeout

2021-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/DISPATCH-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327182#comment-17327182 ] Jiri Daněk commented on DISPATCH-1787: -- Variation on this: a timeout inside one o

[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327172#comment-17327172 ] ASF GitHub Bot commented on DISPATCH-848: - jiridanek commented on pull request

[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init

2021-04-22 Thread GitBox
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824645058 https://travis-ci.com/github/apache/qpid-dispatch/jobs/500355035#L4493 ``` 45: == 45: ERRO

[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149

2021-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327167#comment-17327167 ] ASF GitHub Bot commented on DISPATCH-848: - codecov-commenter edited a comment o

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init

2021-04-22 Thread GitBox
codecov-commenter edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-824182600 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[GitHub] [qpid-dispatch] codecov-commenter edited a comment on pull request #1152: Bump @patternfly/react-core from 4.106.2 to 4.115.1 in /console/react

2021-04-22 Thread GitBox
codecov-commenter edited a comment on pull request #1152: URL: https://github.com/apache/qpid-dispatch/pull/1152#issuecomment-824598478 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1152?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+com

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1152: Bump @patternfly/react-core from 4.106.2 to 4.115.1 in /console/react

2021-04-22 Thread GitBox
codecov-commenter commented on pull request #1152: URL: https://github.com/apache/qpid-dispatch/pull/1152#issuecomment-824598478 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1152?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1151: Bump @patternfly/patternfly from 4.96.2 to 4.102.1 in /console/react

2021-04-22 Thread GitBox
codecov-commenter commented on pull request #1151: URL: https://github.com/apache/qpid-dispatch/pull/1151#issuecomment-824594004 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1151?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u