[jira] [Commented] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-21 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706717#comment-14706717 ] Rajith Attapattu commented on QPID-6701: Couple of points, 1. Assert wa

[jira] [Commented] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-20 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705746#comment-14705746 ] Rajith Attapattu commented on QPID-6701: "QPID-6040 (rev 1620659) ch

[jira] [Created] (QPID-6701) [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown

2015-08-18 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-6701: -- Summary: [Regression btw 0.30 - 0.32] If address doesn't resolve an exception is not thrown Key: QPID-6701 URL: https://issues.apache.org/jira/browse/QPID

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu
s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30379/#review70627 --- On Feb. 2, 2015, 6:38 p.m., rajith attapattu wrote: > > ---

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-02-02 Thread rajith attapattu
/codec2/TypeRegistry.java PRE-CREATION Diff: https://reviews.apache.org/r/30379/diff/ Testing --- Thanks, rajith attapattu

Re: Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-01-28 Thread rajith attapattu
PRE-CREATION > > proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesDecoder.java > PRE-CREATION > > proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30379/diff/ > > > Testing > --- > > > Thanks, > > rajith attapattu > >

Review Request 30379: Skeleton code for a possible approach for codec improvements in proton-j.

2015-01-28 Thread rajith attapattu
proton-j/src/main/java/org/apache/qpid/proton/codec2/TransportTypesEncoder.java PRE-CREATION Diff: https://reviews.apache.org/r/30379/diff/ Testing --- Thanks, rajith attapattu

[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-08 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055304#comment-14055304 ] Rajith Attapattu commented on QPID-5870: > but I wonder what happens aro

[jira] [Updated] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-08 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5870: --- Attachment: QPID-5870.part2.patch I added a check to ensure that the subscription queue is

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052722#comment-14052722 ] Rajith Attapattu commented on QPID-5868: I verified that both the trans

[jira] [Commented] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052523#comment-14052523 ] Rajith Attapattu commented on QPID-5870: Again I apologize for not provi

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052508#comment-14052508 ] Rajith Attapattu commented on QPID-5868: Apologies for not putting enough inf

[jira] [Commented] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-04 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052509#comment-14052509 ] Rajith Attapattu commented on QPID-5868: As for the session being closed, once

[jira] [Updated] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5870: --- Attachment: QPID-5870.patch The subscription queue is now deleted when the consumer is closed

[jira] [Created] (QPID-5870) Closing a topic consumer should delete its exclusive auto-delete queue

2014-07-02 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5870: -- Summary: Closing a topic consumer should delete its exclusive auto-delete queue Key: QPID-5870 URL: https://issues.apache.org/jira/browse/QPID-5870 Project: Qpid

[jira] [Resolved] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is disabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-5869. Resolution: Fixed Assignee: Rajith Attapattu Added a fix on trunk at r1607488. There

[jira] [Updated] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is disabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5869: --- Description: The root cause is due to the ACL module trying to fire an event regardless of

[jira] [Updated] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is disabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5869: --- Summary: Specifying an invalid ACL file will cause a core dumps when management is disabled

[jira] [Updated] (QPID-5869) Specifying an invalid ACL file will cause a core dumps when management is sisabled

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5869: --- Summary: Specifying an invalid ACL file will cause a core dumps when management is sisabled

[jira] [Created] (QPID-5869) Specifying an ACL file will cause a core dumps when management is sisabled

2014-07-02 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5869: -- Summary: Specifying an ACL file will cause a core dumps when management is sisabled Key: QPID-5869 URL: https://issues.apache.org/jira/browse/QPID-5869 Project

[jira] [Updated] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-02 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5868: --- Attachment: QPID-5868.patch This patch suggests a potential fix for the issue. > Java cli

[jira] [Created] (QPID-5868) Java client ignores exceptions when waiting on sync

2014-07-02 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5868: -- Summary: Java client ignores exceptions when waiting on sync Key: QPID-5868 URL: https://issues.apache.org/jira/browse/QPID-5868 Project: Qpid Issue

Re: Welcome Andrew MacBean as a Qpid committer

2014-06-05 Thread Rajith Attapattu
Welcome Andrew! Rajith On Tue, Jun 3, 2014 at 6:25 PM, Andrew MacBean wrote: > Thanks very much! > > Also the kind welcome messages are much appreciated. :) > > -Andrew > On 3 Jun 2014 20:32, "Gordon Sim" wrote: > > > The Qpid PMC have voted to grant commit rights to Andrew MacBean in > > rec

Review Request 22022: [PROTON-589] Implementation to support passive mode for proton-j messenger

2014-05-29 Thread rajith attapattu
based tests. No tests yet for passive mode. Passive mode needs to be tested thoroughly. The purpose of this review is to get agreement about the direction I have taken. Thanks, rajith attapattu

Review Request 22021: [PROTON-589] Changes proposed to Messenger interface and supporting interfaces

2014-05-29 Thread rajith attapattu
, rajith attapattu

[jira] [Updated] (DISPATCH-16) Improve logging for dispatch

2014-02-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated DISPATCH-16: - Attachment: patch_5_remove_set_mask_method.diff > Improve logging for dispa

[jira] [Updated] (DISPATCH-16) Improve logging for dispatch

2014-02-07 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated DISPATCH-16: - Attachment: patch_1_schema_change.diff

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-28 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: (was: log_patch.2) > Improve logging for dispa

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-28 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: log_patch.3 Reworked the patch to work on top of Ted's changes. >

[jira] [Updated] (QPID-5491) Improve logging for dispatch

2014-01-27 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-5491: --- Attachment: log_patch.2 The patch contains the following changes. 1. Each module registers

Review Request 17050: Improvements to logging in dispatch

2014-01-17 Thread rajith attapattu
/log_private.h 1559165 Diff: https://reviews.apache.org/r/17050/diff/ Testing --- All existing tests pass. Thanks, rajith attapattu

[jira] [Comment Edited] (QPID-5491) Improve logging for dispatch

2014-01-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874837#comment-13874837 ] Rajith Attapattu edited comment on QPID-5491 at 1/17/14 2:5

[jira] [Created] (QPID-5491) Improve logging for dispatch

2014-01-17 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-5491: -- Summary: Improve logging for dispatch Key: QPID-5491 URL: https://issues.apache.org/jira/browse/QPID-5491 Project: Qpid Issue Type: Improvement

[jira] [Commented] (QPID-5491) Improve logging for dispatch

2014-01-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874837#comment-13874837 ] Rajith Attapattu commented on QPID-5491: Sample configuration. log

Re: Null Pointer exception in Qpid Java CLient 0.24

2013-10-07 Thread Rajith Attapattu
Yes the older versions (pre 0-10) only works with Binding URL format. Rajith On Mon, Oct 7, 2013 at 1:35 PM, Gordon Sim wrote: > On 10/07/2013 05:51 PM, k.madnani84 wrote: > >> Hi, >> >> I am trying to use Qpid Java client 0.24 with RabbitMQ 3.1.5.I am getting >> a >> null pointer exception an

[jira] [Commented] (QPID-5204) qpid.subject is an invalid JMS property identifier

2013-10-03 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785382#comment-13785382 ] Rajith Attapattu commented on QPID-5204: QPID-3838 prefixes vendor spec

Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.

2013-10-01 Thread rajith attapattu
> On Oct. 1, 2013, 2:29 p.m., rajith attapattu wrote: > > Ship It! QpidQueueOptions.java is no longer in use. Provided the QMF changes are verified by Fraser I don't foresee any other issues. - rajith --- This is an

Re: Review Request 14361: QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java code.

2013-10-01 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14361/#review26555 --- Ship it! Ship It! - rajith attapattu On Oct. 1, 2013, 2:04 p.m

Re: Detecting potential Java deadlocks with JCarder

2013-09-06 Thread Rajith Attapattu
Hey Philip, Thanks for the analysis! I've been closely following your work. JCarder seems like a very useful tool. Given that we use multiple locks, there are many ways to get into deadlock situations which has made the current client untenable in some user environments. I will definitely use thi

Re: Welcome Pavel Moravec as a Qpid committer

2013-09-04 Thread Rajith Attapattu
Congrats and Welcome Pavel! Rajith On Wed, Sep 4, 2013 at 11:17 AM, Gordon Sim wrote: > The Qpid PMC have voted to grant commit rights to Pavel Moravec in > recognition of his long standing contributions to the project. > > Welcome Pavel, and thank you for your continued support for Apache Qpi

Re: POLL: what to do with dev list

2013-08-23 Thread Rajith Attapattu
[x] 1. Remove the dev list entirely Rajith On Fri, Aug 23, 2013 at 9:39 AM, Justin Ross wrote: > 4. Remove dev and user. Instead use discuss at qpid.apache.org. > > On Fri, Aug 23, 2013 at 9:09 AM, Steve Huston > wrote: > > 2 > > > > Steve Huston > > (sent from my iPhone - please excuse brev

Re: RFQ 0.24: Two JIRAs

2013-08-16 Thread Rajith Attapattu
For python, this is indeed the solution we used when a user wanted the Java client to recognize a python string sent in a map or an application property. On Fri, Aug 16, 2013 at 8:55 AM, Gordon Sim wrote: > On 08/16/2013 01:15 PM, Darryl L. Pierce wrote: > >> On Mon, Aug 12, 2013 at 08:52:20PM

[jira] [Resolved] (QPID-3838) [JMS] Vendor specific properties should be prefixed with JMS_

2013-07-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3838. Resolution: Fixed A fix has been made on trunk and also ported to 0.24

Re: svn commit: r1506095 - /qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageProducer.java

2013-07-23 Thread Rajith Attapattu
Sorry, there wasn't JIRA for this. I should have created one. The patch I mentioned was attached to an internal Bugzilla . Rajith On Tue, Jul 23, 2013 at 12:10 PM, Robbie Gemmell wrote: > This also seems like a change which should have a JIRA reference, > particularly if there was a patch. > >

Re: [VOTE] Replace the Qpid website

2013-06-17 Thread Rajith Attapattu
[X] Yes, replace the existing site with the proposed site Rajith On Mon, Jun 17, 2013 at 6:05 PM, Ken Giusti wrote: > > > - Original Message - > > From: "Justin Ross" > > To: dev@qpid.apache.org > > Sent: Monday, June 17, 2013 1:35:14 PM > > Subject: [VOTE] Replace the Qpid website >

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: (was: QPID-4922.patch) > If Consumer close() method is invoked wh

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: QPID-4922.patch > If Consumer close() method is invoked while ins

[jira] [Updated] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4922: --- Attachment: QPID-4922.patch Marks that close has been called and then executes it after the

[jira] [Created] (QPID-4922) If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed.

2013-06-13 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4922: -- Summary: If Consumer close() method is invoked while inside onMessage(), it should be excuted after onMessage() has completed. Key: QPID-4922 URL: https://issues.apache.org

[jira] [Resolved] (QPID-4497) [Java client] Exclusive property for the subscription queue cannot be overridden using the address string

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4497. Resolution: Fixed > [Java client] Exclusive property for the subscription queue can

[jira] [Resolved] (QPID-4540) The subscription queue should only be deleted by the consumer.

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4540. Resolution: Fixed A fix was committed at http://svn.apache.org/viewvc?rev=1434492&view

[jira] [Closed] (QPID-3769) NPE in client AMQDestination.equals()

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu closed QPID-3769. -- Resolution: Fixed Committed to both trunk and 0.22 branch. > NPE in cli

[jira] [Resolved] (QPID-4496) [Java client] Improve error reporting for invalid addresses

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4496. Resolution: Fixed > [Java client] Improve error reporting for invalid addres

[jira] [Resolved] (QPID-4608) JMS client authorization failure throws JMSException instead of JMSSecurityException

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4608. Resolution: Fixed The relevant commits are http://svn.apache.org/viewvc?view=revision

[jira] [Commented] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681283#comment-13681283 ] Rajith Attapattu commented on QPID-4574: Currently the following solution is b

[jira] [Updated] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Fix Version/s: (was: 0.21) Future > [JMS] Deadlock involv

[jira] [Updated] (QPID-4357) If an exception is received while the client is blocked on sync, the client should return immediately rather than timing out.

2013-06-12 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4357: --- Fix Version/s: (was: 0.21) Future > If an exception is recei

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-06-11 Thread rajith attapattu
there > > any impact from not doing so? E.g a message getting stuck acquired for a > > now-closed consumer? > > > > Does any particular attention need paid to the overridden 0-10 specific > > version of this method? > > rajith attapattu wrote: >

[jira] [Updated] (QPID-4906) If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed.

2013-06-11 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4906: --- Attachment: QPID-4906.patch If close() or closed() is called while the dispatcher thread is

Re: AMQP 1.0 JMS client - supplementary coding standards

2013-06-04 Thread Rajith Attapattu
On Tue, Jun 4, 2013 at 1:04 PM, Rob Godfrey wrote: > On 4 June 2013 18:54, Rajith Attapattu wrote: > > > I'm strongly against using dependencies for the JMS client unless it's > > unavoidable. > > We can make exception for slf4j, but even then my pref

Re: AMQP 1.0 JMS client - supplementary coding standards

2013-06-04 Thread Rajith Attapattu
I'm strongly against using dependencies for the JMS client unless it's unavoidable. We can make exception for slf4j, but even then my preference is to use JDK logging. We've had several issues dealing with dependencies in the past. Increasingly our client is being used in various containers like A

[jira] [Created] (QPID-4906) If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed.

2013-06-03 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4906: -- Summary: If Session close() or closed() method is invoked while inside onMessage(), they should be excuted after onMessage() has completed. Key: QPID-4906 URL: https

Re: [VOTE] Create a QPIDJMS JIRA project

2013-05-28 Thread Rajith Attapattu
Yes [X] No [ ] On Tue, May 28, 2013 at 11:05 AM, Robbie Gemmell wrote: > Following recent discussions regarding a more component-focused structure, > and beginning work on a Proton-based AMQP 1.0 JMS client, could everyone > please vote on the following: > > Create a QPIDJMS JIRA project and re

Re: Website update 4

2013-05-24 Thread Rajith Attapattu
On Fri, May 24, 2013 at 8:56 AM, Justin Ross wrote: > On Fri, May 24, 2013 at 8:37 AM, Rob Godfrey >> Sort of. In general, > for release content, there's a special > >> generation step. That's really a per-release task, however, not > >> something that many developers would typically do. The i

Re: [VOTE] Subversion to JIRA integration

2013-05-24 Thread Rajith Attapattu
QPID: Yes [x ] No [ ] On Fri, May 24, 2013 at 7:03 AM, Robbie Gemmell wrote: > Hi all, > > As some of you will already know, a mail was sent to committers@a.oearlier > outlining some of the newer services ASF infra offer that we may not know > about. One in particular stuck out for me, a servic

[jira] [Resolved] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4873. Resolution: Fixed Committed the patch from Helen with modifications to accommodate the

Re: Proton-based AMQP 1.0 JMS client

2013-05-23 Thread Rajith Attapattu
+1 for a different JIRA system. I believe that is the only way we can support an independent release cycle. Rajith On Thu, May 23, 2013 at 2:36 PM, Rob Godfrey wrote: > On 23 May 2013 20:24, Justin Ross wrote: > > > This is great news! > > > > On Thu, May 23, 2013 at 11:07 AM, Robbie Gemmell >

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664819#comment-13664819 ] Rajith Attapattu commented on QPID-4873: Hi Helen, I will take care of it f

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664487#comment-13664487 ] Rajith Attapattu commented on QPID-4873: +1 Seems a good solution! Ra

[jira] [Commented] (QPID-4873) Optimizations in Java client to reduce queue memory footprint

2013-05-22 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664379#comment-13664379 ] Rajith Attapattu commented on QPID-4873: I'm happy with optimization #2 a

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
there > > any impact from not doing so? E.g a message getting stuck acquired for a > > now-closed consumer? > > > > Does any particular attention need paid to the overridden 0-10 specific > > version of this method? > > rajith attapattu wrote: >

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
there > > any impact from not doing so? E.g a message getting stuck acquired for a > > now-closed consumer? > > > > Does any particular attention need paid to the overridden 0-10 specific > > version of this method? > > rajith attapattu wrote: >

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
there > > any impact from not doing so? E.g a message getting stuck acquired for a > > now-closed consumer? > > > > Does any particular attention need paid to the overridden 0-10 specific > > version of this method? > > rajith attapattu wrote: >

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Resolved] (QPID-4864) The JMS client shouldn't hold a lock when creating a messge

2013-05-17 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4864. Resolution: Fixed Removed the lock. Fix committed at http://svn.apache.org/r1483877

[jira] [Created] (QPID-4864) The JMS client shouldn't hold a lock when creating a messge

2013-05-17 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4864: -- Summary: The JMS client shouldn't hold a lock when creating a messge Key: QPID-4864 URL: https://issues.apache.org/jira/browse/QPID-4864 Project:

[jira] [Resolved] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4849. Resolution: Fixed Committed a fix at http://svn.apache.org/r1483079

[jira] [Updated] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4849: --- Labels: JMS SSL (was: JMS SSL,) > Faulty parsing logic in retrieving CN from an

[jira] [Created] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
Rajith Attapattu created QPID-4849: -- Summary: Faulty parsing logic in retrieving CN from an SSL certificate. Key: QPID-4849 URL: https://issues.apache.org/jira/browse/QPID-4849 Project: Qpid

[jira] [Updated] (QPID-4849) Faulty parsing logic in retrieving CN from an SSL certificate.

2013-05-15 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4849: --- Labels: JMS SSL, (was: ) > Faulty parsing logic in retrieving CN from an SSL certific

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-14 Thread rajith attapattu
va/org/apache/qpid/client/BasicMessageConsumer_0_10.java 1480271 Diff: https://reviews.apache.org/r/10738/diff/ Testing --- Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Issue Comment Deleted] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-05-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Comment: was deleted (was: {code} diff --git a/qpid/java/client/src/main/java/org/apache

[jira] [Issue Comment Deleted] (QPID-4574) [JMS] Deadlock involving _failoverMutex and _messageDeliveryLock

2013-05-14 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-4574: --- Comment: was deleted (was: The change here is that the failoverMutex is acquired before

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
gt; > > We probably shouldn't catch all exceptions, or eat the interrupted > > status. > > rajith attapattu wrote: > For starters I will narrow it down to interrupted exception and then log > it. I meant catch the interrupted exception only and ignore. E

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
message to the application. Therefore even if the session initiates a delivery before the consumer is marked closed it will not proceed beyond the notifyConsumer method in BasicMessageConsumer. The dropped message will be released when the consumer is closed. >Dispatcher pe

Re: What is the correct behaviour for the following case

2013-05-09 Thread Rajith Attapattu
On Thu, May 9, 2013 at 11:52 AM, Gordon Sim wrote: > On 05/09/2013 04:40 PM, Rajith Attapattu wrote: > >> If we use the following address with the java client you get an error with >> exchange bind. >> >> "myEx_headers;{create: always,node:{

What is the correct behaviour for the following case

2013-05-09 Thread Rajith Attapattu
If we use the following address with the java client you get an error with exchange bind. "myEx_headers;{create: always,node:{type: topic,x-declare:{type:headers}}}" However the exchange (or queue) is created, all though the bind fails. When this happens, 1. Should we reverse the queue or excha

[jira] [Resolved] (QPID-3317) JMS client doesn't distinguish between node and link bindings

2013-05-09 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-3317. Resolution: Fixed This has been fixed for a while. Any issues arising out of this should be

[jira] [Updated] (QPID-3317) JMS client doesn't distinguish between node and link bindings

2013-05-09 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu updated QPID-3317: --- Fix Version/s: 0.20 > JMS client doesn't distinguish between node and link

[jira] [Commented] (QPID-3838) [JMS] Vendor specific properties should be prefixed with JMS_

2013-05-09 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652992#comment-13652992 ] Rajith Attapattu commented on QPID-3838: I have committed the fix described in

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-08 Thread rajith attapattu
m customers and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Commented] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645788#comment-13645788 ] Rajith Attapattu commented on QPID-4714: Applied patch to the 0.22 branch.

[jira] [Resolved] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-30 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajith Attapattu resolved QPID-4714. Resolution: Fixed Fix Version/s: (was: Future) 0.22

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-25 Thread rajith attapattu
is per-session and only > > incremented/decremented by the Dispatcher thread in a single place, > > shouldn't it just be an AtomicBoolean? > > rajith attapattu wrote: > For the above case, the following needs to happen. > > 1. A delivery is

Request for inclusion in 0.22

2013-04-25 Thread Rajith Attapattu
I would like to include r1475810 in 0.22 The corresponding JIRA (patch attached) is QPID-4714 Rajith

[jira] [Commented] (QPID-4714) AMQConnection close can leak socket connections if exceptions occur earlier in the process

2013-04-25 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641879#comment-13641879 ] Rajith Attapattu commented on QPID-4714: I have checked in a fix at

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
is per-session and only > > incremented/decremented by the Dispatcher thread in a single place, > > shouldn't it just be an AtomicBoolean? > > rajith attapattu wrote: > For the above case, the following needs to happen. > > 1. A delivery is

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
e.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java > 1471133 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/configuration/ClientProperties.java > 1471133 > > Diff: https://reviews.apache.org/r/10738/diff/ > > > Testing > --- > > Java test suite, tests from customers and QE around the deadlock situation. > > > Thanks, > > rajith attapattu > >

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
d/configuration/ClientProperties.java 1471133 Diff: https://reviews.apache.org/r/10738/diff/ Testing --- Java test suite, tests from customers and QE around the deadlock situation. Thanks, rajith attapattu

[jira] [Commented] (QPID-4714) AMQConnection close is leaking socket connections

2013-04-23 Thread Rajith Attapattu (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639735#comment-13639735 ] Rajith Attapattu commented on QPID-4714: If we move the close connection me

  1   2   3   4   5   6   7   8   9   10   >