Royale_Release_Step_010 - Build # 9 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 9 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/9/ to view the results.

Build failed in Jenkins: royale-asjs #1094

2020-04-17 Thread apacheroyaleci
See Changes: -- [...truncated 1.35 MB...] [mxmlc] Loading configuration:

Build failed in Jenkins: royale-asjs #1093

2020-04-17 Thread apacheroyaleci
See Changes: -- [...truncated 1.34 MB...] [mxmlc] Loading configuration:

Build failed in Jenkins: royale-asjs #1092

2020-04-17 Thread apacheroyaleci
See Changes: [carlosrovira] markdown-example: load from a royale docs md page from github -- [...truncated 1.35 MB...] [mxmlc] Loading

Re: 0.9.7 release notes updates - quick check

2020-04-17 Thread Greg Dove
Ok, thanks for clarifying Alex. I will do that later today. On Sat, Apr 18, 2020 at 11:03 AM Alex Harui wrote: > IMO, there is no perfect solution. There will be times where the release > branch is so broken that it will be tossed and re-cut from develop. But > this time around we are trying

Build failed in Jenkins: royale-asjs #1091

2020-04-17 Thread apacheroyaleci
See Changes: [carlosrovira] a new example showing markdown with highlight code, this could be the [greg.dove] minor: Consistency with flash for amf deserialization: the local

Re: [royale-compiler] branch develop updated: fix build

2020-04-17 Thread Alex Harui
Please do not add an Apache header to the README or NOTICE (or the LICENSE). I'm pretty sure it is just a convention to not add the header. Headers are not a legal thing, they are just helpful signposts. A missing header does not change the copyright of the content. I would also argue that

Re: Problems to create AS3 externs when JS library returns some kind of object

2020-04-17 Thread Carlos Rovira
Hi Josh, that's right I could be doing something wrong. What I really don't understand is how setOptions can apply to a concrete marked object. that's what I could not make it work, and I was supposing that was due to the fact that is just a function, not a class, since to make a class I can't

Re: 0.9.7 release notes updates - quick check

2020-04-17 Thread Alex Harui
IMO, there is no perfect solution. There will be times where the release branch is so broken that it will be tossed and re-cut from develop. But this time around we are trying to keep the release branches around, so make changes to the release branch and make sure the RM knows so they RM

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Greg Dove
Thanks Josh, good to know. I think I got close to expressing that with 'the initial path needs to be handled by the server no matter what it is. It may not do anything different other than to serve the same content regardless of the path' But your example with .htaccess is a much more helpful

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Josh Tynjala
Yes, your understanding is correct. The HTML History API is not limited to the hash, and it can update other parts of the URL without reloading the whole page. However, if you are not using a hash, then your server may need some extra configuration to understand which URLs should be mapped to your

0.9.7 release notes updates - quick check

2020-04-17 Thread Greg Dove
I am not sure whether the current work on 0.9.7 release is a dry run or a full effort (I have not been reading all details recently, sorry). I assume it is a full release effort. For 0.9.6 release we had a collective rush to add things to RELEASE NOTES before release. I have a few things I want

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Greg Dove
'AIUI, hash has to be used as the delimiter if you plan to change the route information within the application, otherwise the application will reload.' I am pretty sure that is no longer the case. HTML5 support for history changes it not like the old days and there is good native browser

Re: Problems to create AS3 externs when JS library returns some kind of object

2020-04-17 Thread Josh Tynjala
To be clear, I have successfully used the approach that I suggested with other libraries. Have you tried calling marked["setOptions"]() instead? I think that you should rule out the possibility that you were using the API incorrectly. -- Josh Tynjala Bowler Hat LLC On

Re: Problems to create AS3 externs when JS library returns some kind of object

2020-04-17 Thread Carlos Rovira
Hi Josh, I already tried that approach (without the highlighter to avoid complexity), and was not working. I think what's happening is "marked" is not a class is just a function that gets a string and returns a string, so a instance is created and destroyed each time, but we are not able to store

Royale_Release_Step_010 - Build # 8 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 8 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/8/ to view the results.

Re: [royale-compiler] branch develop updated: fix build

2020-04-17 Thread Christofer Dutz
Hi all. So what is the difference between code and documentation? I would say none. So if I would be asked, I'd probably add the headers to all md, adoc, whatsoever files. Chris Am 17.04.20, 19:02 schrieb "Carlos Rovira" : totally El vie., 17 abr. 2020 a las 18:58, Yishay Weiss ()

Build failed in Jenkins: royale-asjs #1090

2020-04-17 Thread apacheroyaleci
See Changes: [aharui] jgit [aharui] oops, wrong place [aharui] [maven-release-plugin] prepare branch @{releaseLabel} [aharui] [maven-release-plugin] prepare for next development

Jenkins build is back to normal : royale-asjs_jsonly #1289

2020-04-17 Thread apacheroyaleci
See

Re: Problems to create AS3 externs when JS library returns some kind of object

2020-04-17 Thread Josh Tynjala
You may be able to do something like this instead: import marked.setOptions; import marked.Renderer; setOptions({ renderer: new Renderer(), highlight: function(code, language) { const hljs = require('highlight.js'); const validLanguage = hljs.getLanguage(language) ? language :

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Yishay Weiss
Oops, looks like I need to rebuild Core. Ignore this. From: Yishay Weiss Sent: Friday, April 17, 2020 8:05:06 PM To: dev@royale.apache.org Subject: RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function I’m getting

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Yishay Weiss
Glad you fixed it. Wasn’t in Core after all… From: Carlos Rovira Sent: Friday, April 17, 2020 8:11 PM To: Apache Royale Development Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function Hi

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Carlos Rovira
Hi Yishay, just committed, sorry, I was not repairing on that file since is a new one and I had several others new sorry for the confusion now all should work ok Thanks El vie., 17 abr. 2020 a las 19:05, Yishay Weiss () escribió: > I’m getting > > [java] >

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Yishay Weiss
I’m getting [java] C:\dev\flexjs\royale-asjs\frameworks\projects\Jewel\src\main\royale\org\apache\royale\jewel\List.as(277): col: 20 Error: Access of possibly undefine d property IScrollToIndexView. When building Jewel. I searched IScrollToIndexView and it doesn’t exist. From: Carlos

Re: [royale-compiler] branch develop updated: fix build

2020-04-17 Thread Carlos Rovira
totally El vie., 17 abr. 2020 a las 18:58, Yishay Weiss () escribió: > Thanks. Doesn’t it make more sense to recursively exclude *.md files, > something like > > **/*.md > > ? > > From: aha...@apache.org > Sent: Friday, April 17, 2020 7:14 PM > To:

Re: about current framework release (was Re: Routing (was Re: Spectrum Components))

2020-04-17 Thread Carlos Rovira
Hi Alex, I'm just exposing that in the other repos there was various tries and reverts. I was expecting the same here. If you are getting enough progress to get the release in few hours, that's great. But maybe exposing you got all working to finish the release and send an email to the list will

RE: [royale-compiler] branch develop updated: fix build

2020-04-17 Thread Yishay Weiss
Thanks. Doesn’t it make more sense to recursively exclude *.md files, something like **/*.md ? From: aha...@apache.org Sent: Friday, April 17, 2020 7:14 PM To: comm...@royale.apache.org Subject: [royale-compiler] branch develop

Re: Problems to create AS3 externs when JS library returns some kind of object

2020-04-17 Thread Carlos Rovira
Hi, I think we have some kind of limitation. trying multiple ways with the "marked" js library and I couldn't objects in the marked library ( 'setOptions' and the 'Renderer'). I was able just to declare as a function: package { /** * @externs */ COMPILE::JS public function

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Carlos Rovira
Hi Yishay, reverting the maven release plugin and rebuilding Jewel worked for me. I don't see any problem for now El vie., 17 abr. 2020 a las 17:43, Carlos Rovira () escribió: > Hi Yishay, > > the problem is I can't build due to develop in 0.9.8-SNAPSHOT > I'll try locally to reset my repo to a

Royale_Release_Step_010 - Build # 7 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 7 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/7/ to view the results.

Re: about current framework release (was Re: Routing (was Re: Spectrum Components))

2020-04-17 Thread Alex Harui
Hi Carlos, First you are complaining that I was not making enough progress on the release. Then there have clearly been Release_Step emails this week and you are now claiming I did not give you enough warning? -Alex On 4/17/20, 9:38 AM, "Carlos Rovira" wrote: Hi Alex, a part

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Alex Harui
Everything built for me with 0.9.8-SNAPSHOT in Maven up until the error in Jewel. What error are you getting? On 4/17/20, 8:44 AM, "Carlos Rovira" wrote: Hi Yishay, the problem is I can't build due to develop in 0.9.8-SNAPSHOT I'll try locally to reset my repo to a commit

Royale_Release_Step_010 - Build # 6 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 6 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/6/ to view the results.

about current framework release (was Re: Routing (was Re: Spectrum Components))

2020-04-17 Thread Carlos Rovira
Hi Alex, a part from the issue with version bumped, I thought that you were testing and changing, and this could be just a test as done in compiler. If this is the real release, great. But in that case, I think you should cherry pick my latest commit removing a class (scrollToIndex) since right

Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

2020-04-17 Thread Alex Harui
Only at the top level. The maven build should have failed. I just pushed the fix for it. On 4/17/20, 2:57 AM, "Yishay Weiss" wrote: I don’t see any license headers to other md files. Aren’t they filtered out of the RAT check? From: Carlos Rovira

Royale_Release_Step_010 - Build # 5 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 5 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/5/ to view the results.

Royale_Release_Step_010 - Build # 4 - Still Failing!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 4 - Still Failing: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/4/ to view the results.

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Alex Harui
Ideally, supporting the route information in parameters vs hash would be done in a PAYG way. AIUI, hash has to be used as the delimiter if you plan to change the route information within the application, otherwise the application will reload. IOW, if the user is going to navigate in the

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Carlos Rovira
Hi Yishay, the problem is I can't build due to develop in 0.9.8-SNAPSHOT I'll try locally to reset my repo to a commit where the versions are not bumped El vie., 17 abr. 2020 a las 14:44, Yishay Weiss () escribió: > Is Jewel building for you? Even after that change it fails for me. > >

Build failed in Jenkins: royale-asjs_jsonly #1288

2020-04-17 Thread apacheroyaleci
See Changes: [carlosrovira] scrollToIndex: forgot to remove the class here -- [...truncated 1.57 MB...] compile-js: [echo] swc-date

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Yishay Weiss
Is Jewel building for you? Even after that change it fails for me. From: Carlos Rovira Sent: Friday, April 17, 2020 3:34:21 PM To: Apache Royale Development Cc: comm...@royale.apache.org Subject: Re: [royale-asjs] branch develop updated: jewel-scrollToIndex:

Re: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Carlos Rovira
Thanks just commited :) El vie., 17 abr. 2020 a las 13:30, Yishay Weiss () escribió: > Build is failing. Looks like you forgot to remove scrollToIndex from > JewelClasses > > > From: carlosrov...@apache.org > Sent: Friday, April 17, 2020 3:56:44 AM > To:

Build failed in Jenkins: royale-asjs_jsonly #1287

2020-04-17 Thread apacheroyaleci
See Changes: -- [...truncated 1.58 MB...] [echo] ROYALE_COMPILER_HOME:

RE: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove isolated function

2020-04-17 Thread Yishay Weiss
Build is failing. Looks like you forgot to remove scrollToIndex from JewelClasses From: carlosrov...@apache.org Sent: Friday, April 17, 2020 3:56:44 AM To: comm...@royale.apache.org Subject: [royale-asjs] branch develop updated: jewel-scrollToIndex: remove

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Harbs
Whatever you think is fine by me. I don’t remember why I have "if(location.hash)”. It’s possible you can get rid of that conditional. It could be you can get rid of that and handle hashRecieved in a bead. If the hashReceived event has no hash you can then check the URL.You do need to make

Build failed in Jenkins: royale-asjs_jsonly #1286

2020-04-17 Thread apacheroyaleci
See Changes: [piotrzarzycki21] Router: Make onInit protected to give more opportunity to extend it -- [...truncated 1.58 MB...]

RE: [DISCUSS] Discuss Release Apache Royale 1.2.0

2020-04-17 Thread Yishay Weiss
I don’t see any license headers to other md files. Aren’t they filtered out of the RAT check? From: Carlos Rovira Sent: Friday, April 17, 2020 12:34 PM To: Apache Royale Development Subject: Re: [DISCUSS] Discuss Release Apache Royale

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Carlos Rovira
Hi, that's the problem I was talking in the other thread. While a release process goes, we are stuck, for that reason I was proposing to do release from a branch, that is something totally legit and will make the rest of contributors free to continue work. As gitflow indicates, when release is

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Thanks for input Carlos - I think I will have some scenario in future where Router may help me. I would update it with params once develop will be stable. Right now branch is switched to 0.9.8, so Alex probably is doing some work. pt., 17 kwi 2020 o 11:37 Carlos Rovira napisał(a): > Hi Piotr, >

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Carlos Rovira
Hi Piotr, I'm not saying is not right what you're doing. Just pointing that maybe for your use case adding all the Router sttuff is not worthit if you don't plan to make a real router use far beyond adding those params. But I think if there's some scenario not covered with passing params, we need

Re: [DISCUSS] Discuss Release Apache Royale 1.2.0

2020-04-17 Thread Carlos Rovira
Hi Yishay, not sure but probably the empty file added will cause RAT problems with maven maybe you should see if that happens and at least add a license header About content, since is taken from the git history I think is ok thanks El vie., 17 abr. 2020 a las 10:14, Yishay Weiss () escribió:

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Hi Carlos, At some point you are right, but it was just really weird to me that Router has in state parameters property and it's empty. To me it looks like bug. I would be willing to set it properly in Router as Harbs suggested, but if you think it shouldn't be there - What would be the purpose

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Carlos Rovira
Hi Piotr, based on the url you provide, URLParameterBead seems the best option right? Or at least for the info you provided I don't see a SPA for now, just a need to load some params to set a state. If you need a full SPA, then is worth to add Routing and part of that could be receive params.

Build failed in Jenkins: royale-asjs_jsonly #1285

2020-04-17 Thread apacheroyaleci
See Changes: -- [...truncated 1.58 MB...] [echo] ROYALE_COMPILER_HOME:

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
I think it would be better to have it here in Router. pt., 17 kwi 2020 o 09:37 Harbs napisał(a): > Alternatively, you can subclass Router to support setting the parameters > in the onInit method. > > Not sure which of these is best. > > > On Apr 17, 2020, at 10:35 AM, Harbs wrote: > > > >

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
I would like to make in RouteToParameters methods which handle events protected - Any objections to that ? pt., 17 kwi 2020 o 10:14 Piotr Zarzycki napisał(a): > Alex, > > I wanted to try out new stuff. I know about URLParameterBead, but I may > use also some other features available in Routing

Royale_Release_Step_010 - Build # 3 - Failure!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 3 - Failure: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/3/ to view the results.

Build failed in Jenkins: royale-asjs_jsonly #1284

2020-04-17 Thread apacheroyaleci
See Changes: [aharui] Revert "[maven-release-plugin] prepare for next development iteration" [aharui] Revert "[maven-release-plugin] prepare branch @{releaseLabel}" [aharui]

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Alex, I wanted to try out new stuff. I know about URLParameterBead, but I may use also some other features available in Routing itself. pt., 17 kwi 2020 o 10:02 Alex Harui napisał(a): > Could Piotr use URLParameterBead? > > On 4/17/20, 12:37 AM, "Harbs" wrote: > > Alternatively, you can

RE: [DISCUSS] Discuss Release Apache Royale 1.2.0

2020-04-17 Thread Yishay Weiss
Ok Carlos, thanks. I created RELEASE_NOTES.md under compiler-build-tools. I think the main contributors since 1.1 [1] are Alex and Chris so it would be great if they could add their comments there. [1] https://paste.apache.org/kmw0k From: Carlos Rovira Sent: Wednesday, April 15, 2020

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Alex Harui
Could Piotr use URLParameterBead? On 4/17/20, 12:37 AM, "Harbs" wrote: Alternatively, you can subclass Router to support setting the parameters in the onInit method. Not sure which of these is best. > On Apr 17, 2020, at 10:35 AM, Harbs wrote: > > Actually,

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Thanks for pointing it out. Do you suggest me to change framework code or your suggestion is something which I should rather do on my application ? pt., 17 kwi 2020 o 09:35 Harbs napisał(a): > Actually, it’s not going to work because the router.routeState.parameters > will not be set. > > You

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Harbs
Alternatively, you can subclass Router to support setting the parameters in the onInit method. Not sure which of these is best. > On Apr 17, 2020, at 10:35 AM, Harbs wrote: > > Actually, it’s not going to work because the router.routeState.parameters > will not be set. > > You will likely

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Harbs
Actually, it’s not going to work because the router.routeState.parameters will not be set. You will likely need to add code to set the router.routeState.parameters using the part of the location after the question mark. The easiest way to do that would be to either: 1. Modify

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
My url already have a proper look. I wanted to have it like that https://mydomain.com/somefolder/index.html?target=somevalue= somevalue pt., 17 kwi 2020 o 09:15 Alex Harui napisał(a): > What do you

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Harbs
I’m pretty sure it’ll work without the hash as well. Give it a try. > On Apr 17, 2020, at 10:23 AM, Piotr Zarzycki > wrote: > > Hi Harbs, > > Thanks for pointing me out, but this is still that Routing expects me to > use in url hashes - The question is - What if I can't use hashes, but url >

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Hi Harbs, Thanks for pointing me out, but this is still that Routing expects me to use in url hashes - The question is - What if I can't use hashes, but url looks like I have presented in previous email ? Thanks, Piotr pt., 17 kwi 2020 o 09:20 Harbs napisał(a): > This app uses both path based

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Harbs
This app uses both path based and query based routing: https://unhurdle.github.io/spectrum-royale/#!asset?colorstop=dark You can see how it’s done here:

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Alex Harui
What do you want your URLs to look like? Remember that hash is used to keep the browser from reloading the app. On 4/17/20, 12:13 AM, "Piotr Zarzycki" wrote: I'm still looking into the code and it looks like Routing implemented now is not doing what I would expected. Everything is

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
I'm still looking into the code and it looks like Routing implemented now is not doing what I would expected. Everything is based on "hash" property in "location". Instead I need something which is in "search" of location. I will wait for your thoughts before I do try to handle stuff on my end.

Release Step 009 Succeeded

2020-04-17 Thread apacheroyaleci
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands: git push You will need your Apache/Github username and 2FA token.

Release Step 008 Succeeded

2020-04-17 Thread apacheroyaleci
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_008 and run the following commands: git push git checkout release/0.9.7 git push -u origin release/0.9.7 You will need your Apache/Github username and 2FA token.

Build failed in Jenkins: royale-asjs_jsonly #1283

2020-04-17 Thread apacheroyaleci
See Changes: [aharui] [maven-release-plugin] prepare branch @{releaseLabel} [aharui] [maven-release-plugin] prepare for next development iteration

Re: Routing (was Re: Spectrum Components)

2020-04-17 Thread Piotr Zarzycki
Hi Guys, I really thought that I will be able to use Router [1] based on documentation and maybe eventually some look to the code [2] - to figure out how things should be implemented. However it looks like non of the existing stuff helps me to use in in real world application at all. I would like

Royale_Release_Step_010 - Build # 1 - Failure!

2020-04-17 Thread apacheroyaleci
Royale_Release_Step_010 - Build # 1 - Failure: Check console output at http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/Royale_Release_Step_010/1/ to view the results.

Release Step 009 Succeeded

2020-04-17 Thread apacheroyaleci
Log in to the server, open a command prompt, change directory to C:\jenkins\workspace\Royale_Release_Step_009 and run the following commands: git push You will need your Apache/Github username and 2FA token.