Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 6, 2017, 8:07 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 310 (patched) > > > > > > what happens if the

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 6, 2017, 5:48 p.m., Lei Xu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 289 (patched) > > > > > > According to the code style

Re: Review Request 58166: SENTRY-1692 ZK namespace configuration doesn't work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58166/#review171310 --- Ship it! Ship It! - Hao Hao On April 4, 2017, 5:03 a.m.,

Re: Review Request 58093: SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw RuntimeExceptio

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58093/#review171309 --- Ship it! Ship It! - Hao Hao On March 31, 2017, 5:07 a.m.,

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 6, 2017, 10:40 p.m.) Review request for sentry, Alexander

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171244 ---

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

> On April 6, 2017, 7:04 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 310 (patched) > > > > > > Why not directly shutdown

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171237 ---

Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race condition in handling results list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58130/#review171235 --- Ship it! Ship It! - Hao Hao On April 1, 2017, 12:35 a.m.,

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

> On April 6, 2017, 7:05 a.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > > Lines 360 (patched) > > > > > > comment mentioned to return false if failed, but

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171230 ---

Re: Review Request 58093: SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw RuntimeExceptio

> On April 6, 2017, 2:02 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > > Line 137 (original), 135 (patched) > > > > > > do you want to print

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 2:17 p.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

> On April 4, 2017, 4:40 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1638.oracle.sql > > Lines 1 (patched) > > > > > > Why create a new file for create notification id

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/#review171013 ---

Re: Review Request 57570: SENTRY-1644. Partition ACLs disappear after renaming Hive table with partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57570/#review171081 ---

Re: Review Request 58130: SENTRY-1684 FullUpdateInitializer has a race condition in handling results list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58130/#review171041 ---

Re: Review Request 58093: SENTRY-1676: FullUpdateInitializer#createInitialUpdate should not throw RuntimeExceptio

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58093/#review171022 ---

Re: Review Request 57901: SENTRY-1593 Implement client failover for all the sentry clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57901/#review170725 ---

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58164/ --- (Updated April 6, 2017, 1:38 p.m.) Review request for sentry, Alexander

Re: [DISCUSS] Merging Sentry HA branch with master

Have you tried to contact the author of the patch for SENTRY-1205 to get their opinion? If there are major conflicts between the two branches then I think your proposal is ok for 1.8, as the new feature should take precedence over a refactoring effort. However, in future, I think it is not a good