Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-11 Thread Alexander Kolbasov
> On April 12, 2017, 4:50 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 78 (patched) > > > > > > Do you ever expect

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-11 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 12, 2017, 5:38 a.m.) Review request for sentry, Alexander

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-11 Thread Alexander Kolbasov
> On April 12, 2017, 4:50 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 350 (patched) > > > > > > This is most

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-11 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/#review171666 ---

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-11 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 12, 2017, 3:47 a.m.) Review request for sentry, Alexander

Re: Review Request 58164: SENTRY-1638 Update SQL script of MSentryPathChange table to add a column for notification ID

2017-04-11 Thread kalyan kumar kalvagadda
> On April 6, 2017, 12:41 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > > Lines 5 (patched) > > > > > > Am I missing something? why is still

Re: Review Request 58267: SENTRY-1629 sql changed needed for MAuthzPathsMapping.

2017-04-11 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58267/ --- (Updated April 11, 2017, 9:19 p.m.) Review request for sentry, Alexander

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

2017-04-11 Thread Na Li
> On April 10, 2017, 3:56 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > > Line 128 (original), 221 (patched) > > > > > > should retries = i +

Re: Review Request 58284: SENTRY-1687 FullUpdateInitializer can be more efficient

2017-04-11 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58284/#review171573 --- Ship it! Ship It! - Na Li On April 10, 2017, 5:42 a.m.,