Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172585 --- Ship it! Ship It! - Alexander Kolbasov On April 21, 2017, 2:

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/ --- (Updated April 21, 2017, 2:20 a.m.) Review request for sentry. Repository: se

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Hao Hao
> On April 19, 2017, 12:08 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 2728-2731 (patched) > > > > > >

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Hao Hao
> On April 20, 2017, 9:30 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java > > Lines 27 (patched) > > > > > > Please add a com

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172570 --- Ship it! Ship It! - Alexander Kolbasov On April 20, 2017, 11

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Hao Hao
> On April 19, 2017, 3:06 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > > Lines 334 (patched) > > > > > > Is there

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Hao Hao
> On April 19, 2017, 3:06 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > Would this work cor

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 20, 2017, 11:55 p.m.) Review request for sentry. Bugs: SENTRY-

Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size for MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.

2017-04-20 Thread Hao Hao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58593/#review172565 --- Ship it! Ship It! - Hao Hao On April 20, 2017, 8:56 p.m., Le

Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size for MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.

2017-04-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58593/#review172564 --- Ship it! Ship It! - Alexander Kolbasov On April 20, 2017, 8:

Re: Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size for MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58593/#review172562 --- Ship it! Ship It! - Na Li On April 20, 2017, 8:56 p.m., Lei

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 20, 2017, 11:09 p.m.) Review request for sentry. Bugs: SENTRY-

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
> On April 20, 2017, 9:49 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 259 (original), 278 (patched) > > > > > > Ther

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172554 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172553 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Review Request 58412: SENTRY-1587: Refactor SentryStore transaction to persist a single path transcation bundled with corresponding delta path change

2017-04-20 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58412/#review172391 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Review Request 58593: SENTRY-1710. Reduce datanucleus key cache size for MSentryPermChange and MSentryPathChange tables to avoid holes in change IDs.

2017-04-20 Thread Lei Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58593/ --- Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar kalvagadda,

Re: Review Request 58221: SENTRY-1649 move HMS follower to runServer

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58221/ --- (Updated April 20, 2017, 7:26 p.m.) Review request for sentry, Alexander Kolbas

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
> On April 19, 2017, 6:18 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 259 (original), 257 (patched) > > > > > > Th

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 20, 2017, 6:14 p.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread kalyan kumar kalvagadda
> On April 20, 2017, 3:52 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 258 (patched) > > > > > > You may want t

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/ --- (Updated April 20, 2017, 4:28 p.m.) Review request for sentry. Bugs: SENTRY-1

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
> On April 19, 2017, 6:18 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 259 (original), 257 (patched) > > > > > > Th

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
> On April 19, 2017, 6:18 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Line 259 (original), 257 (patched) > > > > > > Th

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread Na Li
> On April 18, 2017, 6:10 p.m., kalyan kumar kalvagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 74 (patched) > > > > > > SENTRY-1587 is a

Re: Review Request 58481: SENTRY-1674 HMSFollower shouldn't print the same value of notification ID multiple times

2017-04-20 Thread kalyan kumar kalvagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58481/#review172502 --- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentr

Re: Custom Sentry Authorizer and binding

2017-04-20 Thread Kalyan Kumar Kalvagadda
Hello Avinash, If I may ask. What is the need to develop new Sentry Binding and Authorizer. There is a generic sentry plug-in to handle generic cases. If you can elaborate your case. It might help people to suggest you if you could re-use existing plug-in's. -Kalyan -Kalyan On Thu, Apr 20,

Re: Solr Sentry Issue

2017-04-20 Thread Na Li
Tushar, I am going to take a look at this issue and then come back to you. Thanks, Lina On Wed, Apr 19, 2017 at 9:45 PM, Waterline Data wrote: > Hello, > > My question is about the Solr Sentry plugin in a Kerberos environment. > > We are encountering an issue with the Solr Sentry plugin. The

Custom Sentry Authorizer and binding

2017-04-20 Thread Avinash Dongre
Hi All, For my product to work in CDH environment with security. I need to develop my own Sentry Binding and Authorizer. I was following code from sentry-binding. If I implement similar binding for my product. How Do I deploy the same ? Is there any document explaining how to write custom sentry